Derivation Path errors are detected.

[perso/Immae/Projets/Cryptomonnaies/BIP39.git] / src / js / index.js

diff --git a/src/js/index.js b/src/js/index.js
index 4f1ab249f3732fb9ae66f7cdc7b0e7d5360a60b7..6f0da65d391a29e58f3dcdc597fc3511039b7e40 100644 (file)
--- a/src/js/index.js
+++ b/src/js/index.js
@@ -43,8 +43,6 @@
     DOM.addressToggle = $(".address-toggle");
     DOM.privateKeyToggle = $(".private-key-toggle");
 
-    var derivationPath = $(".tab-pane.active .path").val();
-
     function init() {
         // Events
         DOM.network.on("change", networkChanged);
@@ -52,12 +50,12 @@
         DOM.passphrase.on("input", delayedPhraseChanged);
         DOM.generate.on("click", generateClicked);
         DOM.more.on("click", showMore);
-        DOM.bip32path.on("input", bip32Changed);
-        DOM.bip44purpose.on("input", bip44Changed);
-        DOM.bip44coin.on("input", bip44Changed);
-        DOM.bip44account.on("input", bip44Changed);
-        DOM.bip44change.on("input", bip44Changed);
-        DOM.tab.on("click", tabClicked);
+        DOM.bip32path.on("input", delayedPhraseChanged);
+        DOM.bip44purpose.on("input", delayedPhraseChanged);
+        DOM.bip44coin.on("input", delayedPhraseChanged);
+        DOM.bip44account.on("input", delayedPhraseChanged);
+        DOM.bip44change.on("input", delayedPhraseChanged);
+        DOM.tab.on("click", delayedPhraseChanged);
         DOM.indexToggle.on("click", toggleIndexes);
         DOM.addressToggle.on("click", toggleAddresses);
         DOM.privateKeyToggle.on("click", togglePrivateKeys);
@@ -72,7 +70,6 @@
     function networkChanged(e) {
         var network = e.target.value;
         networks[network].onSelect();
-        setBip44DerivationPath();
         delayedPhraseChanged();
     }
 
@@ -97,7 +94,8 @@
             return;
         }
         // Get the derivation path
-        var errorText = findDerivationPathErrors();
+        var derivationPath = getDerivationPath();
+        var errorText = findDerivationPathErrors(derivationPath);
         if (errorText) {
             showValidationError(errorText);
             return;
@@ -120,26 +118,6 @@
         }, 50);
     }
 
-    function tabClicked(e) {
-        var activePath = $(e.target.getAttribute("href") + " .path");
-        derivationPath = activePath.val();
-        derivationChanged();
-    }
-
-    function derivationChanged() {
-        delayedPhraseChanged();
-    }
-
-    function bip32Changed() {
-        derivationPath = DOM.bip32path.val();
-        derivationChanged();
-    }
-
-    function bip44Changed() {
-        setBip44DerivationPath();
-        derivationChanged();
-    }
-
     function toggleIndexes() {
         showIndex = !showIndex;
         $("td.index span").toggleClass("invisible");
@@ -227,8 +205,66 @@
         return false;
     }
 
+    function getDerivationPath() {
+        if (DOM.bip44tab.hasClass("active")) {
+            var purpose = parseIntNoNaN(DOM.bip44purpose.val(), 44);
+            var coin = parseIntNoNaN(DOM.bip44coin.val(), 0);
+            var account = parseIntNoNaN(DOM.bip44account.val(), 0);
+            var change = parseIntNoNaN(DOM.bip44change.val(), 0);
+            var path = "m/";
+            path += purpose + "'/";
+            path += coin + "'/";
+            path += account + "'/";
+            path += change;
+            DOM.bip44path.val(path);
+            var derivationPath = DOM.bip44path.val();
+            console.log("Using derivation path from BIP44 tab: " + derivationPath);
+            return derivationPath;
+        }
+        else if (DOM.bip32tab.hasClass("active")) {
+            var derivationPath = DOM.bip32path.val();
+            console.log("Using derivation path from BIP32 tab: " + derivationPath);
+            return derivationPath;
+        }
+        else {
+            console.log("Unknown derivation path");
+        }
+    }
+
     function findDerivationPathErrors(path) {
-        // TODO
+        // TODO is not perfect but is better than nothing
+        // Inspired by
+        // https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki#test-vectors
+        // and
+        // https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki#extended-keys
+        var maxDepth = 255; // TODO verify this!!
+        var maxIndexValue = Math.pow(2, 31); // TODO verify this!!
+        if (path[0] != "m") {
+            return "First character must be 'm'";
+        }
+        if (path.length > 1) {
+            if (path[1] != "/") {
+                return "Separator must be '/'";
+            }
+            var indexes = path.split("/");
+            if (indexes.length > maxDepth) {
+                return "Derivation depth is " + indexes.length + ", must be less than " + maxDepth;
+            }
+            for (var depth = 1; depth<indexes.length; depth++) {
+                var index = indexes[depth];
+                var invalidChars = index.replace(/^[0-9]+'?$/g, "")
+                if (invalidChars.length > 0) {
+                    return "Invalid characters " + invalidChars + " found at depth " + depth;
+                }
+                var indexValue = parseInt(index.replace("'", ""));
+                if (isNaN(depth)) {
+                    return "Invalid number at depth " + depth;
+                }
+                if (indexValue > maxIndexValue) {
+                    return "Value of " + indexValue + " at depth " + depth + " must be less than " + maxIndexValue;
+                }
+            }
+        }
         return false;
     }
 
@@ -264,7 +300,8 @@
                 var key = bip32ExtendedKey.derive(index);
                 var address = key.getAddress().toString();
                 var privkey = key.privKey.toWIF(network);
-                addAddressToList(index, address, privkey);
+                var indexText = getDerivationPath() + "/" + index;
+                addAddressToList(indexText, address, privkey);
             }, 50)
         }
 
@@ -305,14 +342,13 @@
         DOM.extendedPubKey.val("");
     }
 
-    function addAddressToList(index, address, privkey) {
+    function addAddressToList(indexText, address, privkey) {
         var row = $(addressRowTemplate.html());
         // Elements
         var indexCell = row.find(".index span");
         var addressCell = row.find(".address span");
         var privkeyCell = row.find(".privkey span");
         // Content
-        var indexText = derivationPath + "/" + index;
         indexCell.text(indexText);
         addressCell.text(address);
         privkeyCell.text(privkey);
@@ -339,20 +375,6 @@
         });
     }
 
-    function setBip44DerivationPath() {
-        var purpose = parseIntNoNaN(DOM.bip44purpose.val(), 44);
-        var coin = parseIntNoNaN(DOM.bip44coin.val(), 0);
-        var account = parseIntNoNaN(DOM.bip44account.val(), 0);
-        var change = parseIntNoNaN(DOM.bip44change.val(), 0);
-        var path = "m/";
-        path += purpose + "'/";
-        path += coin + "'/";
-        path += account + "'/";
-        path += change;
-        DOM.bip44path.val(path);
-        derivationPath = DOM.bip44path.val();
-    }
-
     function parseIntNoNaN(val, defaultVal) {
         var v = parseInt(val);
         if (isNaN(v)) {