Entropy is truncated from the left

This provides greater compatibility with bip32jp.github.io

diff --git a/src/js/index.js b/src/js/index.js
index d356eb80374340a6564530e281e77b5f51e76ea9..b03f2c8aee98a3c8d5606f898cc7b5803f7a12a5 100644 (file)
--- a/src/js/index.js
+++ b/src/js/index.js
@@ -764,7 +764,8 @@
         }
         // Discard trailing entropy
         var bitsToUse = Math.floor(bits.length / 32) * 32;
-        var binaryStr = bits.substring(0, bitsToUse);
+        var start = bits.length - bitsToUse;
+        var binaryStr = bits.substring(start);
         // Convert entropy string to numeric array
         var entropyArr = [];
         for (var i=0; i<binaryStr.length / 8; i++) {

diff --git a/tests.js b/tests.js
index 33477ace7fceaa9a55e8bc69e0916ee9dd8995cd..9abe573a0c1222478d16f35b13ac8caad0c3ebca 100644 (file)
--- a/tests.js
+++ b/tests.js
@@ -2696,15 +2696,15 @@ page.open(url, function(status) {
 });
 },
 
-// Entropy is truncated from the right
+// Entropy is truncated from the left
 function() {
 page.open(url, function(status) {
-    var expected = "abandon abandon ability";
+    var expected = "avocado zoo zone";
     // use entropy
     page.evaluate(function() {
         $(".use-entropy").prop("checked", true).trigger("change");
         var entropy  = "00000000 00000000 00000000 00000000";
-            entropy += "11111111 11111111 11111111 1111"; // Missing last byte, only first 8 bytes are used
+            entropy += "11111111 11111111 11111111 1111"; // Missing last byte
         $(".entropy").val(entropy).trigger("input");
     });
     // check the entropy is truncated from the right
@@ -2755,8 +2755,6 @@ page.open(url, function(status) {
 // https://bip32jp.github.io/english/index.html
 // NOTES:
 // Is incompatible with:
-//     base 6 with leading zeros
-//     base 6 wth 12 words / 53 chars
 //     base 20
 function() {
 page.open(url, function(status) {