diff options
author | Jeremy Benoist <jeremy.benoist@gmail.com> | 2017-05-16 21:17:10 +0200 |
---|---|---|
committer | Jeremy Benoist <jeremy.benoist@gmail.com> | 2017-05-31 14:00:15 +0200 |
commit | cf05a1ae342b8f59ee0944eeba0f75aa0a1a2816 (patch) | |
tree | eb1485cac9bf91236b6e5b3a1aef4f5638451b51 /tests/Wallabag/ImportBundle/Import | |
parent | 74a75f7d430eb7a69cd377194e52012db34d39b4 (diff) | |
download | wallabag-cf05a1ae342b8f59ee0944eeba0f75aa0a1a2816.tar.gz wallabag-cf05a1ae342b8f59ee0944eeba0f75aa0a1a2816.tar.zst wallabag-cf05a1ae342b8f59ee0944eeba0f75aa0a1a2816.zip |
Reduce imported entries
Down from 2.2 minutes to 1.39 minutes
Diffstat (limited to 'tests/Wallabag/ImportBundle/Import')
3 files changed, 21 insertions, 21 deletions
diff --git a/tests/Wallabag/ImportBundle/Import/ReadabilityImportTest.php b/tests/Wallabag/ImportBundle/Import/ReadabilityImportTest.php index 25eedd1b..8f466d38 100644 --- a/tests/Wallabag/ImportBundle/Import/ReadabilityImportTest.php +++ b/tests/Wallabag/ImportBundle/Import/ReadabilityImportTest.php | |||
@@ -67,14 +67,14 @@ class ReadabilityImportTest extends \PHPUnit_Framework_TestCase | |||
67 | 67 | ||
68 | public function testImport() | 68 | public function testImport() |
69 | { | 69 | { |
70 | $readabilityImport = $this->getReadabilityImport(false, 23); | 70 | $readabilityImport = $this->getReadabilityImport(false, 3); |
71 | $readabilityImport->setFilepath(__DIR__.'/../fixtures/readability.json'); | 71 | $readabilityImport->setFilepath(__DIR__.'/../fixtures/readability.json'); |
72 | 72 | ||
73 | $entryRepo = $this->getMockBuilder('Wallabag\CoreBundle\Repository\EntryRepository') | 73 | $entryRepo = $this->getMockBuilder('Wallabag\CoreBundle\Repository\EntryRepository') |
74 | ->disableOriginalConstructor() | 74 | ->disableOriginalConstructor() |
75 | ->getMock(); | 75 | ->getMock(); |
76 | 76 | ||
77 | $entryRepo->expects($this->exactly(23)) | 77 | $entryRepo->expects($this->exactly(3)) |
78 | ->method('findByUrlAndUserId') | 78 | ->method('findByUrlAndUserId') |
79 | ->willReturn(false); | 79 | ->willReturn(false); |
80 | 80 | ||
@@ -88,14 +88,14 @@ class ReadabilityImportTest extends \PHPUnit_Framework_TestCase | |||
88 | ->getMock(); | 88 | ->getMock(); |
89 | 89 | ||
90 | $this->contentProxy | 90 | $this->contentProxy |
91 | ->expects($this->exactly(23)) | 91 | ->expects($this->exactly(3)) |
92 | ->method('updateEntry') | 92 | ->method('updateEntry') |
93 | ->willReturn($entry); | 93 | ->willReturn($entry); |
94 | 94 | ||
95 | $res = $readabilityImport->import(); | 95 | $res = $readabilityImport->import(); |
96 | 96 | ||
97 | $this->assertTrue($res); | 97 | $this->assertTrue($res); |
98 | $this->assertEquals(['skipped' => 0, 'imported' => 23, 'queued' => 0], $readabilityImport->getSummary()); | 98 | $this->assertEquals(['skipped' => 0, 'imported' => 3, 'queued' => 0], $readabilityImport->getSummary()); |
99 | } | 99 | } |
100 | 100 | ||
101 | public function testImportAndMarkAllAsRead() | 101 | public function testImportAndMarkAllAsRead() |
@@ -165,7 +165,7 @@ class ReadabilityImportTest extends \PHPUnit_Framework_TestCase | |||
165 | ->getMock(); | 165 | ->getMock(); |
166 | 166 | ||
167 | $producer | 167 | $producer |
168 | ->expects($this->exactly(23)) | 168 | ->expects($this->exactly(3)) |
169 | ->method('publish'); | 169 | ->method('publish'); |
170 | 170 | ||
171 | $readabilityImport->setProducer($producer); | 171 | $readabilityImport->setProducer($producer); |
@@ -173,7 +173,7 @@ class ReadabilityImportTest extends \PHPUnit_Framework_TestCase | |||
173 | $res = $readabilityImport->setMarkAsRead(true)->import(); | 173 | $res = $readabilityImport->setMarkAsRead(true)->import(); |
174 | 174 | ||
175 | $this->assertTrue($res); | 175 | $this->assertTrue($res); |
176 | $this->assertEquals(['skipped' => 0, 'imported' => 0, 'queued' => 23], $readabilityImport->getSummary()); | 176 | $this->assertEquals(['skipped' => 0, 'imported' => 0, 'queued' => 3], $readabilityImport->getSummary()); |
177 | } | 177 | } |
178 | 178 | ||
179 | public function testImportWithRedis() | 179 | public function testImportWithRedis() |
@@ -211,7 +211,7 @@ class ReadabilityImportTest extends \PHPUnit_Framework_TestCase | |||
211 | $res = $readabilityImport->setMarkAsRead(true)->import(); | 211 | $res = $readabilityImport->setMarkAsRead(true)->import(); |
212 | 212 | ||
213 | $this->assertTrue($res); | 213 | $this->assertTrue($res); |
214 | $this->assertEquals(['skipped' => 0, 'imported' => 0, 'queued' => 23], $readabilityImport->getSummary()); | 214 | $this->assertEquals(['skipped' => 0, 'imported' => 0, 'queued' => 3], $readabilityImport->getSummary()); |
215 | 215 | ||
216 | $this->assertNotEmpty($redisMock->lpop('readability')); | 216 | $this->assertNotEmpty($redisMock->lpop('readability')); |
217 | } | 217 | } |
diff --git a/tests/Wallabag/ImportBundle/Import/WallabagV1ImportTest.php b/tests/Wallabag/ImportBundle/Import/WallabagV1ImportTest.php index 9f0c5bac..7cbef637 100644 --- a/tests/Wallabag/ImportBundle/Import/WallabagV1ImportTest.php +++ b/tests/Wallabag/ImportBundle/Import/WallabagV1ImportTest.php | |||
@@ -82,14 +82,14 @@ class WallabagV1ImportTest extends \PHPUnit_Framework_TestCase | |||
82 | 82 | ||
83 | public function testImport() | 83 | public function testImport() |
84 | { | 84 | { |
85 | $wallabagV1Import = $this->getWallabagV1Import(false, 3); | 85 | $wallabagV1Import = $this->getWallabagV1Import(false, 1); |
86 | $wallabagV1Import->setFilepath(__DIR__.'/../fixtures/wallabag-v1.json'); | 86 | $wallabagV1Import->setFilepath(__DIR__.'/../fixtures/wallabag-v1.json'); |
87 | 87 | ||
88 | $entryRepo = $this->getMockBuilder('Wallabag\CoreBundle\Repository\EntryRepository') | 88 | $entryRepo = $this->getMockBuilder('Wallabag\CoreBundle\Repository\EntryRepository') |
89 | ->disableOriginalConstructor() | 89 | ->disableOriginalConstructor() |
90 | ->getMock(); | 90 | ->getMock(); |
91 | 91 | ||
92 | $entryRepo->expects($this->exactly(4)) | 92 | $entryRepo->expects($this->exactly(2)) |
93 | ->method('findByUrlAndUserId') | 93 | ->method('findByUrlAndUserId') |
94 | ->will($this->onConsecutiveCalls(false, true, false, false)); | 94 | ->will($this->onConsecutiveCalls(false, true, false, false)); |
95 | 95 | ||
@@ -103,14 +103,14 @@ class WallabagV1ImportTest extends \PHPUnit_Framework_TestCase | |||
103 | ->getMock(); | 103 | ->getMock(); |
104 | 104 | ||
105 | $this->contentProxy | 105 | $this->contentProxy |
106 | ->expects($this->exactly(3)) | 106 | ->expects($this->exactly(1)) |
107 | ->method('updateEntry') | 107 | ->method('updateEntry') |
108 | ->willReturn($entry); | 108 | ->willReturn($entry); |
109 | 109 | ||
110 | $res = $wallabagV1Import->import(); | 110 | $res = $wallabagV1Import->import(); |
111 | 111 | ||
112 | $this->assertTrue($res); | 112 | $this->assertTrue($res); |
113 | $this->assertEquals(['skipped' => 1, 'imported' => 3, 'queued' => 0], $wallabagV1Import->getSummary()); | 113 | $this->assertEquals(['skipped' => 1, 'imported' => 1, 'queued' => 0], $wallabagV1Import->getSummary()); |
114 | } | 114 | } |
115 | 115 | ||
116 | public function testImportAndMarkAllAsRead() | 116 | public function testImportAndMarkAllAsRead() |
@@ -180,7 +180,7 @@ class WallabagV1ImportTest extends \PHPUnit_Framework_TestCase | |||
180 | ->getMock(); | 180 | ->getMock(); |
181 | 181 | ||
182 | $producer | 182 | $producer |
183 | ->expects($this->exactly(4)) | 183 | ->expects($this->exactly(2)) |
184 | ->method('publish'); | 184 | ->method('publish'); |
185 | 185 | ||
186 | $wallabagV1Import->setProducer($producer); | 186 | $wallabagV1Import->setProducer($producer); |
@@ -188,7 +188,7 @@ class WallabagV1ImportTest extends \PHPUnit_Framework_TestCase | |||
188 | $res = $wallabagV1Import->setMarkAsRead(true)->import(); | 188 | $res = $wallabagV1Import->setMarkAsRead(true)->import(); |
189 | 189 | ||
190 | $this->assertTrue($res); | 190 | $this->assertTrue($res); |
191 | $this->assertEquals(['skipped' => 0, 'imported' => 0, 'queued' => 4], $wallabagV1Import->getSummary()); | 191 | $this->assertEquals(['skipped' => 0, 'imported' => 0, 'queued' => 2], $wallabagV1Import->getSummary()); |
192 | } | 192 | } |
193 | 193 | ||
194 | public function testImportWithRedis() | 194 | public function testImportWithRedis() |
@@ -226,7 +226,7 @@ class WallabagV1ImportTest extends \PHPUnit_Framework_TestCase | |||
226 | $res = $wallabagV1Import->setMarkAsRead(true)->import(); | 226 | $res = $wallabagV1Import->setMarkAsRead(true)->import(); |
227 | 227 | ||
228 | $this->assertTrue($res); | 228 | $this->assertTrue($res); |
229 | $this->assertEquals(['skipped' => 0, 'imported' => 0, 'queued' => 4], $wallabagV1Import->getSummary()); | 229 | $this->assertEquals(['skipped' => 0, 'imported' => 0, 'queued' => 2], $wallabagV1Import->getSummary()); |
230 | 230 | ||
231 | $this->assertNotEmpty($redisMock->lpop('wallabag_v1')); | 231 | $this->assertNotEmpty($redisMock->lpop('wallabag_v1')); |
232 | } | 232 | } |
diff --git a/tests/Wallabag/ImportBundle/Import/WallabagV2ImportTest.php b/tests/Wallabag/ImportBundle/Import/WallabagV2ImportTest.php index efcaeb9e..5cc04aa5 100644 --- a/tests/Wallabag/ImportBundle/Import/WallabagV2ImportTest.php +++ b/tests/Wallabag/ImportBundle/Import/WallabagV2ImportTest.php | |||
@@ -89,7 +89,7 @@ class WallabagV2ImportTest extends \PHPUnit_Framework_TestCase | |||
89 | ->disableOriginalConstructor() | 89 | ->disableOriginalConstructor() |
90 | ->getMock(); | 90 | ->getMock(); |
91 | 91 | ||
92 | $entryRepo->expects($this->exactly(24)) | 92 | $entryRepo->expects($this->exactly(6)) |
93 | ->method('findByUrlAndUserId') | 93 | ->method('findByUrlAndUserId') |
94 | ->will($this->onConsecutiveCalls(false, true, false)); | 94 | ->will($this->onConsecutiveCalls(false, true, false)); |
95 | 95 | ||
@@ -106,7 +106,7 @@ class WallabagV2ImportTest extends \PHPUnit_Framework_TestCase | |||
106 | $res = $wallabagV2Import->import(); | 106 | $res = $wallabagV2Import->import(); |
107 | 107 | ||
108 | $this->assertTrue($res); | 108 | $this->assertTrue($res); |
109 | $this->assertEquals(['skipped' => 22, 'imported' => 2, 'queued' => 0], $wallabagV2Import->getSummary()); | 109 | $this->assertEquals(['skipped' => 4, 'imported' => 2, 'queued' => 0], $wallabagV2Import->getSummary()); |
110 | } | 110 | } |
111 | 111 | ||
112 | public function testImportAndMarkAllAsRead() | 112 | public function testImportAndMarkAllAsRead() |
@@ -172,7 +172,7 @@ class WallabagV2ImportTest extends \PHPUnit_Framework_TestCase | |||
172 | ->getMock(); | 172 | ->getMock(); |
173 | 173 | ||
174 | $producer | 174 | $producer |
175 | ->expects($this->exactly(24)) | 175 | ->expects($this->exactly(6)) |
176 | ->method('publish'); | 176 | ->method('publish'); |
177 | 177 | ||
178 | $wallabagV2Import->setProducer($producer); | 178 | $wallabagV2Import->setProducer($producer); |
@@ -180,7 +180,7 @@ class WallabagV2ImportTest extends \PHPUnit_Framework_TestCase | |||
180 | $res = $wallabagV2Import->setMarkAsRead(true)->import(); | 180 | $res = $wallabagV2Import->setMarkAsRead(true)->import(); |
181 | 181 | ||
182 | $this->assertTrue($res); | 182 | $this->assertTrue($res); |
183 | $this->assertEquals(['skipped' => 0, 'imported' => 0, 'queued' => 24], $wallabagV2Import->getSummary()); | 183 | $this->assertEquals(['skipped' => 0, 'imported' => 0, 'queued' => 6], $wallabagV2Import->getSummary()); |
184 | } | 184 | } |
185 | 185 | ||
186 | public function testImportWithRedis() | 186 | public function testImportWithRedis() |
@@ -214,7 +214,7 @@ class WallabagV2ImportTest extends \PHPUnit_Framework_TestCase | |||
214 | $res = $wallabagV2Import->setMarkAsRead(true)->import(); | 214 | $res = $wallabagV2Import->setMarkAsRead(true)->import(); |
215 | 215 | ||
216 | $this->assertTrue($res); | 216 | $this->assertTrue($res); |
217 | $this->assertEquals(['skipped' => 0, 'imported' => 0, 'queued' => 24], $wallabagV2Import->getSummary()); | 217 | $this->assertEquals(['skipped' => 0, 'imported' => 0, 'queued' => 6], $wallabagV2Import->getSummary()); |
218 | 218 | ||
219 | $this->assertNotEmpty($redisMock->lpop('wallabag_v2')); | 219 | $this->assertNotEmpty($redisMock->lpop('wallabag_v2')); |
220 | } | 220 | } |
@@ -267,7 +267,7 @@ class WallabagV2ImportTest extends \PHPUnit_Framework_TestCase | |||
267 | ->disableOriginalConstructor() | 267 | ->disableOriginalConstructor() |
268 | ->getMock(); | 268 | ->getMock(); |
269 | 269 | ||
270 | $entryRepo->expects($this->exactly(24)) | 270 | $entryRepo->expects($this->exactly(6)) |
271 | ->method('findByUrlAndUserId') | 271 | ->method('findByUrlAndUserId') |
272 | ->will($this->onConsecutiveCalls(false, true, false)); | 272 | ->will($this->onConsecutiveCalls(false, true, false)); |
273 | 273 | ||
@@ -284,6 +284,6 @@ class WallabagV2ImportTest extends \PHPUnit_Framework_TestCase | |||
284 | $res = $wallabagV2Import->import(); | 284 | $res = $wallabagV2Import->import(); |
285 | 285 | ||
286 | $this->assertTrue($res); | 286 | $this->assertTrue($res); |
287 | $this->assertEquals(['skipped' => 22, 'imported' => 2, 'queued' => 0], $wallabagV2Import->getSummary()); | 287 | $this->assertEquals(['skipped' => 4, 'imported' => 2, 'queued' => 0], $wallabagV2Import->getSummary()); |
288 | } | 288 | } |
289 | } | 289 | } |