diff options
| author | Jerome Charaoui <jerome@riseup.net> | 2016-12-06 22:17:44 -0500 |
|---|---|---|
| committer | Jeremy Benoist <jbenoist@20minutes.fr> | 2017-06-01 09:43:01 +0200 |
| commit | 7aba665e484c5c36ee029219a999a427d864ff22 (patch) | |
| tree | 9ac57748d91cee32848b5e961e293e1c9a1fa61f /src/Wallabag/ImportBundle/Import/BrowserImport.php | |
| parent | 2a0eec07a5630401a9ceb7add65604f79238f10c (diff) | |
| download | wallabag-7aba665e484c5c36ee029219a999a427d864ff22.tar.gz wallabag-7aba665e484c5c36ee029219a999a427d864ff22.tar.zst wallabag-7aba665e484c5c36ee029219a999a427d864ff22.zip | |
Avoid returning objects passed by reference.
Objects are always passed by reference, so it doesn't make sense to
return an object which is passed by reference as it will always be the
same object. This change makes the code a bit more readable.
Diffstat (limited to 'src/Wallabag/ImportBundle/Import/BrowserImport.php')
| -rw-r--r-- | src/Wallabag/ImportBundle/Import/BrowserImport.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/Wallabag/ImportBundle/Import/BrowserImport.php b/src/Wallabag/ImportBundle/Import/BrowserImport.php index ef0eeb7e..71e65e59 100644 --- a/src/Wallabag/ImportBundle/Import/BrowserImport.php +++ b/src/Wallabag/ImportBundle/Import/BrowserImport.php | |||
| @@ -201,7 +201,7 @@ abstract class BrowserImport extends AbstractImport | |||
| 201 | $entry->setTitle($data['title']); | 201 | $entry->setTitle($data['title']); |
| 202 | 202 | ||
| 203 | // update entry with content (in case fetching failed, the given entry will be return) | 203 | // update entry with content (in case fetching failed, the given entry will be return) |
| 204 | $entry = $this->fetchContent($entry, $data['url'], $data); | 204 | $this->fetchContent($entry, $data['url'], $data); |
| 205 | 205 | ||
| 206 | if (array_key_exists('tags', $data)) { | 206 | if (array_key_exists('tags', $data)) { |
| 207 | $this->tagsAssigner->assignTagsToEntry( | 207 | $this->tagsAssigner->assignTagsToEntry( |