aboutsummaryrefslogtreecommitdiffhomepage
path: root/vendor/google.golang.org/grpc/CONTRIBUTING.md
diff options
context:
space:
mode:
Diffstat (limited to 'vendor/google.golang.org/grpc/CONTRIBUTING.md')
-rw-r--r--vendor/google.golang.org/grpc/CONTRIBUTING.md6
1 files changed, 5 insertions, 1 deletions
diff --git a/vendor/google.golang.org/grpc/CONTRIBUTING.md b/vendor/google.golang.org/grpc/CONTRIBUTING.md
index a5c6e06..0863eb2 100644
--- a/vendor/google.golang.org/grpc/CONTRIBUTING.md
+++ b/vendor/google.golang.org/grpc/CONTRIBUTING.md
@@ -7,7 +7,7 @@ If you are new to github, please start by reading [Pull Request howto](https://h
7## Legal requirements 7## Legal requirements
8 8
9In order to protect both you and ourselves, you will need to sign the 9In order to protect both you and ourselves, you will need to sign the
10[Contributor License Agreement](https://cla.developers.google.com/clas). 10[Contributor License Agreement](https://identity.linuxfoundation.org/projects/cncf).
11 11
12## Guidelines for Pull Requests 12## Guidelines for Pull Requests
13How to get your contributions merged smoothly and quickly. 13How to get your contributions merged smoothly and quickly.
@@ -27,6 +27,10 @@ How to get your contributions merged smoothly and quickly.
27- Keep your PR up to date with upstream/master (if there are merge conflicts, we can't really merge your change). 27- Keep your PR up to date with upstream/master (if there are merge conflicts, we can't really merge your change).
28 28
29- **All tests need to be passing** before your change can be merged. We recommend you **run tests locally** before creating your PR to catch breakages early on. 29- **All tests need to be passing** before your change can be merged. We recommend you **run tests locally** before creating your PR to catch breakages early on.
30 - `make all` to test everything, OR
31 - `make vet` to catch vet errors
32 - `make test` to run the tests
33 - `make testrace` to run tests in race mode
30 34
31- Exceptions to the rules can be made if there's a compelling reason for doing so. 35- Exceptions to the rules can be made if there's a compelling reason for doing so.
32 36