blob: bb79091bb241eed32c4a77c52b239ae322f2842b (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
|
require 'pronto'
require 'shellwords'
module Pronto
class ESLintNpm < Runner
CONFIG_FILE = '.pronto_eslint_npm.yml'.freeze
CONFIG_KEYS = %w(eslint_executable files_to_lint).freeze
attr_writer :eslint_executable
def eslint_executable
@eslint_executable || 'eslint'.freeze
end
def files_to_lint
@files_to_lint || /(\.js|\.es6)$/
end
def files_to_lint=(regexp)
@files_to_lint = regexp.is_a?(Regexp) && regexp || Regexp.new(regexp)
end
def read_config
config_file = File.join(repo_path, CONFIG_FILE)
return unless File.exist?(config_file)
config = YAML.load_file(config_file)
CONFIG_KEYS.each do |config_key|
next unless config[config_key]
send("#{config_key}=", config[config_key])
end
end
def run
return [] if !@patches || @patches.count.zero?
read_config
@patches
.select { |patch| patch.additions > 0 }
.select { |patch| js_file?(patch.new_file_full_path) }
.map { |patch| inspect(patch) }
.flatten.compact
end
private
def repo_path
@_repo_path ||= @patches.first.repo.path
end
def inspect(patch)
offences = run_eslint(patch)
clean_up_eslint_output(offences)
.map do |offence|
patch
.added_lines
.select { |line| line.new_lineno == offence['line'] }
.map { |line| new_message(offence, line) }
end
end
def new_message(offence, line)
path = line.patch.delta.new_file[:path]
level = :warning
Message.new(path, line, level, offence['message'], nil, self.class)
end
def js_file?(path)
files_to_lint =~ path.to_s
end
def run_eslint(patch)
Dir.chdir(repo_path) do
escaped_file_path = Shellwords.escape(patch.new_file_full_path.to_s)
JSON.parse(
`#{eslint_executable} #{escaped_file_path} -f json`
)
end
end
def clean_up_eslint_output(output)
# 1. Filter out offences without a warning or error
# 2. Get the messages for that file
# 3. Ignore errors without a line number for now
output
.select { |offence| offence['errorCount'] + offence['warningCount'] > 0 }
.map { |offence| offence['messages'] }
.flatten.select { |offence| offence['line'] }
end
end
end
|
