Welcom pronto-hlint! This is a whole rewrite of pronto-eslint_npm.

Forking the pronto-eslint_npm repository to build a runner for hlint
haskell linter.

2 files changed, 138 insertions, 163 deletions

diff --git a/spec/pronto/eslint_spec.rb b/spec/pronto/eslint_spec.rb
deleted file mode 100644
index 0924f30..0000000
--- a/spec/pronto/eslint_spec.rb
+++ /dev/null
@@ -1,163 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-module Pronto
-  describe ESLintNpm do
-    let(:eslint) { ESLintNpm.new(patches) }
-    let(:patches) { [] }
-
-    describe '#run' do
-      subject(:run) { eslint.run }
-
-      context 'patches are nil' do
-        let(:patches) { nil }
-
-        it 'returns an empty array' do
-          expect(run).to eql([])
-        end
-      end
-
-      context 'no patches' do
-        let(:patches) { [] }
-
-        it 'returns an empty array' do
-          expect(run).to eql([])
-        end
-      end
-
-      context 'patches with a one and a four warnings' do
-        include_context 'test repo'
-
-        let(:patches) { repo.diff('master') }
-
-        it 'returns correct number of errors' do
-          expect(run.count).to eql(5)
-        end
-
-        it 'has correct first message' do
-          expect(run.first.msg).to eql("'foo' is not defined.")
-        end
-
-        context(
-          'with files to lint config that never matches',
-          config: { 'files_to_lint' => 'will never match' }
-        ) do
-          it 'returns zero errors' do
-            expect(run.count).to eql(0)
-          end
-        end
-
-        context(
-          'with files to lint config that matches only .js',
-          config: { 'files_to_lint' => '\.js$' }
-        ) do
-          it 'returns correct amount of errors' do
-            expect(run.count).to eql(2)
-          end
-        end
-
-        context(
-          'with cmd_line_opts to include .html',
-          config: { 'cmd_line_opts' => '--ext .html' }
-        ) do
-          it 'returns correct number of errors' do
-            expect(run.count).to eql 5
-          end
-        end
-
-        context(
-          'with different eslint executable',
-          config: { 'eslint_executable' => './custom_eslint.sh' }
-        ) do
-          it 'calls the custom eslint eslint_executable' do
-            expect { run }.to raise_error(JSON::ParserError, /custom eslint called/)
-          end
-        end
-      end
-
-      context 'repo with ignored and not ignored file, each with three warnings' do
-        include_context 'eslintignore repo'
-
-        let(:patches) { repo.diff('master') }
-
-        it 'returns correct number of errors' do
-          expect(run.count).to eql(3)
-        end
-
-        it 'has correct first message' do
-          expect(run.first.msg).to eql("'HelloWorld' is defined but never used.")
-        end
-      end
-    end
-
-    describe '#files_to_lint' do
-      subject(:files_to_lint) { eslint.files_to_lint }
-
-      it 'matches .js by default' do
-        expect(files_to_lint).to match('my_js.js')
-      end
-
-      it 'matches .es6 by default' do
-        expect(files_to_lint).to match('my_js.es6')
-      end
-    end
-
-    describe '#eslint_executable' do
-      subject(:eslint_executable) { eslint.eslint_executable }
-
-      it 'is `eslint` by default' do
-        expect(eslint_executable).to eql('eslint')
-      end
-
-      context(
-        'with different eslint executable config',
-        config: { 'eslint_executable' => 'custom_eslint' }
-      ) do
-        it 'is correct' do
-          eslint.read_config
-          expect(eslint_executable).to eql('custom_eslint')
-        end
-      end
-    end
-
-    describe '#eslint_command_line' do
-      subject(:eslint_command_line) { eslint.send(:eslint_command_line, path) }
-      let(:path) { '/some/path.rb' }
-
-      it 'adds json output flag' do
-        expect(eslint_command_line).to include('-f json')
-      end
-
-      it 'adds path' do
-        expect(eslint_command_line).to include(path)
-      end
-
-      it 'starts with eslint executable' do
-        expect(eslint_command_line).to start_with(eslint.eslint_executable)
-      end
-
-      context 'with path that should be escaped' do
-        let(:path) { '/must be/$escaped' }
-
-        it 'escapes the path correctly' do
-          expect(eslint_command_line).to include('/must\\ be/\\$escaped')
-        end
-
-        it 'does not include unescaped path' do
-          expect(eslint_command_line).not_to include(path)
-        end
-      end
-      
-      context(
-        'with some command line options',
-        config: { 'cmd_line_opts' => '--my command --line opts' }
-      ) do
-        it 'includes the custom command line options' do
-          eslint.read_config
-          expect(eslint_command_line).to include('--my command --line opts')
-        end
-      end
-    end
-  end
-end
diff --git a/spec/pronto/hlint_spec.rb b/spec/pronto/hlint_spec.rb
new file mode 100644
index 0000000..fdabab5
--- /dev/null
+++ b/spec/pronto/hlint_spec.rb
@@ -0,0 +1,138 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+module Pronto
+  module Hlint
+    describe Runner do
+      let(:hlint) { Hlint::Runner.new(patches) }
+      let(:patches) { [] }
+
+      describe '#run' do
+        subject(:run) { hlint.run }
+
+        context 'patches are nil' do
+          let(:patches) { nil }
+
+          it 'returns an empty array' do
+            expect(run).to eql([])
+          end
+        end
+
+        context 'no patches' do
+          let(:patches) { [] }
+
+          it 'returns an empty array' do
+            expect(run).to eql([])
+          end
+        end
+
+        context 'patches with a one and a four warnings' do
+          include_context 'test repo'
+
+          let(:patches) { repo.diff('master') }
+
+          it 'returns correct number of errors' do
+            expect(run.count).to eql(3)
+          end
+
+          it 'has correct first message' do
+            expect(run.first.msg).to match("Unused LANGUAGE pragma")
+          end
+
+          context(
+            'with files to lint config that never matches',
+            config: { 'files_to_lint' => 'will never match' }
+          ) do
+            it 'returns zero errors' do
+              expect(run.count).to eql(0)
+            end
+          end
+
+          context(
+            'with files to lint config that matches only .lhs',
+            config: { 'files_to_lint' => '\.lhs$' }
+          ) do
+            it 'returns correct amount of errors' do
+              expect(run.count).to eql(0)
+            end
+          end
+
+          context(
+            'with different hlint executable',
+            config: { 'hlint_executable' => './custom_hlint.sh' }
+          ) do
+            it 'calls the custom hlint hlint_executable' do
+              expect { run }.to raise_error(JSON::ParserError, /hlint called!/)
+            end
+          end
+        end
+      end
+
+      describe '#files_to_lint' do
+        subject(:files_to_lint) { hlint.files_to_lint }
+
+        it 'matches .he by default' do
+          expect(files_to_lint).to match('Types.hs')
+        end
+      end
+
+      describe '#hlint_executable' do
+        subject(:hlint_executable) { hlint.hlint_executable }
+
+        it 'is `hlint` by default' do
+          expect(hlint_executable).to eql('hlint')
+        end
+
+        context(
+          'with different hlint executable config',
+          config: { 'hlint_executable' => 'custom_hlint' }
+        ) do
+          it 'is correct' do
+            hlint.read_config
+            expect(hlint_executable).to eql('custom_hlint')
+          end
+        end
+      end
+
+      describe '#hlint_command_line' do
+        subject(:hlint_command_line) { hlint.send(:hlint_command_line, path) }
+        let(:path) { '/some/path.rb' }
+
+        it 'adds json output flag' do
+          expect(hlint_command_line).to include('--json')
+        end
+
+        it 'adds path' do
+          expect(hlint_command_line).to include(path)
+        end
+
+        it 'starts with hlint executable' do
+          expect(hlint_command_line).to start_with(hlint.hlint_executable)
+        end
+
+        context 'with path that should be escaped' do
+          let(:path) { '/must be/$escaped' }
+
+          it 'escapes the path correctly' do
+            expect(hlint_command_line).to include('/must\\ be/\\$escaped')
+          end
+
+          it 'does not include unescaped path' do
+            expect(hlint_command_line).not_to include(path)
+          end
+        end
+
+        context(
+          'with some command line options',
+          config: { 'cmd_line_opts' => '--my command --line opts' }
+        ) do
+          it 'includes the custom command line options' do
+            hlint.read_config
+            expect(hlint_command_line).to include('--my command --line opts')
+          end
+        end
+      end
+    end
+  end
+end