1 files changed, 65 insertions, 49 deletions

diff --git a/server/tests/api/check-params/video-playlists.ts b/server/tests/api/check-params/video-playlists.ts
index 179ae9201..418af05d1 100644
--- a/server/tests/api/check-params/video-playlists.ts
+++ b/server/tests/api/check-params/video-playlists.ts
@@ -28,6 +28,7 @@ import {
 } from '../../../../shared/extra-utils/requests/check-api-params'
 import { VideoPlaylistPrivacy } from '../../../../shared/models/videos/playlist/video-playlist-privacy.model'
 import { VideoPlaylistType } from '../../../../shared/models/videos/playlist/video-playlist-type.model'
+import { HttpStatusCode } from '../../../../shared/core-utils/miscs/http-error-codes'
 
 describe('Test video playlists API validator', function () {
   let server: ServerInfo
@@ -114,19 +115,34 @@ describe('Test video playlists API validator', function () {
     it('Should fail with a bad account parameter', async function () {
       const accountPath = '/api/v1/accounts/root2/video-playlists'
 
-      await makeGetRequest({ url: server.url, path: accountPath, statusCodeExpected: 404, token: server.accessToken })
+      await makeGetRequest({
+        url: server.url,
+        path: accountPath,
+        statusCodeExpected: HttpStatusCode.NOT_FOUND_404,
+        token: server.accessToken
+      })
     })
 
     it('Should fail with a bad video channel parameter', async function () {
       const accountPath = '/api/v1/video-channels/bad_channel/video-playlists'
 
-      await makeGetRequest({ url: server.url, path: accountPath, statusCodeExpected: 404, token: server.accessToken })
+      await makeGetRequest({
+        url: server.url,
+        path: accountPath,
+        statusCodeExpected: HttpStatusCode.NOT_FOUND_404,
+        token: server.accessToken
+      })
     })
 
     it('Should success with the correct parameters', async function () {
-      await makeGetRequest({ url: server.url, path: globalPath, statusCodeExpected: 200, token: server.accessToken })
-      await makeGetRequest({ url: server.url, path: accountPath, statusCodeExpected: 200, token: server.accessToken })
-      await makeGetRequest({ url: server.url, path: videoChannelPath, statusCodeExpected: 200, token: server.accessToken })
+      await makeGetRequest({ url: server.url, path: globalPath, statusCodeExpected: HttpStatusCode.OK_200, token: server.accessToken })
+      await makeGetRequest({ url: server.url, path: accountPath, statusCodeExpected: HttpStatusCode.OK_200, token: server.accessToken })
+      await makeGetRequest({
+        url: server.url,
+        path: videoChannelPath,
+        statusCodeExpected: HttpStatusCode.OK_200,
+        token: server.accessToken
+      })
     })
   })
 
@@ -142,17 +158,17 @@ describe('Test video playlists API validator', function () {
     })
 
     it('Should success with the correct parameters', async function () {
-      await makeGetRequest({ url: server.url, path: path + playlistUUID + '/videos', statusCodeExpected: 200 })
+      await makeGetRequest({ url: server.url, path: path + playlistUUID + '/videos', statusCodeExpected: HttpStatusCode.OK_200 })
     })
   })
 
   describe('When getting a video playlist', function () {
     it('Should fail with a bad id or uuid', async function () {
-      await getVideoPlaylist(server.url, 'toto', 400)
+      await getVideoPlaylist(server.url, 'toto', HttpStatusCode.BAD_REQUEST_400)
     })
 
     it('Should fail with an unknown playlist', async function () {
-      await getVideoPlaylist(server.url, 42, 404)
+      await getVideoPlaylist(server.url, 42, HttpStatusCode.NOT_FOUND_404)
     })
 
     it('Should fail to get an unlisted playlist with the number id', async function () {
@@ -166,19 +182,19 @@ describe('Test video playlists API validator', function () {
       })
       const playlist = res.body.videoPlaylist
 
-      await getVideoPlaylist(server.url, playlist.id, 404)
-      await getVideoPlaylist(server.url, playlist.uuid, 200)
+      await getVideoPlaylist(server.url, playlist.id, HttpStatusCode.NOT_FOUND_404)
+      await getVideoPlaylist(server.url, playlist.uuid, HttpStatusCode.OK_200)
     })
 
     it('Should succeed with the correct params', async function () {
-      await getVideoPlaylist(server.url, playlistUUID, 200)
+      await getVideoPlaylist(server.url, playlistUUID, HttpStatusCode.OK_200)
     })
   })
 
   describe('When creating/updating a video playlist', function () {
     const getBase = (playlistAttrs: any = {}, wrapper: any = {}) => {
       return Object.assign({
-        expectedStatus: 400,
+        expectedStatus: HttpStatusCode.BAD_REQUEST_400,
         url: server.url,
         token: server.accessToken,
         playlistAttrs: Object.assign({
@@ -194,7 +210,7 @@ describe('Test video playlists API validator', function () {
     }
 
     it('Should fail with an unauthenticated user', async function () {
-      const params = getBase({}, { token: null, expectedStatus: 401 })
+      const params = getBase({}, { token: null, expectedStatus: HttpStatusCode.UNAUTHORIZED_401 })
 
       await createVideoPlaylist(params)
       await updateVideoPlaylist(getUpdate(params, playlistUUID))
@@ -228,7 +244,7 @@ describe('Test video playlists API validator', function () {
     })
 
     it('Should fail with an unknown video channel id', async function () {
-      const params = getBase({ videoChannelId: 42 }, { expectedStatus: 404 })
+      const params = getBase({ videoChannelId: 42 }, { expectedStatus: HttpStatusCode.NOT_FOUND_404 })
 
       await createVideoPlaylist(params)
       await updateVideoPlaylist(getUpdate(params, playlistUUID))
@@ -255,33 +271,33 @@ describe('Test video playlists API validator', function () {
 
     it('Should fail with an unknown playlist to update', async function () {
       await updateVideoPlaylist(getUpdate(
-        getBase({}, { expectedStatus: 404 }),
+        getBase({}, { expectedStatus: HttpStatusCode.NOT_FOUND_404 }),
         42
       ))
     })
 
     it('Should fail to update a playlist of another user', async function () {
       await updateVideoPlaylist(getUpdate(
-        getBase({}, { token: userAccessToken, expectedStatus: 403 }),
+        getBase({}, { token: userAccessToken, expectedStatus: HttpStatusCode.FORBIDDEN_403 }),
         playlistUUID
       ))
     })
 
     it('Should fail to update the watch later playlist', async function () {
       await updateVideoPlaylist(getUpdate(
-        getBase({}, { expectedStatus: 400 }),
+        getBase({}, { expectedStatus: HttpStatusCode.BAD_REQUEST_400 }),
         watchLaterPlaylistId
       ))
     })
 
     it('Should succeed with the correct params', async function () {
       {
-        const params = getBase({}, { expectedStatus: 200 })
+        const params = getBase({}, { expectedStatus: HttpStatusCode.OK_200 })
         await createVideoPlaylist(params)
       }
 
       {
-        const params = getBase({}, { expectedStatus: 204 })
+        const params = getBase({}, { expectedStatus: HttpStatusCode.NO_CONTENT_204 })
         await updateVideoPlaylist(getUpdate(params, playlistUUID))
       }
     })
@@ -290,7 +306,7 @@ describe('Test video playlists API validator', function () {
   describe('When adding an element in a playlist', function () {
     const getBase = (elementAttrs: any = {}, wrapper: any = {}) => {
       return Object.assign({
-        expectedStatus: 400,
+        expectedStatus: HttpStatusCode.BAD_REQUEST_400,
         url: server.url,
         token: server.accessToken,
         playlistId: playlistUUID,
@@ -303,12 +319,12 @@ describe('Test video playlists API validator', function () {
     }
 
     it('Should fail with an unauthenticated user', async function () {
-      const params = getBase({}, { token: null, expectedStatus: 401 })
+      const params = getBase({}, { token: null, expectedStatus: HttpStatusCode.UNAUTHORIZED_401 })
       await addVideoInPlaylist(params)
     })
 
     it('Should fail with the playlist of another user', async function () {
-      const params = getBase({}, { token: userAccessToken, expectedStatus: 403 })
+      const params = getBase({}, { token: userAccessToken, expectedStatus: HttpStatusCode.FORBIDDEN_403 })
       await addVideoInPlaylist(params)
     })
 
@@ -319,13 +335,13 @@ describe('Test video playlists API validator', function () {
       }
 
       {
-        const params = getBase({}, { playlistId: 42, expectedStatus: 404 })
+        const params = getBase({}, { playlistId: 42, expectedStatus: HttpStatusCode.NOT_FOUND_404 })
         await addVideoInPlaylist(params)
       }
     })
 
     it('Should fail with an unknown or incorrect video id', async function () {
-      const params = getBase({ videoId: 42 }, { expectedStatus: 404 })
+      const params = getBase({ videoId: 42 }, { expectedStatus: HttpStatusCode.NOT_FOUND_404 })
       await addVideoInPlaylist(params)
     })
 
@@ -342,7 +358,7 @@ describe('Test video playlists API validator', function () {
     })
 
     it('Succeed with the correct params', async function () {
-      const params = getBase({}, { expectedStatus: 200 })
+      const params = getBase({}, { expectedStatus: HttpStatusCode.OK_200 })
       const res = await addVideoInPlaylist(params)
       playlistElementId = res.body.videoPlaylistElement.id
     })
@@ -359,17 +375,17 @@ describe('Test video playlists API validator', function () {
         }, elementAttrs),
         playlistElementId,
         playlistId: playlistUUID,
-        expectedStatus: 400
+        expectedStatus: HttpStatusCode.BAD_REQUEST_400
       }, wrapper)
     }
 
     it('Should fail with an unauthenticated user', async function () {
-      const params = getBase({}, { token: null, expectedStatus: 401 })
+      const params = getBase({}, { token: null, expectedStatus: HttpStatusCode.UNAUTHORIZED_401 })
       await updateVideoPlaylistElement(params)
     })
 
     it('Should fail with the playlist of another user', async function () {
-      const params = getBase({}, { token: userAccessToken, expectedStatus: 403 })
+      const params = getBase({}, { token: userAccessToken, expectedStatus: HttpStatusCode.FORBIDDEN_403 })
       await updateVideoPlaylistElement(params)
     })
 
@@ -380,7 +396,7 @@ describe('Test video playlists API validator', function () {
       }
 
       {
-        const params = getBase({}, { playlistId: 42, expectedStatus: 404 })
+        const params = getBase({}, { playlistId: 42, expectedStatus: HttpStatusCode.NOT_FOUND_404 })
         await updateVideoPlaylistElement(params)
       }
     })
@@ -392,7 +408,7 @@ describe('Test video playlists API validator', function () {
       }
 
       {
-        const params = getBase({}, { playlistElementId: 42, expectedStatus: 404 })
+        const params = getBase({}, { playlistElementId: 42, expectedStatus: HttpStatusCode.NOT_FOUND_404 })
         await updateVideoPlaylistElement(params)
       }
     })
@@ -410,12 +426,12 @@ describe('Test video playlists API validator', function () {
     })
 
     it('Should fail with an unknown element', async function () {
-      const params = getBase({}, { playlistElementId: 888, expectedStatus: 404 })
+      const params = getBase({}, { playlistElementId: 888, expectedStatus: HttpStatusCode.NOT_FOUND_404 })
       await updateVideoPlaylistElement(params)
     })
 
     it('Succeed with the correct params', async function () {
-      const params = getBase({}, { expectedStatus: 204 })
+      const params = getBase({}, { expectedStatus: HttpStatusCode.NO_CONTENT_204 })
       await updateVideoPlaylistElement(params)
     })
   })
@@ -434,7 +450,7 @@ describe('Test video playlists API validator', function () {
           insertAfterPosition: 2,
           reorderLength: 3
         }, elementAttrs),
-        expectedStatus: 400
+        expectedStatus: HttpStatusCode.BAD_REQUEST_400
       }, wrapper)
     }
 
@@ -453,12 +469,12 @@ describe('Test video playlists API validator', function () {
     })
 
     it('Should fail with an unauthenticated user', async function () {
-      const params = getBase({}, { token: null, expectedStatus: 401 })
+      const params = getBase({}, { token: null, expectedStatus: HttpStatusCode.UNAUTHORIZED_401 })
       await reorderVideosPlaylist(params)
     })
 
     it('Should fail with the playlist of another user', async function () {
-      const params = getBase({}, { token: userAccessToken, expectedStatus: 403 })
+      const params = getBase({}, { token: userAccessToken, expectedStatus: HttpStatusCode.FORBIDDEN_403 })
       await reorderVideosPlaylist(params)
     })
 
@@ -469,7 +485,7 @@ describe('Test video playlists API validator', function () {
       }
 
       {
-        const params = getBase({}, { playlistId: 42, expectedStatus: 404 })
+        const params = getBase({}, { playlistId: 42, expectedStatus: HttpStatusCode.NOT_FOUND_404 })
         await reorderVideosPlaylist(params)
       }
     })
@@ -526,7 +542,7 @@ describe('Test video playlists API validator', function () {
     })
 
     it('Succeed with the correct params', async function () {
-      const params = getBase({}, { expectedStatus: 204 })
+      const params = getBase({}, { expectedStatus: HttpStatusCode.NO_CONTENT_204 })
       await reorderVideosPlaylist(params)
     })
   })
@@ -539,7 +555,7 @@ describe('Test video playlists API validator', function () {
         url: server.url,
         path,
         query: { videoIds: [ 1, 2 ] },
-        statusCodeExpected: 401
+        statusCodeExpected: HttpStatusCode.UNAUTHORIZED_401
       })
     })
 
@@ -572,7 +588,7 @@ describe('Test video playlists API validator', function () {
         token: server.accessToken,
         path,
         query: { videoIds: [ 1, 2 ] },
-        statusCodeExpected: 200
+        statusCodeExpected: HttpStatusCode.OK_200
       })
     })
   })
@@ -584,17 +600,17 @@ describe('Test video playlists API validator', function () {
         token: server.accessToken,
         playlistElementId,
         playlistId: playlistUUID,
-        expectedStatus: 400
+        expectedStatus: HttpStatusCode.BAD_REQUEST_400
       }, wrapper)
     }
 
     it('Should fail with an unauthenticated user', async function () {
-      const params = getBase({ token: null, expectedStatus: 401 })
+      const params = getBase({ token: null, expectedStatus: HttpStatusCode.UNAUTHORIZED_401 })
       await removeVideoFromPlaylist(params)
     })
 
     it('Should fail with the playlist of another user', async function () {
-      const params = getBase({ token: userAccessToken, expectedStatus: 403 })
+      const params = getBase({ token: userAccessToken, expectedStatus: HttpStatusCode.FORBIDDEN_403 })
       await removeVideoFromPlaylist(params)
     })
 
@@ -605,7 +621,7 @@ describe('Test video playlists API validator', function () {
       }
 
       {
-        const params = getBase({ playlistId: 42, expectedStatus: 404 })
+        const params = getBase({ playlistId: 42, expectedStatus: HttpStatusCode.NOT_FOUND_404 })
         await removeVideoFromPlaylist(params)
       }
     })
@@ -617,33 +633,33 @@ describe('Test video playlists API validator', function () {
       }
 
       {
-        const params = getBase({ playlistElementId: 42, expectedStatus: 404 })
+        const params = getBase({ playlistElementId: 42, expectedStatus: HttpStatusCode.NOT_FOUND_404 })
         await removeVideoFromPlaylist(params)
       }
     })
 
     it('Should fail with an unknown element', async function () {
-      const params = getBase({ playlistElementId: 888, expectedStatus: 404 })
+      const params = getBase({ playlistElementId: 888, expectedStatus: HttpStatusCode.NOT_FOUND_404 })
       await removeVideoFromPlaylist(params)
     })
 
     it('Succeed with the correct params', async function () {
-      const params = getBase({ expectedStatus: 204 })
+      const params = getBase({ expectedStatus: HttpStatusCode.NO_CONTENT_204 })
       await removeVideoFromPlaylist(params)
     })
   })
 
   describe('When deleting a playlist', function () {
     it('Should fail with an unknown playlist', async function () {
-      await deleteVideoPlaylist(server.url, server.accessToken, 42, 404)
+      await deleteVideoPlaylist(server.url, server.accessToken, 42, HttpStatusCode.NOT_FOUND_404)
     })
 
     it('Should fail with a playlist of another user', async function () {
-      await deleteVideoPlaylist(server.url, userAccessToken, playlistUUID, 403)
+      await deleteVideoPlaylist(server.url, userAccessToken, playlistUUID, HttpStatusCode.FORBIDDEN_403)
     })
 
     it('Should fail with the watch later playlist', async function () {
-      await deleteVideoPlaylist(server.url, server.accessToken, watchLaterPlaylistId, 400)
+      await deleteVideoPlaylist(server.url, server.accessToken, watchLaterPlaylistId, HttpStatusCode.BAD_REQUEST_400)
     })
 
     it('Should succeed with the correct params', async function () {