Add plugin settings change watcher

3 files changed, 12 insertions, 5 deletions

diff --git a/server/tests/api/server/plugins.ts b/server/tests/api/server/plugins.ts
index 452d05012..9885be4e8 100644
--- a/server/tests/api/server/plugins.ts
+++ b/server/tests/api/server/plugins.ts
@@ -27,7 +27,8 @@ import {
   updatePlugin,
   updatePluginPackageJSON,
   updatePluginSettings,
-  wait
+  wait,
+  waitUntilLog
 } from '../../../../shared/extra-utils'
 import { PluginType } from '../../../../shared/models/plugins/plugin.type'
 import { PeerTubePluginIndex } from '../../../../shared/models/plugins/peertube-plugin-index.model'
@@ -142,7 +143,7 @@ describe('Test plugins', function () {
   it('Should have the correct global css', async function () {
     const res = await getPluginsCSS(server.url)
 
-    expect(res.text).to.contain('--mainBackgroundColor')
+    expect(res.text).to.contain('background-color: red')
   })
 
   it('Should have the plugin loaded in the configuration', async function () {
@@ -258,6 +259,12 @@ describe('Test plugins', function () {
     })
   })
 
+  it('Should have watched settings changes', async function () {
+    this.timeout(10000)
+
+    await waitUntilLog(server, 'Settings changed!')
+  })
+
   it('Should get a plugin and a theme', async function () {
     {
       const res = await getPlugin({
diff --git a/server/tests/fixtures/peertube-plugin-test-external-auth-one/main.js b/server/tests/fixtures/peertube-plugin-test-external-auth-one/main.js
index f29fd1f30..91c67e550 100644
--- a/server/tests/fixtures/peertube-plugin-test-external-auth-one/main.js
+++ b/server/tests/fixtures/peertube-plugin-test-external-auth-one/main.js
@@ -5,7 +5,7 @@ async function register ({
   {
     const result = registerExternalAuth({
       authName: 'external-auth-1',
-      authDisplayName: 'External Auth 1',
+      authDisplayName: () => 'External Auth 1',
       onLogout: user => peertubeHelpers.logger.info('On logout %s', user.username),
       onAuthRequest: (req, res) => {
         const username = req.query.username
@@ -23,7 +23,7 @@ async function register ({
   {
     const result = registerExternalAuth({
       authName: 'external-auth-2',
-      authDisplayName: 'External Auth 2',
+      authDisplayName: () => 'External Auth 2',
       onAuthRequest: (req, res) => {
         result.userAuthenticated({
           req,
diff --git a/server/tests/fixtures/peertube-plugin-test-external-auth-two/main.js b/server/tests/fixtures/peertube-plugin-test-external-auth-two/main.js
index 34fec1bb3..126905ffc 100644
--- a/server/tests/fixtures/peertube-plugin-test-external-auth-two/main.js
+++ b/server/tests/fixtures/peertube-plugin-test-external-auth-two/main.js
@@ -5,7 +5,7 @@ async function register ({
   {
     const result = registerExternalAuth({
       authName: 'external-auth-3',
-      authDisplayName: 'External Auth 3',
+      authDisplayName: () => 'External Auth 3',
       onAuthRequest: (req, res) => {
         result.userAuthenticated({
           req,