Prevent object storage mock conflicts

When running tests in parallel

3 files changed, 44 insertions, 26 deletions

diff --git a/server/tests/peertube-runner/live-transcoding.ts b/server/tests/peertube-runner/live-transcoding.ts
index e7ef941c6..c2ca1de96 100644
--- a/server/tests/peertube-runner/live-transcoding.ts
+++ b/server/tests/peertube-runner/live-transcoding.ts
@@ -31,8 +31,8 @@ describe('Test Live transcoding in peertube-runner program', function () {
   let sqlCommandServer1: SQLCommand
 
   function runSuite (options: {
-    objectStorage: boolean
-  }) {
+    objectStorage?: ObjectStorageCommand
+  } = {}) {
     const { objectStorage } = options
 
     it('Should enable transcoding without additional resolutions', async function () {
@@ -117,7 +117,7 @@ describe('Test Live transcoding in peertube-runner program', function () {
 
         for (const file of files) {
           if (objectStorage) {
-            expectStartWith(file.fileUrl, ObjectStorageCommand.getMockPlaylistBaseUrl())
+            expectStartWith(file.fileUrl, objectStorage.getMockPlaylistBaseUrl())
           }
 
           await makeRawRequest({ url: file.fileUrl, expectedStatus: HttpStatusCode.OK_200 })
@@ -155,24 +155,30 @@ describe('Test Live transcoding in peertube-runner program', function () {
       await servers[0].config.enableTranscoding(true, false, true)
     })
 
-    runSuite({ objectStorage: false })
+    runSuite()
   })
 
   describe('With lives on object storage', function () {
     if (areMockObjectStorageTestsDisabled()) return
 
+    const objectStorage = new ObjectStorageCommand()
+
     before(async function () {
-      await ObjectStorageCommand.prepareDefaultMockBuckets()
+      await objectStorage.prepareDefaultMockBuckets()
 
       await servers[0].kill()
 
-      await servers[0].run(ObjectStorageCommand.getDefaultMockConfig())
+      await servers[0].run(objectStorage.getDefaultMockConfig())
 
       // Wait for peertube runner socket reconnection
       await wait(1500)
     })
 
-    runSuite({ objectStorage: true })
+    runSuite({ objectStorage })
+
+    after(async function () {
+      await objectStorage.cleanupMock()
+    })
   })
 
   describe('Check cleanup', function () {
diff --git a/server/tests/peertube-runner/studio-transcoding.ts b/server/tests/peertube-runner/studio-transcoding.ts
index 400203eb3..69b38a536 100644
--- a/server/tests/peertube-runner/studio-transcoding.ts
+++ b/server/tests/peertube-runner/studio-transcoding.ts
@@ -19,8 +19,8 @@ describe('Test studio transcoding in peertube-runner program', function () {
   let peertubeRunner: PeerTubeRunnerProcess
 
   function runSuite (options: {
-    objectStorage: boolean
-  }) {
+    objectStorage?: ObjectStorageCommand
+  } = {}) {
     const { objectStorage } = options
 
     it('Should run a complex studio transcoding', async function () {
@@ -45,11 +45,11 @@ describe('Test studio transcoding in peertube-runner program', function () {
 
         if (objectStorage) {
           for (const webtorrentFile of video.files) {
-            expectStartWith(webtorrentFile.fileUrl, ObjectStorageCommand.getMockWebTorrentBaseUrl())
+            expectStartWith(webtorrentFile.fileUrl, objectStorage.getMockWebVideosBaseUrl())
           }
 
           for (const hlsFile of video.streamingPlaylists[0].files) {
-            expectStartWith(hlsFile.fileUrl, ObjectStorageCommand.getMockPlaylistBaseUrl())
+            expectStartWith(hlsFile.fileUrl, objectStorage.getMockPlaylistBaseUrl())
           }
         }
 
@@ -80,24 +80,30 @@ describe('Test studio transcoding in peertube-runner program', function () {
   })
 
   describe('With videos on local filesystem storage', function () {
-    runSuite({ objectStorage: false })
+    runSuite()
   })
 
   describe('With videos on object storage', function () {
     if (areMockObjectStorageTestsDisabled()) return
 
+    const objectStorage = new ObjectStorageCommand()
+
     before(async function () {
-      await ObjectStorageCommand.prepareDefaultMockBuckets()
+      await objectStorage.prepareDefaultMockBuckets()
 
       await servers[0].kill()
 
-      await servers[0].run(ObjectStorageCommand.getDefaultMockConfig())
+      await servers[0].run(objectStorage.getDefaultMockConfig())
 
       // Wait for peertube runner socket reconnection
       await wait(1500)
     })
 
-    runSuite({ objectStorage: true })
+    runSuite({ objectStorage })
+
+    after(async function () {
+      await objectStorage.cleanupMock()
+    })
   })
 
   describe('Check cleanup', function () {
diff --git a/server/tests/peertube-runner/vod-transcoding.ts b/server/tests/peertube-runner/vod-transcoding.ts
index dc505baab..aefec394d 100644
--- a/server/tests/peertube-runner/vod-transcoding.ts
+++ b/server/tests/peertube-runner/vod-transcoding.ts
@@ -26,16 +26,16 @@ describe('Test VOD transcoding in peertube-runner program', function () {
   function runSuite (options: {
     webtorrentEnabled: boolean
     hlsEnabled: boolean
-    objectStorage: boolean
+    objectStorage?: ObjectStorageCommand
   }) {
     const { webtorrentEnabled, hlsEnabled, objectStorage } = options
 
     const objectStorageBaseUrlWebTorrent = objectStorage
-      ? ObjectStorageCommand.getMockWebTorrentBaseUrl()
+      ? objectStorage.getMockWebVideosBaseUrl()
       : undefined
 
     const objectStorageBaseUrlHLS = objectStorage
-      ? ObjectStorageCommand.getMockPlaylistBaseUrl()
+      ? objectStorage.getMockPlaylistBaseUrl()
       : undefined
 
     it('Should upload a classic video mp4 and transcode it', async function () {
@@ -262,7 +262,7 @@ describe('Test VOD transcoding in peertube-runner program', function () {
         await servers[0].config.enableTranscoding(true, false, true)
       })
 
-      runSuite({ webtorrentEnabled: true, hlsEnabled: false, objectStorage: false })
+      runSuite({ webtorrentEnabled: true, hlsEnabled: false })
     })
 
     describe('HLS videos only enabled', function () {
@@ -271,7 +271,7 @@ describe('Test VOD transcoding in peertube-runner program', function () {
         await servers[0].config.enableTranscoding(false, true, true)
       })
 
-      runSuite({ webtorrentEnabled: false, hlsEnabled: true, objectStorage: false })
+      runSuite({ webtorrentEnabled: false, hlsEnabled: true })
     })
 
     describe('Web video & HLS enabled', function () {
@@ -280,19 +280,21 @@ describe('Test VOD transcoding in peertube-runner program', function () {
         await servers[0].config.enableTranscoding(true, true, true)
       })
 
-      runSuite({ webtorrentEnabled: true, hlsEnabled: true, objectStorage: false })
+      runSuite({ webtorrentEnabled: true, hlsEnabled: true })
     })
   })
 
   describe('With videos on object storage', function () {
     if (areMockObjectStorageTestsDisabled()) return
 
+    const objectStorage = new ObjectStorageCommand()
+
     before(async function () {
-      await ObjectStorageCommand.prepareDefaultMockBuckets()
+      await objectStorage.prepareDefaultMockBuckets()
 
       await servers[0].kill()
 
-      await servers[0].run(ObjectStorageCommand.getDefaultMockConfig())
+      await servers[0].run(objectStorage.getDefaultMockConfig())
 
       // Wait for peertube runner socket reconnection
       await wait(1500)
@@ -304,7 +306,7 @@ describe('Test VOD transcoding in peertube-runner program', function () {
         await servers[0].config.enableTranscoding(true, false, true)
       })
 
-      runSuite({ webtorrentEnabled: true, hlsEnabled: false, objectStorage: true })
+      runSuite({ webtorrentEnabled: true, hlsEnabled: false, objectStorage })
     })
 
     describe('HLS videos only enabled', function () {
@@ -313,7 +315,7 @@ describe('Test VOD transcoding in peertube-runner program', function () {
         await servers[0].config.enableTranscoding(false, true, true)
       })
 
-      runSuite({ webtorrentEnabled: false, hlsEnabled: true, objectStorage: true })
+      runSuite({ webtorrentEnabled: false, hlsEnabled: true, objectStorage })
     })
 
     describe('Web video & HLS enabled', function () {
@@ -322,7 +324,11 @@ describe('Test VOD transcoding in peertube-runner program', function () {
         await servers[0].config.enableTranscoding(true, true, true)
       })
 
-      runSuite({ webtorrentEnabled: true, hlsEnabled: true, objectStorage: true })
+      runSuite({ webtorrentEnabled: true, hlsEnabled: true, objectStorage })
+    })
+
+    after(async function () {
+      await objectStorage.cleanupMock()
     })
   })