diff options
author | Chocobozzz <me@florianbigard.com> | 2023-07-31 14:34:36 +0200 |
---|---|---|
committer | Chocobozzz <me@florianbigard.com> | 2023-08-11 15:02:33 +0200 |
commit | 3a4992633ee62d5edfbb484d9c6bcb3cf158489d (patch) | |
tree | e4510b39bdac9c318fdb4b47018d08f15368b8f0 /server/middlewares/validators/themes.ts | |
parent | 04d1da5621d25d59bd5fa1543b725c497bf5d9a8 (diff) | |
download | PeerTube-3a4992633ee62d5edfbb484d9c6bcb3cf158489d.tar.gz PeerTube-3a4992633ee62d5edfbb484d9c6bcb3cf158489d.tar.zst PeerTube-3a4992633ee62d5edfbb484d9c6bcb3cf158489d.zip |
Migrate server to ESM
Sorry for the very big commit that may lead to git log issues and merge
conflicts, but it's a major step forward:
* Server can be faster at startup because imports() are async and we can
easily lazy import big modules
* Angular doesn't seem to support ES import (with .js extension), so we
had to correctly organize peertube into a monorepo:
* Use yarn workspace feature
* Use typescript reference projects for dependencies
* Shared projects have been moved into "packages", each one is now a
node module (with a dedicated package.json/tsconfig.json)
* server/tools have been moved into apps/ and is now a dedicated app
bundled and published on NPM so users don't have to build peertube
cli tools manually
* server/tests have been moved into packages/ so we don't compile
them every time we want to run the server
* Use isolatedModule option:
* Had to move from const enum to const
(https://www.typescriptlang.org/docs/handbook/enums.html#objects-vs-enums)
* Had to explictely specify "type" imports when used in decorators
* Prefer tsx (that uses esbuild under the hood) instead of ts-node to
load typescript files (tests with mocha or scripts):
* To reduce test complexity as esbuild doesn't support decorator
metadata, we only test server files that do not import server
models
* We still build tests files into js files for a faster CI
* Remove unmaintained peertube CLI import script
* Removed some barrels to speed up execution (less imports)
Diffstat (limited to 'server/middlewares/validators/themes.ts')
-rw-r--r-- | server/middlewares/validators/themes.ts | 46 |
1 files changed, 0 insertions, 46 deletions
diff --git a/server/middlewares/validators/themes.ts b/server/middlewares/validators/themes.ts deleted file mode 100644 index 080b3e096..000000000 --- a/server/middlewares/validators/themes.ts +++ /dev/null | |||
@@ -1,46 +0,0 @@ | |||
1 | import express from 'express' | ||
2 | import { param } from 'express-validator' | ||
3 | import { HttpStatusCode } from '../../../shared/models/http/http-error-codes' | ||
4 | import { isSafePath } from '../../helpers/custom-validators/misc' | ||
5 | import { isPluginNameValid, isPluginStableOrUnstableVersionValid } from '../../helpers/custom-validators/plugins' | ||
6 | import { PluginManager } from '../../lib/plugins/plugin-manager' | ||
7 | import { areValidationErrors } from './shared' | ||
8 | |||
9 | const serveThemeCSSValidator = [ | ||
10 | param('themeName') | ||
11 | .custom(isPluginNameValid), | ||
12 | param('themeVersion') | ||
13 | .custom(isPluginStableOrUnstableVersionValid), | ||
14 | param('staticEndpoint') | ||
15 | .custom(isSafePath), | ||
16 | |||
17 | (req: express.Request, res: express.Response, next: express.NextFunction) => { | ||
18 | if (areValidationErrors(req, res)) return | ||
19 | |||
20 | const theme = PluginManager.Instance.getRegisteredThemeByShortName(req.params.themeName) | ||
21 | |||
22 | if (!theme || theme.version !== req.params.themeVersion) { | ||
23 | return res.fail({ | ||
24 | status: HttpStatusCode.NOT_FOUND_404, | ||
25 | message: 'No theme named ' + req.params.themeName + ' was found with version ' + req.params.themeVersion | ||
26 | }) | ||
27 | } | ||
28 | |||
29 | if (theme.css.includes(req.params.staticEndpoint) === false) { | ||
30 | return res.fail({ | ||
31 | status: HttpStatusCode.NOT_FOUND_404, | ||
32 | message: 'No static endpoint was found for this theme' | ||
33 | }) | ||
34 | } | ||
35 | |||
36 | res.locals.registeredPlugin = theme | ||
37 | |||
38 | return next() | ||
39 | } | ||
40 | ] | ||
41 | |||
42 | // --------------------------------------------------------------------------- | ||
43 | |||
44 | export { | ||
45 | serveThemeCSSValidator | ||
46 | } | ||