aboutsummaryrefslogtreecommitdiffhomepage
path: root/server/middlewares/validators/shared/video-comments.ts
diff options
context:
space:
mode:
authorChocobozzz <me@florianbigard.com>2023-07-31 14:34:36 +0200
committerChocobozzz <me@florianbigard.com>2023-08-11 15:02:33 +0200
commit3a4992633ee62d5edfbb484d9c6bcb3cf158489d (patch)
treee4510b39bdac9c318fdb4b47018d08f15368b8f0 /server/middlewares/validators/shared/video-comments.ts
parent04d1da5621d25d59bd5fa1543b725c497bf5d9a8 (diff)
downloadPeerTube-3a4992633ee62d5edfbb484d9c6bcb3cf158489d.tar.gz
PeerTube-3a4992633ee62d5edfbb484d9c6bcb3cf158489d.tar.zst
PeerTube-3a4992633ee62d5edfbb484d9c6bcb3cf158489d.zip
Migrate server to ESM
Sorry for the very big commit that may lead to git log issues and merge conflicts, but it's a major step forward: * Server can be faster at startup because imports() are async and we can easily lazy import big modules * Angular doesn't seem to support ES import (with .js extension), so we had to correctly organize peertube into a monorepo: * Use yarn workspace feature * Use typescript reference projects for dependencies * Shared projects have been moved into "packages", each one is now a node module (with a dedicated package.json/tsconfig.json) * server/tools have been moved into apps/ and is now a dedicated app bundled and published on NPM so users don't have to build peertube cli tools manually * server/tests have been moved into packages/ so we don't compile them every time we want to run the server * Use isolatedModule option: * Had to move from const enum to const (https://www.typescriptlang.org/docs/handbook/enums.html#objects-vs-enums) * Had to explictely specify "type" imports when used in decorators * Prefer tsx (that uses esbuild under the hood) instead of ts-node to load typescript files (tests with mocha or scripts): * To reduce test complexity as esbuild doesn't support decorator metadata, we only test server files that do not import server models * We still build tests files into js files for a faster CI * Remove unmaintained peertube CLI import script * Removed some barrels to speed up execution (less imports)
Diffstat (limited to 'server/middlewares/validators/shared/video-comments.ts')
-rw-r--r--server/middlewares/validators/shared/video-comments.ts80
1 files changed, 0 insertions, 80 deletions
diff --git a/server/middlewares/validators/shared/video-comments.ts b/server/middlewares/validators/shared/video-comments.ts
deleted file mode 100644
index 0961b3ec9..000000000
--- a/server/middlewares/validators/shared/video-comments.ts
+++ /dev/null
@@ -1,80 +0,0 @@
1import express from 'express'
2import { VideoCommentModel } from '@server/models/video/video-comment'
3import { MVideoId } from '@server/types/models'
4import { forceNumber } from '@shared/core-utils'
5import { HttpStatusCode, ServerErrorCode } from '@shared/models'
6
7async function doesVideoCommentThreadExist (idArg: number | string, video: MVideoId, res: express.Response) {
8 const id = forceNumber(idArg)
9 const videoComment = await VideoCommentModel.loadById(id)
10
11 if (!videoComment) {
12 res.fail({
13 status: HttpStatusCode.NOT_FOUND_404,
14 message: 'Video comment thread not found'
15 })
16 return false
17 }
18
19 if (videoComment.videoId !== video.id) {
20 res.fail({
21 type: ServerErrorCode.COMMENT_NOT_ASSOCIATED_TO_VIDEO,
22 message: 'Video comment is not associated to this video.'
23 })
24 return false
25 }
26
27 if (videoComment.inReplyToCommentId !== null) {
28 res.fail({ message: 'Video comment is not a thread.' })
29 return false
30 }
31
32 res.locals.videoCommentThread = videoComment
33 return true
34}
35
36async function doesVideoCommentExist (idArg: number | string, video: MVideoId, res: express.Response) {
37 const id = forceNumber(idArg)
38 const videoComment = await VideoCommentModel.loadByIdAndPopulateVideoAndAccountAndReply(id)
39
40 if (!videoComment) {
41 res.fail({
42 status: HttpStatusCode.NOT_FOUND_404,
43 message: 'Video comment thread not found'
44 })
45 return false
46 }
47
48 if (videoComment.videoId !== video.id) {
49 res.fail({
50 type: ServerErrorCode.COMMENT_NOT_ASSOCIATED_TO_VIDEO,
51 message: 'Video comment is not associated to this video.'
52 })
53 return false
54 }
55
56 res.locals.videoCommentFull = videoComment
57 return true
58}
59
60async function doesCommentIdExist (idArg: number | string, res: express.Response) {
61 const id = forceNumber(idArg)
62 const videoComment = await VideoCommentModel.loadByIdAndPopulateVideoAndAccountAndReply(id)
63
64 if (!videoComment) {
65 res.fail({
66 status: HttpStatusCode.NOT_FOUND_404,
67 message: 'Video comment thread not found'
68 })
69 return false
70 }
71
72 res.locals.videoCommentFull = videoComment
73 return true
74}
75
76export {
77 doesVideoCommentThreadExist,
78 doesVideoCommentExist,
79 doesCommentIdExist
80}