aboutsummaryrefslogtreecommitdiffhomepage
path: root/server/middlewares/validators/metrics.ts
diff options
context:
space:
mode:
authorChocobozzz <me@florianbigard.com>2023-07-31 14:34:36 +0200
committerChocobozzz <me@florianbigard.com>2023-08-11 15:02:33 +0200
commit3a4992633ee62d5edfbb484d9c6bcb3cf158489d (patch)
treee4510b39bdac9c318fdb4b47018d08f15368b8f0 /server/middlewares/validators/metrics.ts
parent04d1da5621d25d59bd5fa1543b725c497bf5d9a8 (diff)
downloadPeerTube-3a4992633ee62d5edfbb484d9c6bcb3cf158489d.tar.gz
PeerTube-3a4992633ee62d5edfbb484d9c6bcb3cf158489d.tar.zst
PeerTube-3a4992633ee62d5edfbb484d9c6bcb3cf158489d.zip
Migrate server to ESM
Sorry for the very big commit that may lead to git log issues and merge conflicts, but it's a major step forward: * Server can be faster at startup because imports() are async and we can easily lazy import big modules * Angular doesn't seem to support ES import (with .js extension), so we had to correctly organize peertube into a monorepo: * Use yarn workspace feature * Use typescript reference projects for dependencies * Shared projects have been moved into "packages", each one is now a node module (with a dedicated package.json/tsconfig.json) * server/tools have been moved into apps/ and is now a dedicated app bundled and published on NPM so users don't have to build peertube cli tools manually * server/tests have been moved into packages/ so we don't compile them every time we want to run the server * Use isolatedModule option: * Had to move from const enum to const (https://www.typescriptlang.org/docs/handbook/enums.html#objects-vs-enums) * Had to explictely specify "type" imports when used in decorators * Prefer tsx (that uses esbuild under the hood) instead of ts-node to load typescript files (tests with mocha or scripts): * To reduce test complexity as esbuild doesn't support decorator metadata, we only test server files that do not import server models * We still build tests files into js files for a faster CI * Remove unmaintained peertube CLI import script * Removed some barrels to speed up execution (less imports)
Diffstat (limited to 'server/middlewares/validators/metrics.ts')
-rw-r--r--server/middlewares/validators/metrics.ts60
1 files changed, 0 insertions, 60 deletions
diff --git a/server/middlewares/validators/metrics.ts b/server/middlewares/validators/metrics.ts
deleted file mode 100644
index 986b30a19..000000000
--- a/server/middlewares/validators/metrics.ts
+++ /dev/null
@@ -1,60 +0,0 @@
1import express from 'express'
2import { body } from 'express-validator'
3import { isValidPlayerMode } from '@server/helpers/custom-validators/metrics'
4import { isIdOrUUIDValid, toCompleteUUID } from '@server/helpers/custom-validators/misc'
5import { CONFIG } from '@server/initializers/config'
6import { HttpStatusCode, PlaybackMetricCreate } from '@shared/models'
7import { areValidationErrors, doesVideoExist } from './shared'
8
9const addPlaybackMetricValidator = [
10 body('resolution')
11 .isInt({ min: 0 }),
12 body('fps')
13 .optional()
14 .isInt({ min: 0 }),
15
16 body('p2pPeers')
17 .optional()
18 .isInt({ min: 0 }),
19
20 body('p2pEnabled')
21 .isBoolean(),
22
23 body('playerMode')
24 .custom(isValidPlayerMode),
25
26 body('resolutionChanges')
27 .isInt({ min: 0 }),
28
29 body('errors')
30 .isInt({ min: 0 }),
31
32 body('downloadedBytesP2P')
33 .isInt({ min: 0 }),
34 body('downloadedBytesHTTP')
35 .isInt({ min: 0 }),
36
37 body('uploadedBytesP2P')
38 .isInt({ min: 0 }),
39
40 body('videoId')
41 .customSanitizer(toCompleteUUID)
42 .custom(isIdOrUUIDValid),
43
44 async (req: express.Request, res: express.Response, next: express.NextFunction) => {
45 if (!CONFIG.OPEN_TELEMETRY.METRICS.ENABLED) return res.sendStatus(HttpStatusCode.NO_CONTENT_204)
46
47 const body: PlaybackMetricCreate = req.body
48
49 if (areValidationErrors(req, res)) return
50 if (!await doesVideoExist(body.videoId, res, 'only-immutable-attributes')) return
51
52 return next()
53 }
54]
55
56// ---------------------------------------------------------------------------
57
58export {
59 addPlaybackMetricValidator
60}