diff options
author | Alecks Gates <agates@mail.agates.io> | 2023-05-22 09:00:05 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-05-22 16:00:05 +0200 |
commit | cb0eda5602a21d1626a7face32de6153ed07b5f9 (patch) | |
tree | d6a7a4e31c7267c130871ac8e3beb42994271c20 /server/middlewares/cache | |
parent | 3f0ceab06e5320f62f593c49daa30d963dbc36f9 (diff) | |
download | PeerTube-cb0eda5602a21d1626a7face32de6153ed07b5f9.tar.gz PeerTube-cb0eda5602a21d1626a7face32de6153ed07b5f9.tar.zst PeerTube-cb0eda5602a21d1626a7face32de6153ed07b5f9.zip |
Add Podcast RSS feeds (#5487)
* Initial test implementation of Podcast RSS
This is a pretty simple implementation to add support for The Podcast Namespace in RSS -- instead of affecting the existing RSS implementation, this adds a new UI option.
I attempted to retain compatibility with the rest of the RSS feed implementation as much as possible and have created a temporary fork of the "pfeed" library to support this effort.
* Update to pfeed-podcast 1.2.2
* Initial test implementation of Podcast RSS
This is a pretty simple implementation to add support for The Podcast Namespace in RSS -- instead of affecting the existing RSS implementation, this adds a new UI option.
I attempted to retain compatibility with the rest of the RSS feed implementation as much as possible and have created a temporary fork of the "pfeed" library to support this effort.
* Update to pfeed-podcast 1.2.2
* Initial test implementation of Podcast RSS
This is a pretty simple implementation to add support for The Podcast Namespace in RSS -- instead of affecting the existing RSS implementation, this adds a new UI option.
I attempted to retain compatibility with the rest of the RSS feed implementation as much as possible and have created a temporary fork of the "pfeed" library to support this effort.
* Update to pfeed-podcast 1.2.2
* Add correct feed image to RSS channel
* Prefer HLS videos for podcast RSS
Remove video/stream titles, add optional height attribute to podcast RSS
* Prefix podcast RSS images with root server URL
* Add optional video query support to include captions
* Add transcripts & person images to podcast RSS feed
* Prefer webseed/webtorrent files over HLS fragmented mp4s
* Experimentally adding podcast fields to basic config page
* Add validation for new basic config fields
* Don't include "content" in podcast feed, use full description for "description"
* Initial test implementation of Podcast RSS
This is a pretty simple implementation to add support for The Podcast Namespace in RSS -- instead of affecting the existing RSS implementation, this adds a new UI option.
I attempted to retain compatibility with the rest of the RSS feed implementation as much as possible and have created a temporary fork of the "pfeed" library to support this effort.
* Update to pfeed-podcast 1.2.2
* Add correct feed image to RSS channel
* Prefer HLS videos for podcast RSS
Remove video/stream titles, add optional height attribute to podcast RSS
* Prefix podcast RSS images with root server URL
* Add optional video query support to include captions
* Add transcripts & person images to podcast RSS feed
* Prefer webseed/webtorrent files over HLS fragmented mp4s
* Experimentally adding podcast fields to basic config page
* Add validation for new basic config fields
* Don't include "content" in podcast feed, use full description for "description"
* Add medium/socialInteract to podcast RSS feeds. Use HTML for description
* Change base production image to bullseye, install prosody in image
* Add liveItem and trackers to Podcast RSS feeds
Remove height from alternateEnclosure, replaced with title.
* Clear Podcast RSS feed cache when live streams start/end
* Upgrade to Node 16
* Refactor clearCacheRoute to use ApiCache
* Remove unnecessary type hint
* Update dockerfile to node 16, install python-is-python2
* Use new file paths for captions/playlists
* Fix legacy videos in RSS after migration to object storage
* Improve method of identifying non-fragmented mp4s in podcast RSS feeds
* Don't include fragmented MP4s in podcast RSS feeds
* Add experimental support for podcast:categories on the podcast RSS item
* Fix undefined category when no videos exist
Allows for empty feeds to exist (important for feeds that might only go live)
* Add support for podcast:locked -- user has to opt in to show their email
* Use comma for podcast:categories delimiter
* Make cache clearing async
* Fix merge, temporarily test with pfeed-podcast
* Syntax changes
* Add EXT_MIMETYPE constants for captions
* Update & fix tests, fix enclosure mimetypes, remove admin email
* Add test for podacst:socialInteract
* Add filters hooks for podcast customTags
* Remove showdown, updated to pfeed-podcast 6.1.2
* Add 'action:api.live-video.state.updated' hook
* Avoid assigning undefined category to podcast feeds
* Remove nvmrc
* Remove comment
* Remove unused podcast config
* Remove more unused podcast config
* Fix MChannelAccountDefault type hint missed in merge
* Remove extra line
* Re-add newline in config
* Fix lint errors for isEmailPublic
* Fix thumbnails in podcast feeds
* Requested changes based on review
* Provide podcast rss 2.0 only on video channels
* Misc cleanup for a less messy PR
* Lint fixes
* Remove pfeed-podcast
* Add peertube version to new hooks
* Don't use query include, remove TODO
* Remove film medium hack
* Clear podcast rss cache before video/channel update hooks
* Clear podcast rss cache before video uploaded/deleted hooks
* Refactor podcast feed cache clearing
* Set correct person name from video channel
* Styling
* Fix tests
---------
Co-authored-by: Chocobozzz <me@florianbigard.com>
Diffstat (limited to 'server/middlewares/cache')
-rw-r--r-- | server/middlewares/cache/cache.ts | 14 | ||||
-rw-r--r-- | server/middlewares/cache/shared/api-cache.ts | 45 |
2 files changed, 53 insertions, 6 deletions
diff --git a/server/middlewares/cache/cache.ts b/server/middlewares/cache/cache.ts index e14160ba8..6041c76c3 100644 --- a/server/middlewares/cache/cache.ts +++ b/server/middlewares/cache/cache.ts | |||
@@ -17,12 +17,22 @@ function cacheRoute (duration: string) { | |||
17 | function cacheRouteFactory (options: APICacheOptions) { | 17 | function cacheRouteFactory (options: APICacheOptions) { |
18 | const instance = new ApiCache({ ...defaultOptions, ...options }) | 18 | const instance = new ApiCache({ ...defaultOptions, ...options }) |
19 | 19 | ||
20 | return instance.buildMiddleware.bind(instance) | 20 | return { instance, middleware: instance.buildMiddleware.bind(instance) } |
21 | } | ||
22 | |||
23 | // --------------------------------------------------------------------------- | ||
24 | |||
25 | function buildPodcastGroupsCache (options: { | ||
26 | channelId: number | ||
27 | }) { | ||
28 | return 'podcast-feed-' + options.channelId | ||
21 | } | 29 | } |
22 | 30 | ||
23 | // --------------------------------------------------------------------------- | 31 | // --------------------------------------------------------------------------- |
24 | 32 | ||
25 | export { | 33 | export { |
26 | cacheRoute, | 34 | cacheRoute, |
27 | cacheRouteFactory | 35 | cacheRouteFactory, |
36 | |||
37 | buildPodcastGroupsCache | ||
28 | } | 38 | } |
diff --git a/server/middlewares/cache/shared/api-cache.ts b/server/middlewares/cache/shared/api-cache.ts index 7c366db00..c6197b972 100644 --- a/server/middlewares/cache/shared/api-cache.ts +++ b/server/middlewares/cache/shared/api-cache.ts | |||
@@ -27,7 +27,13 @@ export class ApiCache { | |||
27 | private readonly options: APICacheOptions | 27 | private readonly options: APICacheOptions |
28 | private readonly timers: { [ id: string ]: NodeJS.Timeout } = {} | 28 | private readonly timers: { [ id: string ]: NodeJS.Timeout } = {} |
29 | 29 | ||
30 | private readonly index: { all: string[] } = { all: [] } | 30 | private readonly index = { |
31 | groups: [] as string[], | ||
32 | all: [] as string[] | ||
33 | } | ||
34 | |||
35 | // Cache keys per group | ||
36 | private groups: { [groupIndex: string]: string[] } = {} | ||
31 | 37 | ||
32 | constructor (options: APICacheOptions) { | 38 | constructor (options: APICacheOptions) { |
33 | this.options = { | 39 | this.options = { |
@@ -43,7 +49,7 @@ export class ApiCache { | |||
43 | 49 | ||
44 | return asyncMiddleware( | 50 | return asyncMiddleware( |
45 | async (req: express.Request, res: express.Response, next: express.NextFunction) => { | 51 | async (req: express.Request, res: express.Response, next: express.NextFunction) => { |
46 | const key = Redis.Instance.getPrefix() + 'api-cache-' + req.originalUrl | 52 | const key = this.getCacheKey(req) |
47 | const redis = Redis.Instance.getClient() | 53 | const redis = Redis.Instance.getClient() |
48 | 54 | ||
49 | if (!Redis.Instance.isConnected()) return this.makeResponseCacheable(res, next, key, duration) | 55 | if (!Redis.Instance.isConnected()) return this.makeResponseCacheable(res, next, key, duration) |
@@ -62,6 +68,29 @@ export class ApiCache { | |||
62 | ) | 68 | ) |
63 | } | 69 | } |
64 | 70 | ||
71 | clearGroupSafe (group: string) { | ||
72 | const run = async () => { | ||
73 | const cacheKeys = this.groups[group] | ||
74 | if (!cacheKeys) return | ||
75 | |||
76 | for (const key of cacheKeys) { | ||
77 | try { | ||
78 | await this.clear(key) | ||
79 | } catch (err) { | ||
80 | logger.error('Cannot clear ' + key, { err }) | ||
81 | } | ||
82 | } | ||
83 | |||
84 | delete this.groups[group] | ||
85 | } | ||
86 | |||
87 | void run() | ||
88 | } | ||
89 | |||
90 | private getCacheKey (req: express.Request) { | ||
91 | return Redis.Instance.getPrefix() + 'api-cache-' + req.originalUrl | ||
92 | } | ||
93 | |||
65 | private shouldCacheResponse (response: express.Response) { | 94 | private shouldCacheResponse (response: express.Response) { |
66 | if (!response) return false | 95 | if (!response) return false |
67 | if (this.options.excludeStatus.includes(response.statusCode)) return false | 96 | if (this.options.excludeStatus.includes(response.statusCode)) return false |
@@ -69,8 +98,16 @@ export class ApiCache { | |||
69 | return true | 98 | return true |
70 | } | 99 | } |
71 | 100 | ||
72 | private addIndexEntries (key: string) { | 101 | private addIndexEntries (key: string, res: express.Response) { |
73 | this.index.all.unshift(key) | 102 | this.index.all.unshift(key) |
103 | |||
104 | const groups = res.locals.apicacheGroups || [] | ||
105 | |||
106 | for (const group of groups) { | ||
107 | if (!this.groups[group]) this.groups[group] = [] | ||
108 | |||
109 | this.groups[group].push(key) | ||
110 | } | ||
74 | } | 111 | } |
75 | 112 | ||
76 | private filterBlacklistedHeaders (headers: OutgoingHttpHeaders) { | 113 | private filterBlacklistedHeaders (headers: OutgoingHttpHeaders) { |
@@ -177,7 +214,7 @@ export class ApiCache { | |||
177 | self.accumulateContent(res, content) | 214 | self.accumulateContent(res, content) |
178 | 215 | ||
179 | if (res.locals.apicache.cacheable && res.locals.apicache.content) { | 216 | if (res.locals.apicache.cacheable && res.locals.apicache.content) { |
180 | self.addIndexEntries(key) | 217 | self.addIndexEntries(key, res) |
181 | 218 | ||
182 | const headers = res.locals.apicache.headers || res.getHeaders() | 219 | const headers = res.locals.apicache.headers || res.getHeaders() |
183 | const cacheObject = self.createCacheObject( | 220 | const cacheObject = self.createCacheObject( |