diff options
author | Chocobozzz <me@florianbigard.com> | 2023-07-31 14:34:36 +0200 |
---|---|---|
committer | Chocobozzz <me@florianbigard.com> | 2023-08-11 15:02:33 +0200 |
commit | 3a4992633ee62d5edfbb484d9c6bcb3cf158489d (patch) | |
tree | e4510b39bdac9c318fdb4b47018d08f15368b8f0 /server/controllers/api/videos/view.ts | |
parent | 04d1da5621d25d59bd5fa1543b725c497bf5d9a8 (diff) | |
download | PeerTube-3a4992633ee62d5edfbb484d9c6bcb3cf158489d.tar.gz PeerTube-3a4992633ee62d5edfbb484d9c6bcb3cf158489d.tar.zst PeerTube-3a4992633ee62d5edfbb484d9c6bcb3cf158489d.zip |
Migrate server to ESM
Sorry for the very big commit that may lead to git log issues and merge
conflicts, but it's a major step forward:
* Server can be faster at startup because imports() are async and we can
easily lazy import big modules
* Angular doesn't seem to support ES import (with .js extension), so we
had to correctly organize peertube into a monorepo:
* Use yarn workspace feature
* Use typescript reference projects for dependencies
* Shared projects have been moved into "packages", each one is now a
node module (with a dedicated package.json/tsconfig.json)
* server/tools have been moved into apps/ and is now a dedicated app
bundled and published on NPM so users don't have to build peertube
cli tools manually
* server/tests have been moved into packages/ so we don't compile
them every time we want to run the server
* Use isolatedModule option:
* Had to move from const enum to const
(https://www.typescriptlang.org/docs/handbook/enums.html#objects-vs-enums)
* Had to explictely specify "type" imports when used in decorators
* Prefer tsx (that uses esbuild under the hood) instead of ts-node to
load typescript files (tests with mocha or scripts):
* To reduce test complexity as esbuild doesn't support decorator
metadata, we only test server files that do not import server
models
* We still build tests files into js files for a faster CI
* Remove unmaintained peertube CLI import script
* Removed some barrels to speed up execution (less imports)
Diffstat (limited to 'server/controllers/api/videos/view.ts')
-rw-r--r-- | server/controllers/api/videos/view.ts | 60 |
1 files changed, 0 insertions, 60 deletions
diff --git a/server/controllers/api/videos/view.ts b/server/controllers/api/videos/view.ts deleted file mode 100644 index a747fa334..000000000 --- a/server/controllers/api/videos/view.ts +++ /dev/null | |||
@@ -1,60 +0,0 @@ | |||
1 | import express from 'express' | ||
2 | import { Hooks } from '@server/lib/plugins/hooks' | ||
3 | import { VideoViewsManager } from '@server/lib/views/video-views-manager' | ||
4 | import { MVideoId } from '@server/types/models' | ||
5 | import { HttpStatusCode, VideoView } from '@shared/models' | ||
6 | import { asyncMiddleware, methodsValidator, openapiOperationDoc, optionalAuthenticate, videoViewValidator } from '../../../middlewares' | ||
7 | import { UserVideoHistoryModel } from '../../../models/user/user-video-history' | ||
8 | |||
9 | const viewRouter = express.Router() | ||
10 | |||
11 | viewRouter.all( | ||
12 | [ '/:videoId/views', '/:videoId/watching' ], | ||
13 | openapiOperationDoc({ operationId: 'addView' }), | ||
14 | methodsValidator([ 'PUT', 'POST' ]), | ||
15 | optionalAuthenticate, | ||
16 | asyncMiddleware(videoViewValidator), | ||
17 | asyncMiddleware(viewVideo) | ||
18 | ) | ||
19 | |||
20 | // --------------------------------------------------------------------------- | ||
21 | |||
22 | export { | ||
23 | viewRouter | ||
24 | } | ||
25 | |||
26 | // --------------------------------------------------------------------------- | ||
27 | |||
28 | async function viewVideo (req: express.Request, res: express.Response) { | ||
29 | const video = res.locals.onlyImmutableVideo | ||
30 | |||
31 | const body = req.body as VideoView | ||
32 | |||
33 | const ip = req.ip | ||
34 | const { successView } = await VideoViewsManager.Instance.processLocalView({ | ||
35 | video, | ||
36 | ip, | ||
37 | currentTime: body.currentTime, | ||
38 | viewEvent: body.viewEvent | ||
39 | }) | ||
40 | |||
41 | if (successView) { | ||
42 | Hooks.runAction('action:api.video.viewed', { video, ip, req, res }) | ||
43 | } | ||
44 | |||
45 | await updateUserHistoryIfNeeded(body, video, res) | ||
46 | |||
47 | return res.status(HttpStatusCode.NO_CONTENT_204).end() | ||
48 | } | ||
49 | |||
50 | async function updateUserHistoryIfNeeded (body: VideoView, video: MVideoId, res: express.Response) { | ||
51 | const user = res.locals.oauth?.token.User | ||
52 | if (!user) return | ||
53 | if (user.videosHistoryEnabled !== true) return | ||
54 | |||
55 | await UserVideoHistoryModel.upsert({ | ||
56 | videoId: video.id, | ||
57 | userId: user.id, | ||
58 | currentTime: body.currentTime | ||
59 | }) | ||
60 | } | ||