diff options
author | Chocobozzz <me@florianbigard.com> | 2023-07-31 14:34:36 +0200 |
---|---|---|
committer | Chocobozzz <me@florianbigard.com> | 2023-08-11 15:02:33 +0200 |
commit | 3a4992633ee62d5edfbb484d9c6bcb3cf158489d (patch) | |
tree | e4510b39bdac9c318fdb4b47018d08f15368b8f0 /server/controllers/api/videos/rate.ts | |
parent | 04d1da5621d25d59bd5fa1543b725c497bf5d9a8 (diff) | |
download | PeerTube-3a4992633ee62d5edfbb484d9c6bcb3cf158489d.tar.gz PeerTube-3a4992633ee62d5edfbb484d9c6bcb3cf158489d.tar.zst PeerTube-3a4992633ee62d5edfbb484d9c6bcb3cf158489d.zip |
Migrate server to ESM
Sorry for the very big commit that may lead to git log issues and merge
conflicts, but it's a major step forward:
* Server can be faster at startup because imports() are async and we can
easily lazy import big modules
* Angular doesn't seem to support ES import (with .js extension), so we
had to correctly organize peertube into a monorepo:
* Use yarn workspace feature
* Use typescript reference projects for dependencies
* Shared projects have been moved into "packages", each one is now a
node module (with a dedicated package.json/tsconfig.json)
* server/tools have been moved into apps/ and is now a dedicated app
bundled and published on NPM so users don't have to build peertube
cli tools manually
* server/tests have been moved into packages/ so we don't compile
them every time we want to run the server
* Use isolatedModule option:
* Had to move from const enum to const
(https://www.typescriptlang.org/docs/handbook/enums.html#objects-vs-enums)
* Had to explictely specify "type" imports when used in decorators
* Prefer tsx (that uses esbuild under the hood) instead of ts-node to
load typescript files (tests with mocha or scripts):
* To reduce test complexity as esbuild doesn't support decorator
metadata, we only test server files that do not import server
models
* We still build tests files into js files for a faster CI
* Remove unmaintained peertube CLI import script
* Removed some barrels to speed up execution (less imports)
Diffstat (limited to 'server/controllers/api/videos/rate.ts')
-rw-r--r-- | server/controllers/api/videos/rate.ts | 87 |
1 files changed, 0 insertions, 87 deletions
diff --git a/server/controllers/api/videos/rate.ts b/server/controllers/api/videos/rate.ts deleted file mode 100644 index 6b26a8eee..000000000 --- a/server/controllers/api/videos/rate.ts +++ /dev/null | |||
@@ -1,87 +0,0 @@ | |||
1 | import express from 'express' | ||
2 | import { HttpStatusCode, UserVideoRateUpdate } from '@shared/models' | ||
3 | import { logger } from '../../../helpers/logger' | ||
4 | import { VIDEO_RATE_TYPES } from '../../../initializers/constants' | ||
5 | import { sequelizeTypescript } from '../../../initializers/database' | ||
6 | import { getLocalRateUrl, sendVideoRateChange } from '../../../lib/activitypub/video-rates' | ||
7 | import { asyncMiddleware, asyncRetryTransactionMiddleware, authenticate, videoUpdateRateValidator } from '../../../middlewares' | ||
8 | import { AccountModel } from '../../../models/account/account' | ||
9 | import { AccountVideoRateModel } from '../../../models/account/account-video-rate' | ||
10 | |||
11 | const rateVideoRouter = express.Router() | ||
12 | |||
13 | rateVideoRouter.put('/:id/rate', | ||
14 | authenticate, | ||
15 | asyncMiddleware(videoUpdateRateValidator), | ||
16 | asyncRetryTransactionMiddleware(rateVideo) | ||
17 | ) | ||
18 | |||
19 | // --------------------------------------------------------------------------- | ||
20 | |||
21 | export { | ||
22 | rateVideoRouter | ||
23 | } | ||
24 | |||
25 | // --------------------------------------------------------------------------- | ||
26 | |||
27 | async function rateVideo (req: express.Request, res: express.Response) { | ||
28 | const body: UserVideoRateUpdate = req.body | ||
29 | const rateType = body.rating | ||
30 | const videoInstance = res.locals.videoAll | ||
31 | const userAccount = res.locals.oauth.token.User.Account | ||
32 | |||
33 | await sequelizeTypescript.transaction(async t => { | ||
34 | const sequelizeOptions = { transaction: t } | ||
35 | |||
36 | const accountInstance = await AccountModel.load(userAccount.id, t) | ||
37 | const previousRate = await AccountVideoRateModel.load(accountInstance.id, videoInstance.id, t) | ||
38 | |||
39 | // Same rate, nothing do to | ||
40 | if (rateType === 'none' && !previousRate || previousRate?.type === rateType) return | ||
41 | |||
42 | let likesToIncrement = 0 | ||
43 | let dislikesToIncrement = 0 | ||
44 | |||
45 | if (rateType === VIDEO_RATE_TYPES.LIKE) likesToIncrement++ | ||
46 | else if (rateType === VIDEO_RATE_TYPES.DISLIKE) dislikesToIncrement++ | ||
47 | |||
48 | // There was a previous rate, update it | ||
49 | if (previousRate) { | ||
50 | // We will remove the previous rate, so we will need to update the video count attribute | ||
51 | if (previousRate.type === 'like') likesToIncrement-- | ||
52 | else if (previousRate.type === 'dislike') dislikesToIncrement-- | ||
53 | |||
54 | if (rateType === 'none') { // Destroy previous rate | ||
55 | await previousRate.destroy(sequelizeOptions) | ||
56 | } else { // Update previous rate | ||
57 | previousRate.type = rateType | ||
58 | previousRate.url = getLocalRateUrl(rateType, userAccount.Actor, videoInstance) | ||
59 | await previousRate.save(sequelizeOptions) | ||
60 | } | ||
61 | } else if (rateType !== 'none') { // There was not a previous rate, insert a new one if there is a rate | ||
62 | const query = { | ||
63 | accountId: accountInstance.id, | ||
64 | videoId: videoInstance.id, | ||
65 | type: rateType, | ||
66 | url: getLocalRateUrl(rateType, userAccount.Actor, videoInstance) | ||
67 | } | ||
68 | |||
69 | await AccountVideoRateModel.create(query, sequelizeOptions) | ||
70 | } | ||
71 | |||
72 | const incrementQuery = { | ||
73 | likes: likesToIncrement, | ||
74 | dislikes: dislikesToIncrement | ||
75 | } | ||
76 | |||
77 | await videoInstance.increment(incrementQuery, sequelizeOptions) | ||
78 | |||
79 | await sendVideoRateChange(accountInstance, videoInstance, likesToIncrement, dislikesToIncrement, t) | ||
80 | |||
81 | logger.info('Account video rate for video %s of account %s updated.', videoInstance.name, accountInstance.name) | ||
82 | }) | ||
83 | |||
84 | return res.type('json') | ||
85 | .status(HttpStatusCode.NO_CONTENT_204) | ||
86 | .end() | ||
87 | } | ||