improvements to login and sign-up pages (#3357)

* New login form ui
* Move InstanceAboutAccordion to shared components
* Update closed registration alert text
* Add alert for opened registration and move them bellow login form
* Adjust flex block on signup and login views
* Replace toggle accordion with expand on links in signup and login + scrollTo
* Improve display of login alerts
* Fix missing Component suffix
* Define min-width instance-information block sign-up and login for mobile screens
* Add ability to select specific panels in instanceAboutAccorddion
* Add instance title and short-description to common instanceAboutAccordion
* Clarify title alert in login page
* Add step terms for signup

Co-authored-by: kimsible <kimsible@users.noreply.github.com>
Co-authored-by: Rigel Kent <sendmemail@rigelk.eu>

1 files changed, 16 insertions, 61 deletions

diff --git a/client/src/app/+signup/+register/register.component.html b/client/src/app/+signup/+register/register.component.html
index 7e3704124..bebc5d926 100644
--- a/client/src/app/+signup/+register/register.component.html
+++ b/client/src/app/+signup/+register/register.component.html
@@ -10,19 +10,26 @@
   <div class="wrapper" [hidden]="signupDone">
     <div class="register-form">
       <my-custom-stepper linear *ngIf="!signupDone">
-        <cdk-step [stepControl]="formStepUser" i18n-label label="User">
-          <my-register-step-user
+        <cdk-step [stepControl]="formStepTerms" i18n-label="Stepper label for the registration page describing terms of service" label="Terms">
+          <div class="instance-information">
+            <my-instance-about-accordion (init)="onInstanceAboutAccordionInit($event)" [panels]="instanceInformationPanels"></my-instance-about-accordion>
+          </div>
+
+          <my-register-step-terms
             [hasCodeOfConduct]="!!aboutHtml.codeOfConduct"
-            [videoUploadDisabled]="videoUploadDisabled"
-            (formBuilt)="onUserFormBuilt($event)" (termsClick)="onTermsClick()" (codeOfConductClick)="onCodeOfConductClick()"
-          >
-          </my-register-step-user>
+            (formBuilt)="onTermsFormBuilt($event)" (termsClick)="onTermsClick()" (codeOfConductClick)="onCodeOfConductClick()"
+          ></my-register-step-terms>
+
+          <button cdkStepperNext [disabled]="!formStepTerms || !formStepTerms.valid">{{ defaultNextStepButtonLabel }}</button>
+        </cdk-step>
+
+        <cdk-step [stepControl]="formStepUser" i18n-label="Stepper label for the registration page asking user informations" label="User">
+          <my-register-step-user (formBuilt)="onUserFormBuilt($event)" [videoUploadDisabled]="videoUploadDisabled"></my-register-step-user>
 
-          <button i18n cdkStepperNext [disabled]="!formStepUser || !formStepUser.valid"
-            (click)="signup()">{{ videoUploadDisabled ? 'Signup' : 'Next' }}</button>
+          <button cdkStepperNext [disabled]="!formStepUser || !formStepUser.valid" (click)="videoUploadDisabled && signup()">{{ stepUserButtonLabel }}</button>
         </cdk-step>
 
-        <cdk-step [stepControl]="formStepChannel" i18n-label label="Channel" *ngIf="!videoUploadDisabled">
+        <cdk-step [stepControl]="formStepChannel" i18n-label="Stepper label for the registration page asking information about the default channel" label="Channel" *ngIf="!videoUploadDisabled">
           <my-register-step-channel (formBuilt)="onChannelFormBuilt($event)" [username]="getUsername()"></my-register-step-channel>
 
           <button i18n cdkStepperNext (click)="signup()"
@@ -43,58 +50,6 @@
         </cdk-step>
       </my-custom-stepper>
     </div>
-
-    <div class="instance-information">
-      <ngb-accordion [closeOthers]="true" #accordion="ngbAccordion">
-        <ngb-panel id="instance-features" i18n-title title="Features found on this instance">
-          <ng-template ngbPanelContent>
-            <my-instance-features-table></my-instance-features-table>
-          </ng-template>
-        </ngb-panel>
-
-        <ng-container *ngIf="about">
-          <ngb-panel
-            *ngIf="aboutHtml.administrator || about.instance.maintenanceLifetime || about.instance.businessModel"
-            id="admin-sustainability" i18n-title title="Administrators & Sustainability"
-          >
-            <ng-template ngbPanelContent>
-              <div class="block">
-                <strong i18n>Who are we?</strong>
-                <div [innerHTML]="aboutHtml.administrator"></div>
-              </div>
-
-              <div class="block">
-                <strong i18n>How long do we plan to maintain this instance?</strong>
-                <div [innerHTML]="about.instance.maintenanceLifetime"></div>
-              </div>
-
-              <div class="block">
-                <strong i18n>How will we finance this instance?</strong>
-                <div [innerHTML]="about.instance.businessModel"></div>
-              </div>
-            </ng-template>
-          </ngb-panel>
-
-          <ngb-panel *ngIf="aboutHtml.moderationInformation" id="moderation-information" i18n-title title="Moderation information">
-            <ng-template ngbPanelContent>
-              <div class="block" [innerHTML]="aboutHtml.moderationInformation"></div>
-            </ng-template>
-          </ngb-panel>
-
-          <ngb-panel *ngIf="aboutHtml.codeOfConduct" id="code-of-conduct" i18n-title title="Code of conduct">
-            <ng-template ngbPanelContent>
-              <div class="block" [innerHTML]="aboutHtml.codeOfConduct"></div>
-            </ng-template>
-          </ngb-panel>
-
-          <ngb-panel *ngIf="aboutHtml.terms" id="terms" i18n-title title="Terms">
-            <ng-template ngbPanelContent>
-              <div class="block" [innerHTML]="aboutHtml.terms"></div>
-            </ng-template>
-          </ngb-panel>
-        </ng-container>
-      </ngb-accordion>
-    </div>
   </div>
 
 </div>