Add bulk action on following/followers

2 files changed, 99 insertions, 32 deletions

diff --git a/client/src/app/+admin/follows/followers-list/followers-list.component.html b/client/src/app/+admin/follows/followers-list/followers-list.component.html
index 4f11f261d..8fe0d2348 100644
--- a/client/src/app/+admin/follows/followers-list/followers-list.component.html
+++ b/client/src/app/+admin/follows/followers-list/followers-list.component.html
@@ -9,9 +9,18 @@
   [lazy]="true" (onLazyLoad)="loadLazy($event)" [lazyLoadOnInit]="false"
   [showCurrentPageReport]="true" i18n-currentPageReportTemplate
   currentPageReportTemplate="Showing {{'{first}'}} to {{'{last}'}} of {{'{totalRecords}'}} followers"
+  [(selection)]="selectedFollows"
 >
   <ng-template pTemplate="caption">
     <div class="caption">
+      <div class="left-buttons">
+        <my-action-dropdown
+          *ngIf="isInSelectionMode()" i18n-label label="Batch actions" theme="orange"
+          [actions]="bulkFollowsActions" [entry]="selectedFollows"
+        >
+        </my-action-dropdown>
+      </div>
+
       <div class="ms-auto">
         <my-advanced-input-filter [filters]="searchFilters" (search)="onSearch($event)"></my-advanced-input-filter>
       </div>
@@ -20,6 +29,9 @@
 
   <ng-template pTemplate="header">
     <tr>
+      <th style="width: 40px">
+        <p-tableHeaderCheckbox ariaLabel="Select all rows" i18n-ariaLabel></p-tableHeaderCheckbox>
+      </th>
       <th style="width: 150px;" i18n>Actions</th>
       <th i18n>Follower</th>
       <th style="width: 100px;" i18n pSortableColumn="state">State <p-sortIcon field="state"></p-sortIcon></th>
@@ -30,15 +42,19 @@
 
   <ng-template pTemplate="body" let-follow>
     <tr>
+      <td class="checkbox-cell">
+        <p-tableCheckbox [value]="follow" ariaLabel="Select this row" i18n-ariaLabel></p-tableCheckbox>
+      </td>
+
       <td class="action-cell">
-        <my-button *ngIf="follow.state !== 'accepted'" i18n-title title="Accept" icon="tick" (click)="acceptFollower(follow)"></my-button>
-        <my-button *ngIf="follow.state !== 'rejected'" i18n-title title="Refuse" icon="cross" (click)="rejectFollower(follow)"></my-button>
+        <my-button *ngIf="follow.state !== 'accepted'" i18n-title title="Accept" icon="tick" (click)="acceptFollower([ follow ])"></my-button>
+        <my-button *ngIf="follow.state !== 'rejected'" i18n-title title="Reject" icon="cross" (click)="rejectFollower([ follow ])"></my-button>
 
-        <my-delete-button *ngIf="follow.state === 'rejected'" (click)="deleteFollower(follow)"></my-delete-button>
+        <my-delete-button *ngIf="follow.state === 'rejected'" (click)="deleteFollowers([ follow ])"></my-delete-button>
       </td>
       <td>
         <a [href]="follow.follower.url" i18n-title title="Open actor page in a new tab" target="_blank" rel="noopener noreferrer">
-          {{ follow.follower.name + '@' + follow.follower.host }}
+          {{ buildFollowerName(follow) }}
           <my-global-icon iconName="external-link"></my-global-icon>
         </a>
       </td>
@@ -56,7 +72,7 @@
 
   <ng-template pTemplate="emptymessage">
     <tr>
-      <td colspan="5">
+      <td colspan="6">
         <div class="no-results">
           <ng-container *ngIf="search" i18n>No follower found matching current filters.</ng-container>
           <ng-container *ngIf="!search" i18n>Your instance doesn't have any follower.</ng-container>
diff --git a/client/src/app/+admin/follows/followers-list/followers-list.component.ts b/client/src/app/+admin/follows/followers-list/followers-list.component.ts
index d09e74fef..b2d333e83 100644
--- a/client/src/app/+admin/follows/followers-list/followers-list.component.ts
+++ b/client/src/app/+admin/follows/followers-list/followers-list.component.ts
@@ -1,8 +1,10 @@
 import { SortMeta } from 'primeng/api'
 import { Component, OnInit } from '@angular/core'
 import { ConfirmService, Notifier, RestPagination, RestTable } from '@app/core'
+import { prepareIcu } from '@app/helpers'
 import { AdvancedInputFilter } from '@app/shared/shared-forms'
 import { InstanceFollowService } from '@app/shared/shared-instance'
+import { DropdownAction } from '@app/shared/shared-main'
 import { ActorFollow } from '@shared/models'
 
 @Component({
@@ -16,7 +18,10 @@ export class FollowersListComponent extends RestTable implements OnInit {
   sort: SortMeta = { field: 'createdAt', order: -1 }
   pagination: RestPagination = { count: this.rowsPerPage, start: 0 }
 
-  searchFilters: AdvancedInputFilter[]
+  searchFilters: AdvancedInputFilter[] = []
+
+  selectedFollows: ActorFollow[] = []
+  bulkFollowsActions: DropdownAction<ActorFollow[]>[] = []
 
   constructor (
     private confirmService: ConfirmService,
@@ -24,66 +29,104 @@ export class FollowersListComponent extends RestTable implements OnInit {
     private followService: InstanceFollowService
   ) {
     super()
-
-    this.searchFilters = this.followService.buildFollowsListFilters()
   }
 
   ngOnInit () {
     this.initialize()
+
+    this.searchFilters = this.followService.buildFollowsListFilters()
+
+    this.bulkFollowsActions = [
+      {
+        label: $localize`Reject`,
+        handler: follows => this.rejectFollower(follows),
+        isDisplayed: follows => follows.every(f => f.state !== 'rejected')
+      },
+      {
+        label: $localize`Accept`,
+        handler: follows => this.acceptFollower(follows),
+        isDisplayed: follows => follows.every(f => f.state !== 'accepted')
+      },
+      {
+        label: $localize`Delete`,
+        handler: follows => this.deleteFollowers(follows),
+        isDisplayed: follows => follows.every(f => f.state === 'rejected')
+      }
+    ]
   }
 
   getIdentifier () {
     return 'FollowersListComponent'
   }
 
-  acceptFollower (follow: ActorFollow) {
-    follow.state = 'accepted'
-
-    this.followService.acceptFollower(follow)
+  acceptFollower (follows: ActorFollow[]) {
+    this.followService.acceptFollower(follows)
       .subscribe({
         next: () => {
-          const handle = follow.follower.name + '@' + follow.follower.host
-          this.notifier.success($localize`${handle} accepted in instance followers`)
+          // eslint-disable-next-line max-len
+          const message = prepareIcu($localize`Accepted {count, plural, =1 {{followerName} follow request} other {{count} follow requests}}`)(
+            { count: follows.length, followerName: this.buildFollowerName(follows[0]) },
+            $localize`Follow requests accepted`
+          )
+          this.notifier.success(message)
+
+          this.reloadData()
         },
 
-        error: err => {
-          follow.state = 'pending'
-          this.notifier.error(err.message)
-        }
+        error: err => this.notifier.error(err.message)
       })
   }
 
-  async rejectFollower (follow: ActorFollow) {
-    const message = $localize`Do you really want to reject this follower?`
+  async rejectFollower (follows: ActorFollow[]) {
+    // eslint-disable-next-line max-len
+    const message = prepareIcu($localize`Do you really want to reject {count, plural, =1 {{followerName} follow request?} other {{count} follow requests?}}`)(
+      { count: follows.length, followerName: this.buildFollowerName(follows[0]) },
+      $localize`Do you really want to reject these follow requests?`
+    )
+
     const res = await this.confirmService.confirm(message, $localize`Reject`)
     if (res === false) return
 
-    this.followService.rejectFollower(follow)
+    this.followService.rejectFollower(follows)
         .subscribe({
           next: () => {
-            const handle = follow.follower.name + '@' + follow.follower.host
-            this.notifier.success($localize`${handle} rejected from instance followers`)
+            // eslint-disable-next-line max-len
+            const message = prepareIcu($localize`Rejected {count, plural, =1 {{followerName} follow request} other {{count} follow requests}}`)(
+              { count: follows.length, followerName: this.buildFollowerName(follows[0]) },
+              $localize`Follow requests rejected`
+            )
+            this.notifier.success(message)
 
             this.reloadData()
           },
 
-          error: err => {
-            follow.state = 'pending'
-            this.notifier.error(err.message)
-          }
+          error: err => this.notifier.error(err.message)
         })
   }
 
-  async deleteFollower (follow: ActorFollow) {
-    const message = $localize`Do you really want to delete this follower? It will be able to send again another follow request.`
+  async deleteFollowers (follows: ActorFollow[]) {
+    let message = $localize`Deleted followers will be able to send again a follow request.`
+    message += '<br /><br />'
+
+    // eslint-disable-next-line max-len
+    message += prepareIcu($localize`Do you really want to delete {count, plural, =1 {{followerName} follow request?} other {{count} follow requests?}}`)(
+      { count: follows.length, followerName: this.buildFollowerName(follows[0]) },
+      $localize`Do you really want to delete these follow requests?`
+    )
+
     const res = await this.confirmService.confirm(message, $localize`Delete`)
     if (res === false) return
 
-    this.followService.removeFollower(follow)
+    this.followService.removeFollower(follows)
         .subscribe({
           next: () => {
-            const handle = follow.follower.name + '@' + follow.follower.host
-            this.notifier.success($localize`${handle} removed from instance followers`)
+            // eslint-disable-next-line max-len
+            const message = prepareIcu($localize`Removed {count, plural, =1 {{followerName} follow request} other {{count} follow requests}}`)(
+              { count: follows.length, followerName: this.buildFollowerName(follows[0]) },
+              $localize`Follow requests removed`
+            )
+
+            this.notifier.success(message)
 
             this.reloadData()
           },
@@ -92,6 +135,14 @@ export class FollowersListComponent extends RestTable implements OnInit {
         })
   }
 
+  buildFollowerName (follow: ActorFollow) {
+    return follow.follower.name + '@' + follow.follower.host
+  }
+
+  isInSelectionMode () {
+    return this.selectedFollows.length !== 0
+  }
+
   protected reloadData () {
     this.followService.getFollowers({ pagination: this.pagination, sort: this.sort, search: this.search })
                       .subscribe({