aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorChocobozzz <florian.bigard@gmail.com>2017-03-22 21:47:05 +0100
committerChocobozzz <florian.bigard@gmail.com>2017-03-22 21:56:02 +0100
commite54163c2d5cc925eb56ead831f2fecd000222a98 (patch)
tree142d0592d66d90b489f592a867770235315bee0c
parent6e07c3de88791a0b342e0cc319590048117f9c2d (diff)
downloadPeerTube-e54163c2d5cc925eb56ead831f2fecd000222a98.tar.gz
PeerTube-e54163c2d5cc925eb56ead831f2fecd000222a98.tar.zst
PeerTube-e54163c2d5cc925eb56ead831f2fecd000222a98.zip
Relax on tags (accept any characters and not required anymore)
-rw-r--r--client/src/app/shared/forms/form-validators/video.ts4
-rw-r--r--client/src/app/videos/video-add/video-add.component.ts46
-rw-r--r--client/src/app/videos/video-list/video-miniature.component.scss1
-rw-r--r--server/helpers/custom-validators/videos.js3
-rw-r--r--server/initializers/constants.js2
-rw-r--r--server/middlewares/validators/videos.js2
-rw-r--r--server/tests/api/check-params/videos.js13
7 files changed, 31 insertions, 40 deletions
diff --git a/client/src/app/shared/forms/form-validators/video.ts b/client/src/app/shared/forms/form-validators/video.ts
index d972ee44b..de5112238 100644
--- a/client/src/app/shared/forms/form-validators/video.ts
+++ b/client/src/app/shared/forms/form-validators/video.ts
@@ -24,8 +24,8 @@ export const VIDEO_DESCRIPTION = {
24}; 24};
25 25
26export const VIDEO_TAGS = { 26export const VIDEO_TAGS = {
27 VALIDATORS: [ Validators.pattern('^[a-zA-Z0-9]{0,10}$') ], 27 VALIDATORS: [ Validators.maxLength(10) ],
28 MESSAGES: { 28 MESSAGES: {
29 'pattern': 'A tag should be between 2 and 10 alphanumeric characters long.' 29 'maxlength': 'A tag should be less than 10 characters long.'
30 } 30 }
31}; 31};
diff --git a/client/src/app/videos/video-add/video-add.component.ts b/client/src/app/videos/video-add/video-add.component.ts
index 2ef666e17..5ed1d8841 100644
--- a/client/src/app/videos/video-add/video-add.component.ts
+++ b/client/src/app/videos/video-add/video-add.component.ts
@@ -105,10 +105,6 @@ export class VideoAddComponent extends FormReactive implements OnInit {
105 checkForm() { 105 checkForm() {
106 this.forceCheck(); 106 this.forceCheck();
107 107
108 if (this.tags.length === 0) {
109 this.tagsError = 'You have 0 tags';
110 }
111
112 if (this.filename === null) { 108 if (this.filename === null) {
113 this.fileError = 'You did not add a file.'; 109 this.fileError = 'You did not add a file.';
114 } 110 }
@@ -121,25 +117,9 @@ export class VideoAddComponent extends FormReactive implements OnInit {
121 } 117 }
122 118
123 onTagKeyPress(event: KeyboardEvent) { 119 onTagKeyPress(event: KeyboardEvent) {
124 const currentTag = this.form.value['currentTag'];
125
126 // Enter press 120 // Enter press
127 if (event.keyCode === 13) { 121 if (event.keyCode === 13) {
128 // Check if the tag is valid and does not already exist 122 this.addTagIfPossible();
129 if (
130 currentTag.length >= 2 &&
131 this.form.controls['currentTag'].valid &&
132 this.tags.indexOf(currentTag) === -1
133 ) {
134 this.tags.push(currentTag);
135 this.form.patchValue({ currentTag: '' });
136
137 if (this.tags.length >= 3) {
138 this.form.get('currentTag').disable();
139 }
140
141 this.tagsError = '';
142 }
143 } 123 }
144 } 124 }
145 125
@@ -153,6 +133,9 @@ export class VideoAddComponent extends FormReactive implements OnInit {
153 } 133 }
154 134
155 upload() { 135 upload() {
136 // Maybe the user forgot to press "enter" when he filled the field
137 this.addTagIfPossible();
138
156 if (this.checkForm() === false) { 139 if (this.checkForm() === false) {
157 return; 140 return;
158 } 141 }
@@ -199,4 +182,25 @@ export class VideoAddComponent extends FormReactive implements OnInit {
199 182
200 this.uploader.uploadAll(); 183 this.uploader.uploadAll();
201 } 184 }
185
186 private addTagIfPossible() {
187 const currentTag = this.form.value['currentTag'];
188 if (currentTag === undefined) return;
189
190 // Check if the tag is valid and does not already exist
191 if (
192 currentTag.length >= 2 &&
193 this.form.controls['currentTag'].valid &&
194 this.tags.indexOf(currentTag) === -1
195 ) {
196 this.tags.push(currentTag);
197 this.form.patchValue({ currentTag: '' });
198
199 if (this.tags.length >= 3) {
200 this.form.get('currentTag').disable();
201 }
202
203 this.tagsError = '';
204 }
205 }
202} 206}
diff --git a/client/src/app/videos/video-list/video-miniature.component.scss b/client/src/app/videos/video-list/video-miniature.component.scss
index 0d309062a..b5d24271a 100644
--- a/client/src/app/videos/video-list/video-miniature.component.scss
+++ b/client/src/app/videos/video-list/video-miniature.component.scss
@@ -9,6 +9,7 @@
9 display: inline-block; 9 display: inline-block;
10 position: relative; 10 position: relative;
11 min-width: 220px; 11 min-width: 220px;
12 height: 190px;
12 13
13 .video-miniature-thumbnail { 14 .video-miniature-thumbnail {
14 display: inline-block; 15 display: inline-block;
diff --git a/server/helpers/custom-validators/videos.js b/server/helpers/custom-validators/videos.js
index 92b366717..efa89c427 100644
--- a/server/helpers/custom-validators/videos.js
+++ b/server/helpers/custom-validators/videos.js
@@ -69,8 +69,7 @@ function isVideoTagsValid (tags) {
69 return miscValidators.isArray(tags) && 69 return miscValidators.isArray(tags) &&
70 validator.isInt(tags.length, VIDEOS_CONSTRAINTS_FIELDS.TAGS) && 70 validator.isInt(tags.length, VIDEOS_CONSTRAINTS_FIELDS.TAGS) &&
71 tags.every(function (tag) { 71 tags.every(function (tag) {
72 return validator.isAlphanumeric(tag) && 72 return validator.isLength(tag, VIDEOS_CONSTRAINTS_FIELDS.TAG)
73 validator.isLength(tag, VIDEOS_CONSTRAINTS_FIELDS.TAG)
74 }) 73 })
75} 74}
76 75
diff --git a/server/initializers/constants.js b/server/initializers/constants.js
index 6c5287b19..40f01e389 100644
--- a/server/initializers/constants.js
+++ b/server/initializers/constants.js
@@ -85,7 +85,7 @@ const CONSTRAINTS_FIELDS = {
85 EXTNAME: [ '.mp4', '.ogv', '.webm' ], 85 EXTNAME: [ '.mp4', '.ogv', '.webm' ],
86 INFO_HASH: { min: 40, max: 40 }, // Length, infohash is 20 bytes length but we represent it in hexa so 20 * 2 86 INFO_HASH: { min: 40, max: 40 }, // Length, infohash is 20 bytes length but we represent it in hexa so 20 * 2
87 DURATION: { min: 1, max: 7200 }, // Number 87 DURATION: { min: 1, max: 7200 }, // Number
88 TAGS: { min: 1, max: 3 }, // Number of total tags 88 TAGS: { min: 0, max: 3 }, // Number of total tags
89 TAG: { min: 2, max: 10 }, // Length 89 TAG: { min: 2, max: 10 }, // Length
90 THUMBNAIL: { min: 2, max: 30 }, 90 THUMBNAIL: { min: 2, max: 30 },
91 THUMBNAIL_DATA: { min: 0, max: 20000 }, // Bytes 91 THUMBNAIL_DATA: { min: 0, max: 20000 }, // Bytes
diff --git a/server/middlewares/validators/videos.js b/server/middlewares/validators/videos.js
index 37cc13372..cf3874a97 100644
--- a/server/middlewares/validators/videos.js
+++ b/server/middlewares/validators/videos.js
@@ -23,7 +23,7 @@ function videosAdd (req, res, next) {
23 req.checkBody('name', 'Should have a valid name').isVideoNameValid() 23 req.checkBody('name', 'Should have a valid name').isVideoNameValid()
24 req.checkBody('category', 'Should have a valid category').isVideoCategoryValid() 24 req.checkBody('category', 'Should have a valid category').isVideoCategoryValid()
25 req.checkBody('description', 'Should have a valid description').isVideoDescriptionValid() 25 req.checkBody('description', 'Should have a valid description').isVideoDescriptionValid()
26 req.checkBody('tags', 'Should have correct tags').isVideoTagsValid() 26 req.checkBody('tags', 'Should have correct tags').optional().isVideoTagsValid()
27 27
28 logger.debug('Checking videosAdd parameters', { parameters: req.body, files: req.files }) 28 logger.debug('Checking videosAdd parameters', { parameters: req.body, files: req.files })
29 29
diff --git a/server/tests/api/check-params/videos.js b/server/tests/api/check-params/videos.js
index fbfe6f137..25b4eae31 100644
--- a/server/tests/api/check-params/videos.js
+++ b/server/tests/api/check-params/videos.js
@@ -251,19 +251,6 @@ describe('Test videos API validator', function () {
251 requestsUtils.makePostUploadRequest(server.url, path, server.accessToken, data, attach, done) 251 requestsUtils.makePostUploadRequest(server.url, path, server.accessToken, data, attach, done)
252 }) 252 })
253 253
254 it('Should fail with malformed tags', function (done) {
255 const data = {
256 name: 'my super name',
257 category: 5,
258 description: 'my super description',
259 tags: [ 'my tag' ]
260 }
261 const attach = {
262 'videofile': pathUtils.join(__dirname, '..', 'fixtures', 'video_short.webm')
263 }
264 requestsUtils.makePostUploadRequest(server.url, path, server.accessToken, data, attach, done)
265 })
266
267 it('Should fail without an input file', function (done) { 254 it('Should fail without an input file', function (done) {
268 const data = { 255 const data = {
269 name: 'my super name', 256 name: 'my super name',