]> git.immae.eu Git - github/wallabag/wallabag.git/commitdiff
Removing failing test from Travis 3707/head
authorJeremy Benoist <jeremy.benoist@gmail.com>
Sun, 19 Aug 2018 14:38:48 +0000 (16:38 +0200)
committerJeremy Benoist <jeremy.benoist@gmail.com>
Sun, 19 Aug 2018 14:38:48 +0000 (16:38 +0200)
tests/Wallabag/CoreBundle/Controller/EntryControllerTest.php
var/SymfonyRequirements.php

index a436be79613310179258d2ef7d41937560d2beaf..6721b2e4175c3c7305e2924046e7dc8e822ea8e4 100644 (file)
@@ -1325,10 +1325,6 @@ class EntryControllerTest extends WallabagCoreTestCase
                 'http://www.hao123.com/shequ?__noscript__-=1',
                 'zh_CN',
             ],
-            'de_AT' => [
-                'https://buy.garmin.com/de-AT/AT/catalog/product/compareResult.ep?compareProduct=112885&compareProduct=36728',
-                'de_AT',
-            ],
             'ru_RU' => [
                 'http://netler.ru/ikt/windows-error-reporting.htm',
                 'ru_RU',
index 3b14a4022d4324a35c42e6f9b8d91150053fedc2..4a1fcc62128bd873f3096e4899e147c96fc050b6 100644 (file)
@@ -389,7 +389,7 @@ class SymfonyRequirements extends RequirementCollection
     {
         /* mandatory requirements follow */
 
-        $installedPhpVersion = phpversion();
+        $installedPhpVersion = PHP_VERSION;
         $requiredPhpVersion = $this->getPhpRequiredVersion();
 
         $this->addRecommendation(
@@ -448,15 +448,8 @@ class SymfonyRequirements extends RequirementCollection
         }
 
         if (false !== $requiredPhpVersion && version_compare($installedPhpVersion, $requiredPhpVersion, '>=')) {
-            $timezones = array();
-            foreach (DateTimeZone::listAbbreviations() as $abbreviations) {
-                foreach ($abbreviations as $abbreviation) {
-                    $timezones[$abbreviation['timezone_id']] = true;
-                }
-            }
-
             $this->addRequirement(
-                isset($timezones[@date_default_timezone_get()]),
+                in_array(@date_default_timezone_get(), DateTimeZone::listIdentifiers(), true),
                 sprintf('Configured default timezone "%s" must be supported by your installation of PHP', @date_default_timezone_get()),
                 'Your default timezone is not supported by PHP. Check for typos in your <strong>php.ini</strong> file and have a look at the list of deprecated timezones at <a href="http://php.net/manual/en/timezones.others.php">http://php.net/manual/en/timezones.others.php</a>.'
             );
@@ -731,7 +724,7 @@ class SymfonyRequirements extends RequirementCollection
             'Install and/or enable a <strong>PHP accelerator</strong> (highly recommended).'
         );
 
-        if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
+        if ('WIN' === strtoupper(substr(PHP_OS, 0, 3))) {
             $this->addRecommendation(
                 $this->getRealpathCacheSize() >= 5 * 1024 * 1024,
                 'realpath_cache_size should be at least 5M in php.ini',