]> git.immae.eu Git - github/wallabag/wallabag.git/blob - tests/Wallabag/CoreBundle/Helper/DownloadImagesTest.php
Fix image downloading on null image path
[github/wallabag/wallabag.git] / tests / Wallabag / CoreBundle / Helper / DownloadImagesTest.php
1 <?php
2
3 namespace Tests\Wallabag\CoreBundle\Helper;
4
5 use GuzzleHttp\Client;
6 use GuzzleHttp\Message\Response;
7 use GuzzleHttp\Stream\Stream;
8 use GuzzleHttp\Subscriber\Mock;
9 use Monolog\Handler\TestHandler;
10 use Monolog\Logger;
11 use PHPUnit\Framework\TestCase;
12 use Wallabag\CoreBundle\Helper\DownloadImages;
13
14 class DownloadImagesTest extends TestCase
15 {
16 public function dataForSuccessImage()
17 {
18 return [
19 'imgur' => [
20 '<div><img src="http://i.imgur.com/T9qgcHc.jpg" /></div>',
21 'http://imgur.com/gallery/WxtWY',
22 ],
23 'image with &' => [
24 '<div><img src="https://i2.wp.com/www.tvaddons.ag/wp-content/uploads/2017/01/Screen-Shot-2017-01-07-at-10.17.40-PM.jpg?w=640&amp;ssl=1" /></div>',
25 'https://www.tvaddons.ag/realdebrid-kodi-jarvis/',
26 ],
27 ];
28 }
29
30 /**
31 * @dataProvider dataForSuccessImage
32 */
33 public function testProcessHtml($html, $url)
34 {
35 $client = new Client();
36
37 $mock = new Mock([
38 new Response(200, ['content-type' => 'image/png'], Stream::factory(file_get_contents(__DIR__ . '/../fixtures/unnamed.png'))),
39 ]);
40
41 $client->getEmitter()->attach($mock);
42
43 $logHandler = new TestHandler();
44 $logger = new Logger('test', [$logHandler]);
45
46 $download = new DownloadImages($client, sys_get_temp_dir() . '/wallabag_test', 'http://wallabag.io/', $logger);
47
48 $res = $download->processHtml(123, $html, $url);
49
50 // this the base path of all image (since it's calculated using the entry id: 123)
51 $this->assertContains('http://wallabag.io/assets/images/9/b/9b0ead26/', $res);
52 }
53
54 public function testProcessHtmlWithBadImage()
55 {
56 $client = new Client();
57
58 $mock = new Mock([
59 new Response(200, ['content-type' => 'application/json'], Stream::factory('')),
60 ]);
61
62 $client->getEmitter()->attach($mock);
63
64 $logHandler = new TestHandler();
65 $logger = new Logger('test', [$logHandler]);
66
67 $download = new DownloadImages($client, sys_get_temp_dir() . '/wallabag_test', 'http://wallabag.io/', $logger);
68 $res = $download->processHtml(123, '<div><img src="http://i.imgur.com/T9qgcHc.jpg" /></div>', 'http://imgur.com/gallery/WxtWY');
69
70 $this->assertContains('http://i.imgur.com/T9qgcHc.jpg', $res, 'Image were not replace because of content-type');
71 }
72
73 public function singleImage()
74 {
75 return [
76 ['image/pjpeg', 'jpeg'],
77 ['image/jpeg', 'jpeg'],
78 ['image/png', 'png'],
79 ['image/gif', 'gif'],
80 ];
81 }
82
83 /**
84 * @dataProvider singleImage
85 */
86 public function testProcessSingleImage($header, $extension)
87 {
88 $client = new Client();
89
90 $mock = new Mock([
91 new Response(200, ['content-type' => $header], Stream::factory(file_get_contents(__DIR__ . '/../fixtures/unnamed.png'))),
92 ]);
93
94 $client->getEmitter()->attach($mock);
95
96 $logHandler = new TestHandler();
97 $logger = new Logger('test', [$logHandler]);
98
99 $download = new DownloadImages($client, sys_get_temp_dir() . '/wallabag_test', 'http://wallabag.io/', $logger);
100 $res = $download->processSingleImage(123, 'T9qgcHc.jpg', 'http://imgur.com/gallery/WxtWY');
101
102 $this->assertContains('/assets/images/9/b/9b0ead26/ebe60399.' . $extension, $res);
103 }
104
105 public function testProcessSingleImageWithBadUrl()
106 {
107 $client = new Client();
108
109 $mock = new Mock([
110 new Response(404, []),
111 ]);
112
113 $client->getEmitter()->attach($mock);
114
115 $logHandler = new TestHandler();
116 $logger = new Logger('test', [$logHandler]);
117
118 $download = new DownloadImages($client, sys_get_temp_dir() . '/wallabag_test', 'http://wallabag.io/', $logger);
119 $res = $download->processSingleImage(123, 'T9qgcHc.jpg', 'http://imgur.com/gallery/WxtWY');
120
121 $this->assertFalse($res, 'Image can not be found, so it will not be replaced');
122 }
123
124 public function testProcessSingleImageWithBadImage()
125 {
126 $client = new Client();
127
128 $mock = new Mock([
129 new Response(200, ['content-type' => 'image/png'], Stream::factory('')),
130 ]);
131
132 $client->getEmitter()->attach($mock);
133
134 $logHandler = new TestHandler();
135 $logger = new Logger('test', [$logHandler]);
136
137 $download = new DownloadImages($client, sys_get_temp_dir() . '/wallabag_test', 'http://wallabag.io/', $logger);
138 $res = $download->processSingleImage(123, 'http://i.imgur.com/T9qgcHc.jpg', 'http://imgur.com/gallery/WxtWY');
139
140 $this->assertFalse($res, 'Image can not be loaded, so it will not be replaced');
141 }
142
143 public function testProcessSingleImageFailAbsolute()
144 {
145 $client = new Client();
146
147 $mock = new Mock([
148 new Response(200, ['content-type' => 'image/png'], Stream::factory(file_get_contents(__DIR__ . '/../fixtures/unnamed.png'))),
149 ]);
150
151 $client->getEmitter()->attach($mock);
152
153 $logHandler = new TestHandler();
154 $logger = new Logger('test', [$logHandler]);
155
156 $download = new DownloadImages($client, sys_get_temp_dir() . '/wallabag_test', 'http://wallabag.io/', $logger);
157 $res = $download->processSingleImage(123, '/i.imgur.com/T9qgcHc.jpg', 'imgur.com/gallery/WxtWY');
158
159 $this->assertFalse($res, 'Absolute image can not be determined, so it will not be replaced');
160 }
161
162 public function testProcessRealImage()
163 {
164 $client = new Client();
165
166 $mock = new Mock([
167 new Response(200, ['content-type' => null], Stream::factory(file_get_contents(__DIR__ . '/../fixtures/image-no-content-type.jpg'))),
168 ]);
169
170 $client->getEmitter()->attach($mock);
171
172 $logHandler = new TestHandler();
173 $logger = new Logger('test', [$logHandler]);
174
175 $download = new DownloadImages($client, sys_get_temp_dir() . '/wallabag_test', 'http://wallabag.io/', $logger);
176
177 $res = $download->processSingleImage(
178 123,
179 'https://cdn.theconversation.com/files/157200/article/width926/gsj2rjp2-1487348607.jpg',
180 'https://theconversation.com/conversation-avec-gerald-bronner-ce-nest-pas-la-post-verite-qui-nous-menace-mais-lextension-de-notre-credulite-73089'
181 );
182
183 $this->assertContains('http://wallabag.io/assets/images/9/b/9b0ead26/', $res, 'Content-Type was empty but data is ok for an image');
184 $this->assertContains('DownloadImages: Checking extension (alternative)', $logHandler->getRecords()[3]['message']);
185 }
186
187 public function testProcessImageWithSrcset()
188 {
189 $client = new Client();
190
191 $mock = new Mock([
192 new Response(200, ['content-type' => 'image/jpeg'], Stream::factory(file_get_contents(__DIR__ . '/../fixtures/image-no-content-type.jpg'))),
193 new Response(200, ['content-type' => 'image/jpeg'], Stream::factory(file_get_contents(__DIR__ . '/../fixtures/image-no-content-type.jpg'))),
194 new Response(200, ['content-type' => 'image/jpeg'], Stream::factory(file_get_contents(__DIR__ . '/../fixtures/image-no-content-type.jpg'))),
195 ]);
196
197 $client->getEmitter()->attach($mock);
198
199 $logHandler = new TestHandler();
200 $logger = new Logger('test', [$logHandler]);
201
202 $download = new DownloadImages($client, sys_get_temp_dir() . '/wallabag_test', 'http://wallabag.io/', $logger);
203 $res = $download->processHtml(123, '<p><img class="alignnone wp-image-1153" src="http://piketty.blog.lemonde.fr/files/2017/10/F1FR-530x375.jpg" alt="" width="628" height="444" srcset="http://piketty.blog.lemonde.fr/files/2017/10/F1FR-530x375.jpg 530w, http://piketty.blog.lemonde.fr/files/2017/10/F1FR-768x543.jpg 768w, http://piketty.blog.lemonde.fr/files/2017/10/F1FR-900x636.jpg 900w" sizes="(max-width: 628px) 100vw, 628px" /></p>', 'http://piketty.blog.lemonde.fr/2017/10/12/budget-2018-la-jeunesse-sacrifiee/');
204
205 $this->assertNotContains('http://piketty.blog.lemonde.fr/', $res, 'Image srcset attribute were not replaced');
206 }
207
208 public function testProcessImageWithNullPath()
209 {
210 $client = new Client();
211
212 $mock = new Mock([
213 new Response(200, ['content-type' => null], Stream::factory(file_get_contents(__DIR__ . '/../fixtures/image-no-content-type.jpg'))),
214 ]);
215
216 $client->getEmitter()->attach($mock);
217
218 $logHandler = new TestHandler();
219 $logger = new Logger('test', [$logHandler]);
220
221 $download = new DownloadImages($client, sys_get_temp_dir() . '/wallabag_test', 'http://wallabag.io/', $logger);
222
223 $res = $download->processSingleImage(
224 123,
225 null,
226 'https://framablog.org/2018/06/30/engagement-atypique/'
227 );
228 $this->assertFalse($res);
229 }
230 }