]> git.immae.eu Git - github/shaarli/Shaarli.git/commitdiff
Merge tag 'v0.10.4' into stable
authorArthurHoaro <arthur@hoa.ro>
Sat, 27 Jul 2019 10:34:30 +0000 (12:34 +0200)
committerArthurHoaro <arthur@hoa.ro>
Sat, 27 Jul 2019 10:34:30 +0000 (12:34 +0200)
Release v0.10.4

1  2 
application/Updater.php
index.php
tests/Updater/UpdaterTest.php

diff --combined application/Updater.php
index 034b8ed8b80d82037e99e240bd4b6a2a3e23b4ec,6b94c5e34af485e8327628206cb9c19aa6c6f7f7..86a21fc39b6c701cd33d9ea3b4649f30ef020f50
@@@ -2,6 -2,7 +2,7 @@@
  use Shaarli\Config\ConfigJson;
  use Shaarli\Config\ConfigPhp;
  use Shaarli\Config\ConfigManager;
+ use Shaarli\Thumbnailer;
  
  /**
   * Class Updater.
@@@ -30,6 -31,11 +31,11 @@@ class Update
       */
      protected $isLoggedIn;
  
+     /**
+      * @var array $_SESSION
+      */
+     protected $session;
      /**
       * @var ReflectionMethod[] List of current class methods.
       */
       * @param LinkDB        $linkDB      LinkDB instance.
       * @param ConfigManager $conf        Configuration Manager instance.
       * @param boolean       $isLoggedIn  True if the user is logged in.
+      * @param array         $session     $_SESSION (by reference)
+      *
+      * @throws ReflectionException
       */
-     public function __construct($doneUpdates, $linkDB, $conf, $isLoggedIn)
+     public function __construct($doneUpdates, $linkDB, $conf, $isLoggedIn, &$session = [])
      {
          $this->doneUpdates = $doneUpdates;
          $this->linkDB = $linkDB;
          $this->conf = $conf;
          $this->isLoggedIn = $isLoggedIn;
+         $this->session = &$session;
  
          // Retrieve all update methods.
          $class = new ReflectionClass($this);
              }
          }
  
-         try{
+         try {
              $this->conf->write($this->isLoggedIn);
              return true;
          } catch (IOException $e) {
      }
  
      /**
 +<<<<<<< HEAD
 +=======
       * Rename tags starting with a '-' to work with tag exclusion search.
       */
      public function updateMethodRenameDashTags()
          $this->linkDB->save($this->conf->get('resource.page_cache'));
          return true;
      }
+     /**
+      * Change privateonly session key to visibility.
+      */
+     public function updateMethodVisibilitySession()
+     {
+         if (isset($_SESSION['privateonly'])) {
+             unset($_SESSION['privateonly']);
+             $_SESSION['visibility'] = 'private';
+         }
+         return true;
+     }
+     /**
+      * Add download size and timeout to the configuration file
+      *
+      * @return bool true if the update is successful, false otherwise.
+      */
+     public function updateMethodDownloadSizeAndTimeoutConf()
+     {
+         if ($this->conf->exists('general.download_max_size')
+             && $this->conf->exists('general.download_timeout')
+         ) {
+             return true;
+         }
+         if (! $this->conf->exists('general.download_max_size')) {
+             $this->conf->set('general.download_max_size', 1024*1024*4);
+         }
+         if (! $this->conf->exists('general.download_timeout')) {
+             $this->conf->set('general.download_timeout', 30);
+         }
+         $this->conf->write($this->isLoggedIn);
+         return true;
+     }
+     /**
+      * * Move thumbnails management to WebThumbnailer, coming with new settings.
+      */
+     public function updateMethodWebThumbnailer()
+     {
+         if ($this->conf->exists('thumbnails.mode')) {
+             return true;
+         }
+         $thumbnailsEnabled = extension_loaded('gd') && $this->conf->get('thumbnail.enable_thumbnails', true);
+         $this->conf->set('thumbnails.mode', $thumbnailsEnabled ? Thumbnailer::MODE_ALL : Thumbnailer::MODE_NONE);
+         $this->conf->set('thumbnails.width', 125);
+         $this->conf->set('thumbnails.height', 90);
+         $this->conf->remove('thumbnail');
+         $this->conf->write(true);
+         if ($thumbnailsEnabled) {
+             $this->session['warnings'][] = t(
+                 'You have enabled or changed thumbnails mode. <a href="?do=thumbs_update">Please synchronize them</a>.'
+             );
+         }
+         return true;
+     }
+     /**
+      * Set sticky = false on all links
+      *
+      * @return bool true if the update is successful, false otherwise.
+      */
+     public function updateMethodSetSticky()
+     {
+         foreach ($this->linkDB as $key => $link) {
+             if (isset($link['sticky'])) {
+                 return true;
+             }
+             $link['sticky'] = false;
+             $this->linkDB[$key] = $link;
+         }
+         $this->linkDB->save($this->conf->get('resource.page_cache'));
+         return true;
+     }
  }
  
  /**
diff --combined index.php
index e05055c3370b17d70412d2fe83c6e43671f437c7,4deed1975f23ee6d73455e7b08cba573dbcac1cb..27c67ce1a7f16935ba1916442fe12614dde1933b
+++ b/index.php
@@@ -1,12 -1,6 +1,12 @@@
  <?php
  /**
 +<<<<<<< HEAD
 + * Shaarli v0.8.7 - Shaare your links...
 + *
 + * The personal, minimalist, super-fast, database free, bookmarking service.
 +=======
   * Shaarli - The personal, minimalist, super-fast, database free, bookmarking service.
 +>>>>>>> v0.9.7
   *
   * Friendly fork by the Shaarli community:
   *  - https://github.com/shaarli/Shaarli
@@@ -34,7 -28,7 +34,7 @@@ if (date_default_timezone_get() == '') 
  define('WEB_PATH', substr($_SERVER['REQUEST_URI'], 0, 1+strrpos($_SERVER['REQUEST_URI'], '/', 0)));
  
  // High execution time in case of problematic imports/exports.
- ini_set('max_input_time','60');
+ ini_set('max_input_time', '60');
  
  // Try to set max upload file size and read
  ini_set('memory_limit', '128M');
@@@ -54,7 -48,7 +54,7 @@@ if (! file_exists(__DIR__ . '/vendor/au
          ."If you installed Shaarli through Git or using the development branch,\n"
          ."please refer to the installation documentation to install PHP"
          ." dependencies using Composer:\n"
-         ."- https://shaarli.readthedocs.io/en/master/Server-requirements/\n"
+         ."- https://shaarli.readthedocs.io/en/master/Server-configuration/\n"
          ."- https://shaarli.readthedocs.io/en/master/Download-and-Installation/";
      exit;
  }
@@@ -81,15 -75,17 +81,17 @@@ require_once 'application/Utils.php'
  require_once 'application/PluginManager.php';
  require_once 'application/Router.php';
  require_once 'application/Updater.php';
+ use \Shaarli\Config\ConfigManager;
  use \Shaarli\Languages;
+ use \Shaarli\Security\LoginManager;
+ use \Shaarli\Security\SessionManager;
  use \Shaarli\ThemeUtils;
- use \Shaarli\Config\ConfigManager;
- use \Shaarli\SessionManager;
+ use \Shaarli\Thumbnailer;
  
  // Ensure the PHP version is supported
  try {
      ApplicationUtils::checkPHPVersion('5.5', PHP_VERSION);
- } catch(Exception $exc) {
+ } catch (Exception $exc) {
      header('Content-Type: text/plain; charset=utf-8');
      echo $exc->getMessage();
      exit;
@@@ -106,8 -102,6 +108,6 @@@ if (dirname($_SERVER['SCRIPT_NAME']) !
  // Set default cookie expiration and path.
  session_set_cookie_params($cookie['lifetime'], $cookiedir, $_SERVER['SERVER_NAME']);
  // Set session parameters on server side.
- // If the user does not access any page within this time, his/her session is considered expired.
- define('INACTIVITY_TIMEOUT', 3600); // in seconds.
  // Use cookies to store session.
  ini_set('session.use_cookies', 1);
  // Force cookies for session (phpsessionID forbidden in URL).
@@@ -117,7 -111,7 +117,7 @@@ ini_set('session.use_trans_sid', false)
  
  session_name('shaarli');
  // Start session if needed (Some server auto-start sessions).
- if (session_id() == '') {
+ if (session_status() == PHP_SESSION_NONE) {
      session_start();
  }
  
@@@ -129,6 -123,9 +129,9 @@@ if (isset($_COOKIE['shaarli']) && !Sess
  
  $conf = new ConfigManager();
  $sessionManager = new SessionManager($_SESSION, $conf);
+ $loginManager = new LoginManager($GLOBALS, $conf, $sessionManager);
+ $loginManager->generateStaySignedInToken($_SERVER['REMOTE_ADDR']);
+ $clientIpId = client_ip_id($_SERVER);
  
  // LC_MESSAGES isn't defined without php-intl, in this case use LC_COLLATE locale instead.
  if (! defined('LC_MESSAGES')) {
@@@ -178,246 -175,63 +181,63 @@@ if (! is_file($conf->getConfigFileExt()
      }
  
      // Display the installation form if no existing config is found
-     install($conf, $sessionManager);
+     install($conf, $sessionManager, $loginManager);
  }
  
- // a token depending of deployment salt, user password, and the current ip
- define('STAY_SIGNED_IN_TOKEN', sha1($conf->get('credentials.hash') . $_SERVER['REMOTE_ADDR'] . $conf->get('credentials.salt')));
+ $loginManager->checkLoginState($_COOKIE, $clientIpId);
  
  /**
-  * Checking session state (i.e. is the user still logged in)
+  * Adapter function to ensure compatibility with third-party templates
   *
-  * @param ConfigManager $conf The configuration manager.
+  * @see https://github.com/shaarli/Shaarli/pull/1086
   *
-  * @return bool: true if the user is logged in, false otherwise.
+  * @return bool true when the user is logged in, false otherwise
   */
- function setup_login_state($conf)
- {
-     if ($conf->get('security.open_shaarli')) {
-         return true;
-     }
-     $userIsLoggedIn = false; // By default, we do not consider the user as logged in;
-     $loginFailure = false; // If set to true, every attempt to authenticate the user will fail. This indicates that an important condition isn't met.
-     if (! $conf->exists('credentials.login')) {
-         $userIsLoggedIn = false;  // Shaarli is not configured yet.
-         $loginFailure = true;
-     }
-     if (isset($_COOKIE['shaarli_staySignedIn']) &&
-         $_COOKIE['shaarli_staySignedIn']===STAY_SIGNED_IN_TOKEN &&
-         !$loginFailure)
-     {
-         fillSessionInfo($conf);
-         $userIsLoggedIn = true;
-     }
-     // If session does not exist on server side, or IP address has changed, or session has expired, logout.
-     if (empty($_SESSION['uid'])
-         || ($conf->get('security.session_protection_disabled') === false && $_SESSION['ip'] != allIPs())
-         || time() >= $_SESSION['expires_on'])
-     {
-         logout();
-         $userIsLoggedIn = false;
-         $loginFailure = true;
-     }
-     if (!empty($_SESSION['longlastingsession'])) {
-         $_SESSION['expires_on']=time()+$_SESSION['longlastingsession']; // In case of "Stay signed in" checked.
-     }
-     else {
-         $_SESSION['expires_on']=time()+INACTIVITY_TIMEOUT; // Standard session expiration date.
-     }
-     if (!$loginFailure) {
-         $userIsLoggedIn = true;
-     }
-     return $userIsLoggedIn;
- }
- $userIsLoggedIn = setup_login_state($conf);
- // ------------------------------------------------------------------------------------------
- // Session management
- // Returns the IP address of the client (Used to prevent session cookie hijacking.)
- function allIPs()
- {
-     $ip = $_SERVER['REMOTE_ADDR'];
-     // Then we use more HTTP headers to prevent session hijacking from users behind the same proxy.
-     if (isset($_SERVER['HTTP_X_FORWARDED_FOR'])) { $ip=$ip.'_'.$_SERVER['HTTP_X_FORWARDED_FOR']; }
-     if (isset($_SERVER['HTTP_CLIENT_IP'])) { $ip=$ip.'_'.$_SERVER['HTTP_CLIENT_IP']; }
-     return $ip;
- }
- /**
-  * Load user session.
-  *
-  * @param ConfigManager $conf Configuration Manager instance.
-  */
- function fillSessionInfo($conf)
- {
-     $_SESSION['uid'] = sha1(uniqid('',true).'_'.mt_rand()); // Generate unique random number (different than phpsessionid)
-     $_SESSION['ip']=allIPs();                // We store IP address(es) of the client to make sure session is not hijacked.
-     $_SESSION['username']= $conf->get('credentials.login');
-     $_SESSION['expires_on']=time()+INACTIVITY_TIMEOUT;  // Set session expiration.
- }
- /**
-  * Check that user/password is correct.
-  *
-  * @param string        $login    Username
-  * @param string        $password User password
-  * @param ConfigManager $conf     Configuration Manager instance.
-  *
-  * @return bool: authentication successful or not.
-  */
- function check_auth($login, $password, $conf)
- {
-     $hash = sha1($password . $login . $conf->get('credentials.salt'));
-     if ($login == $conf->get('credentials.login') && $hash == $conf->get('credentials.hash'))
-     {   // Login/password is correct.
-         fillSessionInfo($conf);
-         logm($conf->get('resource.log'), $_SERVER['REMOTE_ADDR'], 'Login successful');
-         return true;
-     }
-     logm($conf->get('resource.log'), $_SERVER['REMOTE_ADDR'], 'Login failed for user '.$login);
-     return false;
- }
- // Returns true if the user is logged in.
  function isLoggedIn()
  {
-     global $userIsLoggedIn;
-     return $userIsLoggedIn;
- }
- // Force logout.
- function logout() {
-     if (isset($_SESSION)) {
-         unset($_SESSION['uid']);
-         unset($_SESSION['ip']);
-         unset($_SESSION['username']);
-         unset($_SESSION['privateonly']);
-         unset($_SESSION['untaggedonly']);
-     }
-     setcookie('shaarli_staySignedIn', FALSE, 0, WEB_PATH);
+     global $loginManager;
+     return $loginManager->isLoggedIn();
  }
  
  
- // ------------------------------------------------------------------------------------------
- // Brute force protection system
- // Several consecutive failed logins will ban the IP address for 30 minutes.
- if (!is_file($conf->get('resource.ban_file', 'data/ipbans.php'))) {
-     // FIXME! globals
-     file_put_contents(
-         $conf->get('resource.ban_file', 'data/ipbans.php'),
-         "<?php\n\$GLOBALS['IPBANS']=".var_export(array('FAILURES'=>array(),'BANS'=>array()),true).";\n?>"
-     );
- }
- include $conf->get('resource.ban_file', 'data/ipbans.php');
- /**
-  * Signal a failed login. Will ban the IP if too many failures:
-  *
-  * @param ConfigManager $conf Configuration Manager instance.
-  */
- function ban_loginFailed($conf)
- {
-     $ip = $_SERVER['REMOTE_ADDR'];
-     $trusted = $conf->get('security.trusted_proxies', array());
-     if (in_array($ip, $trusted)) {
-         $ip = getIpAddressFromProxy($_SERVER, $trusted);
-         if (!$ip) {
-             return;
-         }
-     }
-     $gb = $GLOBALS['IPBANS'];
-     if (! isset($gb['FAILURES'][$ip])) {
-         $gb['FAILURES'][$ip]=0;
-     }
-     $gb['FAILURES'][$ip]++;
-     if ($gb['FAILURES'][$ip] > ($conf->get('security.ban_after') - 1))
-     {
-         $gb['BANS'][$ip] = time() + $conf->get('security.ban_after', 1800);
-         logm($conf->get('resource.log'), $_SERVER['REMOTE_ADDR'], 'IP address banned from login');
-     }
-     $GLOBALS['IPBANS'] = $gb;
-     file_put_contents(
-         $conf->get('resource.ban_file', 'data/ipbans.php'),
-         "<?php\n\$GLOBALS['IPBANS']=".var_export($gb,true).";\n?>"
-     );
- }
- /**
-  * Signals a successful login. Resets failed login counter.
-  *
-  * @param ConfigManager $conf Configuration Manager instance.
-  */
- function ban_loginOk($conf)
- {
-     $ip = $_SERVER['REMOTE_ADDR'];
-     $gb = $GLOBALS['IPBANS'];
-     unset($gb['FAILURES'][$ip]); unset($gb['BANS'][$ip]);
-     $GLOBALS['IPBANS'] = $gb;
-     file_put_contents(
-         $conf->get('resource.ban_file', 'data/ipbans.php'),
-         "<?php\n\$GLOBALS['IPBANS']=".var_export($gb,true).";\n?>"
-     );
- }
- /**
-  * Checks if the user CAN login. If 'true', the user can try to login.
-  *
-  * @param ConfigManager $conf Configuration Manager instance.
-  *
-  * @return bool: true if the user is allowed to login.
-  */
- function ban_canLogin($conf)
- {
-     $ip=$_SERVER["REMOTE_ADDR"]; $gb=$GLOBALS['IPBANS'];
-     if (isset($gb['BANS'][$ip]))
-     {
-         // User is banned. Check if the ban has expired:
-         if ($gb['BANS'][$ip]<=time())
-         {   // Ban expired, user can try to login again.
-             logm($conf->get('resource.log'), $_SERVER['REMOTE_ADDR'], 'Ban lifted.');
-             unset($gb['FAILURES'][$ip]); unset($gb['BANS'][$ip]);
-             file_put_contents(
-                 $conf->get('resource.ban_file', 'data/ipbans.php'),
-                 "<?php\n\$GLOBALS['IPBANS']=".var_export($gb,true).";\n?>"
-             );
-             return true; // Ban has expired, user can login.
-         }
-         return false; // User is banned.
-     }
-     return true; // User is not banned.
- }
  // ------------------------------------------------------------------------------------------
  // Process login form: Check if login/password is correct.
- if (isset($_POST['login']))
- {
-     if (!ban_canLogin($conf)) die(t('I said: NO. You are banned for the moment. Go away.'));
+ if (isset($_POST['login'])) {
+     if (! $loginManager->canLogin($_SERVER)) {
+         die(t('I said: NO. You are banned for the moment. Go away.'));
+     }
      if (isset($_POST['password'])
          && $sessionManager->checkToken($_POST['token'])
-         && (check_auth($_POST['login'], $_POST['password'], $conf))
-     ) {   // Login/password is OK.
-         ban_loginOk($conf);
-         // If user wants to keep the session cookie even after the browser closes:
-         if (!empty($_POST['longlastingsession']))
-         {
-             $_SESSION['longlastingsession'] = 31536000; // (31536000 seconds = 1 year)
-             $expiration = time() + $_SESSION['longlastingsession']; // calculate relative cookie expiration (1 year from now)
-             setcookie('shaarli_staySignedIn', STAY_SIGNED_IN_TOKEN, $expiration, WEB_PATH);
-             $_SESSION['expires_on'] = $expiration;  // Set session expiration on server-side.
-             $cookiedir = ''; if(dirname($_SERVER['SCRIPT_NAME'])!='/') $cookiedir=dirname($_SERVER["SCRIPT_NAME"]).'/';
-             session_set_cookie_params($_SESSION['longlastingsession'],$cookiedir,$_SERVER['SERVER_NAME']); // Set session cookie expiration on client side
+         && $loginManager->checkCredentials($_SERVER['REMOTE_ADDR'], $clientIpId, $_POST['login'], $_POST['password'])
+     ) {
+         $loginManager->handleSuccessfulLogin($_SERVER);
+         $cookiedir = '';
+         if (dirname($_SERVER['SCRIPT_NAME']) != '/') {
              // Note: Never forget the trailing slash on the cookie path!
-             session_regenerate_id(true);  // Send cookie with new expiration date to browser.
+             $cookiedir = dirname($_SERVER["SCRIPT_NAME"]) . '/';
          }
-         else // Standard session expiration (=when browser closes)
-         {
-             $cookiedir = ''; if(dirname($_SERVER['SCRIPT_NAME'])!='/') $cookiedir=dirname($_SERVER["SCRIPT_NAME"]).'/';
-             session_set_cookie_params(0,$cookiedir,$_SERVER['SERVER_NAME']); // 0 means "When browser closes"
-             session_regenerate_id(true);
+         if (!empty($_POST['longlastingsession'])) {
+             // Keep the session cookie even after the browser closes
+             $sessionManager->setStaySignedIn(true);
+             $expirationTime = $sessionManager->extendSession();
+             setcookie(
+                 $loginManager::$STAY_SIGNED_IN_COOKIE,
+                 $loginManager->getStaySignedInToken(),
+                 $expirationTime,
+                 WEB_PATH
+             );
+         } else {
+             // Standard session expiration (=when browser closes)
+             $expirationTime = 0;
          }
  
+         // Send cookie with the new expiration date to the browser
+         session_set_cookie_params($expirationTime, $cookiedir, $_SERVER['SERVER_NAME']);
+         session_regenerate_id(true);
          // Optional redirect after login:
          if (isset($_GET['post'])) {
              $uri = '?post='. urlencode($_GET['post']);
                  exit;
              }
          }
-         header('Location: ?'); exit;
-     }
-     else
-     {
-         ban_loginFailed($conf);
+         header('Location: ?');
+         exit;
+     } else {
+         $loginManager->handleFailedLogin($_SERVER);
          $redir = '&username='. urlencode($_POST['login']);
          if (isset($_GET['post'])) {
              $redir .= '&post=' . urlencode($_GET['post']);
  // ------------------------------------------------------------------------------------------
  // Token management for XSRF protection
  // Token should be used in any form which acts on data (create,update,delete,import...).
- if (!isset($_SESSION['tokens'])) $_SESSION['tokens']=array();  // Token are attached to the session.
+ if (!isset($_SESSION['tokens'])) {
+     $_SESSION['tokens']=array();  // Token are attached to the session.
+ }
  
  /**
   * Daily RSS feed: 1 RSS entry per day giving all the links on that day.
   * Gives the last 7 days (which have links).
   * This RSS feed cannot be filtered.
   *
-  * @param ConfigManager $conf Configuration Manager instance.
+  * @param ConfigManager $conf         Configuration Manager instance
+  * @param LoginManager  $loginManager LoginManager instance
   */
- function showDailyRSS($conf) {
+ function showDailyRSS($conf, $loginManager)
+ {
      // Cache system
      $query = $_SERVER['QUERY_STRING'];
      $cache = new CachedPage(
          $conf->get('config.PAGE_CACHE'),
          page_url($_SERVER),
-         startsWith($query,'do=dailyrss') && !isLoggedIn()
+         startsWith($query, 'do=dailyrss') && !$loginManager->isLoggedIn()
      );
      $cached = $cache->cachedVersion();
      if (!empty($cached)) {
      // Read links from database (and filter private links if used it not logged in).
      $LINKSDB = new LinkDB(
          $conf->get('resource.datastore'),
-         isLoggedIn(),
+         $loginManager->isLoggedIn(),
          $conf->get('privacy.hide_public_links'),
          $conf->get('redirector.url'),
          $conf->get('redirector.encode_url')
                  $conf->get('redirector.url'),
                  $conf->get('redirector.encode_url')
              );
-             $link['thumbnail'] = thumbnail($conf, $link['url']);
              $link['timestamp'] = $link['created']->getTimestamp();
              if (startsWith($link['url'], '?')) {
                  $link['url'] = index_url($_SERVER) . $link['url'];  // make permalink URL absolute
          $tpl->assign('links', $links);
          $tpl->assign('rssdate', escape($dayDate->format(DateTime::RSS)));
          $tpl->assign('hide_timestamps', $conf->get('privacy.hide_timestamps', false));
+         $tpl->assign('index_url', $pageaddr);
          $html = $tpl->draw('dailyrss', true);
  
          echo $html . PHP_EOL;
   * @param PageBuilder   $pageBuilder   Template engine wrapper.
   * @param LinkDB        $LINKSDB       LinkDB instance.
   * @param ConfigManager $conf          Configuration Manager instance.
-  * @param PluginManager $pluginManager Plugin Manager instane.
+  * @param PluginManager $pluginManager Plugin Manager instance.
+  * @param LoginManager  $loginManager  Login Manager instance
   */
- function showDaily($pageBuilder, $LINKSDB, $conf, $pluginManager)
+ function showDaily($pageBuilder, $LINKSDB, $conf, $pluginManager, $loginManager)
  {
      $day = date('Ymd', strtotime('-1 day')); // Yesterday, in format YYYYMMDD.
      if (isset($_GET['day'])) {
-       $day = $_GET['day'];
+         $day = $_GET['day'];
      }
  
      $days = $LINKSDB->days();
               $previousday=$days[$i - 1];
          }
          if ($i < count($days) - 1) {
-           $nextday = $days[$i + 1];
+             $nextday = $days[$i + 1];
          }
      }
      try {
      }
  
      // We pre-format some fields for proper output.
-     foreach($linksToDisplay as $key => $link) {
-         $taglist = explode(' ',$link['tags']);
+     foreach ($linksToDisplay as $key => $link) {
+         $taglist = explode(' ', $link['tags']);
          uasort($taglist, 'strcasecmp');
          $linksToDisplay[$key]['taglist']=$taglist;
          $linksToDisplay[$key]['formatedDescription'] = format_description(
              $conf->get('redirector.url'),
              $conf->get('redirector.encode_url')
          );
-         $linksToDisplay[$key]['thumbnail'] = thumbnail($conf, $link['url']);
          $linksToDisplay[$key]['timestamp'] =  $link['created']->getTimestamp();
      }
  
+     $dayDate = DateTime::createFromFormat(LinkDB::LINK_DATE_FORMAT, $day.'_000000');
+     $data = array(
+         'pagetitle' => $conf->get('general.title') .' - '. format_date($dayDate, false),
+         'linksToDisplay' => $linksToDisplay,
+         'day' => $dayDate->getTimestamp(),
+         'dayDate' => $dayDate,
+         'previousday' => $previousday,
+         'nextday' => $nextday,
+     );
+     /* Hook is called before column construction so that plugins don't have
+        to deal with columns. */
+     $pluginManager->executeHooks('render_daily', $data, array('loggedin' => $loginManager->isLoggedIn()));
      /* We need to spread the articles on 3 columns.
         I did not want to use a JavaScript lib like http://masonry.desandro.com/
         so I manually spread entries with a simple method: I roughly evaluate the
      */
      $columns = array(array(), array(), array()); // Entries to display, for each column.
      $fill = array(0, 0, 0);  // Rough estimate of columns fill.
-     foreach($linksToDisplay as $key => $link) {
+     foreach ($data['linksToDisplay'] as $key => $link) {
          // Roughly estimate length of entry (by counting characters)
          // Title: 30 chars = 1 line. 1 line is 30 pixels height.
          // Description: 836 characters gives roughly 342 pixel height.
          // This is not perfect, but it's usually OK.
          $length = strlen($link['title']) + (342 * strlen($link['description'])) / 836;
          if ($link['thumbnail']) {
-           $length += 100; // 1 thumbnails roughly takes 100 pixels height.
+             $length += 100; // 1 thumbnails roughly takes 100 pixels height.
          }
          // Then put in column which is the less filled:
          $smallest = min($fill); // find smallest value in array.
          $fill[$index] += $length;
      }
  
-     $dayDate = DateTime::createFromFormat(LinkDB::LINK_DATE_FORMAT, $day.'_000000');
-     $data = array(
-         'pagetitle' => $conf->get('general.title') .' - '. format_date($dayDate, false),
-         'linksToDisplay' => $linksToDisplay,
-         'cols' => $columns,
-         'day' => $dayDate->getTimestamp(),
-         'dayDate' => $dayDate,
-         'previousday' => $previousday,
-         'nextday' => $nextday,
-     );
-     $pluginManager->executeHooks('render_daily', $data, array('loggedin' => isLoggedIn()));
+     $data['cols'] = $columns;
  
      foreach ($data as $key => $value) {
          $pageBuilder->assign($key, $value);
      }
  
+     $pageBuilder->assign('pagetitle', t('Daily') .' - '. $conf->get('general.title', 'Shaarli'));
      $pageBuilder->renderPage('daily');
      exit;
  }
   * @param ConfigManager $conf    Configuration Manager instance.
   * @param PluginManager $pluginManager Plugin Manager instance.
   */
- function showLinkList($PAGE, $LINKSDB, $conf, $pluginManager) {
-     buildLinkList($PAGE,$LINKSDB, $conf, $pluginManager); // Compute list of links to display
+ function showLinkList($PAGE, $LINKSDB, $conf, $pluginManager, $loginManager)
+ {
+     buildLinkList($PAGE, $LINKSDB, $conf, $pluginManager, $loginManager);
      $PAGE->renderPage('linklist');
  }
  
   * @param LinkDB         $LINKSDB
   * @param History        $history        instance
   * @param SessionManager $sessionManager SessionManager instance
+  * @param LoginManager   $loginManager   LoginManager instance
   */
- function renderPage($conf, $pluginManager, $LINKSDB, $history, $sessionManager)
+ function renderPage($conf, $pluginManager, $LINKSDB, $history, $sessionManager, $loginManager)
  {
      $updater = new Updater(
          read_updates_file($conf->get('resource.updates')),
          $LINKSDB,
          $conf,
-         isLoggedIn()
+         $loginManager->isLoggedIn(),
+         $_SESSION
      );
      try {
          $newUpdates = $updater->update();
                  $updater->getDoneUpdates()
              );
          }
-     }
-     catch(Exception $e) {
+     } catch (Exception $e) {
          die($e->getMessage());
      }
  
-     $PAGE = new PageBuilder($conf, $LINKSDB, $sessionManager->generateToken());
+     $PAGE = new PageBuilder($conf, $_SESSION, $LINKSDB, $sessionManager->generateToken(), $loginManager->isLoggedIn());
      $PAGE->assign('linkcount', count($LINKSDB));
      $PAGE->assign('privateLinkcount', count_private($LINKSDB));
      $PAGE->assign('plugin_errors', $pluginManager->getErrors());
  
      // Determine which page will be rendered.
      $query = (isset($_SERVER['QUERY_STRING'])) ? $_SERVER['QUERY_STRING'] : '';
-     $targetPage = Router::findPage($query, $_GET, isLoggedIn());
+     $targetPage = Router::findPage($query, $_GET, $loginManager->isLoggedIn());
  
-     if (
-         // if the user isn't logged in
-         !isLoggedIn() &&
+     if (// if the user isn't logged in
+         !$loginManager->isLoggedIn() &&
          // and Shaarli doesn't have public content...
          $conf->get('privacy.hide_public_links') &&
          // and is configured to enforce the login
          'footer',
      );
  
-     foreach($common_hooks as $name) {
+     foreach ($common_hooks as $name) {
          $plugin_data = array();
-         $pluginManager->executeHooks('render_' . $name, $plugin_data,
+         $pluginManager->executeHooks(
+             'render_' . $name,
+             $plugin_data,
              array(
                  'target' => $targetPage,
-                 'loggedin' => isLoggedIn()
+                 'loggedin' => $loginManager->isLoggedIn()
              )
          );
          $PAGE->assign('plugins_' . $name, $plugin_data);
      }
  
      // -------- Display login form.
-     if ($targetPage == Router::$PAGE_LOGIN)
-     {
-         if ($conf->get('security.open_shaarli')) { header('Location: ?'); exit; }  // No need to login for open Shaarli
+     if ($targetPage == Router::$PAGE_LOGIN) {
+         if ($conf->get('security.open_shaarli')) {
+             header('Location: ?');
+             exit;
+         }  // No need to login for open Shaarli
          if (isset($_GET['username'])) {
              $PAGE->assign('username', escape($_GET['username']));
          }
-         $PAGE->assign('returnurl',(isset($_SERVER['HTTP_REFERER']) ? escape($_SERVER['HTTP_REFERER']):''));
+         $PAGE->assign('returnurl', (isset($_SERVER['HTTP_REFERER']) ? escape($_SERVER['HTTP_REFERER']):''));
          // add default state of the 'remember me' checkbox
          $PAGE->assign('remember_user_default', $conf->get('privacy.remember_user_default'));
+         $PAGE->assign('user_can_login', $loginManager->canLogin($_SERVER));
+         $PAGE->assign('pagetitle', t('Login') .' - '. $conf->get('general.title', 'Shaarli'));
          $PAGE->renderPage('loginform');
          exit;
      }
      // -------- User wants to logout.
-     if (isset($_SERVER['QUERY_STRING']) && startsWith($_SERVER['QUERY_STRING'], 'do=logout'))
-     {
+     if (isset($_SERVER['QUERY_STRING']) && startsWith($_SERVER['QUERY_STRING'], 'do=logout')) {
          invalidateCaches($conf->get('resource.page_cache'));
-         logout();
+         $sessionManager->logout();
+         setcookie(LoginManager::$STAY_SIGNED_IN_COOKIE, 'false', 0, WEB_PATH);
          header('Location: ?');
          exit;
      }
  
      // -------- Picture wall
-     if ($targetPage == Router::$PAGE_PICWALL)
-     {
+     if ($targetPage == Router::$PAGE_PICWALL) {
+         $PAGE->assign('pagetitle', t('Picture wall') .' - '. $conf->get('general.title', 'Shaarli'));
+         if (! $conf->get('thumbnails.mode', Thumbnailer::MODE_NONE) === Thumbnailer::MODE_NONE) {
+             $PAGE->assign('linksToDisplay', []);
+             $PAGE->renderPage('picwall');
+             exit;
+         }
          // Optionally filter the results:
          $links = $LINKSDB->filterSearch($_GET);
          $linksToDisplay = array();
  
          // Get only links which have a thumbnail.
-         foreach($links as $link)
-         {
-             $permalink='?'.$link['shorturl'];
-             $thumb=lazyThumbnail($conf, $link['url'],$permalink);
-             if ($thumb!='') // Only output links which have a thumbnail.
-             {
-                 $link['thumbnail']=$thumb; // Thumbnail HTML code.
-                 $linksToDisplay[]=$link; // Add to array.
+         // Note: we do not retrieve thumbnails here, the request is too heavy.
+         foreach ($links as $key => $link) {
+             if (isset($link['thumbnail']) && $link['thumbnail'] !== false) {
+                 $linksToDisplay[] = $link; // Add to array.
              }
          }
  
          $data = array(
              'linksToDisplay' => $linksToDisplay,
          );
-         $pluginManager->executeHooks('render_picwall', $data, array('loggedin' => isLoggedIn()));
+         $pluginManager->executeHooks('render_picwall', $data, array('loggedin' => $loginManager->isLoggedIn()));
  
          foreach ($data as $key => $value) {
              $PAGE->assign($key, $value);
          }
  
          $PAGE->renderPage('picwall');
          exit;
      }
  
      // -------- Tag cloud
-     if ($targetPage == Router::$PAGE_TAGCLOUD)
-     {
-         $visibility = ! empty($_SESSION['privateonly']) ? 'private' : 'all';
+     if ($targetPage == Router::$PAGE_TAGCLOUD) {
+         $visibility = ! empty($_SESSION['visibility']) ? $_SESSION['visibility'] : '';
          $filteringTags = isset($_GET['searchtags']) ? explode(' ', $_GET['searchtags']) : [];
          $tags = $LINKSDB->linksCountPerTag($filteringTags, $visibility);
  
          alphabetical_sort($tags, false, true);
  
          $tagList = array();
-         foreach($tags as $key => $value) {
+         foreach ($tags as $key => $value) {
              if (in_array($key, $filteringTags)) {
                  continue;
              }
              );
          }
  
+         $searchTags = implode(' ', escape($filteringTags));
          $data = array(
-             'search_tags' => implode(' ', escape($filteringTags)),
+             'search_tags' => $searchTags,
              'tags' => $tagList,
          );
-         $pluginManager->executeHooks('render_tagcloud', $data, array('loggedin' => isLoggedIn()));
+         $pluginManager->executeHooks('render_tagcloud', $data, array('loggedin' => $loginManager->isLoggedIn()));
  
          foreach ($data as $key => $value) {
              $PAGE->assign($key, $value);
          }
  
+         $searchTags = ! empty($searchTags) ? $searchTags .' - ' : '';
+         $PAGE->assign('pagetitle', $searchTags. t('Tag cloud') .' - '. $conf->get('general.title', 'Shaarli'));
          $PAGE->renderPage('tag.cloud');
          exit;
      }
  
      // -------- Tag list
-     if ($targetPage == Router::$PAGE_TAGLIST)
-     {
-         $visibility = ! empty($_SESSION['privateonly']) ? 'private' : 'all';
+     if ($targetPage == Router::$PAGE_TAGLIST) {
+         $visibility = ! empty($_SESSION['visibility']) ? $_SESSION['visibility'] : '';
          $filteringTags = isset($_GET['searchtags']) ? explode(' ', $_GET['searchtags']) : [];
          $tags = $LINKSDB->linksCountPerTag($filteringTags, $visibility);
          foreach ($filteringTags as $tag) {
              alphabetical_sort($tags, false, true);
          }
  
+         $searchTags = implode(' ', escape($filteringTags));
          $data = [
-             'search_tags' => implode(' ', escape($filteringTags)),
+             'search_tags' => $searchTags,
              'tags' => $tags,
          ];
-         $pluginManager->executeHooks('render_taglist', $data, ['loggedin' => isLoggedIn()]);
+         $pluginManager->executeHooks('render_taglist', $data, ['loggedin' => $loginManager->isLoggedIn()]);
  
          foreach ($data as $key => $value) {
              $PAGE->assign($key, $value);
          }
  
+         $searchTags = ! empty($searchTags) ? $searchTags .' - ' : '';
+         $PAGE->assign('pagetitle', $searchTags . t('Tag list') .' - '. $conf->get('general.title', 'Shaarli'));
          $PAGE->renderPage('tag.list');
          exit;
      }
  
      // Daily page.
      if ($targetPage == Router::$PAGE_DAILY) {
-         showDaily($PAGE, $LINKSDB, $conf, $pluginManager);
+         showDaily($PAGE, $LINKSDB, $conf, $pluginManager, $loginManager);
      }
  
      // ATOM and RSS feed.
          $cache = new CachedPage(
              $conf->get('resource.page_cache'),
              page_url($_SERVER),
-             startsWith($query,'do='. $targetPage) && !isLoggedIn()
+             startsWith($query, 'do='. $targetPage) && !$loginManager->isLoggedIn()
          );
          $cached = $cache->cachedVersion();
          if (!empty($cached)) {
          }
  
          // Generate data.
-         $feedGenerator = new FeedBuilder($LINKSDB, $feedType, $_SERVER, $_GET, isLoggedIn());
+         $feedGenerator = new FeedBuilder($LINKSDB, $feedType, $_SERVER, $_GET, $loginManager->isLoggedIn());
          $feedGenerator->setLocale(strtolower(setlocale(LC_COLLATE, 0)));
-         $feedGenerator->setHideDates($conf->get('privacy.hide_timestamps') && !isLoggedIn());
+         $feedGenerator->setHideDates($conf->get('privacy.hide_timestamps') && !$loginManager->isLoggedIn());
          $feedGenerator->setUsePermalinks(isset($_GET['permalinks']) || !$conf->get('feed.rss_permalinks'));
          $data = $feedGenerator->buildData();
  
          // Process plugin hook.
          $pluginManager->executeHooks('render_feed', $data, array(
-             'loggedin' => isLoggedIn(),
+             'loggedin' => $loginManager->isLoggedIn(),
              'target' => $targetPage,
          ));
  
      }
  
      // -------- User clicks on a tag in a link: The tag is added to the list of searched tags (searchtags=...)
-     if (isset($_GET['addtag']))
-     {
+     if (isset($_GET['addtag'])) {
          // Get previous URL (http_referer) and add the tag to the searchtags parameters in query.
-         if (empty($_SERVER['HTTP_REFERER'])) { header('Location: ?searchtags='.urlencode($_GET['addtag'])); exit; } // In case browser does not send HTTP_REFERER
-         parse_str(parse_url($_SERVER['HTTP_REFERER'],PHP_URL_QUERY), $params);
+         if (empty($_SERVER['HTTP_REFERER'])) {
+             // In case browser does not send HTTP_REFERER
+             header('Location: ?searchtags='.urlencode($_GET['addtag']));
+             exit;
+         }
+         parse_str(parse_url($_SERVER['HTTP_REFERER'], PHP_URL_QUERY), $params);
  
          // Prevent redirection loop
          if (isset($params['addtag'])) {
          // Append the tag if necessary
          if (empty($params['searchtags'])) {
              $params['searchtags'] = trim($_GET['addtag']);
-         }
-         else if ($addtag) {
+         } elseif ($addtag) {
              $params['searchtags'] = trim($params['searchtags']).' '.trim($_GET['addtag']);
          }
  
-         unset($params['page']); // We also remove page (keeping the same page has no sense, since the results are different)
+         // We also remove page (keeping the same page has no sense, since the
+         // results are different)
+         unset($params['page']);
          header('Location: ?'.http_build_query($params));
          exit;
      }
              $tags = explode(' ', $params['searchtags']);
              // Remove value from array $tags.
              $tags = array_diff($tags, array($_GET['removetag']));
-             $params['searchtags'] = implode(' ',$tags);
+             $params['searchtags'] = implode(' ', $tags);
  
              if (empty($params['searchtags'])) {
                  unset($params['searchtags']);
              }
  
-             unset($params['page']); // We also remove page (keeping the same page has no sense, since the results are different)
+             // We also remove page (keeping the same page has no sense, since
+             // the results are different)
+             unset($params['page']);
          }
          header('Location: ?'.http_build_query($params));
          exit;
      }
  
      // -------- User wants to see only private links (toggle)
-     if (isset($_GET['privateonly'])) {
-         if (empty($_SESSION['privateonly'])) {
-             $_SESSION['privateonly'] = 1; // See only private links
-         } else {
-             unset($_SESSION['privateonly']); // See all links
+     if (isset($_GET['visibility'])) {
+         if ($_GET['visibility'] === 'private') {
+             // Visibility not set or not already private, set private, otherwise reset it
+             if (empty($_SESSION['visibility']) || $_SESSION['visibility'] !== 'private') {
+                 // See only private links
+                 $_SESSION['visibility'] = 'private';
+             } else {
+                 unset($_SESSION['visibility']);
+             }
+         } elseif ($_GET['visibility'] === 'public') {
+             if (empty($_SESSION['visibility']) || $_SESSION['visibility'] !== 'public') {
+                 // See only public links
+                 $_SESSION['visibility'] = 'public';
+             } else {
+                 unset($_SESSION['visibility']);
+             }
          }
  
          if (! empty($_SERVER['HTTP_REFERER'])) {
-             $location = generateLocation($_SERVER['HTTP_REFERER'], $_SERVER['HTTP_HOST'], array('privateonly'));
+             $location = generateLocation($_SERVER['HTTP_REFERER'], $_SERVER['HTTP_HOST'], array('visibility'));
          } else {
              $location = '?';
          }
      }
  
      // -------- Handle other actions allowed for non-logged in users:
-     if (!isLoggedIn())
-     {
+     if (!$loginManager->isLoggedIn()) {
          // User tries to post new link but is not logged in:
          // Show login screen, then redirect to ?post=...
-         if (isset($_GET['post']))
-         {
+         if (isset($_GET['post'])) {
              header( // Redirect to login page, then back to post link.
                  'Location: ?do=login&post='.urlencode($_GET['post']).
                  (!empty($_GET['title'])?'&title='.urlencode($_GET['title']):'').
              exit;
          }
  
-         showLinkList($PAGE, $LINKSDB, $conf, $pluginManager);
+         showLinkList($PAGE, $LINKSDB, $conf, $pluginManager, $loginManager);
          if (isset($_GET['edit_link'])) {
              header('Location: ?do=login&edit_link='. escape($_GET['edit_link']));
              exit;
      // -------- All other functions are reserved for the registered user:
  
      // -------- Display the Tools menu if requested (import/export/bookmarklet...)
-     if ($targetPage == Router::$PAGE_TOOLS)
-     {
+     if ($targetPage == Router::$PAGE_TOOLS) {
          $data = [
              'pageabsaddr' => index_url($_SERVER),
              'sslenabled' => is_https($_SERVER),
              $PAGE->assign($key, $value);
          }
  
+         $PAGE->assign('pagetitle', t('Tools') .' - '. $conf->get('general.title', 'Shaarli'));
          $PAGE->renderPage('tools');
          exit;
      }
  
      // -------- User wants to change his/her password.
-     if ($targetPage == Router::$PAGE_CHANGEPASSWORD)
-     {
+     if ($targetPage == Router::$PAGE_CHANGEPASSWORD) {
          if ($conf->get('security.open_shaarli')) {
              die(t('You are not supposed to change a password on an Open Shaarli.'));
          }
  
-         if (!empty($_POST['setpassword']) && !empty($_POST['oldpassword']))
-         {
-             if (!$sessionManager->checkToken($_POST['token'])) die(t('Wrong token.')); // Go away!
+         if (!empty($_POST['setpassword']) && !empty($_POST['oldpassword'])) {
+             if (!$sessionManager->checkToken($_POST['token'])) {
+                 die(t('Wrong token.')); // Go away!
+             }
  
              // Make sure old password is correct.
-             $oldhash = sha1($_POST['oldpassword'].$conf->get('credentials.login').$conf->get('credentials.salt'));
-             if ($oldhash!= $conf->get('credentials.hash')) {
-                 echo '<script>alert("'. t('The old password is not correct.') .'");document.location=\'?do=changepasswd\';</script>';
+             $oldhash = sha1(
+                 $_POST['oldpassword'].$conf->get('credentials.login').$conf->get('credentials.salt')
+             );
+             if ($oldhash != $conf->get('credentials.hash')) {
+                 echo '<script>alert("'
+                     . t('The old password is not correct.')
+                     .'");document.location=\'?do=changepasswd\';</script>';
                  exit;
              }
              // Save new password
              // Salt renders rainbow-tables attacks useless.
              $conf->set('credentials.salt', sha1(uniqid('', true) .'_'. mt_rand()));
-             $conf->set('credentials.hash', sha1($_POST['setpassword'] . $conf->get('credentials.login') . $conf->get('credentials.salt')));
+             $conf->set(
+                 'credentials.hash',
+                 sha1(
+                     $_POST['setpassword']
+                     . $conf->get('credentials.login')
+                     . $conf->get('credentials.salt')
+                 )
+             );
              try {
-                 $conf->write(isLoggedIn());
-             }
-             catch(Exception $e) {
+                 $conf->write($loginManager->isLoggedIn());
+             } catch (Exception $e) {
                  error_log(
                      'ERROR while writing config file after changing password.' . PHP_EOL .
                      $e->getMessage()
              }
              echo '<script>alert("'. t('Your password has been changed') .'");document.location=\'?do=tools\';</script>';
              exit;
-         }
-         else // show the change password form.
-         {
+         } else {
+             // show the change password form.
+             $PAGE->assign('pagetitle', t('Change password') .' - '. $conf->get('general.title', 'Shaarli'));
              $PAGE->renderPage('changepassword');
              exit;
          }
      }
  
      // -------- User wants to change configuration
-     if ($targetPage == Router::$PAGE_CONFIGURE)
-     {
-         if (!empty($_POST['title']) )
-         {
+     if ($targetPage == Router::$PAGE_CONFIGURE) {
+         if (!empty($_POST['title'])) {
              if (!$sessionManager->checkToken($_POST['token'])) {
                  die(t('Wrong token.')); // Go away!
              }
              $conf->set('general.title', escape($_POST['title']));
              $conf->set('general.header_link', escape($_POST['titleLink']));
              $conf->set('resource.theme', escape($_POST['theme']));
-             $conf->set('redirector.url', escape($_POST['redirector']));
              $conf->set('security.session_protection_disabled', !empty($_POST['disablesessionprotection']));
              $conf->set('privacy.default_private_links', !empty($_POST['privateLinkByDefault']));
              $conf->set('feed.rss_permalinks', !empty($_POST['enableRssPermalinks']));
              $conf->set('api.secret', escape($_POST['apiSecret']));
              $conf->set('translation.language', escape($_POST['language']));
  
+             $thumbnailsMode = extension_loaded('gd') ? $_POST['enableThumbnails'] : Thumbnailer::MODE_NONE;
+             if ($thumbnailsMode !== Thumbnailer::MODE_NONE
+                 && $thumbnailsMode !== $conf->get('thumbnails.mode', Thumbnailer::MODE_NONE)
+             ) {
+                 $_SESSION['warnings'][] = t(
+                     'You have enabled or changed thumbnails mode. '
+                     .'<a href="?do=thumbs_update">Please synchronize them</a>.'
+                 );
+             }
+             $conf->set('thumbnails.mode', $thumbnailsMode);
              try {
-                 $conf->write(isLoggedIn());
+                 $conf->write($loginManager->isLoggedIn());
                  $history->updateSettings();
                  invalidateCaches($conf->get('resource.page_cache'));
-             }
-             catch(Exception $e) {
+             } catch (Exception $e) {
                  error_log(
                      'ERROR while writing config file after configuration update.' . PHP_EOL .
                      $e->getMessage()
              }
              echo '<script>alert("'. t('Configuration was saved.') .'");document.location=\'?do=configure\';</script>';
              exit;
-         }
-         else // Show the configuration form.
-         {
+         } else {
+             // Show the configuration form.
              $PAGE->assign('title', $conf->get('general.title'));
              $PAGE->assign('theme', $conf->get('resource.theme'));
              $PAGE->assign('theme_available', ThemeUtils::getThemes($conf->get('resource.raintpl_tpl')));
-             $PAGE->assign('redirector', $conf->get('redirector.url'));
              list($continents, $cities) = generateTimeZoneData(
                  timezone_identifiers_list(),
                  $conf->get('general.timezone')
              $PAGE->assign('api_secret', $conf->get('api.secret'));
              $PAGE->assign('languages', Languages::getAvailableLanguages());
              $PAGE->assign('language', $conf->get('translation.language'));
+             $PAGE->assign('gd_enabled', extension_loaded('gd'));
+             $PAGE->assign('thumbnails_mode', $conf->get('thumbnails.mode', Thumbnailer::MODE_NONE));
+             $PAGE->assign('pagetitle', t('Configure') .' - '. $conf->get('general.title', 'Shaarli'));
              $PAGE->renderPage('configure');
              exit;
          }
      }
  
      // -------- User wants to rename a tag or delete it
-     if ($targetPage == Router::$PAGE_CHANGETAG)
-     {
+     if ($targetPage == Router::$PAGE_CHANGETAG) {
          if (empty($_POST['fromtag']) || (empty($_POST['totag']) && isset($_POST['renametag']))) {
              $PAGE->assign('fromtag', ! empty($_GET['fromtag']) ? escape($_GET['fromtag']) : '');
+             $PAGE->assign('pagetitle', t('Manage tags') .' - '. $conf->get('general.title', 'Shaarli'));
              $PAGE->renderPage('changetag');
              exit;
          }
              die(t('Wrong token.'));
          }
  
-         $alteredLinks = $LINKSDB->renameTag(escape($_POST['fromtag']), escape($_POST['totag']));
+         $toTag = isset($_POST['totag']) ? escape($_POST['totag']) : null;
+         $alteredLinks = $LINKSDB->renameTag(escape($_POST['fromtag']), $toTag);
          $LINKSDB->save($conf->get('resource.page_cache'));
          foreach ($alteredLinks as $link) {
              $history->updateLink($link);
      }
  
      // -------- User wants to add a link without using the bookmarklet: Show form.
-     if ($targetPage == Router::$PAGE_ADDLINK)
-     {
+     if ($targetPage == Router::$PAGE_ADDLINK) {
+         $PAGE->assign('pagetitle', t('Shaare a new link') .' - '. $conf->get('general.title', 'Shaarli'));
          $PAGE->renderPage('addlink');
          exit;
      }
  
      // -------- User clicked the "Save" button when editing a link: Save link to database.
-     if (isset($_POST['save_edit']))
-     {
+     if (isset($_POST['save_edit'])) {
          // Go away!
          if (! $sessionManager->checkToken($_POST['token'])) {
              die(t('Wrong token.'));
          // Linkdate is kept here to:
          //   - use the same permalink for notes as they're displayed when creating them
          //   - let users hack creation date of their posts
-         //     See: https://shaarli.readthedocs.io/en/master/Various-hacks/#changing-the-timestamp-for-a-shaare
+         //     See: https://shaarli.readthedocs.io/en/master/guides/various-hacks/#changing-the-timestamp-for-a-shaare
          $linkdate = escape($_POST['lf_linkdate']);
          if (isset($LINKSDB[$id])) {
              // Edit
              $link['title'] = $link['url'];
          }
  
+         if ($conf->get('thumbnails.mode', Thumbnailer::MODE_NONE) !== Thumbnailer::MODE_NONE) {
+             $thumbnailer = new Thumbnailer($conf);
+             $link['thumbnail'] = $thumbnailer->get($url);
+         }
+         $link['sticky'] = isset($link['sticky']) ? $link['sticky'] : false;
          $pluginManager->executeHooks('save_link', $link);
  
          $LINKSDB[$id] = $link;
      }
  
      // -------- User clicked the "Cancel" button when editing a link.
-     if (isset($_POST['cancel_edit']))
-     {
+     if (isset($_POST['cancel_edit'])) {
          $id = isset($_POST['lf_id']) ? (int) escape($_POST['lf_id']) : false;
          if (! isset($LINKSDB[$id])) {
              header('Location: ?');
          }
          // If we are called from the bookmarklet, we must close the popup:
-         if (isset($_GET['source']) && ($_GET['source']=='bookmarklet' || $_GET['source']=='firefoxsocialapi')) { echo '<script>self.close();</script>'; exit; }
+         if (isset($_GET['source']) && ($_GET['source']=='bookmarklet' || $_GET['source']=='firefoxsocialapi')) {
+             echo '<script>self.close();</script>';
+             exit;
+         }
          $link = $LINKSDB[$id];
          $returnurl = ( isset($_POST['returnurl']) ? $_POST['returnurl'] : '?' );
          // Scroll to the link which has been edited.
      }
  
      // -------- User clicked the "Delete" button when editing a link: Delete link from database.
-     if ($targetPage == Router::$PAGE_DELETELINK)
-     {
+     if ($targetPage == Router::$PAGE_DELETELINK) {
          if (! $sessionManager->checkToken($_GET['token'])) {
              die(t('Wrong token.'));
          }
              $ids = [$ids];
          }
          // assert at least one id is given
-         if(!count($ids)){
+         if (!count($ids)) {
              die('no id provided');
          }
          foreach ($ids as $id) {
              $id = (int) escape($id);
              $link = $LINKSDB[$id];
              $pluginManager->executeHooks('delete_link', $link);
+             $history->deleteLink($link);
              unset($LINKSDB[$id]);
          }
          $LINKSDB->save($conf->get('resource.page_cache')); // save to disk
-         $history->deleteLink($link);
  
          // If we are called from the bookmarklet, we must close the popup:
-         if (isset($_GET['source']) && ($_GET['source']=='bookmarklet' || $_GET['source']=='firefoxsocialapi')) { echo '<script>self.close();</script>'; exit; }
+         if (isset($_GET['source']) && ($_GET['source']=='bookmarklet' || $_GET['source']=='firefoxsocialapi')) {
+             echo '<script>self.close();</script>';
+             exit;
+         }
  
          $location = '?';
          if (isset($_SERVER['HTTP_REFERER'])) {
              // Don't redirect to where we were previously if it was a permalink or an edit_link, because it would 404.
              $location = generateLocation(
-                     $_SERVER['HTTP_REFERER'],
-                     $_SERVER['HTTP_HOST'],
-                     ['delete_link', 'edit_link', $link['shorturl']]
+                 $_SERVER['HTTP_REFERER'],
+                 $_SERVER['HTTP_HOST'],
+                 ['delete_link', 'edit_link', $link['shorturl']]
              );
          }
  
      }
  
      // -------- User clicked the "EDIT" button on a link: Display link edit form.
-     if (isset($_GET['edit_link']))
-     {
+     if (isset($_GET['edit_link'])) {
          $id = (int) escape($_GET['edit_link']);
          $link = $LINKSDB[$id];  // Read database
-         if (!$link) { header('Location: ?'); exit; } // Link not found in database.
+         if (!$link) {
+             header('Location: ?');
+             exit;
+         } // Link not found in database.
          $link['linkdate'] = $link['created']->format(LinkDB::LINK_DATE_FORMAT);
          $data = array(
              'link' => $link,
              $PAGE->assign($key, $value);
          }
  
+         $PAGE->assign('pagetitle', t('Edit') .' '. t('Shaare') .' - '. $conf->get('general.title', 'Shaarli'));
          $PAGE->renderPage('editlink');
          exit;
      }
          $link_is_new = false;
          // Check if URL is not already in database (in this case, we will edit the existing link)
          $link = $LINKSDB->getLinkFromUrl($url);
-         if (! $link)
-         {
+         if (! $link) {
              $link_is_new = true;
              $linkdate = strval(date(LinkDB::LINK_DATE_FORMAT));
              // Get title if it was provided in URL (by the bookmarklet).
              $description = empty($_GET['description']) ? '' : escape($_GET['description']);
              $tags = empty($_GET['tags']) ? '' : escape($_GET['tags']);
              $private = !empty($_GET['private']) && $_GET['private'] === "1" ? 1 : 0;
-             // If this is an HTTP(S) link, we try go get the page to extract the title (otherwise we will to straight to the edit form.)
+             // If this is an HTTP(S) link, we try go get the page to extract
+             // the title (otherwise we will to straight to the edit form.)
              if (empty($title) && strpos(get_url_scheme($url), 'http') !== false) {
                  // Short timeout to keep the application responsive
                  // The callback will fill $charset and $title with data from the downloaded page.
-                 get_http_response($url, 25, 4194304, get_curl_download_callback($charset, $title));
+                 get_http_response(
+                     $url,
+                     $conf->get('general.download_timeout', 30),
+                     $conf->get('general.download_max_size', 4194304),
+                     get_curl_download_callback($charset, $title)
+                 );
                  if (! empty($title) && strtolower($charset) != 'utf-8') {
                      $title = mb_convert_encoding($title, 'utf-8', $charset);
                  }
              $PAGE->assign($key, $value);
          }
  
+         $PAGE->assign('pagetitle', t('Shaare') .' - '. $conf->get('general.title', 'Shaarli'));
          $PAGE->renderPage('editlink');
          exit;
      }
  
+     if ($targetPage == Router::$PAGE_PINLINK) {
+         if (! isset($_GET['id']) || empty($LINKSDB[$_GET['id']])) {
+             // FIXME! Use a proper error system.
+             $msg = t('Invalid link ID provided');
+             echo '<script>alert("'. $msg .'");document.location=\''. index_url($_SERVER) .'\';</script>';
+             exit;
+         }
+         if (! $sessionManager->checkToken($_GET['token'])) {
+             die('Wrong token.');
+         }
+         $link = $LINKSDB[$_GET['id']];
+         $link['sticky'] = ! $link['sticky'];
+         $LINKSDB[(int) $_GET['id']] = $link;
+         $LINKSDB->save($conf->get('resource.page_cache'));
+         header('Location: '.index_url($_SERVER));
+         exit;
+     }
      if ($targetPage == Router::$PAGE_EXPORT) {
          // Export links as a Netscape Bookmarks file
  
          if (empty($_GET['selection'])) {
+             $PAGE->assign('pagetitle', t('Export') .' - '. $conf->get('general.title', 'Shaarli'));
              $PAGE->renderPage('export');
              exit;
          }
          header('Content-Type: text/html; charset=utf-8');
          header(
              'Content-disposition: attachment; filename=bookmarks_'
-            .$selection.'_'.$now->format(LinkDB::LINK_DATE_FORMAT).'.html'
+             .$selection.'_'.$now->format(LinkDB::LINK_DATE_FORMAT).'.html'
          );
          $PAGE->assign('date', $now->format(DateTime::RFC822));
          $PAGE->assign('eol', PHP_EOL);
                      true
                  )
              );
+             $PAGE->assign('pagetitle', t('Import') .' - '. $conf->get('general.title', 'Shaarli'));
              $PAGE->renderPage('import');
              exit;
          }
          $pluginMeta = $pluginManager->getPluginsMeta();
  
          // Split plugins into 2 arrays: ordered enabled plugins and disabled.
-         $enabledPlugins = array_filter($pluginMeta, function($v) { return $v['order'] !== false; });
+         $enabledPlugins = array_filter($pluginMeta, function ($v) {
+             return $v['order'] !== false;
+         });
          // Load parameters.
          $enabledPlugins = load_plugin_parameter_values($enabledPlugins, $conf->get('plugins', array()));
          uasort(
              $enabledPlugins,
-             function($a, $b) { return $a['order'] - $b['order']; }
+             function ($a, $b) {
+                 return $a['order'] - $b['order'];
+             }
          );
-         $disabledPlugins = array_filter($pluginMeta, function($v) { return $v['order'] === false; });
+         $disabledPlugins = array_filter($pluginMeta, function ($v) {
+             return $v['order'] === false;
+         });
  
          $PAGE->assign('enabledPlugins', $enabledPlugins);
          $PAGE->assign('disabledPlugins', $disabledPlugins);
+         $PAGE->assign('pagetitle', t('Plugin administration') .' - '. $conf->get('general.title', 'Shaarli'));
          $PAGE->renderPage('pluginsadmin');
          exit;
      }
                  foreach ($_POST as $param => $value) {
                      $conf->set('plugins.'. $param, escape($value));
                  }
-             }
-             else {
+             } else {
                  $conf->set('general.enabled_plugins', save_plugin_config($_POST));
              }
-             $conf->write(isLoggedIn());
+             $conf->write($loginManager->isLoggedIn());
              $history->updateSettings();
-         }
-         catch (Exception $e) {
+         } catch (Exception $e) {
              error_log(
                  'ERROR while saving plugin configuration:.' . PHP_EOL .
                  $e->getMessage()
              );
  
              // TODO: do not handle exceptions/errors in JS.
-             echo '<script>alert("'. $e->getMessage() .'");document.location=\'?do='. Router::$PAGE_PLUGINSADMIN .'\';</script>';
+             echo '<script>alert("'
+                 . $e->getMessage()
+                 .'");document.location=\'?do='
+                 . Router::$PAGE_PLUGINSADMIN
+                 .'\';</script>';
              exit;
          }
          header('Location: ?do='. Router::$PAGE_PLUGINSADMIN);
          exit;
      }
  
+     // -------- Thumbnails Update
+     if ($targetPage == Router::$PAGE_THUMBS_UPDATE) {
+         $ids = [];
+         foreach ($LINKSDB as $link) {
+             // A note or not HTTP(S)
+             if ($link['url'][0] === '?' || ! startsWith(strtolower($link['url']), 'http')) {
+                 continue;
+             }
+             $ids[] = $link['id'];
+         }
+         $PAGE->assign('ids', $ids);
+         $PAGE->assign('pagetitle', t('Thumbnails update') .' - '. $conf->get('general.title', 'Shaarli'));
+         $PAGE->renderPage('thumbnails');
+         exit;
+     }
+     // -------- Single Thumbnail Update
+     if ($targetPage == Router::$AJAX_THUMB_UPDATE) {
+         if (! isset($_POST['id']) || ! ctype_digit($_POST['id'])) {
+             http_response_code(400);
+             exit;
+         }
+         $id = (int) $_POST['id'];
+         if (empty($LINKSDB[$id])) {
+             http_response_code(404);
+             exit;
+         }
+         $thumbnailer = new Thumbnailer($conf);
+         $link = $LINKSDB[$id];
+         $link['thumbnail'] = $thumbnailer->get($link['url']);
+         $LINKSDB[$id] = $link;
+         $LINKSDB->save($conf->get('resource.page_cache'));
+         echo json_encode($link);
+         exit;
+     }
      // -------- Otherwise, simply display search form and links:
-     showLinkList($PAGE, $LINKSDB, $conf, $pluginManager);
+     showLinkList($PAGE, $LINKSDB, $conf, $pluginManager, $loginManager);
      exit;
  }
  
   * @param LinkDB        $LINKSDB       LinkDB instance.
   * @param ConfigManager $conf          Configuration Manager instance.
   * @param PluginManager $pluginManager Plugin Manager instance.
+  * @param LoginManager  $loginManager  LoginManager instance
   */
- function buildLinkList($PAGE,$LINKSDB, $conf, $pluginManager)
+ function buildLinkList($PAGE, $LINKSDB, $conf, $pluginManager, $loginManager)
  {
      // Used in templates
      if (isset($_GET['searchtags'])) {
          }
      } else {
          // Filter links according search parameters.
-         $visibility = ! empty($_SESSION['privateonly']) ? 'private' : 'all';
+         $visibility = ! empty($_SESSION['visibility']) ? $_SESSION['visibility'] : '';
          $request = [
              'searchtags' => $searchtags,
              'searchterm' => $searchterm,
          $keys[] = $key;
      }
  
      // Select articles according to paging.
      $pagecount = ceil(count($keys) / $_SESSION['LINKS_PER_PAGE']);
      $pagecount = $pagecount == 0 ? 1 : $pagecount;
      // Start index.
      $i = ($page-1) * $_SESSION['LINKS_PER_PAGE'];
      $end = $i + $_SESSION['LINKS_PER_PAGE'];
+     $thumbnailsEnabled = $conf->get('thumbnails.mode', Thumbnailer::MODE_NONE) !== Thumbnailer::MODE_NONE;
+     if ($thumbnailsEnabled) {
+         $thumbnailer = new Thumbnailer($conf);
+     }
      $linkDisp = array();
-     while ($i<$end && $i<count($keys))
-     {
+     while ($i<$end && $i<count($keys)) {
          $link = $linksToDisplay[$keys[$i]];
          $link['description'] = format_description(
              $link['description'],
          $taglist = preg_split('/\s+/', $link['tags'], -1, PREG_SPLIT_NO_EMPTY);
          uasort($taglist, 'strcasecmp');
          $link['taglist'] = $taglist;
+         // Logged in, thumbnails enabled, not a note,
+         // and (never retrieved yet or no valid cache file)
+         if ($loginManager->isLoggedIn() && $thumbnailsEnabled && $link['url'][0] != '?'
+             && (! isset($link['thumbnail']) || ($link['thumbnail'] !== false && ! is_file($link['thumbnail'])))
+         ) {
+             $elem = $LINKSDB[$keys[$i]];
+             $elem['thumbnail'] = $thumbnailer->get($link['url']);
+             $LINKSDB[$keys[$i]] = $elem;
+             $updateDB = true;
+             $link['thumbnail'] = $elem['thumbnail'];
+         }
          // Check for both signs of a note: starting with ? and 7 chars long.
-         if ($link['url'][0] === '?' &&
-             strlen($link['url']) === 7) {
+         if ($link['url'][0] === '?' && strlen($link['url']) === 7) {
              $link['url'] = index_url($_SERVER) . $link['url'];
          }
  
          $i++;
      }
  
+     // If we retrieved new thumbnails, we update the database.
+     if (!empty($updateDB)) {
+         $LINKSDB->save($conf->get('resource.page_cache'));
+     }
      // Compute paging navigation
      $searchtagsUrl = $searchtags === '' ? '' : '&searchtags=' . urlencode($searchtags);
      $searchtermUrl = empty($searchterm) ? '' : '&searchterm=' . urlencode($searchterm);
          'result_count' => count($linksToDisplay),
          'search_term' => $searchterm,
          'search_tags' => $searchtags,
-         'visibility' => ! empty($_SESSION['privateonly']) ? 'private' : '',
+         'visibility' => ! empty($_SESSION['visibility']) ? $_SESSION['visibility'] : '',
          'redirector' => $conf->get('redirector.url'),  // Optional redirector URL.
          'links' => $linkDisp,
      );
      // If there is only a single link, we change on-the-fly the title of the page.
      if (count($linksToDisplay) == 1) {
          $data['pagetitle'] = $linksToDisplay[$keys[0]]['title'] .' - '. $conf->get('general.title');
+     } elseif (! empty($searchterm) || ! empty($searchtags)) {
+         $data['pagetitle'] = t('Search: ');
+         $data['pagetitle'] .= ! empty($searchterm) ? $searchterm .' ' : '';
+         $bracketWrap = function ($tag) {
+             return '['. $tag .']';
+         };
+         $data['pagetitle'] .= ! empty($searchtags)
+             ? implode(' ', array_map($bracketWrap, preg_split('/\s+/', $searchtags))).' '
+             : '';
+         $data['pagetitle'] .= '- '. $conf->get('general.title');
      }
  
-     $pluginManager->executeHooks('render_linklist', $data, array('loggedin' => isLoggedIn()));
+     $pluginManager->executeHooks('render_linklist', $data, array('loggedin' => $loginManager->isLoggedIn()));
  
      foreach ($data as $key => $value) {
          $PAGE->assign($key, $value);
      return;
  }
  
- /**
-  * Compute the thumbnail for a link.
-  *
-  * With a link to the original URL.
-  * Understands various services (youtube.com...)
-  * Input: $url = URL for which the thumbnail must be found.
-  *        $href = if provided, this URL will be followed instead of $url
-  * Returns an associative array with thumbnail attributes (src,href,width,height,style,alt)
-  * Some of them may be missing.
-  * Return an empty array if no thumbnail available.
-  *
-  * @param ConfigManager $conf Configuration Manager instance.
-  * @param string        $url
-  * @param string|bool   $href
-  *
-  * @return array
-  */
- function computeThumbnail($conf, $url, $href = false)
- {
-     if (!$conf->get('thumbnail.enable_thumbnails')) return array();
-     if ($href==false) $href=$url;
-     // For most hosts, the URL of the thumbnail can be easily deduced from the URL of the link.
-     // (e.g. http://www.youtube.com/watch?v=spVypYk4kto --->  http://img.youtube.com/vi/spVypYk4kto/default.jpg )
-     //                                     ^^^^^^^^^^^                                 ^^^^^^^^^^^
-     $domain = parse_url($url,PHP_URL_HOST);
-     if ($domain=='youtube.com' || $domain=='www.youtube.com')
-     {
-         parse_str(parse_url($url,PHP_URL_QUERY), $params); // Extract video ID and get thumbnail
-         if (!empty($params['v'])) return array('src'=>'https://img.youtube.com/vi/'.$params['v'].'/default.jpg',
-                                                'href'=>$href,'width'=>'120','height'=>'90','alt'=>'YouTube thumbnail');
-     }
-     if ($domain=='youtu.be') // Youtube short links
-     {
-         $path = parse_url($url,PHP_URL_PATH);
-         return array('src'=>'https://img.youtube.com/vi'.$path.'/default.jpg',
-                      'href'=>$href,'width'=>'120','height'=>'90','alt'=>'YouTube thumbnail');
-     }
-     if ($domain=='pix.toile-libre.org') // pix.toile-libre.org image hosting
-     {
-         parse_str(parse_url($url,PHP_URL_QUERY), $params); // Extract image filename.
-         if (!empty($params) && !empty($params['img'])) return array('src'=>'http://pix.toile-libre.org/upload/thumb/'.urlencode($params['img']),
-                                                                     'href'=>$href,'style'=>'max-width:120px; max-height:150px','alt'=>'pix.toile-libre.org thumbnail');
-     }
-     if ($domain=='imgur.com')
-     {
-         $path = parse_url($url,PHP_URL_PATH);
-         if (startsWith($path,'/a/')) return array(); // Thumbnails for albums are not available.
-         if (startsWith($path,'/r/')) return array('src'=>'https://i.imgur.com/'.basename($path).'s.jpg',
-                                                   'href'=>$href,'width'=>'90','height'=>'90','alt'=>'imgur.com thumbnail');
-         if (startsWith($path,'/gallery/')) return array('src'=>'https://i.imgur.com'.substr($path,8).'s.jpg',
-                                                         'href'=>$href,'width'=>'90','height'=>'90','alt'=>'imgur.com thumbnail');
-         if (substr_count($path,'/')==1) return array('src'=>'https://i.imgur.com/'.substr($path,1).'s.jpg',
-                                                      'href'=>$href,'width'=>'90','height'=>'90','alt'=>'imgur.com thumbnail');
-     }
-     if ($domain=='i.imgur.com')
-     {
-         $pi = pathinfo(parse_url($url,PHP_URL_PATH));
-         if (!empty($pi['filename'])) return array('src'=>'https://i.imgur.com/'.$pi['filename'].'s.jpg',
-                                                   'href'=>$href,'width'=>'90','height'=>'90','alt'=>'imgur.com thumbnail');
-     }
-     if ($domain=='dailymotion.com' || $domain=='www.dailymotion.com')
-     {
-         if (strpos($url,'dailymotion.com/video/')!==false)
-         {
-             $thumburl=str_replace('dailymotion.com/video/','dailymotion.com/thumbnail/video/',$url);
-             return array('src'=>$thumburl,
-                          'href'=>$href,'width'=>'120','style'=>'height:auto;','alt'=>'DailyMotion thumbnail');
-         }
-     }
-     if (endsWith($domain,'.imageshack.us'))
-     {
-         $ext=strtolower(pathinfo($url,PATHINFO_EXTENSION));
-         if ($ext=='jpg' || $ext=='jpeg' || $ext=='png' || $ext=='gif')
-         {
-             $thumburl = substr($url,0,strlen($url)-strlen($ext)).'th.'.$ext;
-             return array('src'=>$thumburl,
-                          'href'=>$href,'width'=>'120','style'=>'height:auto;','alt'=>'imageshack.us thumbnail');
-         }
-     }
-     // Some other hosts are SLOW AS HELL and usually require an extra HTTP request to get the thumbnail URL.
-     // So we deport the thumbnail generation in order not to slow down page generation
-     // (and we also cache the thumbnail)
-     if (! $conf->get('thumbnail.enable_localcache')) return array(); // If local cache is disabled, no thumbnails for services which require the use a local cache.
-     if ($domain=='flickr.com' || endsWith($domain,'.flickr.com')
-         || $domain=='vimeo.com'
-         || $domain=='ted.com' || endsWith($domain,'.ted.com')
-         || $domain=='xkcd.com' || endsWith($domain,'.xkcd.com')
-     )
-     {
-         if ($domain=='vimeo.com')
-         {   // Make sure this vimeo URL points to a video (/xxx... where xxx is numeric)
-             $path = parse_url($url,PHP_URL_PATH);
-             if (!preg_match('!/\d+.+?!',$path)) return array(); // This is not a single video URL.
-         }
-         if ($domain=='xkcd.com' || endsWith($domain,'.xkcd.com'))
-         {   // Make sure this URL points to a single comic (/xxx... where xxx is numeric)
-             $path = parse_url($url,PHP_URL_PATH);
-             if (!preg_match('!/\d+.+?!',$path)) return array();
-         }
-         if ($domain=='ted.com' || endsWith($domain,'.ted.com'))
-         {   // Make sure this TED URL points to a video (/talks/...)
-             $path = parse_url($url,PHP_URL_PATH);
-             if ("/talks/" !== substr($path,0,7)) return array(); // This is not a single video URL.
-         }
-         $sign = hash_hmac('sha256', $url, $conf->get('credentials.salt')); // We use the salt to sign data (it's random, secret, and specific to each installation)
-         return array('src'=>index_url($_SERVER).'?do=genthumbnail&hmac='.$sign.'&url='.urlencode($url),
-                      'href'=>$href,'width'=>'120','style'=>'height:auto;','alt'=>'thumbnail');
-     }
-     // For all other, we try to make a thumbnail of links ending with .jpg/jpeg/png/gif
-     // Technically speaking, we should download ALL links and check their Content-Type to see if they are images.
-     // But using the extension will do.
-     $ext=strtolower(pathinfo($url,PATHINFO_EXTENSION));
-     if ($ext=='jpg' || $ext=='jpeg' || $ext=='png' || $ext=='gif')
-     {
-         $sign = hash_hmac('sha256', $url, $conf->get('credentials.salt')); // We use the salt to sign data (it's random, secret, and specific to each installation)
-         return array('src'=>index_url($_SERVER).'?do=genthumbnail&hmac='.$sign.'&url='.urlencode($url),
-                      'href'=>$href,'width'=>'120','style'=>'height:auto;','alt'=>'thumbnail');
-     }
-     return array(); // No thumbnail.
- }
- // Returns the HTML code to display a thumbnail for a link
- // with a link to the original URL.
- // Understands various services (youtube.com...)
- // Input: $url = URL for which the thumbnail must be found.
- //        $href = if provided, this URL will be followed instead of $url
- // Returns '' if no thumbnail available.
- function thumbnail($url,$href=false)
- {
-     // FIXME!
-     global $conf;
-     $t = computeThumbnail($conf, $url,$href);
-     if (count($t)==0) return ''; // Empty array = no thumbnail for this URL.
-     $html='<a href="'.escape($t['href']).'"><img src="'.escape($t['src']).'"';
-     if (!empty($t['width']))  $html.=' width="'.escape($t['width']).'"';
-     if (!empty($t['height'])) $html.=' height="'.escape($t['height']).'"';
-     if (!empty($t['style']))  $html.=' style="'.escape($t['style']).'"';
-     if (!empty($t['alt']))    $html.=' alt="'.escape($t['alt']).'"';
-     $html.='></a>';
-     return $html;
- }
- // Returns the HTML code to display a thumbnail for a link
- // for the picture wall (using lazy image loading)
- // Understands various services (youtube.com...)
- // Input: $url = URL for which the thumbnail must be found.
- //        $href = if provided, this URL will be followed instead of $url
- // Returns '' if no thumbnail available.
- function lazyThumbnail($conf, $url,$href=false)
- {
-     // FIXME!
-     global $conf;
-     $t = computeThumbnail($conf, $url,$href);
-     if (count($t)==0) return ''; // Empty array = no thumbnail for this URL.
-     $html='<a href="'.escape($t['href']).'">';
-     // Lazy image
-     $html.='<img class="b-lazy" src="#" data-src="'.escape($t['src']).'"';
-     if (!empty($t['width']))  $html.=' width="'.escape($t['width']).'"';
-     if (!empty($t['height'])) $html.=' height="'.escape($t['height']).'"';
-     if (!empty($t['style']))  $html.=' style="'.escape($t['style']).'"';
-     if (!empty($t['alt']))    $html.=' alt="'.escape($t['alt']).'"';
-     $html.='>';
-     // No-JavaScript fallback.
-     $html.='<noscript><img src="'.escape($t['src']).'"';
-     if (!empty($t['width']))  $html.=' width="'.escape($t['width']).'"';
-     if (!empty($t['height'])) $html.=' height="'.escape($t['height']).'"';
-     if (!empty($t['style']))  $html.=' style="'.escape($t['style']).'"';
-     if (!empty($t['alt']))    $html.=' alt="'.escape($t['alt']).'"';
-     $html.='></noscript></a>';
-     return $html;
- }
  /**
   * Installation
   * This function should NEVER be called if the file data/config.php exists.
   *
   * @param ConfigManager  $conf           Configuration Manager instance.
   * @param SessionManager $sessionManager SessionManager instance
+  * @param LoginManager   $loginManager   LoginManager instance
   */
- function install($conf, $sessionManager) {
+ function install($conf, $sessionManager, $loginManager)
+ {
      // On free.fr host, make sure the /sessions directory exists, otherwise login will not work.
-     if (endsWith($_SERVER['HTTP_HOST'],'.free.fr') && !is_dir($_SERVER['DOCUMENT_ROOT'].'/sessions')) mkdir($_SERVER['DOCUMENT_ROOT'].'/sessions',0705);
+     if (endsWith($_SERVER['HTTP_HOST'], '.free.fr') && !is_dir($_SERVER['DOCUMENT_ROOT'].'/sessions')) {
+         mkdir($_SERVER['DOCUMENT_ROOT'].'/sessions', 0705);
+     }
  
  
      // This part makes sure sessions works correctly.
      // (Because on some hosts, session.save_path may not be set correctly,
      // or we may not have write access to it.)
-     if (isset($_GET['test_session']) && ( !isset($_SESSION) || !isset($_SESSION['session_tested']) || $_SESSION['session_tested']!='Working'))
-     {
+     if (isset($_GET['test_session'])
+         && ( !isset($_SESSION) || !isset($_SESSION['session_tested']) || $_SESSION['session_tested']!='Working')) {
          // Step 2: Check if data in session is correct.
          $msg = t(
              '<pre>Sessions do not seem to work correctly on your server.<br>'.
          echo '<br><a href="?">'. t('Click to try again.') .'</a></pre>';
          die;
      }
-     if (!isset($_SESSION['session_tested']))
-     {   // Step 1 : Try to store data in session and reload page.
+     if (!isset($_SESSION['session_tested'])) {
+         // Step 1 : Try to store data in session and reload page.
          $_SESSION['session_tested'] = 'Working';  // Try to set a variable in session.
          header('Location: '.index_url($_SERVER).'?test_session');  // Redirect to check stored data.
      }
-     if (isset($_GET['test_session']))
-     {   // Step 3: Sessions are OK. Remove test parameter from URL.
+     if (isset($_GET['test_session'])) {
+         // Step 3: Sessions are OK. Remove test parameter from URL.
          header('Location: '.index_url($_SERVER));
      }
  
  
-     if (!empty($_POST['setlogin']) && !empty($_POST['setpassword']))
-     {
+     if (!empty($_POST['setlogin']) && !empty($_POST['setpassword'])) {
          $tz = 'UTC';
          if (!empty($_POST['continent']) && !empty($_POST['city'])
              && isTimeZoneValid($_POST['continent'], $_POST['city'])
          );
          try {
              // Everything is ok, let's create config file.
-             $conf->write(isLoggedIn());
-         }
-         catch(Exception $e) {
+             $conf->write($loginManager->isLoggedIn());
+         } catch (Exception $e) {
              error_log(
-                     'ERROR while writing config file after installation.' . PHP_EOL .
+                 'ERROR while writing config file after installation.' . PHP_EOL .
                      $e->getMessage()
-                 );
+             );
  
              // TODO: do not handle exceptions/errors in JS.
              echo '<script>alert("'. $e->getMessage() .'");document.location=\'?\';</script>';
              exit;
          }
-         echo '<script>alert("Shaarli is now configured. Please enter your login/password and start shaaring your links!");document.location=\'?do=login\';</script>';
+         echo '<script>alert('
+             .'"Shaarli is now configured. '
+             .'Please enter your login/password and start shaaring your links!"'
+             .');document.location=\'?do=login\';</script>';
          exit;
      }
  
-     $PAGE = new PageBuilder($conf, null, $sessionManager->generateToken());
+     $PAGE = new PageBuilder($conf, $_SESSION, null, $sessionManager->generateToken());
      list($continents, $cities) = generateTimeZoneData(timezone_identifiers_list(), date_default_timezone_get());
      $PAGE->assign('continents', $continents);
      $PAGE->assign('cities', $cities);
      exit;
  }
  
- /**
-  * Because some f*cking services like flickr require an extra HTTP request to get the thumbnail URL,
-  * I have deported the thumbnail URL code generation here, otherwise this would slow down page generation.
-  * The following function takes the URL a link (e.g. a flickr page) and return the proper thumbnail.
-  * This function is called by passing the URL:
-  * http://mywebsite.com/shaarli/?do=genthumbnail&hmac=[HMAC]&url=[URL]
-  * [URL] is the URL of the link (e.g. a flickr page)
-  * [HMAC] is the signature for the [URL] (so that these URL cannot be forged).
-  * The function below will fetch the image from the webservice and store it in the cache.
-  *
-  * @param ConfigManager $conf Configuration Manager instance,
-  */
- function genThumbnail($conf)
- {
-     // Make sure the parameters in the URL were generated by us.
-     $sign = hash_hmac('sha256', $_GET['url'], $conf->get('credentials.salt'));
-     if ($sign!=$_GET['hmac']) die('Naughty boy!');
-     $cacheDir = $conf->get('resource.thumbnails_cache', 'cache');
-     // Let's see if we don't already have the image for this URL in the cache.
-     $thumbname=hash('sha1',$_GET['url']).'.jpg';
-     if (is_file($cacheDir .'/'. $thumbname))
-     {   // We have the thumbnail, just serve it:
-         header('Content-Type: image/jpeg');
-         echo file_get_contents($cacheDir .'/'. $thumbname);
-         return;
-     }
-     // We may also serve a blank image (if service did not respond)
-     $blankname=hash('sha1',$_GET['url']).'.gif';
-     if (is_file($cacheDir .'/'. $blankname))
-     {
-         header('Content-Type: image/gif');
-         echo file_get_contents($cacheDir .'/'. $blankname);
-         return;
-     }
-     // Otherwise, generate the thumbnail.
-     $url = $_GET['url'];
-     $domain = parse_url($url,PHP_URL_HOST);
-     if ($domain=='flickr.com' || endsWith($domain,'.flickr.com'))
-     {
-         // Crude replacement to handle new flickr domain policy (They prefer www. now)
-         $url = str_replace('http://flickr.com/','http://www.flickr.com/',$url);
-         // Is this a link to an image, or to a flickr page ?
-         $imageurl='';
-         if (endsWith(parse_url($url, PHP_URL_PATH), '.jpg'))
-         {  // This is a direct link to an image. e.g. http://farm1.staticflickr.com/5/5921913_ac83ed27bd_o.jpg
-             preg_match('!(http://farm\d+\.staticflickr\.com/\d+/\d+_\w+_)\w.jpg!',$url,$matches);
-             if (!empty($matches[1])) $imageurl=$matches[1].'m.jpg';
-         }
-         else // This is a flickr page (html)
-         {
-             // Get the flickr html page.
-             list($headers, $content) = get_http_response($url, 20);
-             if (strpos($headers[0], '200 OK') !== false)
-             {
-                 // flickr now nicely provides the URL of the thumbnail in each flickr page.
-                 preg_match('!<link rel=\"image_src\" href=\"(.+?)\"!', $content, $matches);
-                 if (!empty($matches[1])) $imageurl=$matches[1];
-                 // In albums (and some other pages), the link rel="image_src" is not provided,
-                 // but flickr provides:
-                 // <meta property="og:image" content="http://farm4.staticflickr.com/3398/3239339068_25d13535ff_z.jpg" />
-                 if ($imageurl=='')
-                 {
-                     preg_match('!<meta property=\"og:image\" content=\"(.+?)\"!', $content, $matches);
-                     if (!empty($matches[1])) $imageurl=$matches[1];
-                 }
-             }
-         }
-         if ($imageurl!='')
-         {   // Let's download the image.
-             // Image is 240x120, so 10 seconds to download should be enough.
-             list($headers, $content) = get_http_response($imageurl, 10);
-             if (strpos($headers[0], '200 OK') !== false) {
-                 // Save image to cache.
-                 file_put_contents($cacheDir .'/'. $thumbname, $content);
-                 header('Content-Type: image/jpeg');
-                 echo $content;
-                 return;
-             }
-         }
-     }
-     elseif ($domain=='vimeo.com' )
-     {
-         // This is more complex: we have to perform a HTTP request, then parse the result.
-         // Maybe we should deport this to JavaScript ? Example: http://stackoverflow.com/questions/1361149/get-img-thumbnails-from-vimeo/4285098#4285098
-         $vid = substr(parse_url($url,PHP_URL_PATH),1);
-         list($headers, $content) = get_http_response('https://vimeo.com/api/v2/video/'.escape($vid).'.php', 5);
-         if (strpos($headers[0], '200 OK') !== false) {
-             $t = unserialize($content);
-             $imageurl = $t[0]['thumbnail_medium'];
-             // Then we download the image and serve it to our client.
-             list($headers, $content) = get_http_response($imageurl, 10);
-             if (strpos($headers[0], '200 OK') !== false) {
-                 // Save image to cache.
-                 file_put_contents($cacheDir .'/'. $thumbname, $content);
-                 header('Content-Type: image/jpeg');
-                 echo $content;
-                 return;
-             }
-         }
-     }
-     elseif ($domain=='ted.com' || endsWith($domain,'.ted.com'))
-     {
-         // The thumbnail for TED talks is located in the <link rel="image_src" [...]> tag on that page
-         // http://www.ted.com/talks/mikko_hypponen_fighting_viruses_defending_the_net.html
-         // <link rel="image_src" href="http://images.ted.com/images/ted/28bced335898ba54d4441809c5b1112ffaf36781_389x292.jpg" />
-         list($headers, $content) = get_http_response($url, 5);
-         if (strpos($headers[0], '200 OK') !== false) {
-             // Extract the link to the thumbnail
-             preg_match('!link rel="image_src" href="(http://images.ted.com/images/ted/.+_\d+x\d+\.jpg)"!', $content, $matches);
-             if (!empty($matches[1]))
-             {   // Let's download the image.
-                 $imageurl=$matches[1];
-                 // No control on image size, so wait long enough
-                 list($headers, $content) = get_http_response($imageurl, 20);
-                 if (strpos($headers[0], '200 OK') !== false) {
-                     $filepath = $cacheDir .'/'. $thumbname;
-                     file_put_contents($filepath, $content); // Save image to cache.
-                     if (resizeImage($filepath))
-                     {
-                         header('Content-Type: image/jpeg');
-                         echo file_get_contents($filepath);
-                         return;
-                     }
-                 }
-             }
-         }
-     }
-     elseif ($domain=='xkcd.com' || endsWith($domain,'.xkcd.com'))
-     {
-         // There is no thumbnail available for xkcd comics, so download the whole image and resize it.
-         // http://xkcd.com/327/
-         // <img src="http://imgs.xkcd.com/comics/exploits_of_a_mom.png" title="<BLABLA>" alt="<BLABLA>" />
-         list($headers, $content) = get_http_response($url, 5);
-         if (strpos($headers[0], '200 OK') !== false) {
-             // Extract the link to the thumbnail
-             preg_match('!<img src="(http://imgs.xkcd.com/comics/.*)" title="[^s]!', $content, $matches);
-             if (!empty($matches[1]))
-             {   // Let's download the image.
-                 $imageurl=$matches[1];
-                 // No control on image size, so wait long enough
-                 list($headers, $content) = get_http_response($imageurl, 20);
-                 if (strpos($headers[0], '200 OK') !== false) {
-                     $filepath = $cacheDir.'/'.$thumbname;
-                     // Save image to cache.
-                     file_put_contents($filepath, $content);
-                     if (resizeImage($filepath))
-                     {
-                         header('Content-Type: image/jpeg');
-                         echo file_get_contents($filepath);
-                         return;
-                     }
-                 }
-             }
-         }
-     }
-     else
-     {
-         // For all other domains, we try to download the image and make a thumbnail.
-         // We allow 30 seconds max to download (and downloads are limited to 4 Mb)
-         list($headers, $content) = get_http_response($url, 30);
-         if (strpos($headers[0], '200 OK') !== false) {
-             $filepath = $cacheDir .'/'.$thumbname;
-             // Save image to cache.
-             file_put_contents($filepath, $content);
-             if (resizeImage($filepath))
-             {
-                 header('Content-Type: image/jpeg');
-                 echo file_get_contents($filepath);
-                 return;
-             }
-         }
-     }
-     // Otherwise, return an empty image (8x8 transparent gif)
-     $blankgif = base64_decode('R0lGODlhCAAIAIAAAP///////yH5BAEKAAEALAAAAAAIAAgAAAIHjI+py+1dAAA7');
-     // Also put something in cache so that this URL is not requested twice.
-     file_put_contents($cacheDir .'/'. $blankname, $blankgif);
-     header('Content-Type: image/gif');
-     echo $blankgif;
- }
- // Make a thumbnail of the image (to width: 120 pixels)
- // Returns true if success, false otherwise.
- function resizeImage($filepath)
- {
-     if (!function_exists('imagecreatefromjpeg')) return false; // GD not present: no thumbnail possible.
-     // Trick: some stupid people rename GIF as JPEG... or else.
-     // So we really try to open each image type whatever the extension is.
-     $header=file_get_contents($filepath,false,NULL,0,256); // Read first 256 bytes and try to sniff file type.
-     $im=false;
-     $i=strpos($header,'GIF8'); if (($i!==false) && ($i==0)) $im = imagecreatefromgif($filepath); // Well this is crude, but it should be enough.
-     $i=strpos($header,'PNG'); if (($i!==false) && ($i==1)) $im = imagecreatefrompng($filepath);
-     $i=strpos($header,'JFIF'); if ($i!==false) $im = imagecreatefromjpeg($filepath);
-     if (!$im) return false;  // Unable to open image (corrupted or not an image)
-     $w = imagesx($im);
-     $h = imagesy($im);
-     $ystart = 0; $yheight=$h;
-     if ($h>$w) { $ystart= ($h/2)-($w/2); $yheight=$w/2; }
-     $nw = 120;   // Desired width
-     $nh = min(floor(($h*$nw)/$w),120); // Compute new width/height, but maximum 120 pixels height.
-     // Resize image:
-     $im2 = imagecreatetruecolor($nw,$nh);
-     imagecopyresampled($im2, $im, 0, 0, 0, $ystart, $nw, $nh, $w, $yheight);
-     imageinterlace($im2,true); // For progressive JPEG.
-     $tempname=$filepath.'_TEMP.jpg';
-     imagejpeg($im2, $tempname, 90);
-     imagedestroy($im);
-     imagedestroy($im2);
-     unlink($filepath);
-     rename($tempname,$filepath);  // Overwrite original picture with thumbnail.
-     return true;
+ if (isset($_SERVER['QUERY_STRING']) && startsWith($_SERVER['QUERY_STRING'], 'do=dailyrss')) {
+     showDailyRSS($conf, $loginManager);
+     exit;
  }
  
- if (isset($_SERVER['QUERY_STRING']) && startsWith($_SERVER['QUERY_STRING'], 'do=genthumbnail')) { genThumbnail($conf); exit; }  // Thumbnail generation/cache does not need the link database.
- if (isset($_SERVER['QUERY_STRING']) && startsWith($_SERVER['QUERY_STRING'], 'do=dailyrss')) { showDailyRSS($conf); exit; }
  if (!isset($_SESSION['LINKS_PER_PAGE'])) {
      $_SESSION['LINKS_PER_PAGE'] = $conf->get('general.links_per_page', 20);
  }
  
  try {
      $history = new History($conf->get('resource.history'));
- } catch(Exception $e) {
+ } catch (Exception $e) {
      die($e->getMessage());
  }
  
  $linkDb = new LinkDB(
      $conf->get('resource.datastore'),
-     isLoggedIn(),
+     $loginManager->isLoggedIn(),
      $conf->get('privacy.hide_public_links'),
      $conf->get('redirector.url'),
      $conf->get('redirector.encode_url')
@@@ -2306,23 -1889,37 +1895,37 @@@ $container['history'] = $history
  $app = new \Slim\App($container);
  
  // REST API routes
- $app->group('/api/v1', function() {
+ $app->group('/api/v1', function () {
      $this->get('/info', '\Shaarli\Api\Controllers\Info:getInfo')->setName('getInfo');
      $this->get('/links', '\Shaarli\Api\Controllers\Links:getLinks')->setName('getLinks');
      $this->get('/links/{id:[\d]+}', '\Shaarli\Api\Controllers\Links:getLink')->setName('getLink');
      $this->post('/links', '\Shaarli\Api\Controllers\Links:postLink')->setName('postLink');
      $this->put('/links/{id:[\d]+}', '\Shaarli\Api\Controllers\Links:putLink')->setName('putLink');
      $this->delete('/links/{id:[\d]+}', '\Shaarli\Api\Controllers\Links:deleteLink')->setName('deleteLink');
+     $this->get('/tags', '\Shaarli\Api\Controllers\Tags:getTags')->setName('getTags');
+     $this->get('/tags/{tagName:[\w]+}', '\Shaarli\Api\Controllers\Tags:getTag')->setName('getTag');
+     $this->put('/tags/{tagName:[\w]+}', '\Shaarli\Api\Controllers\Tags:putTag')->setName('putTag');
+     $this->delete('/tags/{tagName:[\w]+}', '\Shaarli\Api\Controllers\Tags:deleteTag')->setName('deleteTag');
      $this->get('/history', '\Shaarli\Api\Controllers\History:getHistory')->setName('getHistory');
  })->add('\Shaarli\Api\ApiMiddleware');
  
  $response = $app->run(true);
  // Hack to make Slim and Shaarli router work together:
  // If a Slim route isn't found and NOT API call, we call renderPage().
  if ($response->getStatusCode() == 404 && strpos($_SERVER['REQUEST_URI'], '/api/v1') === false) {
      // We use UTF-8 for proper international characters handling.
      header('Content-Type: text/html; charset=utf-8');
-     renderPage($conf, $pluginManager, $linkDb, $history, $sessionManager);
+     renderPage($conf, $pluginManager, $linkDb, $history, $sessionManager, $loginManager);
  } else {
+     $response = $response
+         ->withHeader('Access-Control-Allow-Origin', '*')
+         ->withHeader(
+             'Access-Control-Allow-Headers',
+             'X-Requested-With, Content-Type, Accept, Origin, Authorization'
+         )
+         ->withHeader('Access-Control-Allow-Methods', 'GET, POST, PUT, DELETE, OPTIONS');
      $app->respond($response);
  }
index 77578528b5474b88578f4fb724498102577d415f,c4a6e7ef4fee86c9634e9aaff4cfdc7f6f8d03d7..608e331dac04a4c12da14fa920338c79d4f95110
@@@ -2,6 -2,7 +2,7 @@@
  use Shaarli\Config\ConfigJson;
  use Shaarli\Config\ConfigManager;
  use Shaarli\Config\ConfigPhp;
+ use Shaarli\Thumbnailer;
  
  require_once 'tests/Updater/DummyUpdater.php';
  require_once 'inc/rain.tpl.class.php';
@@@ -20,7 -21,7 +21,7 @@@ class UpdaterTest extends PHPUnit_Frame
      /**
       * @var string Config file path (without extension).
       */
-     protected static $configFile = 'tests/utils/config/configJson';
+     protected static $configFile = 'sandbox/config';
  
      /**
       * @var ConfigManager
@@@ -32,6 -33,7 +33,7 @@@
       */
      public function setUp()
      {
+         copy('tests/utils/config/configJson.json.php', self::$configFile .'.json.php');
          $this->conf = new ConfigManager(self::$configFile);
      }
  
@@@ -391,20 -393,32 +393,32 @@@ $GLOBALS[\'privateLinkByDefault\'] = tr
          $this->assertEquals('Naming conventions... #private', $linkDB[0]['description']);
          $this->assertEquals('samba cartoon web', $linkDB[0]['tags']);
          $this->assertTrue($linkDB[0]['private']);
-         $this->assertEquals(DateTime::createFromFormat(LinkDB::LINK_DATE_FORMAT, '20121206_142300'), $linkDB[0]['created']);
+         $this->assertEquals(
+             DateTime::createFromFormat(LinkDB::LINK_DATE_FORMAT, '20121206_142300'),
+             $linkDB[0]['created']
+         );
  
          $this->assertTrue(isset($linkDB[1]));
          $this->assertFalse(isset($linkDB[1]['linkdate']));
          $this->assertEquals(1, $linkDB[1]['id']);
          $this->assertEquals('UserFriendly - Samba', $linkDB[1]['title']);
-         $this->assertEquals(DateTime::createFromFormat(LinkDB::LINK_DATE_FORMAT, '20121206_172539'), $linkDB[1]['created']);
+         $this->assertEquals(
+             DateTime::createFromFormat(LinkDB::LINK_DATE_FORMAT, '20121206_172539'),
+             $linkDB[1]['created']
+         );
  
          $this->assertTrue(isset($linkDB[2]));
          $this->assertFalse(isset($linkDB[2]['linkdate']));
          $this->assertEquals(2, $linkDB[2]['id']);
          $this->assertEquals('Geek and Poke', $linkDB[2]['title']);
-         $this->assertEquals(DateTime::createFromFormat(LinkDB::LINK_DATE_FORMAT, '20121206_182539'), $linkDB[2]['created']);
-         $this->assertEquals(DateTime::createFromFormat(LinkDB::LINK_DATE_FORMAT, '20121206_190301'), $linkDB[2]['updated']);
+         $this->assertEquals(
+             DateTime::createFromFormat(LinkDB::LINK_DATE_FORMAT, '20121206_182539'),
+             $linkDB[2]['created']
+         );
+         $this->assertEquals(
+             DateTime::createFromFormat(LinkDB::LINK_DATE_FORMAT, '20121206_190301'),
+             $linkDB[2]['updated']
+         );
      }
  
      /**
          $this->assertFalse($this->conf->get('security.markdown_escape'));
      }
  
 -
      /**
       * Test updateMethodEscapeMarkdown with markdown plugin disabled
       * => setting markdown_escape set to true.
          $this->assertTrue($updater->updateMethodAtomDefault());
          $this->assertTrue($this->conf->get('feed.show_atom'));
      }
+     /**
+      * Test updateMethodDownloadSizeAndTimeoutConf, it should be set if none is already defined.
+      */
+     public function testUpdateMethodDownloadSizeAndTimeoutConf()
+     {
+         $sandboxConf = 'sandbox/config';
+         copy(self::$configFile . '.json.php', $sandboxConf . '.json.php');
+         $this->conf = new ConfigManager($sandboxConf);
+         $updater = new Updater([], [], $this->conf, true);
+         $this->assertTrue($updater->updateMethodDownloadSizeAndTimeoutConf());
+         $this->assertEquals(4194304, $this->conf->get('general.download_max_size'));
+         $this->assertEquals(30, $this->conf->get('general.download_timeout'));
+         $this->conf = new ConfigManager($sandboxConf);
+         $this->assertEquals(4194304, $this->conf->get('general.download_max_size'));
+         $this->assertEquals(30, $this->conf->get('general.download_timeout'));
+     }
+     /**
+      * Test updateMethodDownloadSizeAndTimeoutConf, it shouldn't be set if it is already defined.
+      */
+     public function testUpdateMethodDownloadSizeAndTimeoutConfIgnore()
+     {
+         $sandboxConf = 'sandbox/config';
+         copy(self::$configFile . '.json.php', $sandboxConf . '.json.php');
+         $this->conf = new ConfigManager($sandboxConf);
+         $this->conf->set('general.download_max_size', 38);
+         $this->conf->set('general.download_timeout', 70);
+         $updater = new Updater([], [], $this->conf, true);
+         $this->assertTrue($updater->updateMethodDownloadSizeAndTimeoutConf());
+         $this->assertEquals(38, $this->conf->get('general.download_max_size'));
+         $this->assertEquals(70, $this->conf->get('general.download_timeout'));
+     }
+     /**
+      * Test updateMethodDownloadSizeAndTimeoutConf, only the maz size should be set here.
+      */
+     public function testUpdateMethodDownloadSizeAndTimeoutConfOnlySize()
+     {
+         $sandboxConf = 'sandbox/config';
+         copy(self::$configFile . '.json.php', $sandboxConf . '.json.php');
+         $this->conf = new ConfigManager($sandboxConf);
+         $this->conf->set('general.download_max_size', 38);
+         $updater = new Updater([], [], $this->conf, true);
+         $this->assertTrue($updater->updateMethodDownloadSizeAndTimeoutConf());
+         $this->assertEquals(38, $this->conf->get('general.download_max_size'));
+         $this->assertEquals(30, $this->conf->get('general.download_timeout'));
+     }
+     /**
+      * Test updateMethodDownloadSizeAndTimeoutConf, only the time out should be set here.
+      */
+     public function testUpdateMethodDownloadSizeAndTimeoutConfOnlyTimeout()
+     {
+         $sandboxConf = 'sandbox/config';
+         copy(self::$configFile . '.json.php', $sandboxConf . '.json.php');
+         $this->conf = new ConfigManager($sandboxConf);
+         $this->conf->set('general.download_timeout', 3);
+         $updater = new Updater([], [], $this->conf, true);
+         $this->assertTrue($updater->updateMethodDownloadSizeAndTimeoutConf());
+         $this->assertEquals(4194304, $this->conf->get('general.download_max_size'));
+         $this->assertEquals(3, $this->conf->get('general.download_timeout'));
+     }
+     /**
+ <<<<<<< HEAD
+      * Test updateMethodWebThumbnailer with thumbnails enabled.
+      */
+     public function testUpdateMethodWebThumbnailerEnabled()
+     {
+         $this->conf->remove('thumbnails');
+         $this->conf->set('thumbnail.enable_thumbnails', true);
+         $updater = new Updater([], [], $this->conf, true, $_SESSION);
+         $this->assertTrue($updater->updateMethodWebThumbnailer());
+         $this->assertFalse($this->conf->exists('thumbnail'));
+         $this->assertEquals(\Shaarli\Thumbnailer::MODE_ALL, $this->conf->get('thumbnails.mode'));
+         $this->assertEquals(125, $this->conf->get('thumbnails.width'));
+         $this->assertEquals(90, $this->conf->get('thumbnails.height'));
+         $this->assertContains('You have enabled or changed thumbnails', $_SESSION['warnings'][0]);
+     }
+     /**
+      * Test updateMethodWebThumbnailer with thumbnails disabled.
+      */
+     public function testUpdateMethodWebThumbnailerDisabled()
+     {
+         $this->conf->remove('thumbnails');
+         $this->conf->set('thumbnail.enable_thumbnails', false);
+         $updater = new Updater([], [], $this->conf, true, $_SESSION);
+         $this->assertTrue($updater->updateMethodWebThumbnailer());
+         $this->assertFalse($this->conf->exists('thumbnail'));
+         $this->assertEquals(Thumbnailer::MODE_NONE, $this->conf->get('thumbnails.mode'));
+         $this->assertEquals(125, $this->conf->get('thumbnails.width'));
+         $this->assertEquals(90, $this->conf->get('thumbnails.height'));
+         $this->assertTrue(empty($_SESSION['warnings']));
+     }
+     /**
+      * Test updateMethodWebThumbnailer with thumbnails disabled.
+      */
+     public function testUpdateMethodWebThumbnailerNothingToDo()
+     {
+         $updater = new Updater([], [], $this->conf, true, $_SESSION);
+         $this->assertTrue($updater->updateMethodWebThumbnailer());
+         $this->assertFalse($this->conf->exists('thumbnail'));
+         $this->assertEquals(Thumbnailer::MODE_COMMON, $this->conf->get('thumbnails.mode'));
+         $this->assertEquals(90, $this->conf->get('thumbnails.width'));
+         $this->assertEquals(53, $this->conf->get('thumbnails.height'));
+         $this->assertTrue(empty($_SESSION['warnings']));
+     }
+     /**
+      * Test updateMethodSetSticky().
+      */
+     public function testUpdateStickyValid()
+     {
+         $blank = [
+             'id' => 1,
+             'url' => 'z',
+             'title' => '',
+             'description' => '',
+             'tags' => '',
+             'created' => new DateTime(),
+         ];
+         $links = [
+             1 => ['id' => 1] + $blank,
+             2 => ['id' => 2] + $blank,
+         ];
+         $refDB = new ReferenceLinkDB();
+         $refDB->setLinks($links);
+         $refDB->write(self::$testDatastore);
+         $linkDB = new LinkDB(self::$testDatastore, true, false);
+         $updater = new Updater(array(), $linkDB, $this->conf, true);
+         $this->assertTrue($updater->updateMethodSetSticky());
+         $linkDB = new LinkDB(self::$testDatastore, true, false);
+         foreach ($linkDB as $link) {
+             $this->assertFalse($link['sticky']);
+         }
+     }
+     /**
+      * Test updateMethodSetSticky().
+      */
+     public function testUpdateStickyNothingToDo()
+     {
+         $blank = [
+             'id' => 1,
+             'url' => 'z',
+             'title' => '',
+             'description' => '',
+             'tags' => '',
+             'created' => new DateTime(),
+         ];
+         $links = [
+             1 => ['id' => 1, 'sticky' => true] + $blank,
+             2 => ['id' => 2] + $blank,
+         ];
+         $refDB = new ReferenceLinkDB();
+         $refDB->setLinks($links);
+         $refDB->write(self::$testDatastore);
+         $linkDB = new LinkDB(self::$testDatastore, true, false);
+         $updater = new Updater(array(), $linkDB, $this->conf, true);
+         $this->assertTrue($updater->updateMethodSetSticky());
+         $linkDB = new LinkDB(self::$testDatastore, true, false);
+         $this->assertTrue($linkDB[1]['sticky']);
+     }
  }