]> git.immae.eu Git - github/shaarli/Shaarli.git/commitdiff
LinkDBTest: only check that the datastore is created and non-empty 254/head
authorVirtualTam <virtualtam@flibidi.net>
Sun, 28 Jun 2015 12:53:26 +0000 (14:53 +0200)
committerVirtualTam <virtualtam@flibidi.net>
Sun, 28 Jun 2015 12:53:26 +0000 (14:53 +0200)
Fixes #252
Relates to #238

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
tests/LinkDBTest.php

index a54fc501caca0d3f6b3f17efc660bae65aec493e..ee8dbee3181840efae91014803e2ac809f63e6da 100644 (file)
@@ -15,7 +15,6 @@ class LinkDBTest extends PHPUnit_Framework_TestCase
 {
     // datastore to test write operations
     protected static $testDatastore = 'tests/datastore.php';
-    protected static $dummyDatastoreFilesize = 759;
     protected static $refDB = null;
     protected static $publicLinkDB = null;
     protected static $privateLinkDB = null;
@@ -109,10 +108,7 @@ class LinkDBTest extends PHPUnit_Framework_TestCase
         $this->assertFileExists(self::$testDatastore);
 
         // ensure the correct data has been written
-        $this->assertEquals(
-            self::$dummyDatastoreFilesize,
-            filesize(self::$testDatastore)
-        );
+        $this->assertGreaterThan(0, filesize(self::$testDatastore));
     }
 
     /**
@@ -121,17 +117,15 @@ class LinkDBTest extends PHPUnit_Framework_TestCase
     public function testCheckDBLoad()
     {
         $linkDB = new LinkDB(self::$testDatastore, false, false);
-        $this->assertEquals(
-            self::$dummyDatastoreFilesize,
-            filesize(self::$testDatastore)
-        );
+        $datastoreSize = filesize(self::$testDatastore);
+        $this->assertGreaterThan(0, $datastoreSize);
 
         $checkDB = self::getMethod('checkDB');
         $checkDB->invokeArgs($linkDB, array());
 
         // ensure the datastore is left unmodified
         $this->assertEquals(
-            self::$dummyDatastoreFilesize,
+            $datastoreSize,
             filesize(self::$testDatastore)
         );
     }