]> git.immae.eu Git - github/fretlink/pronto-hlint.git/commitdiff
Depend on newest versions of pronto and eslint (less strictly)
authorMindaugas Mozūras <mindaugas.mozuras@gmail.com>
Mon, 14 Mar 2016 21:08:08 +0000 (23:08 +0200)
committerMindaugas Mozūras <mindaugas.mozuras@gmail.com>
Mon, 14 Mar 2016 21:08:08 +0000 (23:08 +0200)
lib/pronto/eslint.rb
pronto-eslint.gemspec
spec/pronto/eslint_spec.rb

index 67e9229021ea9f2a3f8858f04793363ad30cd123..b6ccff1fee5f2c17b51393f6b70ce1d59f0b4697 100644 (file)
@@ -3,10 +3,10 @@ require 'eslintrb'
 
 module Pronto
   class ESLint < Runner
-    def run(patches, _)
-      return [] unless patches
+    def run
+      return [] unless @patches
 
-      patches.select { |patch| patch.additions > 0 }
+      @patches.select { |patch| patch.additions > 0 }
         .select { |patch| js_file?(patch.new_file_full_path) }
         .map { |patch| inspect(patch) }
         .flatten.compact
@@ -26,7 +26,7 @@ module Pronto
       path = line.patch.delta.new_file[:path]
       level = :warning
 
-      Message.new(path, line, level, offence['message'])
+      Message.new(path, line, level, offence['message'], nil, self.class)
     end
 
     def js_file?(path)
index 7a575603ddaf071914aba43e12f64c0c271c2c5c..77da780974bffeecde7d96d395c667287b88aebd 100644 (file)
@@ -34,9 +34,9 @@ Gem::Specification.new do |s|
   s.extra_rdoc_files = ['LICENSE', 'README.md']
   s.require_paths = ['lib']
 
-  s.add_dependency('pronto', '~> 0.5.0')
-  s.add_dependency('eslintrb', '~> 2.0.0')
-  s.add_development_dependency('rake', '~> 10.4')
-  s.add_development_dependency('rspec', '~> 3.3')
+  s.add_dependency('pronto', '~> 0.6.0')
+  s.add_dependency('eslintrb', '~> 2.0', '>= 2.0.0')
+  s.add_development_dependency('rake', '~> 11.0')
+  s.add_development_dependency('rspec', '~> 3.4')
   s.add_development_dependency('rspec-its', '~> 1.2')
 end
index 8bd0bc848f1bcf193945fc9262925cc9219c446a..29d46e481c78e21576870693ffe6b3f4dd8525da 100644 (file)
@@ -2,10 +2,10 @@ require 'spec_helper'
 
 module Pronto
   describe ESLint do
-    let(:eslint) { ESLint.new }
+    let(:eslint) { ESLint.new(patches) }
 
     describe '#run' do
-      subject { eslint.run(patches, nil) }
+      subject { eslint.run }
 
       context 'patches are nil' do
         let(:patches) { nil }