Derivation Path errors are detected.

diff --git a/bip39-standalone.html b/bip39-standalone.html
index 9d975eba83e36033edc04dc8745af8430502119d..dfeaa651ed6b0e921fe44bc9e76bf78be2fc9271 100644 (file)
--- a/bip39-standalone.html
+++ b/bip39-standalone.html
@@ -14838,7 +14838,39 @@ var Mnemonic = function(language) {
     }
 
     function findDerivationPathErrors(path) {
-        // TODO
+        // TODO is not perfect but is better than nothing
+        // Inspired by
+        // https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki#test-vectors
+        // and
+        // https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki#extended-keys
+        var maxDepth = 255; // TODO verify this!!
+        var maxIndexValue = Math.pow(2, 31); // TODO verify this!!
+        if (path[0] != "m") {
+            return "First character must be 'm'";
+        }
+        if (path.length > 1) {
+            if (path[1] != "/") {
+                return "Separator must be '/'";
+            }
+            var indexes = path.split("/");
+            if (indexes.length > maxDepth) {
+                return "Derivation depth is " + indexes.length + ", must be less than " + maxDepth;
+            }
+            for (var depth = 1; depth<indexes.length; depth++) {
+                var index = indexes[depth];
+                var invalidChars = index.replace(/^[0-9]+'?$/g, "")
+                if (invalidChars.length > 0) {
+                    return "Invalid characters " + invalidChars + " found at depth " + depth;
+                }
+                var indexValue = parseInt(index.replace("'", ""));
+                if (isNaN(depth)) {
+                    return "Invalid number at depth " + depth;
+                }
+                if (indexValue > maxIndexValue) {
+                    return "Value of " + indexValue + " at depth " + depth + " must be less than " + maxIndexValue;
+                }
+            }
+        }
         return false;
     }
 

diff --git a/src/js/index.js b/src/js/index.js
index f131e01c84d1832d0238ca6d9d28ac8a41e57381..6f0da65d391a29e58f3dcdc597fc3511039b7e40 100644 (file)
--- a/src/js/index.js
+++ b/src/js/index.js
@@ -232,7 +232,39 @@
     }
 
     function findDerivationPathErrors(path) {
-        // TODO
+        // TODO is not perfect but is better than nothing
+        // Inspired by
+        // https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki#test-vectors
+        // and
+        // https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki#extended-keys
+        var maxDepth = 255; // TODO verify this!!
+        var maxIndexValue = Math.pow(2, 31); // TODO verify this!!
+        if (path[0] != "m") {
+            return "First character must be 'm'";
+        }
+        if (path.length > 1) {
+            if (path[1] != "/") {
+                return "Separator must be '/'";
+            }
+            var indexes = path.split("/");
+            if (indexes.length > maxDepth) {
+                return "Derivation depth is " + indexes.length + ", must be less than " + maxDepth;
+            }
+            for (var depth = 1; depth<indexes.length; depth++) {
+                var index = indexes[depth];
+                var invalidChars = index.replace(/^[0-9]+'?$/g, "")
+                if (invalidChars.length > 0) {
+                    return "Invalid characters " + invalidChars + " found at depth " + depth;
+                }
+                var indexValue = parseInt(index.replace("'", ""));
+                if (isNaN(depth)) {
+                    return "Invalid number at depth " + depth;
+                }
+                if (indexValue > maxIndexValue) {
+                    return "Value of " + indexValue + " at depth " + depth + " must be less than " + maxIndexValue;
+                }
+            }
+        }
         return false;
     }