From a5365ec3d924a91abdd80c4f58d2158472788de9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Isma=C3=ABl=20Bouya?= <ismael.bouya@normalesup.org>
Date: Mon, 21 Jan 2019 21:06:33 +0100
Subject: Move all fixmes to mantisbt issue tracking

Fixes https://git.immae.eu/mantisbt/view.php?id=111
---
 virtual/modules/websites/commons/stats.nix | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

(limited to 'virtual/modules/websites/commons/stats.nix')

diff --git a/virtual/modules/websites/commons/stats.nix b/virtual/modules/websites/commons/stats.nix
index a7ade3b..b5bf0e0 100644
--- a/virtual/modules/websites/commons/stats.nix
+++ b/virtual/modules/websites/commons/stats.nix
@@ -6,8 +6,12 @@ in {
     services.myWebsites.commons.stats = {
       enable = lib.mkEnableOption "enable statistics";
       sites = lib.mkOption {
-        # FIXME: specify
-        type = lib.types.listOf (lib.types.unspecified);
+        type = lib.types.listOf (lib.types.submodule {
+          options = {
+            conf = lib.mkOption { type = lib.types.path; };
+            name = lib.mkOption { type = lib.types.string; };
+          };
+        });
         default = [];
         description = "Sites to generate stats";
       };
@@ -51,13 +55,10 @@ in {
             goaccess $TMPFILE --no-progress -o /var/lib/goaccess/${domain}/index.html -p ${conf}
             '';
           in "${d}/bin/stats-${domain}";
-      # FIXME: running several goaccess simultaneously seems to be
-      # bugged?
       in
         pkgs.lib.lists.imap0 (i: v: "${toString (i+5)} 0 * * * root ${stats v.name v.conf}") cfg.sites;
     };
 
-    # FIXME: initial sync
     system.activationScripts.goaccess = ''
       mkdir -p /var/lib/goaccess
     '' +
-- 
cgit v1.2.3