From b787a7757ea73b9d10c14cb21758feb07dfc5885 Mon Sep 17 00:00:00 2001 From: Jeremy Benoist Date: Mon, 28 Mar 2016 16:43:33 +0200 Subject: Refacto wallabag import Use an abstract class to store all common action from wallabag vX import. Move specificity in v1 & v2 import. --- .../ImportBundle/Import/WallabagV2Import.php | 59 +++------------------- 1 file changed, 8 insertions(+), 51 deletions(-) (limited to 'src/Wallabag/ImportBundle/Import/WallabagV2Import.php') diff --git a/src/Wallabag/ImportBundle/Import/WallabagV2Import.php b/src/Wallabag/ImportBundle/Import/WallabagV2Import.php index b31d63a3..d0035b63 100644 --- a/src/Wallabag/ImportBundle/Import/WallabagV2Import.php +++ b/src/Wallabag/ImportBundle/Import/WallabagV2Import.php @@ -2,9 +2,7 @@ namespace Wallabag\ImportBundle\Import; -use Wallabag\CoreBundle\Entity\Entry; - -class WallabagV2Import extends WallabagV1Import implements ImportInterface +class WallabagV2Import extends WallabagImport { /** * {@inheritdoc} @@ -31,55 +29,14 @@ class WallabagV2Import extends WallabagV1Import implements ImportInterface } /** - * @param $entries + * {@inheritdoc} */ - protected function parseEntries($entries) + protected function prepareEntry($entry = [], $markAsRead = false) { - $i = 1; - - foreach ($entries as $importedEntry) { - $existingEntry = $this->em - ->getRepository('WallabagCoreBundle:Entry') - ->findByUrlAndUserId($importedEntry['url'], $this->user->getId()); - - if (false !== $existingEntry) { - ++$this->skippedEntries; - continue; - } - - $importedEntry['html'] = $importedEntry['content']; - $importedEntry['content_type'] = $importedEntry['mimetype']; - - $entry = $this->contentProxy->updateEntry( - new Entry($this->user), - $importedEntry['url'], - $importedEntry - ); - - if (array_key_exists('tags', $importedEntry) && !empty($importedEntry['tags'])) { - $this->contentProxy->assignTagsToEntry( - $entry, - $importedEntry['tags'] - ); - } - - if (isset($importedEntry['preview_picture'])) { - $entry->setPreviewPicture($importedEntry['preview_picture']); - } - - $entry->setArchived($importedEntry['is_archived'] || $this->markAsRead); - $entry->setStarred($importedEntry['is_starred']); - - $this->em->persist($entry); - ++$this->importedEntries; - - // flush every 20 entries - if (($i % 20) === 0) { - $this->em->flush(); - } - ++$i; - } - - $this->em->flush(); + return [ + 'html' => $entry['content'], + 'content_type' => $entry['mimetype'], + 'is_archived' => ($entry['is_archived'] || $markAsRead), + ] + $entry; } } -- cgit v1.2.3