From 4d0ec0e72108ff47952906e5d968a7c3eb0a76f9 Mon Sep 17 00:00:00 2001 From: Jeremy Benoist Date: Sun, 27 Mar 2016 20:35:56 +0200 Subject: Fix some Scrutinizer issues --- .../ImportBundle/Import/WallabagV1Import.php | 25 +++++++++++++--------- 1 file changed, 15 insertions(+), 10 deletions(-) (limited to 'src/Wallabag/ImportBundle/Import/WallabagV1Import.php') diff --git a/src/Wallabag/ImportBundle/Import/WallabagV1Import.php b/src/Wallabag/ImportBundle/Import/WallabagV1Import.php index 173a587f..82160bae 100644 --- a/src/Wallabag/ImportBundle/Import/WallabagV1Import.php +++ b/src/Wallabag/ImportBundle/Import/WallabagV1Import.php @@ -7,7 +7,6 @@ use Psr\Log\NullLogger; use Doctrine\ORM\EntityManager; use Wallabag\CoreBundle\Entity\Entry; use Wallabag\UserBundle\Entity\User; -use Wallabag\CoreBundle\Tools\Utils; use Wallabag\CoreBundle\Helper\ContentProxy; class WallabagV1Import implements ImportInterface @@ -153,19 +152,25 @@ class WallabagV1Import implements ImportInterface continue; } - // @see ContentProxy->updateEntry - $entry = new Entry($this->user); - $entry->setUrl($importedEntry['url']); + $data = [ + 'title' => $importedEntry['title'], + 'html' => $importedEntry['content'], + 'url' => $importedEntry['url'], + 'content_type' => '', + 'language' => '', + ]; + // force content to be refreshed in case on bad fetch in the v1 installation if (in_array($importedEntry['title'], $untitled)) { - $entry = $this->contentProxy->updateEntry($entry, $importedEntry['url']); - } else { - $entry->setContent($importedEntry['content']); - $entry->setTitle($importedEntry['title']); - $entry->setReadingTime(Utils::getReadingTime($importedEntry['content'])); - $entry->setDomainName(parse_url($importedEntry['url'], PHP_URL_HOST)); + $data = []; } + $entry = $this->contentProxy->updateEntry( + new Entry($this->user), + $importedEntry['url'], + $data + ); + if (array_key_exists('tags', $importedEntry) && $importedEntry['tags'] != '') { $this->contentProxy->assignTagsToEntry( $entry, -- cgit v1.2.3