From 73f7eabb6e10cff09a79105b6525e3c269e3cf08 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicolas=20L=C5=93uillet?= Date: Fri, 25 Nov 2016 13:47:09 +0100 Subject: Added hasColumn() in migration to check column existence --- app/DoctrineMigrations/Version20160410190541.php | 44 +++++++++++++++++++++--- 1 file changed, 40 insertions(+), 4 deletions(-) (limited to 'app/DoctrineMigrations/Version20160410190541.php') diff --git a/app/DoctrineMigrations/Version20160410190541.php b/app/DoctrineMigrations/Version20160410190541.php index f034b0e4..5de53d4b 100644 --- a/app/DoctrineMigrations/Version20160410190541.php +++ b/app/DoctrineMigrations/Version20160410190541.php @@ -21,7 +21,41 @@ class Version20160410190541 extends AbstractMigration implements ContainerAwareI private function getTable($tableName) { - return $this->container->getParameter('database_table_prefix') . $tableName; + return $this->container->getParameter('database_table_prefix').$tableName; + } + + private function hasColumn($tableName, $columnName) + { + switch ($this->connection->getDatabasePlatform()->getName()) { + case 'sqlite': + $rows = $this->connection->executeQuery('pragma table_info('.$tableName.')')->fetchAll(); + foreach ($rows as $column) { + if (strcasecmp($column['name'], $columnName) === 0) { + return true; + } + } + + return false; + case 'mysql': + $rows = $this->connection->executeQuery('SHOW COLUMNS FROM '.$tableName)->fetchAll(); + foreach ($rows as $column) { + if (strcasecmp($column['Field'], $columnName) === 0) { + return true; + } + } + + return false; + case 'postgresql': + $sql = sprintf("SELECT count(*) + FROM information_schema.columns + WHERE table_schema = 'public' AND table_name = '%s' AND column_name = '%s'", + $tableName, + $columnName + ); + $result = $this->connection->executeQuery($sql)->fetch(); + + return $result['count'] > 0; + } } /** @@ -29,13 +63,15 @@ class Version20160410190541 extends AbstractMigration implements ContainerAwareI */ public function up(Schema $schema) { + $this->skipIf($this->hasColumn($this->getTable('entry'), 'uuid'), 'It seems that you already played this migration.'); + if ($this->connection->getDatabasePlatform()->getName() == 'postgresql') { $this->addSql('ALTER TABLE "'.$this->getTable('entry').'" ADD uuid UUID DEFAULT NULL'); } else { $this->addSql('ALTER TABLE "'.$this->getTable('entry').'" ADD uuid LONGTEXT DEFAULT NULL'); } - $this->addSql("INSERT INTO \"".$this->getTable('craue_config_setting')."\" (name, value, section) VALUES ('share_public', '1', 'entry')"); + $this->addSql('INSERT INTO "'.$this->getTable('craue_config_setting')."\" (name, value, section) VALUES ('share_public', '1', 'entry')"); } /** @@ -43,9 +79,9 @@ class Version20160410190541 extends AbstractMigration implements ContainerAwareI */ public function down(Schema $schema) { - $this->abortIf($this->connection->getDatabasePlatform()->getName() != 'sqlite', 'This down migration can\'t be executed on SQLite databases, because SQLite don\'t support DROP COLUMN.'); + $this->skipIf($this->connection->getDatabasePlatform()->getName() != 'sqlite', 'This down migration can\'t be executed on SQLite databases, because SQLite don\'t support DROP COLUMN.'); $this->addSql('ALTER TABLE "'.$this->getTable('entry').'" DROP uuid'); - $this->addSql("DELETE FROM \"".$this->getTable('craue_config_setting')."\" WHERE name = 'share_public'"); + $this->addSql('DELETE FROM "'.$this->getTable('craue_config_setting')."\" WHERE name = 'share_public'"); } } -- cgit v1.2.3 From 986cb536457e921dacf7ab5c7bc16ad4b2108781 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicolas=20L=C5=93uillet?= Date: Fri, 25 Nov 2016 17:36:15 +0100 Subject: Removed my hasColumn and used the existing one in Doctrine --- app/DoctrineMigrations/Version20160410190541.php | 36 +----------------------- 1 file changed, 1 insertion(+), 35 deletions(-) (limited to 'app/DoctrineMigrations/Version20160410190541.php') diff --git a/app/DoctrineMigrations/Version20160410190541.php b/app/DoctrineMigrations/Version20160410190541.php index 5de53d4b..c2360937 100644 --- a/app/DoctrineMigrations/Version20160410190541.php +++ b/app/DoctrineMigrations/Version20160410190541.php @@ -24,46 +24,12 @@ class Version20160410190541 extends AbstractMigration implements ContainerAwareI return $this->container->getParameter('database_table_prefix').$tableName; } - private function hasColumn($tableName, $columnName) - { - switch ($this->connection->getDatabasePlatform()->getName()) { - case 'sqlite': - $rows = $this->connection->executeQuery('pragma table_info('.$tableName.')')->fetchAll(); - foreach ($rows as $column) { - if (strcasecmp($column['name'], $columnName) === 0) { - return true; - } - } - - return false; - case 'mysql': - $rows = $this->connection->executeQuery('SHOW COLUMNS FROM '.$tableName)->fetchAll(); - foreach ($rows as $column) { - if (strcasecmp($column['Field'], $columnName) === 0) { - return true; - } - } - - return false; - case 'postgresql': - $sql = sprintf("SELECT count(*) - FROM information_schema.columns - WHERE table_schema = 'public' AND table_name = '%s' AND column_name = '%s'", - $tableName, - $columnName - ); - $result = $this->connection->executeQuery($sql)->fetch(); - - return $result['count'] > 0; - } - } - /** * @param Schema $schema */ public function up(Schema $schema) { - $this->skipIf($this->hasColumn($this->getTable('entry'), 'uuid'), 'It seems that you already played this migration.'); + $this->skipIf($schema->getTable($this->getTable('entry'))->hasColumn('uuid'), 'It seems that you already played this migration.'); if ($this->connection->getDatabasePlatform()->getName() == 'postgresql') { $this->addSql('ALTER TABLE "'.$this->getTable('entry').'" ADD uuid UUID DEFAULT NULL'); -- cgit v1.2.3 From 597755b8c7f45310df072d2185fc7bd406f9a39e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicolas=20L=C5=93uillet?= Date: Sat, 26 Nov 2016 16:06:14 +0100 Subject: Cleaned old migrations --- app/DoctrineMigrations/Version20160410190541.php | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) (limited to 'app/DoctrineMigrations/Version20160410190541.php') diff --git a/app/DoctrineMigrations/Version20160410190541.php b/app/DoctrineMigrations/Version20160410190541.php index c2360937..0cdec008 100644 --- a/app/DoctrineMigrations/Version20160410190541.php +++ b/app/DoctrineMigrations/Version20160410190541.php @@ -29,15 +29,14 @@ class Version20160410190541 extends AbstractMigration implements ContainerAwareI */ public function up(Schema $schema) { - $this->skipIf($schema->getTable($this->getTable('entry'))->hasColumn('uuid'), 'It seems that you already played this migration.'); + $entryTable = $schema->getTable($this->getTable('entry')); - if ($this->connection->getDatabasePlatform()->getName() == 'postgresql') { - $this->addSql('ALTER TABLE "'.$this->getTable('entry').'" ADD uuid UUID DEFAULT NULL'); - } else { - $this->addSql('ALTER TABLE "'.$this->getTable('entry').'" ADD uuid LONGTEXT DEFAULT NULL'); - } + $this->skipIf($entryTable->hasColumn('uuid'), 'It seems that you already played this migration.'); - $this->addSql('INSERT INTO "'.$this->getTable('craue_config_setting')."\" (name, value, section) VALUES ('share_public', '1', 'entry')"); + $entryTable->addColumn('uuid', 'guid', [ + 'notnull' => false, + ]); + $this->addSql('INSERT INTO '.$this->getTable('craue_config_setting')." (name, value, section) VALUES ('share_public', '1', 'entry')"); } /** @@ -45,9 +44,9 @@ class Version20160410190541 extends AbstractMigration implements ContainerAwareI */ public function down(Schema $schema) { - $this->skipIf($this->connection->getDatabasePlatform()->getName() != 'sqlite', 'This down migration can\'t be executed on SQLite databases, because SQLite don\'t support DROP COLUMN.'); + $entryTable = $schema->getTable($this->getTable('entry')); + $entryTable->dropColumn('uuid'); - $this->addSql('ALTER TABLE "'.$this->getTable('entry').'" DROP uuid'); - $this->addSql('DELETE FROM "'.$this->getTable('craue_config_setting')."\" WHERE name = 'share_public'"); + $this->addSql('DELETE FROM '.$this->getTable('craue_config_setting')." WHERE name = 'share_public'"); } } -- cgit v1.2.3