From b12e23ad8a80097da47061c9329d418eee4607d0 Mon Sep 17 00:00:00 2001 From: Jeremy Benoist Date: Sun, 29 Mar 2020 11:39:49 +0200 Subject: Cleanup cookie jar As of latest Guzzle release, it's fixed so we can removed that code. --- src/Wallabag/CoreBundle/Helper/FileCookieJar.php | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/src/Wallabag/CoreBundle/Helper/FileCookieJar.php b/src/Wallabag/CoreBundle/Helper/FileCookieJar.php index 9a63e949..4b4dca10 100644 --- a/src/Wallabag/CoreBundle/Helper/FileCookieJar.php +++ b/src/Wallabag/CoreBundle/Helper/FileCookieJar.php @@ -9,7 +9,6 @@ use Psr\Log\LoggerInterface; /** * Overidden Cookie behavior to: - * - fix multiple concurrent writes (see https://github.com/guzzle/guzzle/pull/1884) * - ignore error when the cookie file is malformatted (resulting in clearing it). */ class FileCookieJar extends BaseFileCookieJar @@ -27,29 +26,6 @@ class FileCookieJar extends BaseFileCookieJar $this->logger = $logger; } - /** - * Saves the cookies to a file. - * - * @param string $filename File to save - * - * @throws \RuntimeException if the file cannot be found or created - */ - public function save($filename) - { - $json = []; - foreach ($this as $cookie) { - if ($cookie->getExpires() && !$cookie->getDiscard()) { - $json[] = $cookie->toArray(); - } - } - - if (false === file_put_contents($filename, json_encode($json), LOCK_EX)) { - // @codeCoverageIgnoreStart - throw new \RuntimeException("Unable to save file {$filename}"); - // @codeCoverageIgnoreEnd - } - } - /** * Load cookies from a JSON formatted file. * -- cgit v1.2.3