aboutsummaryrefslogtreecommitdiffhomepage
path: root/tests/Wallabag/CoreBundle/Helper/ContentProxyTest.php
diff options
context:
space:
mode:
Diffstat (limited to 'tests/Wallabag/CoreBundle/Helper/ContentProxyTest.php')
-rw-r--r--tests/Wallabag/CoreBundle/Helper/ContentProxyTest.php463
1 files changed, 314 insertions, 149 deletions
diff --git a/tests/Wallabag/CoreBundle/Helper/ContentProxyTest.php b/tests/Wallabag/CoreBundle/Helper/ContentProxyTest.php
index 4f70ed0c..f94c2137 100644
--- a/tests/Wallabag/CoreBundle/Helper/ContentProxyTest.php
+++ b/tests/Wallabag/CoreBundle/Helper/ContentProxyTest.php
@@ -2,10 +2,17 @@
2 2
3namespace Tests\Wallabag\CoreBundle\Helper; 3namespace Tests\Wallabag\CoreBundle\Helper;
4 4
5use Graby\Graby;
6use Monolog\Handler\TestHandler;
7use Monolog\Logger;
5use Psr\Log\NullLogger; 8use Psr\Log\NullLogger;
6use Wallabag\CoreBundle\Helper\ContentProxy; 9use Symfony\Component\Validator\ConstraintViolation;
10use Symfony\Component\Validator\ConstraintViolationList;
11use Symfony\Component\Validator\Validator\RecursiveValidator;
7use Wallabag\CoreBundle\Entity\Entry; 12use Wallabag\CoreBundle\Entity\Entry;
8use Wallabag\CoreBundle\Entity\Tag; 13use Wallabag\CoreBundle\Entity\Tag;
14use Wallabag\CoreBundle\Helper\ContentProxy;
15use Wallabag\CoreBundle\Helper\RuleBasedTagger;
9use Wallabag\UserBundle\Entity\User; 16use Wallabag\UserBundle\Entity\User;
10 17
11class ContentProxyTest extends \PHPUnit_Framework_TestCase 18class ContentProxyTest extends \PHPUnit_Framework_TestCase
@@ -33,17 +40,18 @@ class ContentProxyTest extends \PHPUnit_Framework_TestCase
33 'language' => '', 40 'language' => '',
34 ]); 41 ]);
35 42
36 $proxy = new ContentProxy($graby, $tagger, $this->getTagRepositoryMock(), $this->getLogger(), $this->fetchingErrorMessage); 43 $proxy = new ContentProxy($graby, $tagger, $this->getValidator(), $this->getLogger(), $this->fetchingErrorMessage);
37 $entry = $proxy->updateEntry(new Entry(new User()), 'http://user@:80'); 44 $entry = new Entry(new User());
45 $proxy->updateEntry($entry, 'http://user@:80');
38 46
39 $this->assertEquals('http://user@:80', $entry->getUrl()); 47 $this->assertSame('http://user@:80', $entry->getUrl());
40 $this->assertEmpty($entry->getTitle()); 48 $this->assertEmpty($entry->getTitle());
41 $this->assertEquals($this->fetchingErrorMessage, $entry->getContent()); 49 $this->assertSame($this->fetchingErrorMessage, $entry->getContent());
42 $this->assertEmpty($entry->getPreviewPicture()); 50 $this->assertEmpty($entry->getPreviewPicture());
43 $this->assertEmpty($entry->getMimetype()); 51 $this->assertEmpty($entry->getMimetype());
44 $this->assertEmpty($entry->getLanguage()); 52 $this->assertEmpty($entry->getLanguage());
45 $this->assertEquals(0.0, $entry->getReadingTime()); 53 $this->assertSame(0.0, $entry->getReadingTime());
46 $this->assertEquals(false, $entry->getDomainName()); 54 $this->assertSame(null, $entry->getDomainName());
47 } 55 }
48 56
49 public function testWithEmptyContent() 57 public function testWithEmptyContent()
@@ -67,17 +75,18 @@ class ContentProxyTest extends \PHPUnit_Framework_TestCase
67 'language' => '', 75 'language' => '',
68 ]); 76 ]);
69 77
70 $proxy = new ContentProxy($graby, $tagger, $this->getTagRepositoryMock(), $this->getLogger(), $this->fetchingErrorMessage); 78 $proxy = new ContentProxy($graby, $tagger, $this->getValidator(), $this->getLogger(), $this->fetchingErrorMessage);
71 $entry = $proxy->updateEntry(new Entry(new User()), 'http://0.0.0.0'); 79 $entry = new Entry(new User());
80 $proxy->updateEntry($entry, 'http://0.0.0.0');
72 81
73 $this->assertEquals('http://0.0.0.0', $entry->getUrl()); 82 $this->assertSame('http://0.0.0.0', $entry->getUrl());
74 $this->assertEmpty($entry->getTitle()); 83 $this->assertEmpty($entry->getTitle());
75 $this->assertEquals($this->fetchingErrorMessage, $entry->getContent()); 84 $this->assertSame($this->fetchingErrorMessage, $entry->getContent());
76 $this->assertEmpty($entry->getPreviewPicture()); 85 $this->assertEmpty($entry->getPreviewPicture());
77 $this->assertEmpty($entry->getMimetype()); 86 $this->assertEmpty($entry->getMimetype());
78 $this->assertEmpty($entry->getLanguage()); 87 $this->assertEmpty($entry->getLanguage());
79 $this->assertEquals(0.0, $entry->getReadingTime()); 88 $this->assertSame(0.0, $entry->getReadingTime());
80 $this->assertEquals('0.0.0.0', $entry->getDomainName()); 89 $this->assertSame('0.0.0.0', $entry->getDomainName());
81 } 90 }
82 91
83 public function testWithEmptyContentButOG() 92 public function testWithEmptyContentButOG()
@@ -106,18 +115,19 @@ class ContentProxyTest extends \PHPUnit_Framework_TestCase
106 ], 115 ],
107 ]); 116 ]);
108 117
109 $proxy = new ContentProxy($graby, $tagger, $this->getTagRepositoryMock(), $this->getLogger(), $this->fetchingErrorMessage); 118 $proxy = new ContentProxy($graby, $tagger, $this->getValidator(), $this->getLogger(), $this->fetchingErrorMessage);
110 $entry = $proxy->updateEntry(new Entry(new User()), 'http://domain.io'); 119 $entry = new Entry(new User());
120 $proxy->updateEntry($entry, 'http://domain.io');
111 121
112 $this->assertEquals('http://domain.io', $entry->getUrl()); 122 $this->assertSame('http://domain.io', $entry->getUrl());
113 $this->assertEquals('my title', $entry->getTitle()); 123 $this->assertSame('my title', $entry->getTitle());
114 $this->assertEquals($this->fetchingErrorMessage . '<p><i>But we found a short description: </i></p>desc', $entry->getContent()); 124 $this->assertSame($this->fetchingErrorMessage . '<p><i>But we found a short description: </i></p>desc', $entry->getContent());
115 $this->assertEmpty($entry->getPreviewPicture()); 125 $this->assertEmpty($entry->getPreviewPicture());
116 $this->assertEmpty($entry->getLanguage()); 126 $this->assertEmpty($entry->getLanguage());
117 $this->assertEmpty($entry->getHttpStatus()); 127 $this->assertEmpty($entry->getHttpStatus());
118 $this->assertEmpty($entry->getMimetype()); 128 $this->assertEmpty($entry->getMimetype());
119 $this->assertEquals(0.0, $entry->getReadingTime()); 129 $this->assertSame(0.0, $entry->getReadingTime());
120 $this->assertEquals('domain.io', $entry->getDomainName()); 130 $this->assertSame('domain.io', $entry->getDomainName());
121 } 131 }
122 132
123 public function testWithContent() 133 public function testWithContent()
@@ -147,18 +157,19 @@ class ContentProxyTest extends \PHPUnit_Framework_TestCase
147 ], 157 ],
148 ]); 158 ]);
149 159
150 $proxy = new ContentProxy($graby, $tagger, $this->getTagRepositoryMock(), $this->getLogger(), $this->fetchingErrorMessage); 160 $proxy = new ContentProxy($graby, $tagger, $this->getValidator(), $this->getLogger(), $this->fetchingErrorMessage);
151 $entry = $proxy->updateEntry(new Entry(new User()), 'http://0.0.0.0'); 161 $entry = new Entry(new User());
162 $proxy->updateEntry($entry, 'http://0.0.0.0');
152 163
153 $this->assertEquals('http://1.1.1.1', $entry->getUrl()); 164 $this->assertSame('http://1.1.1.1', $entry->getUrl());
154 $this->assertEquals('this is my title', $entry->getTitle()); 165 $this->assertSame('this is my title', $entry->getTitle());
155 $this->assertContains('this is my content', $entry->getContent()); 166 $this->assertContains('this is my content', $entry->getContent());
156 $this->assertEquals('http://3.3.3.3/cover.jpg', $entry->getPreviewPicture()); 167 $this->assertSame('http://3.3.3.3/cover.jpg', $entry->getPreviewPicture());
157 $this->assertEquals('text/html', $entry->getMimetype()); 168 $this->assertSame('text/html', $entry->getMimetype());
158 $this->assertEquals('fr', $entry->getLanguage()); 169 $this->assertSame('fr', $entry->getLanguage());
159 $this->assertEquals('200', $entry->getHttpStatus()); 170 $this->assertSame('200', $entry->getHttpStatus());
160 $this->assertEquals(4.0, $entry->getReadingTime()); 171 $this->assertSame(4.0, $entry->getReadingTime());
161 $this->assertEquals('1.1.1.1', $entry->getDomainName()); 172 $this->assertSame('1.1.1.1', $entry->getDomainName());
162 } 173 }
163 174
164 public function testWithContentAndNoOgImage() 175 public function testWithContentAndNoOgImage()
@@ -184,205 +195,359 @@ class ContentProxyTest extends \PHPUnit_Framework_TestCase
184 'open_graph' => [ 195 'open_graph' => [
185 'og_title' => 'my OG title', 196 'og_title' => 'my OG title',
186 'og_description' => 'OG desc', 197 'og_description' => 'OG desc',
187 'og_image' => false, 198 'og_image' => null,
188 ], 199 ],
189 ]); 200 ]);
190 201
191 $proxy = new ContentProxy($graby, $tagger, $this->getTagRepositoryMock(), $this->getLogger(), $this->fetchingErrorMessage); 202 $proxy = new ContentProxy($graby, $tagger, $this->getValidator(), $this->getLogger(), $this->fetchingErrorMessage);
192 $entry = $proxy->updateEntry(new Entry(new User()), 'http://0.0.0.0'); 203 $entry = new Entry(new User());
204 $proxy->updateEntry($entry, 'http://0.0.0.0');
193 205
194 $this->assertEquals('http://1.1.1.1', $entry->getUrl()); 206 $this->assertSame('http://1.1.1.1', $entry->getUrl());
195 $this->assertEquals('this is my title', $entry->getTitle()); 207 $this->assertSame('this is my title', $entry->getTitle());
196 $this->assertContains('this is my content', $entry->getContent()); 208 $this->assertContains('this is my content', $entry->getContent());
197 $this->assertNull($entry->getPreviewPicture()); 209 $this->assertNull($entry->getPreviewPicture());
198 $this->assertEquals('text/html', $entry->getMimetype()); 210 $this->assertSame('text/html', $entry->getMimetype());
199 $this->assertEquals('fr', $entry->getLanguage()); 211 $this->assertSame('fr', $entry->getLanguage());
200 $this->assertEquals('200', $entry->getHttpStatus()); 212 $this->assertSame('200', $entry->getHttpStatus());
201 $this->assertEquals(4.0, $entry->getReadingTime()); 213 $this->assertSame(4.0, $entry->getReadingTime());
202 $this->assertEquals('1.1.1.1', $entry->getDomainName()); 214 $this->assertSame('1.1.1.1', $entry->getDomainName());
203 } 215 }
204 216
205 public function testWithForcedContent() 217 public function testWithContentAndBadLanguage()
206 { 218 {
207 $tagger = $this->getTaggerMock(); 219 $tagger = $this->getTaggerMock();
208 $tagger->expects($this->once()) 220 $tagger->expects($this->once())
209 ->method('tag'); 221 ->method('tag');
210 222
211 $graby = $this->getMockBuilder('Graby\Graby')->getMock(); 223 $validator = $this->getValidator();
212 224 $validator->expects($this->once())
213 $proxy = new ContentProxy($graby, $tagger, $this->getTagRepositoryMock(), $this->getLogger(), $this->fetchingErrorMessage); 225 ->method('validate')
214 $entry = $proxy->updateEntry(new Entry(new User()), 'http://0.0.0.0', [ 226 ->willReturn(new ConstraintViolationList([new ConstraintViolation('oops', 'oops', [], 'oops', 'language', 'dontexist')]));
215 'html' => str_repeat('this is my content', 325),
216 'title' => 'this is my title',
217 'url' => 'http://1.1.1.1',
218 'content_type' => 'text/html',
219 'language' => 'fr',
220 ]);
221
222 $this->assertEquals('http://1.1.1.1', $entry->getUrl());
223 $this->assertEquals('this is my title', $entry->getTitle());
224 $this->assertContains('this is my content', $entry->getContent());
225 $this->assertEquals('text/html', $entry->getMimetype());
226 $this->assertEquals('fr', $entry->getLanguage());
227 $this->assertEquals(4.0, $entry->getReadingTime());
228 $this->assertEquals('1.1.1.1', $entry->getDomainName());
229 }
230 227
231 public function testTaggerThrowException()
232 {
233 $graby = $this->getMockBuilder('Graby\Graby') 228 $graby = $this->getMockBuilder('Graby\Graby')
229 ->setMethods(['fetchContent'])
234 ->disableOriginalConstructor() 230 ->disableOriginalConstructor()
235 ->getMock(); 231 ->getMock();
236 232
237 $tagger = $this->getTaggerMock(); 233 $graby->expects($this->any())
238 $tagger->expects($this->once()) 234 ->method('fetchContent')
239 ->method('tag') 235 ->willReturn([
240 ->will($this->throwException(new \Exception())); 236 'html' => str_repeat('this is my content', 325),
241 237 'title' => 'this is my title',
242 $tagRepo = $this->getTagRepositoryMock(); 238 'url' => 'http://1.1.1.1',
243 $proxy = new ContentProxy($graby, $tagger, $tagRepo, $this->getLogger(), $this->fetchingErrorMessage); 239 'content_type' => 'text/html',
240 'language' => 'dontexist',
241 'status' => '200',
242 ]);
244 243
245 $entry = $proxy->updateEntry(new Entry(new User()), 'http://0.0.0.0', [ 244 $proxy = new ContentProxy($graby, $tagger, $validator, $this->getLogger(), $this->fetchingErrorMessage);
246 'html' => str_repeat('this is my content', 325), 245 $entry = new Entry(new User());
247 'title' => 'this is my title', 246 $proxy->updateEntry($entry, 'http://0.0.0.0');
248 'url' => 'http://1.1.1.1',
249 'content_type' => 'text/html',
250 'language' => 'fr',
251 ]);
252 247
253 $this->assertCount(0, $entry->getTags()); 248 $this->assertSame('http://1.1.1.1', $entry->getUrl());
249 $this->assertSame('this is my title', $entry->getTitle());
250 $this->assertContains('this is my content', $entry->getContent());
251 $this->assertSame('text/html', $entry->getMimetype());
252 $this->assertNull($entry->getLanguage());
253 $this->assertSame('200', $entry->getHttpStatus());
254 $this->assertSame(4.0, $entry->getReadingTime());
255 $this->assertSame('1.1.1.1', $entry->getDomainName());
254 } 256 }
255 257
256 public function testAssignTagsWithArrayAndExtraSpaces() 258 public function testWithContentAndBadOgImage()
257 { 259 {
260 $tagger = $this->getTaggerMock();
261 $tagger->expects($this->once())
262 ->method('tag');
263
264 $validator = $this->getValidator();
265 $validator->expects($this->exactly(2))
266 ->method('validate')
267 ->will($this->onConsecutiveCalls(
268 new ConstraintViolationList(),
269 new ConstraintViolationList([new ConstraintViolation('oops', 'oops', [], 'oops', 'url', 'https://')])
270 ));
271
258 $graby = $this->getMockBuilder('Graby\Graby') 272 $graby = $this->getMockBuilder('Graby\Graby')
273 ->setMethods(['fetchContent'])
259 ->disableOriginalConstructor() 274 ->disableOriginalConstructor()
260 ->getMock(); 275 ->getMock();
261 276
262 $tagRepo = $this->getTagRepositoryMock(); 277 $graby->expects($this->any())
263 $proxy = new ContentProxy($graby, $this->getTaggerMock(), $tagRepo, $this->getLogger(), $this->fetchingErrorMessage); 278 ->method('fetchContent')
279 ->willReturn([
280 'html' => str_repeat('this is my content', 325),
281 'title' => 'this is my title',
282 'url' => 'http://1.1.1.1',
283 'content_type' => 'text/html',
284 'language' => 'fr',
285 'status' => '200',
286 'open_graph' => [
287 'og_title' => 'my OG title',
288 'og_description' => 'OG desc',
289 'og_image' => 'https://',
290 ],
291 ]);
264 292
293 $proxy = new ContentProxy($graby, $tagger, $validator, $this->getLogger(), $this->fetchingErrorMessage);
265 $entry = new Entry(new User()); 294 $entry = new Entry(new User());
295 $proxy->updateEntry($entry, 'http://0.0.0.0');
266 296
267 $proxy->assignTagsToEntry($entry, [' tag1', 'tag2 ']); 297 $this->assertSame('http://1.1.1.1', $entry->getUrl());
268 298 $this->assertSame('this is my title', $entry->getTitle());
269 $this->assertCount(2, $entry->getTags()); 299 $this->assertContains('this is my content', $entry->getContent());
270 $this->assertEquals('tag1', $entry->getTags()[0]->getLabel()); 300 $this->assertNull($entry->getPreviewPicture());
271 $this->assertEquals('tag2', $entry->getTags()[1]->getLabel()); 301 $this->assertSame('text/html', $entry->getMimetype());
302 $this->assertSame('fr', $entry->getLanguage());
303 $this->assertSame('200', $entry->getHttpStatus());
304 $this->assertSame(4.0, $entry->getReadingTime());
305 $this->assertSame('1.1.1.1', $entry->getDomainName());
272 } 306 }
273 307
274 public function testAssignTagsWithString() 308 public function testWithForcedContent()
275 { 309 {
276 $graby = $this->getMockBuilder('Graby\Graby') 310 $tagger = $this->getTaggerMock();
277 ->disableOriginalConstructor() 311 $tagger->expects($this->once())
278 ->getMock(); 312 ->method('tag');
279
280 $tagRepo = $this->getTagRepositoryMock();
281 $proxy = new ContentProxy($graby, $this->getTaggerMock(), $tagRepo, $this->getLogger(), $this->fetchingErrorMessage);
282 313
314 $proxy = new ContentProxy((new Graby()), $tagger, $this->getValidator(), $this->getLogger(), $this->fetchingErrorMessage);
283 $entry = new Entry(new User()); 315 $entry = new Entry(new User());
316 $proxy->updateEntry(
317 $entry,
318 'http://0.0.0.0',
319 [
320 'html' => str_repeat('this is my content', 325),
321 'title' => 'this is my title',
322 'url' => 'http://1.1.1.1',
323 'content_type' => 'text/html',
324 'language' => 'fr',
325 'date' => '1395635872',
326 'authors' => ['Jeremy', 'Nico', 'Thomas'],
327 'all_headers' => [
328 'Cache-Control' => 'no-cache',
329 ],
330 ]
331 );
284 332
285 $proxy->assignTagsToEntry($entry, 'tag1, tag2'); 333 $this->assertSame('http://1.1.1.1', $entry->getUrl());
286 334 $this->assertSame('this is my title', $entry->getTitle());
287 $this->assertCount(2, $entry->getTags()); 335 $this->assertContains('this is my content', $entry->getContent());
288 $this->assertEquals('tag1', $entry->getTags()[0]->getLabel()); 336 $this->assertSame('text/html', $entry->getMimetype());
289 $this->assertEquals('tag2', $entry->getTags()[1]->getLabel()); 337 $this->assertSame('fr', $entry->getLanguage());
338 $this->assertSame(4.0, $entry->getReadingTime());
339 $this->assertSame('1.1.1.1', $entry->getDomainName());
340 $this->assertSame('24/03/2014', $entry->getPublishedAt()->format('d/m/Y'));
341 $this->assertContains('Jeremy', $entry->getPublishedBy());
342 $this->assertContains('Nico', $entry->getPublishedBy());
343 $this->assertContains('Thomas', $entry->getPublishedBy());
344 $this->assertContains('no-cache', $entry->getHeaders());
290 } 345 }
291 346
292 public function testAssignTagsWithEmptyArray() 347 public function testWithForcedContentAndDatetime()
293 { 348 {
294 $graby = $this->getMockBuilder('Graby\Graby') 349 $tagger = $this->getTaggerMock();
295 ->disableOriginalConstructor() 350 $tagger->expects($this->once())
296 ->getMock(); 351 ->method('tag');
297 352
298 $tagRepo = $this->getTagRepositoryMock(); 353 $logHandler = new TestHandler();
299 $proxy = new ContentProxy($graby, $this->getTaggerMock(), $tagRepo, $this->getLogger(), $this->fetchingErrorMessage); 354 $logger = new Logger('test', [$logHandler]);
300 355
356 $proxy = new ContentProxy((new Graby()), $tagger, $this->getValidator(), $logger, $this->fetchingErrorMessage);
301 $entry = new Entry(new User()); 357 $entry = new Entry(new User());
358 $proxy->updateEntry(
359 $entry,
360 'http://1.1.1.1',
361 [
362 'html' => str_repeat('this is my content', 325),
363 'title' => 'this is my title',
364 'url' => 'http://1.1.1.1',
365 'content_type' => 'text/html',
366 'language' => 'fr',
367 'date' => '2016-09-08T11:55:58+0200',
368 ]
369 );
302 370
303 $proxy->assignTagsToEntry($entry, []); 371 $this->assertSame('http://1.1.1.1', $entry->getUrl());
304 372 $this->assertSame('this is my title', $entry->getTitle());
305 $this->assertCount(0, $entry->getTags()); 373 $this->assertContains('this is my content', $entry->getContent());
374 $this->assertSame('text/html', $entry->getMimetype());
375 $this->assertSame('fr', $entry->getLanguage());
376 $this->assertSame(4.0, $entry->getReadingTime());
377 $this->assertSame('1.1.1.1', $entry->getDomainName());
378 $this->assertSame('08/09/2016', $entry->getPublishedAt()->format('d/m/Y'));
306 } 379 }
307 380
308 public function testAssignTagsWithEmptyString() 381 public function testWithForcedContentAndBadDate()
309 { 382 {
310 $graby = $this->getMockBuilder('Graby\Graby') 383 $tagger = $this->getTaggerMock();
311 ->disableOriginalConstructor() 384 $tagger->expects($this->once())
312 ->getMock(); 385 ->method('tag');
313 386
314 $tagRepo = $this->getTagRepositoryMock(); 387 $logger = new Logger('foo');
315 $proxy = new ContentProxy($graby, $this->getTaggerMock(), $tagRepo, $this->getLogger(), $this->fetchingErrorMessage); 388 $handler = new TestHandler();
389 $logger->pushHandler($handler);
316 390
391 $proxy = new ContentProxy((new Graby()), $tagger, $this->getValidator(), $logger, $this->fetchingErrorMessage);
317 $entry = new Entry(new User()); 392 $entry = new Entry(new User());
393 $proxy->updateEntry(
394 $entry,
395 'http://1.1.1.1',
396 [
397 'html' => str_repeat('this is my content', 325),
398 'title' => 'this is my title',
399 'url' => 'http://1.1.1.1',
400 'content_type' => 'text/html',
401 'language' => 'fr',
402 'date' => '01 02 2012',
403 ]
404 );
318 405
319 $proxy->assignTagsToEntry($entry, ''); 406 $this->assertSame('http://1.1.1.1', $entry->getUrl());
407 $this->assertSame('this is my title', $entry->getTitle());
408 $this->assertContains('this is my content', $entry->getContent());
409 $this->assertSame('text/html', $entry->getMimetype());
410 $this->assertSame('fr', $entry->getLanguage());
411 $this->assertSame(4.0, $entry->getReadingTime());
412 $this->assertSame('1.1.1.1', $entry->getDomainName());
413 $this->assertNull($entry->getPublishedAt());
320 414
321 $this->assertCount(0, $entry->getTags()); 415 $records = $handler->getRecords();
416
417 $this->assertCount(1, $records);
418 $this->assertContains('Error while defining date', $records[0]['message']);
322 } 419 }
323 420
324 public function testAssignTagsAlreadyAssigned() 421 public function testTaggerThrowException()
325 { 422 {
326 $graby = $this->getMockBuilder('Graby\Graby') 423 $tagger = $this->getTaggerMock();
327 ->disableOriginalConstructor() 424 $tagger->expects($this->once())
328 ->getMock(); 425 ->method('tag')
426 ->will($this->throwException(new \Exception()));
329 427
330 $tagRepo = $this->getTagRepositoryMock(); 428 $proxy = new ContentProxy((new Graby()), $tagger, $this->getValidator(), $this->getLogger(), $this->fetchingErrorMessage);
331 $proxy = new ContentProxy($graby, $this->getTaggerMock(), $tagRepo, $this->getLogger(), $this->fetchingErrorMessage); 429 $entry = new Entry(new User());
430 $proxy->updateEntry(
431 $entry,
432 'http://1.1.1.1',
433 [
434 'html' => str_repeat('this is my content', 325),
435 'title' => 'this is my title',
436 'url' => 'http://1.1.1.1',
437 'content_type' => 'text/html',
438 'language' => 'fr',
439 ]
440 );
332 441
333 $tagEntity = new Tag(); 442 $this->assertCount(0, $entry->getTags());
334 $tagEntity->setLabel('tag1'); 443 }
335 444
336 $entry = new Entry(new User()); 445 public function dataForCrazyHtml()
337 $entry->addTag($tagEntity); 446 {
447 return [
448 'script and comment' => [
449 '<strong>Script inside:</strong> <!--[if gte IE 4]><script>alert(\'lol\');</script><![endif]--><br />',
450 'lol',
451 ],
452 'script' => [
453 '<strong>Script inside:</strong><script>alert(\'lol\');</script>',
454 'script',
455 ],
456 ];
457 }
338 458
339 $proxy->assignTagsToEntry($entry, 'tag1, tag2'); 459 /**
460 * @dataProvider dataForCrazyHtml
461 */
462 public function testWithCrazyHtmlContent($html, $escapedString)
463 {
464 $tagger = $this->getTaggerMock();
465 $tagger->expects($this->once())
466 ->method('tag');
340 467
341 $this->assertCount(2, $entry->getTags()); 468 $proxy = new ContentProxy((new Graby()), $tagger, $this->getValidator(), $this->getLogger(), $this->fetchingErrorMessage);
342 $this->assertEquals('tag1', $entry->getTags()[0]->getLabel()); 469 $entry = new Entry(new User());
343 $this->assertEquals('tag2', $entry->getTags()[1]->getLabel()); 470 $proxy->updateEntry(
471 $entry,
472 'http://1.1.1.1',
473 [
474 'html' => $html,
475 'title' => 'this is my title',
476 'url' => 'http://1.1.1.1',
477 'content_type' => 'text/html',
478 'language' => 'fr',
479 'status' => '200',
480 'open_graph' => [
481 'og_title' => 'my OG title',
482 'og_description' => 'OG desc',
483 'og_image' => 'http://3.3.3.3/cover.jpg',
484 ],
485 ]
486 );
487
488 $this->assertSame('http://1.1.1.1', $entry->getUrl());
489 $this->assertSame('this is my title', $entry->getTitle());
490 $this->assertNotContains($escapedString, $entry->getContent());
491 $this->assertSame('http://3.3.3.3/cover.jpg', $entry->getPreviewPicture());
492 $this->assertSame('text/html', $entry->getMimetype());
493 $this->assertSame('fr', $entry->getLanguage());
494 $this->assertSame('200', $entry->getHttpStatus());
495 $this->assertSame('1.1.1.1', $entry->getDomainName());
344 } 496 }
345 497
346 public function testAssignTagsNotFlushed() 498 public function testWithImageAsContent()
347 { 499 {
500 $tagger = $this->getTaggerMock();
501 $tagger->expects($this->once())
502 ->method('tag');
503
348 $graby = $this->getMockBuilder('Graby\Graby') 504 $graby = $this->getMockBuilder('Graby\Graby')
505 ->setMethods(['fetchContent'])
349 ->disableOriginalConstructor() 506 ->disableOriginalConstructor()
350 ->getMock(); 507 ->getMock();
351 508
352 $tagRepo = $this->getTagRepositoryMock(); 509 $graby->expects($this->any())
353 $tagRepo->expects($this->never()) 510 ->method('fetchContent')
354 ->method('__call'); 511 ->willReturn([
355 512 'html' => '<p><img src="http://1.1.1.1/image.jpg" /></p>',
356 $proxy = new ContentProxy($graby, $this->getTaggerMock(), $tagRepo, $this->getLogger(), $this->fetchingErrorMessage); 513 'title' => 'this is my title',
357 514 'url' => 'http://1.1.1.1/image.jpg',
358 $tagEntity = new Tag(); 515 'content_type' => 'image/jpeg',
359 $tagEntity->setLabel('tag1'); 516 'status' => '200',
517 'open_graph' => [],
518 ]);
360 519
520 $proxy = new ContentProxy($graby, $tagger, $this->getValidator(), $this->getLogger(), $this->fetchingErrorMessage);
361 $entry = new Entry(new User()); 521 $entry = new Entry(new User());
362 522 $proxy->updateEntry($entry, 'http://0.0.0.0');
363 $proxy->assignTagsToEntry($entry, 'tag1', [$tagEntity]); 523
364 524 $this->assertSame('http://1.1.1.1/image.jpg', $entry->getUrl());
365 $this->assertCount(1, $entry->getTags()); 525 $this->assertSame('this is my title', $entry->getTitle());
366 $this->assertEquals('tag1', $entry->getTags()[0]->getLabel()); 526 $this->assertContains('http://1.1.1.1/image.jpg', $entry->getContent());
527 $this->assertSame('http://1.1.1.1/image.jpg', $entry->getPreviewPicture());
528 $this->assertSame('image/jpeg', $entry->getMimetype());
529 $this->assertSame('200', $entry->getHttpStatus());
530 $this->assertSame('1.1.1.1', $entry->getDomainName());
367 } 531 }
368 532
369 private function getTaggerMock() 533 private function getTaggerMock()
370 { 534 {
371 return $this->getMockBuilder('Wallabag\CoreBundle\Helper\RuleBasedTagger') 535 return $this->getMockBuilder(RuleBasedTagger::class)
372 ->setMethods(['tag']) 536 ->setMethods(['tag'])
373 ->disableOriginalConstructor() 537 ->disableOriginalConstructor()
374 ->getMock(); 538 ->getMock();
375 } 539 }
376 540
377 private function getTagRepositoryMock() 541 private function getLogger()
378 { 542 {
379 return $this->getMockBuilder('Wallabag\CoreBundle\Repository\TagRepository') 543 return new NullLogger();
380 ->disableOriginalConstructor()
381 ->getMock();
382 } 544 }
383 545
384 private function getLogger() 546 private function getValidator()
385 { 547 {
386 return new NullLogger(); 548 return $this->getMockBuilder(RecursiveValidator::class)
549 ->setMethods(['validate'])
550 ->disableOriginalConstructor()
551 ->getMock();
387 } 552 }
388} 553}