diff options
Diffstat (limited to 'src/Wallabag/CoreBundle/Tests')
5 files changed, 341 insertions, 3 deletions
diff --git a/src/Wallabag/CoreBundle/Tests/Controller/ConfigControllerTest.php b/src/Wallabag/CoreBundle/Tests/Controller/ConfigControllerTest.php index 7085151a..7b32354f 100644 --- a/src/Wallabag/CoreBundle/Tests/Controller/ConfigControllerTest.php +++ b/src/Wallabag/CoreBundle/Tests/Controller/ConfigControllerTest.php | |||
@@ -479,4 +479,59 @@ class ConfigControllerTest extends WallabagCoreTestCase | |||
479 | $this->assertGreaterThan(1, $alert = $crawler->filter('body')->extract(array('_text'))); | 479 | $this->assertGreaterThan(1, $alert = $crawler->filter('body')->extract(array('_text'))); |
480 | $this->assertContains($expectedMessage, $alert[0]); | 480 | $this->assertContains($expectedMessage, $alert[0]); |
481 | } | 481 | } |
482 | |||
483 | public function testTaggingRuleCreation() | ||
484 | { | ||
485 | $this->logInAs('admin'); | ||
486 | $client = $this->getClient(); | ||
487 | |||
488 | $crawler = $client->request('GET', '/config'); | ||
489 | |||
490 | $this->assertTrue($client->getResponse()->isSuccessful()); | ||
491 | |||
492 | $form = $crawler->filter('button[id=tagging_rule_save]')->form(); | ||
493 | |||
494 | $data = array( | ||
495 | 'tagging_rule[rule]' => 'readingTime <= 3', | ||
496 | 'tagging_rule[tags]' => 'short reading', | ||
497 | ); | ||
498 | |||
499 | $client->submit($form, $data); | ||
500 | |||
501 | $this->assertEquals(302, $client->getResponse()->getStatusCode()); | ||
502 | |||
503 | $crawler = $client->followRedirect(); | ||
504 | |||
505 | $this->assertGreaterThan(1, $alert = $crawler->filter('div.messages.success')->extract(array('_text'))); | ||
506 | $this->assertContains('Tagging rules updated', $alert[0]); | ||
507 | |||
508 | $deleteLink = $crawler->filter('.delete')->last()->link(); | ||
509 | |||
510 | $crawler = $client->click($deleteLink); | ||
511 | $this->assertEquals(302, $client->getResponse()->getStatusCode()); | ||
512 | |||
513 | $crawler = $client->followRedirect(); | ||
514 | $this->assertGreaterThan(1, $alert = $crawler->filter('div.messages.success')->extract(array('_text'))); | ||
515 | $this->assertContains('Tagging rule deleted', $alert[0]); | ||
516 | } | ||
517 | |||
518 | public function dataForTaggingRuleFailed() | ||
519 | { | ||
520 | return array( | ||
521 | array( | ||
522 | array( | ||
523 | 'rss_config[rule]' => 'unknownVar <= 3', | ||
524 | 'rss_config[tags]' => 'cool tag', | ||
525 | ), | ||
526 | 'The variable « unknownVar » does not exist.', | ||
527 | ), | ||
528 | array( | ||
529 | array( | ||
530 | 'rss_config[rule]' => 'length(domainName) <= 42', | ||
531 | 'rss_config[tags]' => 'cool tag', | ||
532 | ), | ||
533 | 'The operator « length » does not exist.', | ||
534 | ), | ||
535 | ); | ||
536 | } | ||
482 | } | 537 | } |
diff --git a/src/Wallabag/CoreBundle/Tests/Controller/EntryControllerTest.php b/src/Wallabag/CoreBundle/Tests/Controller/EntryControllerTest.php index 56b4c9e4..af62aee8 100644 --- a/src/Wallabag/CoreBundle/Tests/Controller/EntryControllerTest.php +++ b/src/Wallabag/CoreBundle/Tests/Controller/EntryControllerTest.php | |||
@@ -102,6 +102,44 @@ class EntryControllerTest extends WallabagCoreTestCase | |||
102 | $this->assertContains('Google', $alert[0]); | 102 | $this->assertContains('Google', $alert[0]); |
103 | } | 103 | } |
104 | 104 | ||
105 | /** | ||
106 | * This test will require an internet connection. | ||
107 | */ | ||
108 | public function testPostNewThatWillBeTaggued() | ||
109 | { | ||
110 | $this->logInAs('admin'); | ||
111 | $client = $this->getClient(); | ||
112 | |||
113 | $crawler = $client->request('GET', '/new'); | ||
114 | |||
115 | $this->assertEquals(200, $client->getResponse()->getStatusCode()); | ||
116 | |||
117 | $form = $crawler->filter('button[type=submit]')->form(); | ||
118 | |||
119 | $data = array( | ||
120 | 'entry[url]' => $url = 'https://github.com/wallabag/wallabag', | ||
121 | ); | ||
122 | |||
123 | $client->submit($form, $data); | ||
124 | |||
125 | $this->assertEquals(302, $client->getResponse()->getStatusCode()); | ||
126 | |||
127 | $crawler = $client->followRedirect(); | ||
128 | |||
129 | $em = $client->getContainer() | ||
130 | ->get('doctrine.orm.entity_manager'); | ||
131 | $entry = $em | ||
132 | ->getRepository('WallabagCoreBundle:Entry') | ||
133 | ->findOneByUrl($url); | ||
134 | $tags = $entry->getTags(); | ||
135 | |||
136 | $this->assertCount(1, $tags); | ||
137 | $this->assertEquals('wallabag', $tags[0]->getLabel()); | ||
138 | |||
139 | $em->remove($entry); | ||
140 | $em->flush(); | ||
141 | } | ||
142 | |||
105 | public function testArchive() | 143 | public function testArchive() |
106 | { | 144 | { |
107 | $this->logInAs('admin'); | 145 | $this->logInAs('admin'); |
diff --git a/src/Wallabag/CoreBundle/Tests/Form/DataTransformer/StringToListTransformerTest.php b/src/Wallabag/CoreBundle/Tests/Form/DataTransformer/StringToListTransformerTest.php new file mode 100644 index 00000000..d114e5f3 --- /dev/null +++ b/src/Wallabag/CoreBundle/Tests/Form/DataTransformer/StringToListTransformerTest.php | |||
@@ -0,0 +1,50 @@ | |||
1 | <?php | ||
2 | |||
3 | namespace Wallabag\CoreBundle\Tests\Form\DataTransformer; | ||
4 | |||
5 | use Wallabag\CoreBundle\Form\DataTransformer\StringToListTransformer; | ||
6 | |||
7 | class StringToListTransformerTest extends \PHPUnit_Framework_TestCase | ||
8 | { | ||
9 | /** | ||
10 | * @dataProvider transformProvider | ||
11 | */ | ||
12 | public function testTransformWithValidData($inputData, $expectedResult) | ||
13 | { | ||
14 | $transformer = new StringToListTransformer(); | ||
15 | |||
16 | $this->assertSame($expectedResult, $transformer->transform($inputData)); | ||
17 | } | ||
18 | |||
19 | public function transformProvider() | ||
20 | { | ||
21 | return array( | ||
22 | array( null, '' ), | ||
23 | array( array(), '' ), | ||
24 | array( array('single value'), 'single value' ), | ||
25 | array( array('first value', 'second value'), 'first value,second value' ), | ||
26 | ); | ||
27 | } | ||
28 | |||
29 | /** | ||
30 | * @dataProvider reverseTransformProvider | ||
31 | */ | ||
32 | public function testReverseTransformWithValidData($inputData, $expectedResult) | ||
33 | { | ||
34 | $transformer = new StringToListTransformer(); | ||
35 | |||
36 | $this->assertSame($expectedResult, $transformer->reverseTransform($inputData)); | ||
37 | } | ||
38 | |||
39 | public function reverseTransformProvider() | ||
40 | { | ||
41 | return array( | ||
42 | array( null, null ), | ||
43 | array( '', array() ), | ||
44 | array( 'single value', array('single value') ), | ||
45 | array( 'first value,second value', array('first value', 'second value') ), | ||
46 | array( 'first value, second value', array('first value', 'second value') ), | ||
47 | array( 'first value, , second value', array('first value', 'second value') ), | ||
48 | ); | ||
49 | } | ||
50 | } | ||
diff --git a/src/Wallabag/CoreBundle/Tests/Helper/ContentProxyTest.php b/src/Wallabag/CoreBundle/Tests/Helper/ContentProxyTest.php index 4bce4708..ef7cbd5b 100644 --- a/src/Wallabag/CoreBundle/Tests/Helper/ContentProxyTest.php +++ b/src/Wallabag/CoreBundle/Tests/Helper/ContentProxyTest.php | |||
@@ -2,6 +2,9 @@ | |||
2 | 2 | ||
3 | namespace Wallabag\CoreBundle\Tests\Helper; | 3 | namespace Wallabag\CoreBundle\Tests\Helper; |
4 | 4 | ||
5 | use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase; | ||
6 | use Psr\Log\NullLogger; | ||
7 | |||
5 | use Wallabag\CoreBundle\Entity\Entry; | 8 | use Wallabag\CoreBundle\Entity\Entry; |
6 | use Wallabag\UserBundle\Entity\User; | 9 | use Wallabag\UserBundle\Entity\User; |
7 | use Wallabag\CoreBundle\Helper\ContentProxy; | 10 | use Wallabag\CoreBundle\Helper\ContentProxy; |
@@ -10,6 +13,10 @@ class ContentProxyTest extends \PHPUnit_Framework_TestCase | |||
10 | { | 13 | { |
11 | public function testWithEmptyContent() | 14 | public function testWithEmptyContent() |
12 | { | 15 | { |
16 | $tagger = $this->getTaggerMock(); | ||
17 | $tagger->expects($this->once()) | ||
18 | ->method('tag'); | ||
19 | |||
13 | $graby = $this->getMockBuilder('Graby\Graby') | 20 | $graby = $this->getMockBuilder('Graby\Graby') |
14 | ->setMethods(array('fetchContent')) | 21 | ->setMethods(array('fetchContent')) |
15 | ->disableOriginalConstructor() | 22 | ->disableOriginalConstructor() |
@@ -25,7 +32,7 @@ class ContentProxyTest extends \PHPUnit_Framework_TestCase | |||
25 | 'language' => '', | 32 | 'language' => '', |
26 | )); | 33 | )); |
27 | 34 | ||
28 | $proxy = new ContentProxy($graby); | 35 | $proxy = new ContentProxy($graby, $tagger, $this->getLogger()); |
29 | $entry = $proxy->updateEntry(new Entry(new User()), 'http://0.0.0.0'); | 36 | $entry = $proxy->updateEntry(new Entry(new User()), 'http://0.0.0.0'); |
30 | 37 | ||
31 | $this->assertEquals('http://0.0.0.0', $entry->getUrl()); | 38 | $this->assertEquals('http://0.0.0.0', $entry->getUrl()); |
@@ -40,6 +47,10 @@ class ContentProxyTest extends \PHPUnit_Framework_TestCase | |||
40 | 47 | ||
41 | public function testWithEmptyContentButOG() | 48 | public function testWithEmptyContentButOG() |
42 | { | 49 | { |
50 | $tagger = $this->getTaggerMock(); | ||
51 | $tagger->expects($this->once()) | ||
52 | ->method('tag'); | ||
53 | |||
43 | $graby = $this->getMockBuilder('Graby\Graby') | 54 | $graby = $this->getMockBuilder('Graby\Graby') |
44 | ->setMethods(array('fetchContent')) | 55 | ->setMethods(array('fetchContent')) |
45 | ->disableOriginalConstructor() | 56 | ->disableOriginalConstructor() |
@@ -59,7 +70,7 @@ class ContentProxyTest extends \PHPUnit_Framework_TestCase | |||
59 | ), | 70 | ), |
60 | )); | 71 | )); |
61 | 72 | ||
62 | $proxy = new ContentProxy($graby); | 73 | $proxy = new ContentProxy($graby, $tagger, $this->getLogger()); |
63 | $entry = $proxy->updateEntry(new Entry(new User()), 'http://domain.io'); | 74 | $entry = $proxy->updateEntry(new Entry(new User()), 'http://domain.io'); |
64 | 75 | ||
65 | $this->assertEquals('http://domain.io', $entry->getUrl()); | 76 | $this->assertEquals('http://domain.io', $entry->getUrl()); |
@@ -74,6 +85,10 @@ class ContentProxyTest extends \PHPUnit_Framework_TestCase | |||
74 | 85 | ||
75 | public function testWithContent() | 86 | public function testWithContent() |
76 | { | 87 | { |
88 | $tagger = $this->getTaggerMock(); | ||
89 | $tagger->expects($this->once()) | ||
90 | ->method('tag'); | ||
91 | |||
77 | $graby = $this->getMockBuilder('Graby\Graby') | 92 | $graby = $this->getMockBuilder('Graby\Graby') |
78 | ->setMethods(array('fetchContent')) | 93 | ->setMethods(array('fetchContent')) |
79 | ->disableOriginalConstructor() | 94 | ->disableOriginalConstructor() |
@@ -94,7 +109,7 @@ class ContentProxyTest extends \PHPUnit_Framework_TestCase | |||
94 | ), | 109 | ), |
95 | )); | 110 | )); |
96 | 111 | ||
97 | $proxy = new ContentProxy($graby); | 112 | $proxy = new ContentProxy($graby, $tagger, $this->getLogger()); |
98 | $entry = $proxy->updateEntry(new Entry(new User()), 'http://0.0.0.0'); | 113 | $entry = $proxy->updateEntry(new Entry(new User()), 'http://0.0.0.0'); |
99 | 114 | ||
100 | $this->assertEquals('http://1.1.1.1', $entry->getUrl()); | 115 | $this->assertEquals('http://1.1.1.1', $entry->getUrl()); |
@@ -106,4 +121,17 @@ class ContentProxyTest extends \PHPUnit_Framework_TestCase | |||
106 | $this->assertEquals(4.0, $entry->getReadingTime()); | 121 | $this->assertEquals(4.0, $entry->getReadingTime()); |
107 | $this->assertEquals('1.1.1.1', $entry->getDomainName()); | 122 | $this->assertEquals('1.1.1.1', $entry->getDomainName()); |
108 | } | 123 | } |
124 | |||
125 | private function getTaggerMock() | ||
126 | { | ||
127 | return $this->getMockBuilder('Wallabag\CoreBundle\Helper\RuleBasedTagger') | ||
128 | ->setMethods(array('tag')) | ||
129 | ->disableOriginalConstructor() | ||
130 | ->getMock(); | ||
131 | } | ||
132 | |||
133 | private function getLogger() | ||
134 | { | ||
135 | return new NullLogger(); | ||
136 | } | ||
109 | } | 137 | } |
diff --git a/src/Wallabag/CoreBundle/Tests/Helper/RuleBasedTaggerTest.php b/src/Wallabag/CoreBundle/Tests/Helper/RuleBasedTaggerTest.php new file mode 100644 index 00000000..5180f7dd --- /dev/null +++ b/src/Wallabag/CoreBundle/Tests/Helper/RuleBasedTaggerTest.php | |||
@@ -0,0 +1,167 @@ | |||
1 | <?php | ||
2 | |||
3 | namespace Wallabag\CoreBundle\Tests\Helper; | ||
4 | |||
5 | use Wallabag\CoreBundle\Entity\Config; | ||
6 | use Wallabag\CoreBundle\Entity\Entry; | ||
7 | use Wallabag\CoreBundle\Entity\Tag; | ||
8 | use Wallabag\CoreBundle\Entity\TaggingRule; | ||
9 | use Wallabag\UserBundle\Entity\User; | ||
10 | use Wallabag\CoreBundle\Helper\RuleBasedTagger; | ||
11 | |||
12 | class RuleBasedTaggerTest extends \PHPUnit_Framework_TestCase | ||
13 | { | ||
14 | private $rulerz; | ||
15 | private $tagRepository; | ||
16 | private $entryRepository; | ||
17 | private $tagger; | ||
18 | |||
19 | public function setUp() | ||
20 | { | ||
21 | $this->rulerz = $this->getRulerZMock(); | ||
22 | $this->tagRepository = $this->getTagRepositoryMock(); | ||
23 | $this->entryRepository = $this->getEntryRepositoryMock(); | ||
24 | |||
25 | $this->tagger = new RuleBasedTagger($this->rulerz, $this->tagRepository, $this->entryRepository); | ||
26 | } | ||
27 | |||
28 | public function testTagWithNoRule() | ||
29 | { | ||
30 | $entry = new Entry($this->getUser()); | ||
31 | |||
32 | $this->tagger->tag($entry); | ||
33 | |||
34 | $this->assertTrue($entry->getTags()->isEmpty()); | ||
35 | } | ||
36 | |||
37 | public function testTagWithNoMatchingRule() | ||
38 | { | ||
39 | $taggingRule = $this->getTaggingRule('rule as string', array('foo', 'bar')); | ||
40 | $user = $this->getUser([$taggingRule]); | ||
41 | $entry = new Entry($user); | ||
42 | |||
43 | $this->rulerz | ||
44 | ->expects($this->once()) | ||
45 | ->method('satisfies') | ||
46 | ->with($entry, 'rule as string') | ||
47 | ->willReturn(false); | ||
48 | |||
49 | $this->tagger->tag($entry); | ||
50 | |||
51 | $this->assertTrue($entry->getTags()->isEmpty()); | ||
52 | } | ||
53 | |||
54 | public function testTagWithAMatchingRule() | ||
55 | { | ||
56 | $taggingRule = $this->getTaggingRule('rule as string', array('foo', 'bar')); | ||
57 | $user = $this->getUser([$taggingRule]); | ||
58 | $entry = new Entry($user); | ||
59 | |||
60 | $this->rulerz | ||
61 | ->expects($this->once()) | ||
62 | ->method('satisfies') | ||
63 | ->with($entry, 'rule as string') | ||
64 | ->willReturn(true); | ||
65 | |||
66 | $this->tagger->tag($entry); | ||
67 | |||
68 | $this->assertFalse($entry->getTags()->isEmpty()); | ||
69 | |||
70 | $tags = $entry->getTags(); | ||
71 | $this->assertSame('foo', $tags[0]->getLabel()); | ||
72 | $this->assertSame($user, $tags[0]->getUser()); | ||
73 | $this->assertSame('bar', $tags[1]->getLabel()); | ||
74 | $this->assertSame($user, $tags[1]->getUser()); | ||
75 | } | ||
76 | |||
77 | public function testTagWithAMixOfMatchingRules() | ||
78 | { | ||
79 | $taggingRule = $this->getTaggingRule('bla bla', array('hey')); | ||
80 | $otherTaggingRule = $this->getTaggingRule('rule as string', array('foo')); | ||
81 | |||
82 | $user = $this->getUser([$taggingRule, $otherTaggingRule]); | ||
83 | $entry = new Entry($user); | ||
84 | |||
85 | $this->rulerz | ||
86 | ->method('satisfies') | ||
87 | ->will($this->onConsecutiveCalls(false, true)); | ||
88 | |||
89 | $this->tagger->tag($entry); | ||
90 | |||
91 | $this->assertFalse($entry->getTags()->isEmpty()); | ||
92 | |||
93 | $tags = $entry->getTags(); | ||
94 | $this->assertSame('foo', $tags[0]->getLabel()); | ||
95 | $this->assertSame($user, $tags[0]->getUser()); | ||
96 | } | ||
97 | |||
98 | public function testWhenTheTagExists() | ||
99 | { | ||
100 | $taggingRule = $this->getTaggingRule('rule as string', array('foo')); | ||
101 | $user = $this->getUser([$taggingRule]); | ||
102 | $entry = new Entry($user); | ||
103 | $tag = new Tag($user); | ||
104 | |||
105 | $this->rulerz | ||
106 | ->expects($this->once()) | ||
107 | ->method('satisfies') | ||
108 | ->with($entry, 'rule as string') | ||
109 | ->willReturn(true); | ||
110 | |||
111 | $this->tagRepository | ||
112 | ->expects($this->once()) | ||
113 | ->method('findOneByLabelAndUserId') | ||
114 | ->willReturn($tag); | ||
115 | |||
116 | $this->tagger->tag($entry); | ||
117 | |||
118 | $this->assertFalse($entry->getTags()->isEmpty()); | ||
119 | |||
120 | $tags = $entry->getTags(); | ||
121 | $this->assertSame($tag, $tags[0]); | ||
122 | } | ||
123 | |||
124 | private function getUser(array $taggingRules = []) | ||
125 | { | ||
126 | $user = new User(); | ||
127 | $config = new Config($user); | ||
128 | |||
129 | $user->setConfig($config); | ||
130 | |||
131 | foreach ($taggingRules as $rule) { | ||
132 | $config->addTaggingRule($rule); | ||
133 | } | ||
134 | |||
135 | return $user; | ||
136 | } | ||
137 | |||
138 | private function getTaggingRule($rule, array $tags) | ||
139 | { | ||
140 | $taggingRule = new TaggingRule(); | ||
141 | $taggingRule->setRule($rule); | ||
142 | $taggingRule->setTags($tags); | ||
143 | |||
144 | return $taggingRule; | ||
145 | } | ||
146 | |||
147 | private function getRulerZMock() | ||
148 | { | ||
149 | return $this->getMockBuilder('RulerZ\RulerZ') | ||
150 | ->disableOriginalConstructor() | ||
151 | ->getMock(); | ||
152 | } | ||
153 | |||
154 | private function getTagRepositoryMock() | ||
155 | { | ||
156 | return $this->getMockBuilder('Wallabag\CoreBundle\Repository\TagRepository') | ||
157 | ->disableOriginalConstructor() | ||
158 | ->getMock(); | ||
159 | } | ||
160 | |||
161 | private function getEntryRepositoryMock() | ||
162 | { | ||
163 | return $this->getMockBuilder('Wallabag\CoreBundle\Repository\EntryRepository') | ||
164 | ->disableOriginalConstructor() | ||
165 | ->getMock(); | ||
166 | } | ||
167 | } | ||