diff options
Diffstat (limited to 'src/Wallabag/CoreBundle/Form/Type')
-rw-r--r-- | src/Wallabag/CoreBundle/Form/Type/ConfigType.php | 2 | ||||
-rw-r--r-- | src/Wallabag/CoreBundle/Form/Type/EntryFilterType.php | 24 |
2 files changed, 16 insertions, 10 deletions
diff --git a/src/Wallabag/CoreBundle/Form/Type/ConfigType.php b/src/Wallabag/CoreBundle/Form/Type/ConfigType.php index 4cf22200..74c53bf0 100644 --- a/src/Wallabag/CoreBundle/Form/Type/ConfigType.php +++ b/src/Wallabag/CoreBundle/Form/Type/ConfigType.php | |||
@@ -32,7 +32,6 @@ class ConfigType extends AbstractType | |||
32 | $builder | 32 | $builder |
33 | ->add('theme', ChoiceType::class, [ | 33 | ->add('theme', ChoiceType::class, [ |
34 | 'choices' => array_flip($this->themes), | 34 | 'choices' => array_flip($this->themes), |
35 | 'choices_as_values' => true, | ||
36 | 'label' => 'config.form_settings.theme_label', | 35 | 'label' => 'config.form_settings.theme_label', |
37 | ]) | 36 | ]) |
38 | ->add('items_per_page', null, [ | 37 | ->add('items_per_page', null, [ |
@@ -49,7 +48,6 @@ class ConfigType extends AbstractType | |||
49 | ]) | 48 | ]) |
50 | ->add('language', ChoiceType::class, [ | 49 | ->add('language', ChoiceType::class, [ |
51 | 'choices' => array_flip($this->languages), | 50 | 'choices' => array_flip($this->languages), |
52 | 'choices_as_values' => true, | ||
53 | 'label' => 'config.form_settings.language_label', | 51 | 'label' => 'config.form_settings.language_label', |
54 | ]) | 52 | ]) |
55 | ->add('save', SubmitType::class, [ | 53 | ->add('save', SubmitType::class, [ |
diff --git a/src/Wallabag/CoreBundle/Form/Type/EntryFilterType.php b/src/Wallabag/CoreBundle/Form/Type/EntryFilterType.php index f3f848e9..3c597b5d 100644 --- a/src/Wallabag/CoreBundle/Form/Type/EntryFilterType.php +++ b/src/Wallabag/CoreBundle/Form/Type/EntryFilterType.php | |||
@@ -36,17 +36,26 @@ class EntryFilterType extends AbstractType | |||
36 | $builder | 36 | $builder |
37 | ->add('readingTime', NumberRangeFilterType::class, [ | 37 | ->add('readingTime', NumberRangeFilterType::class, [ |
38 | 'apply_filter' => function (QueryInterface $filterQuery, $field, $values) { | 38 | 'apply_filter' => function (QueryInterface $filterQuery, $field, $values) { |
39 | $value = $values['value']; | 39 | $lower = $values['value']['left_number'][0]; |
40 | $upper = $values['value']['right_number'][0]; | ||
41 | |||
42 | $min = (int) ($lower * $this->user->getConfig()->getReadingSpeed()); | ||
43 | $max = (int) ($upper * $this->user->getConfig()->getReadingSpeed()); | ||
40 | 44 | ||
41 | if (null === $value['left_number'][0] || null === $value['right_number'][0]) { | 45 | if (null === $lower && null === $upper) { |
46 | // no value? no filter | ||
42 | return; | 47 | return; |
48 | } elseif (null === $lower && null !== $upper) { | ||
49 | // only lower value is defined: query all entries with reading LOWER THAN this value | ||
50 | $expression = $filterQuery->getExpr()->lte($field, $max); | ||
51 | } elseif (null !== $lower && null === $upper) { | ||
52 | // only upper value is defined: query all entries with reading GREATER THAN this value | ||
53 | $expression = $filterQuery->getExpr()->gte($field, $min); | ||
54 | } else { | ||
55 | // both value are defined, perform a between | ||
56 | $expression = $filterQuery->getExpr()->between($field, $min, $max); | ||
43 | } | 57 | } |
44 | 58 | ||
45 | $min = (int) ($value['left_number'][0] * $this->user->getConfig()->getReadingSpeed()); | ||
46 | $max = (int) ($value['right_number'][0] * $this->user->getConfig()->getReadingSpeed()); | ||
47 | |||
48 | $expression = $filterQuery->getExpr()->between($field, $min, $max); | ||
49 | |||
50 | return $filterQuery->createCondition($expression); | 59 | return $filterQuery->createCondition($expression); |
51 | }, | 60 | }, |
52 | 'label' => 'entry.filters.reading_time.label', | 61 | 'label' => 'entry.filters.reading_time.label', |
@@ -113,7 +122,6 @@ class EntryFilterType extends AbstractType | |||
113 | ]) | 122 | ]) |
114 | ->add('language', ChoiceFilterType::class, [ | 123 | ->add('language', ChoiceFilterType::class, [ |
115 | 'choices' => array_flip($this->repository->findDistinctLanguageByUser($this->user->getId())), | 124 | 'choices' => array_flip($this->repository->findDistinctLanguageByUser($this->user->getId())), |
116 | 'choices_as_values' => true, | ||
117 | 'label' => 'entry.filters.language_label', | 125 | 'label' => 'entry.filters.language_label', |
118 | ]) | 126 | ]) |
119 | ; | 127 | ; |