diff options
17 files changed, 70 insertions, 11 deletions
diff --git a/docs/en/user/errors_during_fetching.rst b/docs/en/user/errors_during_fetching.rst index 68892750..6684563a 100644 --- a/docs/en/user/errors_during_fetching.rst +++ b/docs/en/user/errors_during_fetching.rst | |||
@@ -12,9 +12,21 @@ There may be several reasons: | |||
12 | How can I help to fix that? | 12 | How can I help to fix that? |
13 | --------------------------- | 13 | --------------------------- |
14 | 14 | ||
15 | - `by sending us an email with the article's URL <mailto:hello@wallabag.org>`_ | 15 | You can `sending us an email with the article's URL <mailto:hello@wallabag.org>`_. |
16 | - by trying to fix this article by yourself :) by creating a file for the article. | 16 | |
17 | You can use `this tool <http://siteconfig.fivefilters.org/>`__. | 17 | Or you can also try to fix this problem by yourself (so we can be focused on improving wallabag internally instead of writing siteconfig :) ). |
18 | |||
19 | You can try to see if it works here: `http://f43.me/feed/test <http://f43.me/feed/test>`_ (it uses almost the same system as wallabag to retrieve content). | ||
20 | |||
21 | If it works here and not on wallabag, it means there is something internally in wallabag that breaks the parser (hard to fix: please open an issue about it). | ||
22 | |||
23 | If it doesn't works, try to extract a site config using: `http://siteconfig.fivefilters.org/ <http://siteconfig.fivefilters.org/>`_ (select which part of the content is actually the content). You can `read this documentation before <http://help.fivefilters.org/customer/en/portal/articles/223153-site-patterns>`_. | ||
24 | |||
25 | You can test it on **f43.me** website: click on **Want to try a custom siteconfig?** and put the generated file from siteconfig.fivefilters.org. | ||
26 | |||
27 | Repeat until you have something ok. | ||
28 | |||
29 | Then you can submit a pull request to `https://github.com/fivefilters/ftr-site-config <https://github.com/fivefilters/ftr-site-config>`_ which is the global repo for siteconfig files. | ||
18 | 30 | ||
19 | How can I try to re-fetch this article? | 31 | How can I try to re-fetch this article? |
20 | --------------------------------------- | 32 | --------------------------------------- |
diff --git a/docs/fr/user/errors_during_fetching.rst b/docs/fr/user/errors_during_fetching.rst index 74290bef..1a60e4bd 100644 --- a/docs/fr/user/errors_during_fetching.rst +++ b/docs/fr/user/errors_during_fetching.rst | |||
@@ -12,9 +12,21 @@ Il peut y avoir plusieurs raisons : | |||
12 | Comment puis-je aider pour réparer ça ? | 12 | Comment puis-je aider pour réparer ça ? |
13 | --------------------------------------- | 13 | --------------------------------------- |
14 | 14 | ||
15 | - `en nous envoyant un email avec l'URL de l'article <mailto:hello@wallabag.org>`_ | 15 | Vous pouvez `nous envoyer un email avec l'URL de l'article <mailto:hello@wallabag.org>`_. |
16 | - en essayant de réparer cet article par vous-même :) en créant un fichier pour l'article. | 16 | |
17 | Vous pouvez utiliser `cet outil <http://siteconfig.fivefilters.org/>`__. | 17 | Ou vous pouvez aussi essayer de résoudre ce problème vous même (comme ça, nous restons concentrés pour améliorer wallabag au lieu d'écrire ces fichiers de configuration :) ). |
18 | |||
19 | Vous pouvez essayer de voir si ça fonctionne ici : `http://f43.me/feed/test <http://f43.me/feed/test>`_ (ce site utilise principalement la même manière de fonctionner que wallabag pour récupérer les articles). | ||
20 | |||
21 | Si ça fonctionne ici et pas sur wallabag, c'est qu'il y a un souci avec wallabag qui casse le parser (difficile à résoudre : merci d'ouvrir un nouveau ticket à ce sujet). | ||
22 | |||
23 | Si ça ne fonctionne pas, vous pouvez essayer de créer un fichier de configuration en utilisant : `http://siteconfig.fivefilters.org/ <http://siteconfig.fivefilters.org/>`_ (sélectionnez les parties du contenu qui correspondent à ce que vous souhaitez garder). Vous pouvez `lire cette documentation avant <http://help.fivefilters.org/customer/en/portal/articles/223153-site-patterns>`_. | ||
24 | |||
25 | Vous pouvez tester ce fichier sur le site **f43.me** : cliquez sur **Want to try a custom siteconfig?** et insérez le fichier généré depuis siteconfig.fivefilters.org. | ||
26 | |||
27 | Répétez cette opération jusqu'à avoir quelque chose qui vous convienne. | ||
28 | |||
29 | Ensuite, vous pouvez créer une pull request ici `https://github.com/fivefilters/ftr-site-config <https://github.com/fivefilters/ftr-site-config>`_, qui est le projet principal pour stocker les fichiers de configuration. | ||
18 | 30 | ||
19 | Comment puis-je réessayer de récupérer le contenu ? | 31 | Comment puis-je réessayer de récupérer le contenu ? |
20 | --------------------------------------------------- | 32 | --------------------------------------------------- |
diff --git a/src/Wallabag/CoreBundle/Resources/translations/messages.da.yml b/src/Wallabag/CoreBundle/Resources/translations/messages.da.yml index b04b9512..2652a102 100644 --- a/src/Wallabag/CoreBundle/Resources/translations/messages.da.yml +++ b/src/Wallabag/CoreBundle/Resources/translations/messages.da.yml | |||
@@ -208,6 +208,8 @@ entry: | |||
208 | url_label: 'Url' | 208 | url_label: 'Url' |
209 | # is_public_label: 'Public' | 209 | # is_public_label: 'Public' |
210 | save_label: 'Gem' | 210 | save_label: 'Gem' |
211 | public: | ||
212 | # shared_by_wallabag: "This article has been shared by <a href=%wallabag_instance%'>wallabag</a>" | ||
211 | 213 | ||
212 | about: | 214 | about: |
213 | page_title: 'Om' | 215 | page_title: 'Om' |
diff --git a/src/Wallabag/CoreBundle/Resources/translations/messages.de.yml b/src/Wallabag/CoreBundle/Resources/translations/messages.de.yml index 6ea3f5c5..e0f29b61 100644 --- a/src/Wallabag/CoreBundle/Resources/translations/messages.de.yml +++ b/src/Wallabag/CoreBundle/Resources/translations/messages.de.yml | |||
@@ -208,6 +208,8 @@ entry: | |||
208 | url_label: 'URL' | 208 | url_label: 'URL' |
209 | is_public_label: 'Öffentlich' | 209 | is_public_label: 'Öffentlich' |
210 | save_label: 'Speichern' | 210 | save_label: 'Speichern' |
211 | public: | ||
212 | # shared_by_wallabag: "This article has been shared by <a href='%wallabag_instance%'>wallabag</a>" | ||
211 | 213 | ||
212 | about: | 214 | about: |
213 | page_title: 'Über' | 215 | page_title: 'Über' |
diff --git a/src/Wallabag/CoreBundle/Resources/translations/messages.en.yml b/src/Wallabag/CoreBundle/Resources/translations/messages.en.yml index 38631e24..b8e98112 100644 --- a/src/Wallabag/CoreBundle/Resources/translations/messages.en.yml +++ b/src/Wallabag/CoreBundle/Resources/translations/messages.en.yml | |||
@@ -208,6 +208,8 @@ entry: | |||
208 | url_label: 'Url' | 208 | url_label: 'Url' |
209 | is_public_label: 'Public' | 209 | is_public_label: 'Public' |
210 | save_label: 'Save' | 210 | save_label: 'Save' |
211 | public: | ||
212 | shared_by_wallabag: "This article has been shared by <a href='%wallabag_instance%'>wallabag</a>" | ||
211 | 213 | ||
212 | about: | 214 | about: |
213 | page_title: 'About' | 215 | page_title: 'About' |
diff --git a/src/Wallabag/CoreBundle/Resources/translations/messages.es.yml b/src/Wallabag/CoreBundle/Resources/translations/messages.es.yml index a1fc34ef..70633bd7 100644 --- a/src/Wallabag/CoreBundle/Resources/translations/messages.es.yml +++ b/src/Wallabag/CoreBundle/Resources/translations/messages.es.yml | |||
@@ -208,6 +208,8 @@ entry: | |||
208 | url_label: 'Url' | 208 | url_label: 'Url' |
209 | is_public_label: 'Es Público' | 209 | is_public_label: 'Es Público' |
210 | save_label: 'Guardar' | 210 | save_label: 'Guardar' |
211 | public: | ||
212 | # shared_by_wallabag: "This article has been shared by <a href='%wallabag_instance%'>wallabag</a>" | ||
211 | 213 | ||
212 | about: | 214 | about: |
213 | page_title: 'Acerca de' | 215 | page_title: 'Acerca de' |
diff --git a/src/Wallabag/CoreBundle/Resources/translations/messages.fa.yml b/src/Wallabag/CoreBundle/Resources/translations/messages.fa.yml index 740302c5..074ab7a8 100644 --- a/src/Wallabag/CoreBundle/Resources/translations/messages.fa.yml +++ b/src/Wallabag/CoreBundle/Resources/translations/messages.fa.yml | |||
@@ -208,6 +208,8 @@ entry: | |||
208 | url_label: 'نشانی' | 208 | url_label: 'نشانی' |
209 | is_public_label: 'عمومی' | 209 | is_public_label: 'عمومی' |
210 | save_label: 'ذخیره' | 210 | save_label: 'ذخیره' |
211 | public: | ||
212 | # shared_by_wallabag: "This article has been shared by <a href='%wallabag_instance%'>wallabag</a>" | ||
211 | 213 | ||
212 | about: | 214 | about: |
213 | page_title: 'درباره' | 215 | page_title: 'درباره' |
diff --git a/src/Wallabag/CoreBundle/Resources/translations/messages.fr.yml b/src/Wallabag/CoreBundle/Resources/translations/messages.fr.yml index ad4fc99f..6d85a5ae 100644 --- a/src/Wallabag/CoreBundle/Resources/translations/messages.fr.yml +++ b/src/Wallabag/CoreBundle/Resources/translations/messages.fr.yml | |||
@@ -208,6 +208,8 @@ entry: | |||
208 | url_label: 'Url' | 208 | url_label: 'Url' |
209 | is_public_label: 'Public' | 209 | is_public_label: 'Public' |
210 | save_label: 'Enregistrer' | 210 | save_label: 'Enregistrer' |
211 | public: | ||
212 | shared_by_wallabag: "Cet article a été partagé par <a href='%wallabag_instance%'>wallabag</a>" | ||
211 | 213 | ||
212 | about: | 214 | about: |
213 | page_title: 'À propos' | 215 | page_title: 'À propos' |
diff --git a/src/Wallabag/CoreBundle/Resources/translations/messages.it.yml b/src/Wallabag/CoreBundle/Resources/translations/messages.it.yml index e0bd9d8b..15f7e774 100644 --- a/src/Wallabag/CoreBundle/Resources/translations/messages.it.yml +++ b/src/Wallabag/CoreBundle/Resources/translations/messages.it.yml | |||
@@ -208,6 +208,8 @@ entry: | |||
208 | url_label: 'Url' | 208 | url_label: 'Url' |
209 | is_public_label: 'Pubblico' | 209 | is_public_label: 'Pubblico' |
210 | save_label: 'Salva' | 210 | save_label: 'Salva' |
211 | public: | ||
212 | # shared_by_wallabag: "This article has been shared by <a href='%wallabag_instance%'>wallabag</a>" | ||
211 | 213 | ||
212 | about: | 214 | about: |
213 | page_title: 'About' | 215 | page_title: 'About' |
diff --git a/src/Wallabag/CoreBundle/Resources/translations/messages.oc.yml b/src/Wallabag/CoreBundle/Resources/translations/messages.oc.yml index b26bed87..1d10be2a 100644 --- a/src/Wallabag/CoreBundle/Resources/translations/messages.oc.yml +++ b/src/Wallabag/CoreBundle/Resources/translations/messages.oc.yml | |||
@@ -208,6 +208,8 @@ entry: | |||
208 | url_label: 'Url' | 208 | url_label: 'Url' |
209 | is_public_label: 'Public' | 209 | is_public_label: 'Public' |
210 | save_label: 'Enregistrar' | 210 | save_label: 'Enregistrar' |
211 | public: | ||
212 | # shared_by_wallabag: "This article has been shared by <a href='%wallabag_instance%'>wallabag</a>" | ||
211 | 213 | ||
212 | about: | 214 | about: |
213 | page_title: 'A prepaus' | 215 | page_title: 'A prepaus' |
diff --git a/src/Wallabag/CoreBundle/Resources/translations/messages.pl.yml b/src/Wallabag/CoreBundle/Resources/translations/messages.pl.yml index 285d73e5..9791a3b2 100644 --- a/src/Wallabag/CoreBundle/Resources/translations/messages.pl.yml +++ b/src/Wallabag/CoreBundle/Resources/translations/messages.pl.yml | |||
@@ -208,6 +208,8 @@ entry: | |||
208 | url_label: 'Adres URL' | 208 | url_label: 'Adres URL' |
209 | is_public_label: 'Publiczny' | 209 | is_public_label: 'Publiczny' |
210 | save_label: 'Zapisz' | 210 | save_label: 'Zapisz' |
211 | public: | ||
212 | # shared_by_wallabag: "This article has been shared by <a href='%wallabag_instance%'>wallabag</a>" | ||
211 | 213 | ||
212 | about: | 214 | about: |
213 | page_title: 'O nas' | 215 | page_title: 'O nas' |
@@ -284,7 +286,7 @@ quickstart: | |||
284 | import: 'Skonfigurować import' | 286 | import: 'Skonfigurować import' |
285 | first_steps: | 287 | first_steps: |
286 | title: 'Pierwsze kroki' | 288 | title: 'Pierwsze kroki' |
287 | description: "Teraz wallabag jest poprawnie skonfigurowany, więc czas zarchiwizować Internet. Klinknij w prawym górnym rogu na znak +, aby dodać link" | 289 | description: "Teraz wallabag jest poprawnie skonfigurowany, więc czas zarchiwizować Internet. Klinknij w prawym górnym rogu na znak +, aby dodać link" |
288 | new_article: 'Zapisz swój pierwszy artukuł' | 290 | new_article: 'Zapisz swój pierwszy artukuł' |
289 | unread_articles: 'I sklasyfikuj go!' | 291 | unread_articles: 'I sklasyfikuj go!' |
290 | migrate: | 292 | migrate: |
diff --git a/src/Wallabag/CoreBundle/Resources/translations/messages.ro.yml b/src/Wallabag/CoreBundle/Resources/translations/messages.ro.yml index fba6f998..2b1d4f6d 100644 --- a/src/Wallabag/CoreBundle/Resources/translations/messages.ro.yml +++ b/src/Wallabag/CoreBundle/Resources/translations/messages.ro.yml | |||
@@ -208,6 +208,8 @@ entry: | |||
208 | url_label: 'Url' | 208 | url_label: 'Url' |
209 | # is_public_label: 'Public' | 209 | # is_public_label: 'Public' |
210 | save_label: 'Salvează' | 210 | save_label: 'Salvează' |
211 | public: | ||
212 | # shared_by_wallabag: "This article has been shared by <a href='%wallabag_instance%'>wallabag</a>" | ||
211 | 213 | ||
212 | about: | 214 | about: |
213 | page_title: 'Despre' | 215 | page_title: 'Despre' |
diff --git a/src/Wallabag/CoreBundle/Resources/translations/messages.tr.yml b/src/Wallabag/CoreBundle/Resources/translations/messages.tr.yml index 1694e212..8cfc245a 100644 --- a/src/Wallabag/CoreBundle/Resources/translations/messages.tr.yml +++ b/src/Wallabag/CoreBundle/Resources/translations/messages.tr.yml | |||
@@ -207,6 +207,8 @@ entry: | |||
207 | url_label: 'Url' | 207 | url_label: 'Url' |
208 | is_public_label: 'Herkes tarafından erişime açık olsun mu?' | 208 | is_public_label: 'Herkes tarafından erişime açık olsun mu?' |
209 | save_label: 'Kaydet' | 209 | save_label: 'Kaydet' |
210 | public: | ||
211 | # shared_by_wallabag: "This article has been shared by <a href='%wallabag_instance%'>wallabag</a>" | ||
210 | 212 | ||
211 | about: | 213 | about: |
212 | page_title: 'Hakkımızda' | 214 | page_title: 'Hakkımızda' |
diff --git a/src/Wallabag/CoreBundle/Resources/views/themes/common/Entry/share.html.twig b/src/Wallabag/CoreBundle/Resources/views/themes/common/Entry/share.html.twig index b82b3d3d..a0a0d3c3 100644 --- a/src/Wallabag/CoreBundle/Resources/views/themes/common/Entry/share.html.twig +++ b/src/Wallabag/CoreBundle/Resources/views/themes/common/Entry/share.html.twig | |||
@@ -27,11 +27,20 @@ | |||
27 | width: 600px; | 27 | width: 600px; |
28 | } | 28 | } |
29 | </style> | 29 | </style> |
30 | <meta property="og:title" content="{{ entry.title | raw }}" /> | ||
31 | <meta property="og:type" content="article" /> | ||
32 | <meta property="og:url" content="{{ app.request.uri }}" /> | ||
33 | {% if entry.previewPicture is not null %} | ||
34 | <meta property="og:image" content="{{ entry.previewPicture }}" /> | ||
35 | {% else %} | ||
36 | <meta property="og:image" content="{{ app.request.schemeAndHttpHost }}{{ asset('bundles/wallabagcore/themes/_global/img/logo-other_themes.png') }}" /> | ||
37 | {% endif %} | ||
30 | </head> | 38 | </head> |
31 | <body> | 39 | <body> |
32 | <header> | 40 | <header> |
33 | <h1>{{ entry.title | raw }}</h1> | 41 | <h1>{{ entry.title | raw }}</h1> |
34 | <span><a href="{{ entry.url|e }}" target="_blank" title="{{ 'entry.view.original_article'|trans }} : {{ entry.title|e }}" class="tool">{{ entry.domainName|removeWww }}</a></span> | 42 | <div><a href="{{ entry.url|e }}" target="_blank" title="{{ 'entry.view.original_article'|trans }} : {{ entry.title|e }}" class="tool">{{ entry.domainName|removeWww }}</a></div> |
43 | <div>{{ "entry.public.shared_by_wallabag"|trans({'%wallabag_instance%': url('homepage')})|raw }}</div> | ||
35 | </header> | 44 | </header> |
36 | <article> | 45 | <article> |
37 | {{ entry.content | raw }} | 46 | {{ entry.content | raw }} |
diff --git a/src/Wallabag/UserBundle/Resources/views/Manage/edit.html.twig b/src/Wallabag/UserBundle/Resources/views/Manage/edit.html.twig index d5cf99c3..67843f20 100644 --- a/src/Wallabag/UserBundle/Resources/views/Manage/edit.html.twig +++ b/src/Wallabag/UserBundle/Resources/views/Manage/edit.html.twig | |||
@@ -68,7 +68,7 @@ | |||
68 | <br/> | 68 | <br/> |
69 | 69 | ||
70 | {{ form_widget(edit_form.save, {'attr': {'class': 'btn waves-effect waves-light'}}) }} | 70 | {{ form_widget(edit_form.save, {'attr': {'class': 'btn waves-effect waves-light'}}) }} |
71 | {{ form_rest(edit_form) }} | 71 | {{ form_widget(edit_form._token) }} |
72 | </form> | 72 | </form> |
73 | <p> | 73 | <p> |
74 | {{ form_start(delete_form) }} | 74 | {{ form_start(delete_form) }} |
diff --git a/tests/Wallabag/CoreBundle/Controller/EntryControllerTest.php b/tests/Wallabag/CoreBundle/Controller/EntryControllerTest.php index c40e10a5..d7bf03ba 100644 --- a/tests/Wallabag/CoreBundle/Controller/EntryControllerTest.php +++ b/tests/Wallabag/CoreBundle/Controller/EntryControllerTest.php | |||
@@ -753,7 +753,7 @@ class EntryControllerTest extends WallabagCoreTestCase | |||
753 | $this->assertCount(2, $crawler->filter('div[class=entry]')); | 753 | $this->assertCount(2, $crawler->filter('div[class=entry]')); |
754 | } | 754 | } |
755 | 755 | ||
756 | public function testCache() | 756 | public function testShareEntryPublicly() |
757 | { | 757 | { |
758 | $this->logInAs('admin'); | 758 | $this->logInAs('admin'); |
759 | $client = $this->getClient(); | 759 | $client = $this->getClient(); |
@@ -778,6 +778,10 @@ class EntryControllerTest extends WallabagCoreTestCase | |||
778 | $this->assertContains('public', $client->getResponse()->headers->get('cache-control')); | 778 | $this->assertContains('public', $client->getResponse()->headers->get('cache-control')); |
779 | $this->assertContains('s-maxage=25200', $client->getResponse()->headers->get('cache-control')); | 779 | $this->assertContains('s-maxage=25200', $client->getResponse()->headers->get('cache-control')); |
780 | $this->assertNotContains('no-cache', $client->getResponse()->headers->get('cache-control')); | 780 | $this->assertNotContains('no-cache', $client->getResponse()->headers->get('cache-control')); |
781 | $this->assertContains('og:title', $client->getResponse()->getContent()); | ||
782 | $this->assertContains('og:type', $client->getResponse()->getContent()); | ||
783 | $this->assertContains('og:url', $client->getResponse()->getContent()); | ||
784 | $this->assertContains('og:image', $client->getResponse()->getContent()); | ||
781 | 785 | ||
782 | // sharing is now disabled | 786 | // sharing is now disabled |
783 | $client->getContainer()->get('craue_config')->set('share_public', 0); | 787 | $client->getContainer()->get('craue_config')->set('share_public', 0); |
diff --git a/tests/Wallabag/UserBundle/Controller/ManageControllerTest.php b/tests/Wallabag/UserBundle/Controller/ManageControllerTest.php index 19b824b8..243a4459 100644 --- a/tests/Wallabag/UserBundle/Controller/ManageControllerTest.php +++ b/tests/Wallabag/UserBundle/Controller/ManageControllerTest.php | |||
@@ -23,7 +23,7 @@ class ManageControllerTest extends WallabagCoreTestCase | |||
23 | 23 | ||
24 | // Create a new user in the database | 24 | // Create a new user in the database |
25 | $crawler = $client->request('GET', '/users/'); | 25 | $crawler = $client->request('GET', '/users/'); |
26 | $this->assertEquals(200, $client->getResponse()->getStatusCode(), "Unexpected HTTP status code for GET /users/"); | 26 | $this->assertEquals(200, $client->getResponse()->getStatusCode(), 'Unexpected HTTP status code for GET /users/'); |
27 | $crawler = $client->click($crawler->selectLink('user.list.create_new_one')->link()); | 27 | $crawler = $client->click($crawler->selectLink('user.list.create_new_one')->link()); |
28 | 28 | ||
29 | // Fill in the form and submit it | 29 | // Fill in the form and submit it |