aboutsummaryrefslogtreecommitdiffhomepage
path: root/tests
diff options
context:
space:
mode:
authorThomas Citharel <tcit@tcit.fr>2017-05-28 14:53:04 +0200
committerJeremy Benoist <jeremy.benoist@gmail.com>2019-04-01 13:24:40 +0200
commitbfe02a0b481055bb4e799200c8daa9a0ad987c71 (patch)
treeb82431b5ca4b24de1ddab6f0407e1ae7cda54083 /tests
parent3620dae1e6b3fab5a4ba4001b4581ce7ed795996 (diff)
downloadwallabag-bfe02a0b481055bb4e799200c8daa9a0ad987c71.tar.gz
wallabag-bfe02a0b481055bb4e799200c8daa9a0ad987c71.tar.zst
wallabag-bfe02a0b481055bb4e799200c8daa9a0ad987c71.zip
Hash the urls to check if they exist
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Diffstat (limited to 'tests')
-rw-r--r--tests/Wallabag/ApiBundle/Controller/EntryRestControllerTest.php55
-rw-r--r--tests/Wallabag/CoreBundle/Command/GenerateUrlHashesCommandTest.php101
2 files changed, 154 insertions, 2 deletions
diff --git a/tests/Wallabag/ApiBundle/Controller/EntryRestControllerTest.php b/tests/Wallabag/ApiBundle/Controller/EntryRestControllerTest.php
index 2151f587..8d96d7b8 100644
--- a/tests/Wallabag/ApiBundle/Controller/EntryRestControllerTest.php
+++ b/tests/Wallabag/ApiBundle/Controller/EntryRestControllerTest.php
@@ -987,6 +987,8 @@ class EntryRestControllerTest extends WallabagApiTestCase
987 { 987 {
988 $this->client->request('GET', '/api/entries/exists?url=http://0.0.0.0/entry2'); 988 $this->client->request('GET', '/api/entries/exists?url=http://0.0.0.0/entry2');
989 989
990 $this->client->request('GET', '/api/entries/exists?hashedurl=' . hash('md5', 'http://0.0.0.0/entry2'));
991
990 $this->assertSame(200, $this->client->getResponse()->getStatusCode()); 992 $this->assertSame(200, $this->client->getResponse()->getStatusCode());
991 993
992 $content = json_decode($this->client->getResponse()->getContent(), true); 994 $content = json_decode($this->client->getResponse()->getContent(), true);
@@ -994,10 +996,22 @@ class EntryRestControllerTest extends WallabagApiTestCase
994 $this->assertTrue($content['exists']); 996 $this->assertTrue($content['exists']);
995 } 997 }
996 998
999 public function testGetEntriesExistsWithHash()
1000 {
1001 $this->client->request('GET', '/api/entries/exists?hashedurl=' . hash('md5', 'http://0.0.0.0/entry2'));
1002
1003 $this->assertSame(200, $this->client->getResponse()->getStatusCode());
1004
1005 $content = json_decode($this->client->getResponse()->getContent(), true);
1006
1007 $this->assertSame(2, $content['exists']);
1008 }
1009
997 public function testGetEntriesExistsWithManyUrls() 1010 public function testGetEntriesExistsWithManyUrls()
998 { 1011 {
999 $url1 = 'http://0.0.0.0/entry2'; 1012 $url1 = 'http://0.0.0.0/entry2';
1000 $url2 = 'http://0.0.0.0/entry10'; 1013 $url2 = 'http://0.0.0.0/entry10';
1014
1001 $this->client->request('GET', '/api/entries/exists?urls[]=' . $url1 . '&urls[]=' . $url2 . '&return_id=1'); 1015 $this->client->request('GET', '/api/entries/exists?urls[]=' . $url1 . '&urls[]=' . $url2 . '&return_id=1');
1002 1016
1003 $this->assertSame(200, $this->client->getResponse()->getStatusCode()); 1017 $this->assertSame(200, $this->client->getResponse()->getStatusCode());
@@ -1027,9 +1041,46 @@ class EntryRestControllerTest extends WallabagApiTestCase
1027 $this->assertFalse($content[$url2]); 1041 $this->assertFalse($content[$url2]);
1028 } 1042 }
1029 1043
1044 public function testGetEntriesExistsWithManyUrlsHashed()
1045 {
1046 $url1 = 'http://0.0.0.0/entry2';
1047 $url2 = 'http://0.0.0.0/entry10';
1048 $this->client->request('GET', '/api/entries/exists?hashedurls[]='.hash('md5',$url1).'&hashedurls[]='.hash('md5',$url2) . '&return_id=1');
1049
1050 $this->assertSame(200, $this->client->getResponse()->getStatusCode());
1051
1052 $content = json_decode($this->client->getResponse()->getContent(), true);
1053
1054 $this->assertArrayHasKey($url1, $content);
1055 $this->assertArrayHasKey($url2, $content);
1056 $this->assertSame(2, $content[$url1]);
1057 $this->assertNull($content[$url2]);
1058
1059 $this->assertArrayHasKey(hash('md5', $url1), $content);
1060 $this->assertArrayHasKey(hash('md5', $url2), $content);
1061 $this->assertEquals(2, $content[hash('md5', $url1)]);
1062 $this->assertEquals(false, $content[hash('md5', $url2)]);
1063 }
1064
1065 public function testGetEntriesExistsWithManyUrlsHashedReturnBool()
1066 {
1067 $url1 = 'http://0.0.0.0/entry2';
1068 $url2 = 'http://0.0.0.0/entry10';
1069 $this->client->request('GET', '/api/entries/exists?hashedurls[]='.hash('md5',$url1).'&hashedurls[]='.hash('md5',$url2));
1070
1071 $this->assertSame(200, $this->client->getResponse()->getStatusCode());
1072
1073 $content = json_decode($this->client->getResponse()->getContent(), true);
1074
1075 $this->assertArrayHasKey($url1, $content);
1076 $this->assertArrayHasKey($url2, $content);
1077 $this->assertTrue($content[$url1]);
1078 $this->assertFalse($content[$url2]);
1079 }
1080
1030 public function testGetEntriesExistsWhichDoesNotExists() 1081 public function testGetEntriesExistsWhichDoesNotExists()
1031 { 1082 {
1032 $this->client->request('GET', '/api/entries/exists?url=http://google.com/entry2'); 1083 $this->client->request('GET', '/api/entries/exists?hashedurl='.hash('md5','http://google.com/entry2'));
1033 1084
1034 $this->assertSame(200, $this->client->getResponse()->getStatusCode()); 1085 $this->assertSame(200, $this->client->getResponse()->getStatusCode());
1035 1086
@@ -1040,7 +1091,7 @@ class EntryRestControllerTest extends WallabagApiTestCase
1040 1091
1041 public function testGetEntriesExistsWithNoUrl() 1092 public function testGetEntriesExistsWithNoUrl()
1042 { 1093 {
1043 $this->client->request('GET', '/api/entries/exists?url='); 1094 $this->client->request('GET', '/api/entries/exists?hashedurl=');
1044 1095
1045 $this->assertSame(403, $this->client->getResponse()->getStatusCode()); 1096 $this->assertSame(403, $this->client->getResponse()->getStatusCode());
1046 } 1097 }
diff --git a/tests/Wallabag/CoreBundle/Command/GenerateUrlHashesCommandTest.php b/tests/Wallabag/CoreBundle/Command/GenerateUrlHashesCommandTest.php
new file mode 100644
index 00000000..8ca772cb
--- /dev/null
+++ b/tests/Wallabag/CoreBundle/Command/GenerateUrlHashesCommandTest.php
@@ -0,0 +1,101 @@
1<?php
2
3namespace Tests\Wallabag\CoreBundle\Command;
4
5use Symfony\Bundle\FrameworkBundle\Console\Application;
6use Symfony\Component\Console\Tester\CommandTester;
7use Tests\Wallabag\CoreBundle\WallabagCoreTestCase;
8use Wallabag\CoreBundle\Command\GenerateUrlHashesCommand;
9use Wallabag\CoreBundle\Entity\Entry;
10
11class GenerateUrlHashesCommandTest extends WallabagCoreTestCase
12{
13 public function testRunGenerateUrlHashesCommand()
14 {
15 $application = new Application($this->getClient()->getKernel());
16 $application->add(new GenerateUrlHashesCommand());
17
18 $command = $application->find('wallabag:generate-hashed-urls');
19
20 $tester = new CommandTester($command);
21 $tester->execute([
22 'command' => $command->getName(),
23 ]);
24
25 $this->assertContains('Generating hashed urls for the 3 user account entries', $tester->getDisplay());
26 $this->assertContains('Finished generated hashed urls', $tester->getDisplay());
27 }
28
29 public function testRunGenerateUrlHashesCommandWithBadUsername()
30 {
31 $application = new Application($this->getClient()->getKernel());
32 $application->add(new GenerateUrlHashesCommand());
33
34 $command = $application->find('wallabag:generate-hashed-urls');
35
36 $tester = new CommandTester($command);
37 $tester->execute([
38 'command' => $command->getName(),
39 'username' => 'unknown',
40 ]);
41
42 $this->assertContains('User "unknown" not found', $tester->getDisplay());
43 }
44
45 public function testRunGenerateUrlHashesCommandForUser()
46 {
47 $application = new Application($this->getClient()->getKernel());
48 $application->add(new GenerateUrlHashesCommand());
49
50 $command = $application->find('wallabag:generate-hashed-urls');
51
52 $tester = new CommandTester($command);
53 $tester->execute([
54 'command' => $command->getName(),
55 'username' => 'admin',
56 ]);
57
58 $this->assertContains('Generated hashed urls for user admin', $tester->getDisplay());
59 }
60
61 public function testGenerateUrls()
62 {
63 $url = 'http://www.lemonde.fr/sport/visuel/2017/05/05/rondelle-prison-blanchissage-comprendre-le-hockey-sur-glace_5122587_3242.html';
64 $client = $this->getClient();
65 $em = $client->getContainer()->get('doctrine.orm.entity_manager');
66
67 $this->logInAs('admin');
68
69 $user = $em->getRepository('WallabagUserBundle:User')->findOneById($this->getLoggedInUserId());
70
71 $entry1 = new Entry($user);
72 $entry1->setUrl($url);
73
74 $em->persist($entry1);
75
76 $em->flush();
77
78 $this->assertNull($entry1->getHashedUrl());
79
80 $application = new Application($this->getClient()->getKernel());
81 $application->add(new GenerateUrlHashesCommand());
82
83 $command = $application->find('wallabag:generate-hashed-urls');
84
85 $tester = new CommandTester($command);
86 $tester->execute([
87 'command' => $command->getName(),
88 'username' => 'admin',
89 ]);
90
91 $this->assertContains('Generated hashed urls for user admin', $tester->getDisplay());
92
93 $entry = $em->getRepository('WallabagCoreBundle:Entry')->findOneByUrl($url);
94
95 $this->assertEquals($entry->getHashedUrl(), hash('sha512', $url));
96
97 $query = $em->createQuery('DELETE FROM Wallabag\CoreBundle\Entity\Entry e WHERE e.url = :url');
98 $query->setParameter('url', $url);
99 $query->execute();
100 }
101}