aboutsummaryrefslogtreecommitdiffhomepage
path: root/tests/Wallabag
diff options
context:
space:
mode:
authorJeremy Benoist <jeremy.benoist@gmail.com>2017-05-12 07:53:21 +0200
committerJeremy Benoist <jeremy.benoist@gmail.com>2017-05-31 14:00:15 +0200
commit74a75f7d430eb7a69cd377194e52012db34d39b4 (patch)
treebb85741afe742e24351167699c434a955ab4a9fa /tests/Wallabag
parentfb436e8ca0c7468b9698050df0b78447e2d0854f (diff)
downloadwallabag-74a75f7d430eb7a69cd377194e52012db34d39b4.tar.gz
wallabag-74a75f7d430eb7a69cd377194e52012db34d39b4.tar.zst
wallabag-74a75f7d430eb7a69cd377194e52012db34d39b4.zip
Use graby ContentExtractor to clean html
It might be better to re-use some graby functionalities to clean html instead of building a new system.
Diffstat (limited to 'tests/Wallabag')
-rw-r--r--tests/Wallabag/CoreBundle/Helper/ContentProxyTest.php55
1 files changed, 55 insertions, 0 deletions
diff --git a/tests/Wallabag/CoreBundle/Helper/ContentProxyTest.php b/tests/Wallabag/CoreBundle/Helper/ContentProxyTest.php
index 44fca073..7a50b373 100644
--- a/tests/Wallabag/CoreBundle/Helper/ContentProxyTest.php
+++ b/tests/Wallabag/CoreBundle/Helper/ContentProxyTest.php
@@ -8,6 +8,7 @@ use Wallabag\CoreBundle\Entity\Entry;
8use Wallabag\CoreBundle\Entity\Tag; 8use Wallabag\CoreBundle\Entity\Tag;
9use Wallabag\UserBundle\Entity\User; 9use Wallabag\UserBundle\Entity\User;
10use Wallabag\CoreBundle\Helper\RuleBasedTagger; 10use Wallabag\CoreBundle\Helper\RuleBasedTagger;
11use Graby\Graby;
11 12
12class ContentProxyTest extends \PHPUnit_Framework_TestCase 13class ContentProxyTest extends \PHPUnit_Framework_TestCase
13{ 14{
@@ -253,6 +254,60 @@ class ContentProxyTest extends \PHPUnit_Framework_TestCase
253 $this->assertCount(0, $entry->getTags()); 254 $this->assertCount(0, $entry->getTags());
254 } 255 }
255 256
257 public function dataForCrazyHtml()
258 {
259 return [
260 'script and comment' => [
261 '<strong>Script inside:</strong> <!--[if gte IE 4]><script>alert(\'lol\');</script><![endif]--><br />',
262 'lol'
263 ],
264 'script' => [
265 '<strong>Script inside:</strong><script>alert(\'lol\');</script>',
266 'script'
267 ],
268 ];
269 }
270
271 /**
272 * @dataProvider dataForCrazyHtml
273 */
274 public function testWithCrazyHtmlContent($html, $escapedString)
275 {
276 $tagger = $this->getTaggerMock();
277 $tagger->expects($this->once())
278 ->method('tag');
279
280 $graby = new Graby();
281
282 $proxy = new ContentProxy($graby, $tagger, $this->getTagRepositoryMock(), $this->getLogger(), $this->fetchingErrorMessage);
283 $entry = $proxy->updateEntry(
284 new Entry(new User()),
285 'http://1.1.1.1',
286 [
287 'html' => $html,
288 'title' => 'this is my title',
289 'url' => 'http://1.1.1.1',
290 'content_type' => 'text/html',
291 'language' => 'fr',
292 'status' => '200',
293 'open_graph' => [
294 'og_title' => 'my OG title',
295 'og_description' => 'OG desc',
296 'og_image' => 'http://3.3.3.3/cover.jpg',
297 ],
298 ]
299 );
300
301 $this->assertEquals('http://1.1.1.1', $entry->getUrl());
302 $this->assertEquals('this is my title', $entry->getTitle());
303 $this->assertNotContains($escapedString, $entry->getContent());
304 $this->assertEquals('http://3.3.3.3/cover.jpg', $entry->getPreviewPicture());
305 $this->assertEquals('text/html', $entry->getMimetype());
306 $this->assertEquals('fr', $entry->getLanguage());
307 $this->assertEquals('200', $entry->getHttpStatus());
308 $this->assertEquals('1.1.1.1', $entry->getDomainName());
309 }
310
256 private function getTaggerMock() 311 private function getTaggerMock()
257 { 312 {
258 return $this->getMockBuilder(RuleBasedTagger::class) 313 return $this->getMockBuilder(RuleBasedTagger::class)