Add test on RegistrationConfirmedListener

And PLEASE @nicosomb, NEVER EVER inject the whole container inside a service.

1 files changed, 15 insertions, 9 deletions

diff --git a/src/Wallabag/CoreBundle/EventListener/RegistrationConfirmedListener.php b/src/Wallabag/CoreBundle/EventListener/RegistrationConfirmedListener.php
index bcc84923..68c25f1f 100644
--- a/src/Wallabag/CoreBundle/EventListener/RegistrationConfirmedListener.php
+++ b/src/Wallabag/CoreBundle/EventListener/RegistrationConfirmedListener.php
@@ -2,22 +2,28 @@
 
 namespace Wallabag\CoreBundle\EventListener;
 
-use FOS\UserBundle\FOSUserEvents;
-use Symfony\Component\DependencyInjection\Container;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
+use Doctrine\ORM\EntityManager;
 use FOS\UserBundle\Event\FilterUserResponseEvent;
+use FOS\UserBundle\FOSUserEvents;
 use Wallabag\CoreBundle\Entity\Config;
 
 class RegistrationConfirmedListener implements EventSubscriberInterface
 {
     private $em;
-    private $container;
+    private $theme;
+    private $itemsOnPage;
+    private $rssLimit;
+    private $language;
 
-    public function __construct(Container $container, $em)
+    public function __construct(EntityManager $em, $theme, $itemsOnPage, $rssLimit, $language)
     {
-        $this->container = $container;
         $this->em = $em;
+        $this->theme = $theme;
+        $this->itemsOnPage = $itemsOnPage;
+        $this->rssLimit = $rssLimit;
+        $this->language = $language;
     }
 
     public static function getSubscribedEvents()
@@ -34,10 +40,10 @@ class RegistrationConfirmedListener implements EventSubscriberInterface
         }
 
         $config = new Config($event->getUser());
-        $config->setTheme($this->container->getParameter('theme'));
-        $config->setItemsPerPage($this->container->getParameter('items_on_page'));
-        $config->setRssLimit($this->container->getParameter('rss_limit'));
-        $config->setLanguage($this->container->getParameter('language'));
+        $config->setTheme($this->theme);
+        $config->setItemsPerPage($this->itemsOnPage);
+        $config->setRssLimit($this->rssLimit);
+        $config->setLanguage($this->language);
         $this->em->persist($config);
         $this->em->flush();
     }