diff options
author | Jeremy Benoist <jeremy.benoist@gmail.com> | 2016-12-14 11:54:30 +0100 |
---|---|---|
committer | Jeremy Benoist <jeremy.benoist@gmail.com> | 2016-12-15 21:38:16 +0100 |
commit | 21e7ccef3d960f4747d58fc0c9e081618e9451eb (patch) | |
tree | 295c0af56ecaaf9202618d14b67244da373e5f99 /src/Wallabag/CoreBundle/Controller/EntryController.php | |
parent | 202a66ce02bf42743e66fbc1ea1dbfe5b6a1c83a (diff) | |
download | wallabag-21e7ccef3d960f4747d58fc0c9e081618e9451eb.tar.gz wallabag-21e7ccef3d960f4747d58fc0c9e081618e9451eb.tar.zst wallabag-21e7ccef3d960f4747d58fc0c9e081618e9451eb.zip |
Fix tests & deprecation notice
Diffstat (limited to 'src/Wallabag/CoreBundle/Controller/EntryController.php')
-rw-r--r-- | src/Wallabag/CoreBundle/Controller/EntryController.php | 18 |
1 files changed, 13 insertions, 5 deletions
diff --git a/src/Wallabag/CoreBundle/Controller/EntryController.php b/src/Wallabag/CoreBundle/Controller/EntryController.php index 8c13255e..9ed1cb12 100644 --- a/src/Wallabag/CoreBundle/Controller/EntryController.php +++ b/src/Wallabag/CoreBundle/Controller/EntryController.php | |||
@@ -23,17 +23,25 @@ class EntryController extends Controller | |||
23 | * @param Request $request | 23 | * @param Request $request |
24 | * @param int $page | 24 | * @param int $page |
25 | * | 25 | * |
26 | * @Route("/search/{page}", name="search", defaults={"page" = "1"}) | 26 | * @Route("/search/{page}", name="search", defaults={"page" = 1}) |
27 | * | ||
28 | * Default parameter for page is hardcoded (in duplication of the defaults from the Route) | ||
29 | * because this controller is also called inside the layout template without any page as argument | ||
27 | * | 30 | * |
28 | * @return \Symfony\Component\HttpFoundation\Response | 31 | * @return \Symfony\Component\HttpFoundation\Response |
29 | */ | 32 | */ |
30 | public function searchFormAction(Request $request, $page, $currentRoute) | 33 | public function searchFormAction(Request $request, $page = 1, $currentRoute = null) |
31 | { | 34 | { |
35 | // fallback to retrieve currentRoute from query parameter instead of injected one (when using inside a template) | ||
36 | if (null === $currentRoute && $request->query->has('currentRoute')) { | ||
37 | $currentRoute = $request->query->get('currentRoute'); | ||
38 | } | ||
39 | |||
32 | $form = $this->createForm(SearchEntryType::class); | 40 | $form = $this->createForm(SearchEntryType::class); |
33 | 41 | ||
34 | $form->handleRequest($request); | 42 | $form->handleRequest($request); |
35 | 43 | ||
36 | if ($form->isValid()) { | 44 | if ($form->isSubmitted() && $form->isValid()) { |
37 | return $this->showEntries('search', $request, $page); | 45 | return $this->showEntries('search', $request, $page); |
38 | } | 46 | } |
39 | 47 | ||
@@ -90,7 +98,7 @@ class EntryController extends Controller | |||
90 | 98 | ||
91 | $form->handleRequest($request); | 99 | $form->handleRequest($request); |
92 | 100 | ||
93 | if ($form->isValid()) { | 101 | if ($form->isSubmitted() && $form->isValid()) { |
94 | $existingEntry = $this->checkIfEntryAlreadyExists($entry); | 102 | $existingEntry = $this->checkIfEntryAlreadyExists($entry); |
95 | 103 | ||
96 | if (false !== $existingEntry) { | 104 | if (false !== $existingEntry) { |
@@ -173,7 +181,7 @@ class EntryController extends Controller | |||
173 | 181 | ||
174 | $form->handleRequest($request); | 182 | $form->handleRequest($request); |
175 | 183 | ||
176 | if ($form->isValid()) { | 184 | if ($form->isSubmitted() && $form->isValid()) { |
177 | $em = $this->getDoctrine()->getManager(); | 185 | $em = $this->getDoctrine()->getManager(); |
178 | $em->persist($entry); | 186 | $em->persist($entry); |
179 | $em->flush(); | 187 | $em->flush(); |