diff options
author | Thomas Citharel <tcit@tcit.fr> | 2019-01-12 13:09:36 +0100 |
---|---|---|
committer | Jeremy Benoist <jeremy.benoist@gmail.com> | 2019-02-27 14:29:14 +0100 |
commit | 3784688a88230d9c3aec4ca518be52ea1c70aeb9 (patch) | |
tree | e0bf2cec861ac74ec5e1e4ef482e0506087a545c | |
parent | a86c3f1759a3c0ecbf095888789c2a08d71b5c09 (diff) | |
download | wallabag-3784688a88230d9c3aec4ca518be52ea1c70aeb9.tar.gz wallabag-3784688a88230d9c3aec4ca518be52ea1c70aeb9.tar.zst wallabag-3784688a88230d9c3aec4ca518be52ea1c70aeb9.zip |
Replace continue; with break; to avoid PHP 7.3 warnings
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
7 files changed, 9 insertions, 9 deletions
diff --git a/src/Wallabag/CoreBundle/GuzzleSiteAuthenticator/GrabySiteConfigBuilder.php b/src/Wallabag/CoreBundle/GuzzleSiteAuthenticator/GrabySiteConfigBuilder.php index 90e00c62..2e57aac8 100644 --- a/src/Wallabag/CoreBundle/GuzzleSiteAuthenticator/GrabySiteConfigBuilder.php +++ b/src/Wallabag/CoreBundle/GuzzleSiteAuthenticator/GrabySiteConfigBuilder.php | |||
@@ -114,7 +114,7 @@ class GrabySiteConfigBuilder implements SiteConfigBuilder | |||
114 | $extraFields = []; | 114 | $extraFields = []; |
115 | foreach ($extraFieldsStrings as $extraField) { | 115 | foreach ($extraFieldsStrings as $extraField) { |
116 | if (false === strpos($extraField, '=')) { | 116 | if (false === strpos($extraField, '=')) { |
117 | continue; | 117 | break; |
118 | } | 118 | } |
119 | 119 | ||
120 | list($fieldName, $fieldValue) = explode('=', $extraField, 2); | 120 | list($fieldName, $fieldValue) = explode('=', $extraField, 2); |
diff --git a/src/Wallabag/CoreBundle/Helper/DownloadImages.php b/src/Wallabag/CoreBundle/Helper/DownloadImages.php index cc3dcfce..8c1c208f 100644 --- a/src/Wallabag/CoreBundle/Helper/DownloadImages.php +++ b/src/Wallabag/CoreBundle/Helper/DownloadImages.php | |||
@@ -56,7 +56,7 @@ class DownloadImages | |||
56 | $imagePath = $this->processSingleImage($entryId, $image, $url, $relativePath); | 56 | $imagePath = $this->processSingleImage($entryId, $image, $url, $relativePath); |
57 | 57 | ||
58 | if (false === $imagePath) { | 58 | if (false === $imagePath) { |
59 | continue; | 59 | break; |
60 | } | 60 | } |
61 | 61 | ||
62 | // if image contains "&" and we can't find it in the html it might be because it's encoded as & | 62 | // if image contains "&" and we can't find it in the html it might be because it's encoded as & |
diff --git a/src/Wallabag/CoreBundle/Helper/RuleBasedTagger.php b/src/Wallabag/CoreBundle/Helper/RuleBasedTagger.php index fbdf2ac7..d156df84 100644 --- a/src/Wallabag/CoreBundle/Helper/RuleBasedTagger.php +++ b/src/Wallabag/CoreBundle/Helper/RuleBasedTagger.php | |||
@@ -37,7 +37,7 @@ class RuleBasedTagger | |||
37 | 37 | ||
38 | foreach ($rules as $rule) { | 38 | foreach ($rules as $rule) { |
39 | if (!$this->rulerz->satisfies($entry, $rule->getRule())) { | 39 | if (!$this->rulerz->satisfies($entry, $rule->getRule())) { |
40 | continue; | 40 | break; |
41 | } | 41 | } |
42 | 42 | ||
43 | $this->logger->info('Matching rule.', [ | 43 | $this->logger->info('Matching rule.', [ |
diff --git a/src/Wallabag/CoreBundle/Helper/TagsAssigner.php b/src/Wallabag/CoreBundle/Helper/TagsAssigner.php index e6b4989f..519150f5 100644 --- a/src/Wallabag/CoreBundle/Helper/TagsAssigner.php +++ b/src/Wallabag/CoreBundle/Helper/TagsAssigner.php | |||
@@ -49,7 +49,7 @@ class TagsAssigner | |||
49 | 49 | ||
50 | // avoid empty tag | 50 | // avoid empty tag |
51 | if (0 === \strlen($label)) { | 51 | if (0 === \strlen($label)) { |
52 | continue; | 52 | break; |
53 | } | 53 | } |
54 | 54 | ||
55 | if (isset($tagsNotYetFlushed[$label])) { | 55 | if (isset($tagsNotYetFlushed[$label])) { |
diff --git a/src/Wallabag/ImportBundle/Import/AbstractImport.php b/src/Wallabag/ImportBundle/Import/AbstractImport.php index d39d71b6..5ae4aa8d 100644 --- a/src/Wallabag/ImportBundle/Import/AbstractImport.php +++ b/src/Wallabag/ImportBundle/Import/AbstractImport.php | |||
@@ -169,7 +169,7 @@ abstract class AbstractImport implements ImportInterface | |||
169 | $entry = $this->parseEntry($importedEntry); | 169 | $entry = $this->parseEntry($importedEntry); |
170 | 170 | ||
171 | if (null === $entry) { | 171 | if (null === $entry) { |
172 | continue; | 172 | break; |
173 | } | 173 | } |
174 | 174 | ||
175 | // store each entry to be flushed so we can trigger the entry.saved event for each of them | 175 | // store each entry to be flushed so we can trigger the entry.saved event for each of them |
diff --git a/src/Wallabag/ImportBundle/Import/BrowserImport.php b/src/Wallabag/ImportBundle/Import/BrowserImport.php index 804bc6cd..178ebe8e 100644 --- a/src/Wallabag/ImportBundle/Import/BrowserImport.php +++ b/src/Wallabag/ImportBundle/Import/BrowserImport.php | |||
@@ -158,13 +158,13 @@ abstract class BrowserImport extends AbstractImport | |||
158 | 158 | ||
159 | foreach ($entries as $importedEntry) { | 159 | foreach ($entries as $importedEntry) { |
160 | if ((array) $importedEntry !== $importedEntry) { | 160 | if ((array) $importedEntry !== $importedEntry) { |
161 | continue; | 161 | break; |
162 | } | 162 | } |
163 | 163 | ||
164 | $entry = $this->parseEntry($importedEntry); | 164 | $entry = $this->parseEntry($importedEntry); |
165 | 165 | ||
166 | if (null === $entry) { | 166 | if (null === $entry) { |
167 | continue; | 167 | break; |
168 | } | 168 | } |
169 | 169 | ||
170 | // @see AbstractImport | 170 | // @see AbstractImport |
@@ -206,7 +206,7 @@ abstract class BrowserImport extends AbstractImport | |||
206 | { | 206 | { |
207 | foreach ($entries as $importedEntry) { | 207 | foreach ($entries as $importedEntry) { |
208 | if ((array) $importedEntry !== $importedEntry) { | 208 | if ((array) $importedEntry !== $importedEntry) { |
209 | continue; | 209 | break; |
210 | } | 210 | } |
211 | 211 | ||
212 | // set userId for the producer (it won't know which user is connected) | 212 | // set userId for the producer (it won't know which user is connected) |
diff --git a/src/Wallabag/ImportBundle/Import/InstapaperImport.php b/src/Wallabag/ImportBundle/Import/InstapaperImport.php index 439c978c..6b6b35af 100644 --- a/src/Wallabag/ImportBundle/Import/InstapaperImport.php +++ b/src/Wallabag/ImportBundle/Import/InstapaperImport.php | |||
@@ -65,7 +65,7 @@ class InstapaperImport extends AbstractImport | |||
65 | $handle = fopen($this->filepath, 'r'); | 65 | $handle = fopen($this->filepath, 'r'); |
66 | while (false !== ($data = fgetcsv($handle, 10240))) { | 66 | while (false !== ($data = fgetcsv($handle, 10240))) { |
67 | if ('URL' === $data[0]) { | 67 | if ('URL' === $data[0]) { |
68 | continue; | 68 | break; |
69 | } | 69 | } |
70 | 70 | ||
71 | // last element in the csv is the folder where the content belong | 71 | // last element in the csv is the folder where the content belong |