From fe16b01edb80ac2f2212125fadba8358dff91b95 Mon Sep 17 00:00:00 2001 From: ArthurHoaro Date: Thu, 8 Jan 2015 15:09:46 +0100 Subject: * removed the language attribute on the script element since it is obsolete and we can safely omit it. * make QRCode JS works with IE : * behave as a normal link if canvas aren't supported (<=IE8) * default parameter values in JS aren't widely supported (see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters ), use this method instead: http://stackoverflow.com/a/148918/1484919 * dataset isn't supported in IE9 use getAttribute instead * addEventListener works with IE9+ and other browsers --- tpl/linklist.html | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) (limited to 'tpl/linklist.html') diff --git a/tpl/linklist.html b/tpl/linklist.html index 42a75a1a..d5bfadf8 100644 --- a/tpl/linklist.html +++ b/tpl/linklist.html @@ -52,7 +52,7 @@ archive - {/if}
QR-Code
- + onclick="return showQrCode(this);" class="qrcode" data-permalink="{$scripturl}?{$value.linkdate|smallHash}"> - {$value.url|htmlspecialchars}
{if="$value.tags"}
@@ -79,12 +79,20 @@ function remove_qrcode() return false; } +function isCanvasSupported(){ + var elem = document.createElement('canvas'); + return !!(elem.getContext && elem.getContext('2d')); +} + // Show the QR-Code of a permalink (when the QR-Code icon is clicked). -function showQrCode(caller,loading=false) +function showQrCode(caller,loading) { + if( !isCanvasSupported() ) return true; + // Dynamic javascript lib loading: We only load qr.js if the QR code icon is clicked: if (typeof(qr)=='undefined') // Load qr.js only if not present. { + loading = typeof loading !== 'undefined' ? loading : false; if (!loading) // If javascript lib is still loading, do not append script to body. { var element = document.createElement("script"); @@ -101,12 +109,12 @@ function showQrCode(caller,loading=false) // Build the div which contains the QR-Code: var element = document.createElement('div'); element.id="permalinkQrcode"; - // Make QR-Code div commit sepuku when clicked: - if ( element.attachEvent ){ element.attachEvent('onclick', 'this.parentNode.removeChild(this);' ); } // Damn IE - else { element.setAttribute('onclick', 'this.parentNode.removeChild(this);' ); } + + // Make QR-Code div commit sepuku when clicked: + element.addEventListener('click', remove_qrcode ); // Works on every canvas supported browser // Build the QR-Code: - var image = qr.image({size: 8,value: caller.dataset.permalink}); + var image = qr.image({size: 8,value: caller.getAttribute('data-permalink')}); if (image) { element.appendChild(image); -- cgit v1.2.3