From 5d8de7587d67b5c3e5d1fed8562d9b87ecde80c1 Mon Sep 17 00:00:00 2001
From: ArthurHoaro <arthur@hoa.ro>
Date: Sat, 10 Oct 2020 17:40:26 +0200
Subject: Feature: bulk creation of bookmarks

This changes creates a new form in addlink page allowing to create
multiple bookmarks at once more easily. It focuses on re-using as much
existing code and template component as  possible.

These changes includes:
  - a new form in addlink (hidden behind a button by default),
containing a text area for URL, and tags/private status to apply to
created links
  - this form displays a new template called editlink.batch, itself
including editlink template multiple times
  - User interation in this new templates are handle by a new JS script
(shaare-batch.js) making AJAX requests, and therefore does not need page
reloading
  - ManageShaareController has been split into 3 distinct controllers:
    + ShaareAdd: displays addlink template
    + ShaareManage: various operation applied on existing shaares
(change visibility, pin, deletion, etc.)
    + ShaarePublish: handles creation/edit forms and saving Shaare's
form
  - Updated translations

Fixes #137
---
 .../ManageShaareControllerTest/PinBookmarkTest.php | 145 ---------------------
 1 file changed, 145 deletions(-)
 delete mode 100644 tests/front/controller/admin/ManageShaareControllerTest/PinBookmarkTest.php

(limited to 'tests/front/controller/admin/ManageShaareControllerTest/PinBookmarkTest.php')

diff --git a/tests/front/controller/admin/ManageShaareControllerTest/PinBookmarkTest.php b/tests/front/controller/admin/ManageShaareControllerTest/PinBookmarkTest.php
deleted file mode 100644
index 50ce7df1..00000000
--- a/tests/front/controller/admin/ManageShaareControllerTest/PinBookmarkTest.php
+++ /dev/null
@@ -1,145 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Shaarli\Front\Controller\Admin\ManageShaareControllerTest;
-
-use Shaarli\Bookmark\Bookmark;
-use Shaarli\Bookmark\Exception\BookmarkNotFoundException;
-use Shaarli\Front\Controller\Admin\FrontAdminControllerMockHelper;
-use Shaarli\Front\Controller\Admin\ManageShaareController;
-use Shaarli\Http\HttpAccess;
-use Shaarli\Security\SessionManager;
-use Shaarli\TestCase;
-use Slim\Http\Request;
-use Slim\Http\Response;
-
-class PinBookmarkTest extends TestCase
-{
-    use FrontAdminControllerMockHelper;
-
-    /** @var ManageShaareController */
-    protected $controller;
-
-    public function setUp(): void
-    {
-        $this->createContainer();
-
-        $this->container->httpAccess = $this->createMock(HttpAccess::class);
-        $this->controller = new ManageShaareController($this->container);
-    }
-
-    /**
-     * Test pin bookmark - with valid input
-     *
-     * @dataProvider initialStickyValuesProvider()
-     */
-    public function testPinBookmarkIsStickyNull(?bool $sticky, bool $expectedValue): void
-    {
-        $id = 123;
-
-        $request = $this->createMock(Request::class);
-        $response = new Response();
-
-        $bookmark = (new Bookmark())
-            ->setId(123)
-            ->setUrl('http://domain.tld')
-            ->setTitle('Title 123')
-            ->setSticky($sticky)
-        ;
-
-        $this->container->bookmarkService->expects(static::once())->method('get')->with(123)->willReturn($bookmark);
-        $this->container->bookmarkService->expects(static::once())->method('set')->with($bookmark, true);
-
-        // Make sure that PluginManager hook is triggered
-        $this->container->pluginManager
-            ->expects(static::once())
-            ->method('executeHooks')
-            ->with('save_link')
-        ;
-
-        $result = $this->controller->pinBookmark($request, $response, ['id' => (string) $id]);
-
-        static::assertSame(302, $result->getStatusCode());
-        static::assertSame(['/subfolder/'], $result->getHeader('location'));
-
-        static::assertSame($expectedValue, $bookmark->isSticky());
-    }
-
-    public function initialStickyValuesProvider(): array
-    {
-        // [initialStickyState, isStickyAfterPin]
-        return [[null, true], [false, true], [true, false]];
-    }
-
-    /**
-     * Test pin bookmark - invalid bookmark ID
-     */
-    public function testDisplayEditFormInvalidId(): void
-    {
-        $id = 'invalid';
-
-        $request = $this->createMock(Request::class);
-        $response = new Response();
-
-        $this->container->sessionManager
-            ->expects(static::once())
-            ->method('setSessionParameter')
-            ->with(SessionManager::KEY_ERROR_MESSAGES, ['Bookmark with identifier invalid could not be found.'])
-        ;
-
-        $result = $this->controller->pinBookmark($request, $response, ['id' => $id]);
-
-        static::assertSame(302, $result->getStatusCode());
-        static::assertSame(['/subfolder/'], $result->getHeader('location'));
-    }
-
-    /**
-     * Test pin bookmark - Bookmark ID not provided
-     */
-    public function testDisplayEditFormIdNotProvided(): void
-    {
-        $request = $this->createMock(Request::class);
-        $response = new Response();
-
-        $this->container->sessionManager
-            ->expects(static::once())
-            ->method('setSessionParameter')
-            ->with(SessionManager::KEY_ERROR_MESSAGES, ['Bookmark with identifier  could not be found.'])
-        ;
-
-        $result = $this->controller->pinBookmark($request, $response, []);
-
-        static::assertSame(302, $result->getStatusCode());
-        static::assertSame(['/subfolder/'], $result->getHeader('location'));
-    }
-
-    /**
-     * Test pin bookmark - bookmark not found
-     */
-    public function testDisplayEditFormBookmarkNotFound(): void
-    {
-        $id = 123;
-
-        $request = $this->createMock(Request::class);
-        $response = new Response();
-
-        $this->container->bookmarkService
-            ->expects(static::once())
-            ->method('get')
-            ->with($id)
-            ->willThrowException(new BookmarkNotFoundException())
-        ;
-
-        $this->container->sessionManager
-            ->expects(static::once())
-            ->method('setSessionParameter')
-            ->with(SessionManager::KEY_ERROR_MESSAGES, ['Bookmark with identifier 123 could not be found.'])
-        ;
-
-        $result = $this->controller->pinBookmark($request, $response, ['id' => (string) $id]);
-
-        static::assertSame(302, $result->getStatusCode());
-        static::assertSame(['/subfolder/'], $result->getHeader('location'));
-    }
-}
-- 
cgit v1.2.3