From b1baca99f280570d0336b4d71ad1f9dca213a35b Mon Sep 17 00:00:00 2001 From: ArthurHoaro Date: Sun, 27 Sep 2020 14:07:08 +0200 Subject: Convert legacy PHPUnit @expected* to new ->expect* Converted automatically using https://github.com/ArthurHoaro/convert-legacy-phpunit-expect --- tests/config/ConfigJsonTest.php | 14 +++++++------- tests/config/ConfigManagerTest.php | 22 +++++++++++----------- tests/config/ConfigPluginTest.php | 4 ++-- 3 files changed, 20 insertions(+), 20 deletions(-) (limited to 'tests/config') diff --git a/tests/config/ConfigJsonTest.php b/tests/config/ConfigJsonTest.php index f1612e9b..f884b0c6 100644 --- a/tests/config/ConfigJsonTest.php +++ b/tests/config/ConfigJsonTest.php @@ -38,12 +38,12 @@ class ConfigJsonTest extends \PHPUnit\Framework\TestCase /** * Read a non existent config file -> empty array. - * - * @expectedException \Exception - * @expectedExceptionMessageRegExp /An error occurred while parsing JSON configuration file \([\w\/\.]+\): error code #4/ */ public function testReadInvalidJson() { + $this->expectException(\Exception::class); + $this->expectExceptionMessageRegExp(' /An error occurred while parsing JSON configuration file \\([\\w\\/\\.]+\\): error code #4/'); + $this->configIO->read('tests/utils/config/configInvalid.json.php'); } @@ -110,22 +110,22 @@ class ConfigJsonTest extends \PHPUnit\Framework\TestCase /** * Write to invalid path. - * - * @expectedException \Shaarli\Exceptions\IOException */ public function testWriteInvalidArray() { + $this->expectException(\Shaarli\Exceptions\IOException::class); + $conf = array('conf' => 'value'); @$this->configIO->write(array(), $conf); } /** * Write to invalid path. - * - * @expectedException \Shaarli\Exceptions\IOException */ public function testWriteInvalidBlank() { + $this->expectException(\Shaarli\Exceptions\IOException::class); + $conf = array('conf' => 'value'); @$this->configIO->write('', $conf); } diff --git a/tests/config/ConfigManagerTest.php b/tests/config/ConfigManagerTest.php index 69456bce..802e6524 100644 --- a/tests/config/ConfigManagerTest.php +++ b/tests/config/ConfigManagerTest.php @@ -95,44 +95,44 @@ class ConfigManagerTest extends \PHPUnit\Framework\TestCase /** * Set with an empty key. - * - * @expectedException \Exception - * @expectedExceptionMessageRegExp #^Invalid setting key parameter. String expected, got.*# */ public function testSetEmptyKey() { + $this->expectException(\Exception::class); + $this->expectExceptionMessageRegExp('#^Invalid setting key parameter. String expected, got.*#'); + $this->conf->set('', 'stuff'); } /** * Set with an array key. - * - * @expectedException \Exception - * @expectedExceptionMessageRegExp #^Invalid setting key parameter. String expected, got.*# */ public function testSetArrayKey() { + $this->expectException(\Exception::class); + $this->expectExceptionMessageRegExp('#^Invalid setting key parameter. String expected, got.*#'); + $this->conf->set(array('foo' => 'bar'), 'stuff'); } /** * Remove with an empty key. - * - * @expectedException \Exception - * @expectedExceptionMessageRegExp #^Invalid setting key parameter. String expected, got.*# */ public function testRmoveEmptyKey() { + $this->expectException(\Exception::class); + $this->expectExceptionMessageRegExp('#^Invalid setting key parameter. String expected, got.*#'); + $this->conf->remove(''); } /** * Try to write the config without mandatory parameter (e.g. 'login'). - * - * @expectedException Shaarli\Config\Exception\MissingFieldConfigException */ public function testWriteMissingParameter() { + $this->expectException(\Shaarli\Config\Exception\MissingFieldConfigException::class); + $this->conf->setConfigFile('tests/utils/config/configTmp'); $this->assertFalse(file_exists($this->conf->getConfigFileExt())); $this->conf->reload(); diff --git a/tests/config/ConfigPluginTest.php b/tests/config/ConfigPluginTest.php index b2cc0045..3a45f623 100644 --- a/tests/config/ConfigPluginTest.php +++ b/tests/config/ConfigPluginTest.php @@ -46,11 +46,11 @@ class ConfigPluginTest extends \PHPUnit\Framework\TestCase /** * Test save_plugin_config with invalid data. - * - * @expectedException Shaarli\Config\Exception\PluginConfigOrderException */ public function testSavePluginConfigInvalid() { + $this->expectException(\Shaarli\Config\Exception\PluginConfigOrderException::class); + $data = array( 'plugin2' => 0, 'plugin3' => 0, -- cgit v1.2.3