From 42a72c02fa4b6a5eb9d26a7a3a990e497fc10df3 Mon Sep 17 00:00:00 2001
From: Ganesh Kandu <kanduganesh@gmail.com>
Date: Tue, 27 Oct 2020 17:42:35 +0530
Subject: Replaced PHP_EOL  to "\n"
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

i was getting error

```
An error occurred while parsing JSON configuration file (data/config.json.php): error code #4
➜ Syntax error
Please check your JSON syntax (without PHP comment tags) using a JSON lint tool such as jsonlint.com.
```
after debug i found
```php
        $data = str_replace(self::getPhpHeaders(), '', $data);
        $data = str_replace(self::getPhpSuffix(), '', $data);
```
doesn't removing php header and php suffix

cause of this issue was PHP_EOL represents the endline character for the current system. if my  ```config.json.php```  was encoded with unix ( LF ) and php running on windows windows encoding ( CR LF ) is not same as unix encoding ( LF ) so ```str_replace``` doesn't replace strin  then it causes issue.
---
 application/config/ConfigJson.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'application/config/ConfigJson.php')

diff --git a/application/config/ConfigJson.php b/application/config/ConfigJson.php
index c0c0dab9..eaa4ee3f 100644
--- a/application/config/ConfigJson.php
+++ b/application/config/ConfigJson.php
@@ -73,7 +73,7 @@ class ConfigJson implements ConfigIO
      */
     public static function getPhpHeaders()
     {
-        return '<?php /*'. PHP_EOL;
+        return '<?php /*'. "\n";
     }
 
     /**
@@ -85,6 +85,6 @@ class ConfigJson implements ConfigIO
      */
     public static function getPhpSuffix()
     {
-        return PHP_EOL . '*/ ?>';
+        return "\n" . '*/ ?>';
     }
 }
-- 
cgit v1.2.3


From e69e3fef7bbdc7299ae01aa0e0258395d2e49818 Mon Sep 17 00:00:00 2001
From: Ganesh Kandu <kanduganesh@gmail.com>
Date: Tue, 27 Oct 2020 18:08:14 +0530
Subject: Removed PHP_EOL

just replace "*/ ?>" and "<?php /*" with '' and "Trim" output whatever is EOF will trimmed out.
---
 application/config/ConfigJson.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'application/config/ConfigJson.php')

diff --git a/application/config/ConfigJson.php b/application/config/ConfigJson.php
index eaa4ee3f..23b22269 100644
--- a/application/config/ConfigJson.php
+++ b/application/config/ConfigJson.php
@@ -19,7 +19,7 @@ class ConfigJson implements ConfigIO
         $data = file_get_contents($filepath);
         $data = str_replace(self::getPhpHeaders(), '', $data);
         $data = str_replace(self::getPhpSuffix(), '', $data);
-        $data = json_decode($data, true);
+        $data = json_decode(trim($data), true);
         if ($data === null) {
             $errorCode = json_last_error();
             $error  = sprintf(
@@ -73,7 +73,7 @@ class ConfigJson implements ConfigIO
      */
     public static function getPhpHeaders()
     {
-        return '<?php /*'. "\n";
+        return '<?php /*';
     }
 
     /**
@@ -85,6 +85,6 @@ class ConfigJson implements ConfigIO
      */
     public static function getPhpSuffix()
     {
-        return "\n" . '*/ ?>';
+        return '*/ ?>';
     }
 }
-- 
cgit v1.2.3