From 141a86c503af8e314381b3ee39ba4287fdfac63e Mon Sep 17 00:00:00 2001 From: ArthurHoaro Date: Wed, 11 May 2016 00:05:22 +0200 Subject: Add private link counter --- application/LinkUtils.php | 16 ++++++++++++++++ index.php | 17 +++-------------- tests/LinkUtilsTest.php | 9 +++++++++ tpl/page.header.html | 3 ++- 4 files changed, 30 insertions(+), 15 deletions(-) diff --git a/application/LinkUtils.php b/application/LinkUtils.php index 2df76ba8..da04ca97 100644 --- a/application/LinkUtils.php +++ b/application/LinkUtils.php @@ -77,3 +77,19 @@ function html_extract_charset($html) return false; } + +/** + * Count private links in given linklist. + * + * @param array $links Linklist. + * + * @return int Number of private links. + */ +function count_private($links) +{ + $cpt = 0; + foreach ($links as $link) { + $cpt = $link['private'] == true ? $cpt + 1 : $cpt; + } + return $cpt; +} diff --git a/index.php b/index.php index 01c23195..90fdac81 100644 --- a/index.php +++ b/index.php @@ -736,7 +736,6 @@ function showDaily($pageBuilder, $LINKSDB) $dayDate = DateTime::createFromFormat(LinkDB::LINK_DATE_FORMAT, $day.'_000000'); $data = array( 'linksToDisplay' => $linksToDisplay, - 'linkcount' => count($LINKSDB), 'cols' => $columns, 'day' => $dayDate->getTimestamp(), 'previousday' => $previousday, @@ -792,6 +791,8 @@ function renderPage() } $PAGE = new PageBuilder(); + $PAGE->assign('linkcount', count($LINKSDB)); + $PAGE->assign('privateLinkcount', count_private($LINKSDB)); // Determine which page will be rendered. $query = (isset($_SERVER['QUERY_STRING'])) ? $_SERVER['QUERY_STRING'] : ''; @@ -855,7 +856,6 @@ function renderPage() } $data = array( - 'linkcount' => count($LINKSDB), 'linksToDisplay' => $linksToDisplay, ); $pluginManager->executeHooks('render_picwall', $data, array('loggedin' => isLoggedIn())); @@ -905,7 +905,6 @@ function renderPage() } $data = array( - 'linkcount' => count($LINKSDB), 'tags' => $tagList, ); $pluginManager->executeHooks('render_tagcloud', $data, array('loggedin' => isLoggedIn())); @@ -1099,7 +1098,6 @@ function renderPage() if ($targetPage == Router::$PAGE_TOOLS) { $data = array( - 'linkcount' => count($LINKSDB), 'pageabsaddr' => index_url($_SERVER), ); $pluginManager->executeHooks('render_tools', $data); @@ -1144,7 +1142,6 @@ function renderPage() } else // show the change password form. { - $PAGE->assign('linkcount',count($LINKSDB)); $PAGE->assign('token',getToken()); $PAGE->renderPage('changepassword'); exit; @@ -1192,7 +1189,6 @@ function renderPage() } else // Show the configuration form. { - $PAGE->assign('linkcount',count($LINKSDB)); $PAGE->assign('token',getToken()); $PAGE->assign('title', empty($GLOBALS['title']) ? '' : $GLOBALS['title'] ); $PAGE->assign('redirector', empty($GLOBALS['redirector']) ? '' : $GLOBALS['redirector'] ); @@ -1208,7 +1204,6 @@ function renderPage() if ($targetPage == Router::$PAGE_CHANGETAG) { if (empty($_POST['fromtag']) || (empty($_POST['totag']) && isset($_POST['renametag']))) { - $PAGE->assign('linkcount', count($LINKSDB)); $PAGE->assign('token', getToken()); $PAGE->assign('tags', $LINKSDB->allTags()); $PAGE->renderPage('changetag'); @@ -1257,7 +1252,6 @@ function renderPage() // -------- User wants to add a link without using the bookmarklet: Show form. if ($targetPage == Router::$PAGE_ADDLINK) { - $PAGE->assign('linkcount',count($LINKSDB)); $PAGE->renderPage('addlink'); exit; } @@ -1383,7 +1377,6 @@ function renderPage() $link = $LINKSDB[$_GET['edit_link']]; // Read database if (!$link) { header('Location: ?'); exit; } // Link not found in database. $data = array( - 'linkcount' => count($LINKSDB), 'link' => $link, 'link_is_new' => false, 'token' => getToken(), @@ -1451,7 +1444,6 @@ function renderPage() } $data = array( - 'linkcount' => count($LINKSDB), 'link' => $link, 'link_is_new' => $link_is_new, 'token' => getToken(), // XSRF protection. @@ -1473,7 +1465,6 @@ function renderPage() // Export links as a Netscape Bookmarks file if (empty($_GET['selection'])) { - $PAGE->assign('linkcount',count($LINKSDB)); $PAGE->renderPage('export'); exit; } @@ -1532,7 +1523,6 @@ function renderPage() // -------- Show upload/import dialog: if ($targetPage == Router::$PAGE_IMPORT) { - $PAGE->assign('linkcount',count($LINKSDB)); $PAGE->assign('token',getToken()); $PAGE->assign('maxfilesize',getMaxFileSize()); $PAGE->renderPage('import'); @@ -1764,7 +1754,6 @@ function buildLinkList($PAGE,$LINKSDB) // Fill all template fields. $data = array( - 'linkcount' => count($LINKSDB), 'previous_page_url' => $previous_page_url, 'next_page_url' => $next_page_url, 'page_current' => $page, @@ -2039,7 +2028,7 @@ function install() $timezone_html = 'Timezone:'.$timezone_form.''; } - $PAGE = new pageBuilder; + $PAGE = new PageBuilder(); $PAGE->assign('timezone_html',$timezone_html); $PAGE->assign('timezone_js',$timezone_js); $PAGE->renderPage('install'); diff --git a/tests/LinkUtilsTest.php b/tests/LinkUtilsTest.php index 609a80cb..d1b022fd 100644 --- a/tests/LinkUtilsTest.php +++ b/tests/LinkUtilsTest.php @@ -84,4 +84,13 @@ class LinkUtilsTest extends PHPUnit_Framework_TestCase $html = 'stuff'; $this->assertFalse(html_extract_charset($html)); } + + /** + * Test count_private. + */ + public function testCountPrivateLinks() + { + $refDB = new ReferenceLinkDB(); + $this->assertEquals($refDB->countPrivateLinks(), count_private($refDB->getLinks())); + } } diff --git a/tpl/page.header.html b/tpl/page.header.html index 52429f23..3a09ecd9 100644 --- a/tpl/page.header.html +++ b/tpl/page.header.html @@ -2,7 +2,8 @@
- {if="!empty($linkcount)"}{$linkcount} links{/if} + {if="!empty($linkcount)"}{$linkcount} links{/if}
+ {if="!empty($privateLinkcount)"}{$privateLinkcount} private links{/if}