diff options
-rw-r--r-- | application/LinkDB.php | 2 | ||||
-rw-r--r-- | tests/LinkDBTest.php | 30 | ||||
-rw-r--r-- | tests/utils/ReferenceLinkDB.php | 2 |
3 files changed, 6 insertions, 28 deletions
diff --git a/application/LinkDB.php b/application/LinkDB.php index e9d216ea..d80434bf 100644 --- a/application/LinkDB.php +++ b/application/LinkDB.php | |||
@@ -291,7 +291,7 @@ You use the community supported version of the original Shaarli project, by Seba | |||
291 | 291 | ||
292 | // Remove private tags if the user is not logged in. | 292 | // Remove private tags if the user is not logged in. |
293 | if (! $this->_loggedIn) { | 293 | if (! $this->_loggedIn) { |
294 | $link['tags'] = preg_replace('/(^|\s*)\.[^($| )]+\s*$/', '', $link['tags']); | 294 | $link['tags'] = preg_replace('/(^|\s+)\.[^($|\s)]+\s*/', ' ', $link['tags']); |
295 | } | 295 | } |
296 | 296 | ||
297 | // Do not use the redirector for internal links (Shaarli note URL starting with a '?'). | 297 | // Do not use the redirector for internal links (Shaarli note URL starting with a '?'). |
diff --git a/tests/LinkDBTest.php b/tests/LinkDBTest.php index e413928a..31306069 100644 --- a/tests/LinkDBTest.php +++ b/tests/LinkDBTest.php | |||
@@ -317,6 +317,10 @@ class LinkDBTest extends PHPUnit_Framework_TestCase | |||
317 | '-exclude' => 1, | 317 | '-exclude' => 1, |
318 | '.hidden' => 1, | 318 | '.hidden' => 1, |
319 | 'hashtag' => 2, | 319 | 'hashtag' => 2, |
320 | 'tag1' => 1, | ||
321 | 'tag2' => 1, | ||
322 | 'tag3' => 1, | ||
323 | 'tag4' => 1, | ||
320 | ), | 324 | ), |
321 | self::$privateLinkDB->allTags() | 325 | self::$privateLinkDB->allTags() |
322 | ); | 326 | ); |
@@ -429,30 +433,4 @@ class LinkDBTest extends PHPUnit_Framework_TestCase | |||
429 | { | 433 | { |
430 | self::$publicLinkDB->filterHash(''); | 434 | self::$publicLinkDB->filterHash(''); |
431 | } | 435 | } |
432 | |||
433 | /** | ||
434 | * test whitespace handling in tags. | ||
435 | * split on whitespace runs and don't allow empty tags. | ||
436 | */ | ||
437 | public function testReadTagsWithWhitespace() | ||
438 | { | ||
439 | // test load contains "tags": " tag1 tag2 tag3 tag4 " | ||
440 | $ds = '<?php /* '; | ||
441 | $ds .= 'fY5BDoMwDAS/gvwB4hRKMY9BEaASNQKUuL1U/L22D721Odheez'; | ||
442 | $ds .= 'baQEjvQtgSeIdX12I/onfyYAjU6e1GkOL2mAMvMPxAC8mWIydD'; | ||
443 | $ds .= 'enHsU0jrXlj1heCZk5k7gpX5oLr+ErUdkGBeypTjwXHfdOUItD'; | ||
444 | $ds .= 'XycbgXHb24KxFYafWVtYvVRoQiQhw5vixrJDdY/LyENP5PcJ4f */ ?>'; | ||
445 | file_put_contents(self::$testDatastore, $ds); | ||
446 | self::$publicLinkDB = new LinkDB(self::$testDatastore, false, false); | ||
447 | |||
448 | $this->assertEquals( | ||
449 | array( | ||
450 | 'tag1' => 1, | ||
451 | 'tag2' => 1, | ||
452 | 'tag3' => 1, | ||
453 | 'tag4' => 1 | ||
454 | ), | ||
455 | self::$publicLinkDB->allTags() | ||
456 | ); | ||
457 | } | ||
458 | } | 436 | } |
diff --git a/tests/utils/ReferenceLinkDB.php b/tests/utils/ReferenceLinkDB.php index fe16baac..fcc7a4f9 100644 --- a/tests/utils/ReferenceLinkDB.php +++ b/tests/utils/ReferenceLinkDB.php | |||
@@ -75,7 +75,7 @@ class ReferenceLinkDB | |||
75 | '', | 75 | '', |
76 | 1, | 76 | 1, |
77 | '20121206_182539', | 77 | '20121206_182539', |
78 | 'dev cartoon' | 78 | 'dev cartoon tag1 tag2 tag3 tag4 ' |
79 | ); | 79 | ); |
80 | } | 80 | } |
81 | 81 | ||