diff options
author | ArthurHoaro <arthur@hoa.ro> | 2015-06-11 13:53:27 +0200 |
---|---|---|
committer | ArthurHoaro <arthur@hoa.ro> | 2015-06-23 16:35:36 +0200 |
commit | 5f85fcd863fe261921953ea3bd1742f3e1b7cf68 (patch) | |
tree | 5615922c1c696ec04cc60625a8d401b2b297a462 /tpl/picwall.html | |
parent | 0923a2bc1b097bf1def882722db489d83d95c423 (diff) | |
download | Shaarli-5f85fcd863fe261921953ea3bd1742f3e1b7cf68.tar.gz Shaarli-5f85fcd863fe261921953ea3bd1742f3e1b7cf68.tar.zst Shaarli-5f85fcd863fe261921953ea3bd1742f3e1b7cf68.zip |
Working on shaarli/Shaarli#224
I reviewed character escaping everywhere with the following ideas:
* use a single common function to escape user data: `escape` using `htmlspecialchars`.
* sanitize fields in `index.php` after reading them from datastore and before sending them to templates.
It means no escaping function in Twig templates.
2 reasons:
* it reduces risks of security issue for future user made templates
* more readable templates
* sanitize user configuration fields after loading them.
Diffstat (limited to 'tpl/picwall.html')
-rw-r--r-- | tpl/picwall.html | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tpl/picwall.html b/tpl/picwall.html index e686afe1..9a2a4715 100644 --- a/tpl/picwall.html +++ b/tpl/picwall.html | |||
@@ -9,7 +9,7 @@ | |||
9 | <div id="picwall_container"> | 9 | <div id="picwall_container"> |
10 | {loop="linksToDisplay"} | 10 | {loop="linksToDisplay"} |
11 | <div class="picwall_pictureframe"> | 11 | <div class="picwall_pictureframe"> |
12 | {$value.thumbnail}<a href="{$value.url}"><span class="info">{$value.title|htmlspecialchars}</span></a> | 12 | {$value.thumbnail}<a href="{$value.url}"><span class="info">{$value.title}</span></a> |
13 | </div> | 13 | </div> |
14 | {/loop} | 14 | {/loop} |
15 | </div> | 15 | </div> |