diff options
| author | ArthurHoaro <arthur@hoa.ro> | 2020-10-02 17:50:59 +0200 |
|---|---|---|
| committer | ArthurHoaro <arthur@hoa.ro> | 2020-10-13 13:50:11 +0200 |
| commit | efb7d21b52eb033530e80e5e49d175e6e3b031f4 (patch) | |
| tree | 4f34052788a08be1a30cb88c3339ae14e0b7c4da /application/front/controller | |
| parent | 29c31b7ec6ca48ba37b7eb6da650931fd0cb7164 (diff) | |
| download | Shaarli-efb7d21b52eb033530e80e5e49d175e6e3b031f4.tar.gz Shaarli-efb7d21b52eb033530e80e5e49d175e6e3b031f4.tar.zst Shaarli-efb7d21b52eb033530e80e5e49d175e6e3b031f4.zip | |
Add strict types for bookmarks management
Parameters typing and using strict types overall increase the codebase
quality by enforcing the a given parameter will have the expected type.
It also removes the need to unnecessary unit tests checking methods
behavior with invalid input.
Diffstat (limited to 'application/front/controller')
| -rw-r--r-- | application/front/controller/admin/ThumbnailsController.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/application/front/controller/admin/ThumbnailsController.php b/application/front/controller/admin/ThumbnailsController.php index 81c87ed0..4dc09d38 100644 --- a/application/front/controller/admin/ThumbnailsController.php +++ b/application/front/controller/admin/ThumbnailsController.php | |||
| @@ -52,7 +52,7 @@ class ThumbnailsController extends ShaarliAdminController | |||
| 52 | } | 52 | } |
| 53 | 53 | ||
| 54 | try { | 54 | try { |
| 55 | $bookmark = $this->container->bookmarkService->get($id); | 55 | $bookmark = $this->container->bookmarkService->get((int) $id); |
| 56 | } catch (BookmarkNotFoundException $e) { | 56 | } catch (BookmarkNotFoundException $e) { |
| 57 | return $response->withStatus(404); | 57 | return $response->withStatus(404); |
| 58 | } | 58 | } |