diff options
author | ArthurHoaro <arthur@hoa.ro> | 2020-10-16 12:16:54 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-10-16 12:16:54 +0200 |
commit | cd2878edeeb1f28356c486c73a12af827b2d9f93 (patch) | |
tree | 0518028680da108dba684d37605130ffe036de1b | |
parent | f34554c6c2cd8fe99fe2e8907bfc196a4884416a (diff) | |
parent | 4b3aca66238f4ec31ab67c990fd388738e959289 (diff) | |
download | Shaarli-cd2878edeeb1f28356c486c73a12af827b2d9f93.tar.gz Shaarli-cd2878edeeb1f28356c486c73a12af827b2d9f93.tar.zst Shaarli-cd2878edeeb1f28356c486c73a12af827b2d9f93.zip |
Merge pull request #1592 from ArthurHoaro/fix/strict-type-daily
Strict types: fix an issue in daily where the date could be an int
-rw-r--r-- | application/bookmark/BookmarkFileService.php | 2 | ||||
-rw-r--r-- | tests/bookmark/BookmarkFileServiceTest.php | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/application/bookmark/BookmarkFileService.php b/application/bookmark/BookmarkFileService.php index 804b2520..eb7899bf 100644 --- a/application/bookmark/BookmarkFileService.php +++ b/application/bookmark/BookmarkFileService.php | |||
@@ -349,7 +349,7 @@ class BookmarkFileService implements BookmarkServiceInterface | |||
349 | $bookmarkDays = array_keys($bookmarkDays); | 349 | $bookmarkDays = array_keys($bookmarkDays); |
350 | sort($bookmarkDays); | 350 | sort($bookmarkDays); |
351 | 351 | ||
352 | return $bookmarkDays; | 352 | return array_map('strval', $bookmarkDays); |
353 | } | 353 | } |
354 | 354 | ||
355 | /** | 355 | /** |
diff --git a/tests/bookmark/BookmarkFileServiceTest.php b/tests/bookmark/BookmarkFileServiceTest.php index 59c0608c..42485c99 100644 --- a/tests/bookmark/BookmarkFileServiceTest.php +++ b/tests/bookmark/BookmarkFileServiceTest.php | |||
@@ -690,12 +690,12 @@ class BookmarkFileServiceTest extends TestCase | |||
690 | */ | 690 | */ |
691 | public function testDays() | 691 | public function testDays() |
692 | { | 692 | { |
693 | $this->assertEquals( | 693 | $this->assertSame( |
694 | ['20100309', '20100310', '20121206', '20121207', '20130614', '20150310'], | 694 | ['20100309', '20100310', '20121206', '20121207', '20130614', '20150310'], |
695 | $this->publicLinkDB->days() | 695 | $this->publicLinkDB->days() |
696 | ); | 696 | ); |
697 | 697 | ||
698 | $this->assertEquals( | 698 | $this->assertSame( |
699 | ['20100309', '20100310', '20121206', '20121207', '20130614', '20141125', '20150310'], | 699 | ['20100309', '20100310', '20121206', '20121207', '20130614', '20141125', '20150310'], |
700 | $this->privateLinkDB->days() | 700 | $this->privateLinkDB->days() |
701 | ); | 701 | ); |