aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorArthurHoaro <arthur@hoa.ro>2020-11-06 10:00:03 +0100
committerGitHub <noreply@github.com>2020-11-06 10:00:03 +0100
commit8c5f6c786d00310b2e863aa316927effb7bfeedb (patch)
tree5f3083c9b8d7078dbb1e9986db4fb7f6f8b6266b
parent48df9f45b8c4b2995c1e04146071628668531b37 (diff)
parentcfdd2094407e61f371c02117c8c66916a6d1d807 (diff)
downloadShaarli-8c5f6c786d00310b2e863aa316927effb7bfeedb.tar.gz
Shaarli-8c5f6c786d00310b2e863aa316927effb7bfeedb.tar.zst
Shaarli-8c5f6c786d00310b2e863aa316927effb7bfeedb.zip
Merge pull request #1627 from ArthurHoaro/fix/unexpected-error
Display error details even with dev.debug set to false
-rw-r--r--application/front/controller/visitor/ErrorController.php11
-rw-r--r--assets/default/scss/shaarli.scss6
-rw-r--r--inc/languages/fr/LC_MESSAGES/shaarli.po14
-rw-r--r--tests/front/controller/visitor/ErrorControllerTest.php29
-rw-r--r--tpl/default/error.html8
5 files changed, 58 insertions, 10 deletions
diff --git a/application/front/controller/visitor/ErrorController.php b/application/front/controller/visitor/ErrorController.php
index 8da11172..428e8254 100644
--- a/application/front/controller/visitor/ErrorController.php
+++ b/application/front/controller/visitor/ErrorController.php
@@ -26,8 +26,14 @@ class ErrorController extends ShaarliVisitorController
26 $response = $response->withStatus($throwable->getCode()); 26 $response = $response->withStatus($throwable->getCode());
27 } else { 27 } else {
28 // Internal error (any other Throwable) 28 // Internal error (any other Throwable)
29 if ($this->container->conf->get('dev.debug', false)) { 29 if ($this->container->conf->get('dev.debug', false) || $this->container->loginManager->isLoggedIn()) {
30 $this->assignView('message', $throwable->getMessage()); 30 $this->assignView('message', t('Error: ') . $throwable->getMessage());
31 $this->assignView(
32 'text',
33 '<a href="https://github.com/shaarli/Shaarli/issues/new">'
34 . t('Please report it on Github.')
35 . '</a>'
36 );
31 $this->assignView('stacktrace', exception2text($throwable)); 37 $this->assignView('stacktrace', exception2text($throwable));
32 } else { 38 } else {
33 $this->assignView('message', t('An unexpected error occurred.')); 39 $this->assignView('message', t('An unexpected error occurred.'));
@@ -36,7 +42,6 @@ class ErrorController extends ShaarliVisitorController
36 $response = $response->withStatus(500); 42 $response = $response->withStatus(500);
37 } 43 }
38 44
39
40 return $response->write($this->render('error')); 45 return $response->write($this->render('error'));
41 } 46 }
42} 47}
diff --git a/assets/default/scss/shaarli.scss b/assets/default/scss/shaarli.scss
index a7f091e9..3404ce12 100644
--- a/assets/default/scss/shaarli.scss
+++ b/assets/default/scss/shaarli.scss
@@ -1266,11 +1266,15 @@ form {
1266 margin: 70px 0 25px; 1266 margin: 70px 0 25px;
1267 } 1267 }
1268 1268
1269 a {
1270 color: var(--main-color);
1271 }
1272
1269 pre { 1273 pre {
1270 margin: 0 20%; 1274 margin: 0 20%;
1271 padding: 20px 0; 1275 padding: 20px 0;
1272 text-align: left; 1276 text-align: left;
1273 line-height: .7em; 1277 line-height: 1em;
1274 } 1278 }
1275} 1279}
1276 1280
diff --git a/inc/languages/fr/LC_MESSAGES/shaarli.po b/inc/languages/fr/LC_MESSAGES/shaarli.po
index 4c363fa8..51bef6c7 100644
--- a/inc/languages/fr/LC_MESSAGES/shaarli.po
+++ b/inc/languages/fr/LC_MESSAGES/shaarli.po
@@ -1,8 +1,8 @@
1msgid "" 1msgid ""
2msgstr "" 2msgstr ""
3"Project-Id-Version: Shaarli\n" 3"Project-Id-Version: Shaarli\n"
4"POT-Creation-Date: 2020-11-05 16:47+0100\n" 4"POT-Creation-Date: 2020-11-05 19:43+0100\n"
5"PO-Revision-Date: 2020-11-05 16:48+0100\n" 5"PO-Revision-Date: 2020-11-05 19:44+0100\n"
6"Last-Translator: \n" 6"Last-Translator: \n"
7"Language-Team: Shaarli\n" 7"Language-Team: Shaarli\n"
8"Language: fr_FR\n" 8"Language: fr_FR\n"
@@ -501,7 +501,15 @@ msgstr "mois"
501msgid "Monthly" 501msgid "Monthly"
502msgstr "Mensuel" 502msgstr "Mensuel"
503 503
504#: application/front/controller/visitor/ErrorController.php:33 504#: application/front/controller/visitor/ErrorController.php:30
505msgid "Error: "
506msgstr "Erreur : "
507
508#: application/front/controller/visitor/ErrorController.php:34
509msgid "Please report it on Github."
510msgstr "Merci de la rapporter sur Github."
511
512#: application/front/controller/visitor/ErrorController.php:39
505msgid "An unexpected error occurred." 513msgid "An unexpected error occurred."
506msgstr "Une erreur inattendue s'est produite." 514msgstr "Une erreur inattendue s'est produite."
507 515
diff --git a/tests/front/controller/visitor/ErrorControllerTest.php b/tests/front/controller/visitor/ErrorControllerTest.php
index 75408cf4..e18a6fa2 100644
--- a/tests/front/controller/visitor/ErrorControllerTest.php
+++ b/tests/front/controller/visitor/ErrorControllerTest.php
@@ -50,7 +50,31 @@ class ErrorControllerTest extends TestCase
50 } 50 }
51 51
52 /** 52 /**
53 * Test displaying error with any exception (no debug): only display an error occurred with HTTP 500. 53 * Test displaying error with any exception (no debug) while logged in:
54 * display full error details
55 */
56 public function testDisplayAnyExceptionErrorNoDebugLoggedIn(): void
57 {
58 $request = $this->createMock(Request::class);
59 $response = new Response();
60
61 // Save RainTPL assigned variables
62 $assignedVariables = [];
63 $this->assignTemplateVars($assignedVariables);
64
65 $this->container->loginManager->method('isLoggedIn')->willReturn(true);
66
67 $result = ($this->controller)($request, $response, new \Exception('abc'));
68
69 static::assertSame(500, $result->getStatusCode());
70 static::assertSame('Error: abc', $assignedVariables['message']);
71 static::assertContainsPolyfill('Please report it on Github', $assignedVariables['text']);
72 static::assertArrayHasKey('stacktrace', $assignedVariables);
73 }
74
75 /**
76 * Test displaying error with any exception (no debug) while logged out:
77 * display standard error without detail
54 */ 78 */
55 public function testDisplayAnyExceptionErrorNoDebug(): void 79 public function testDisplayAnyExceptionErrorNoDebug(): void
56 { 80 {
@@ -61,10 +85,13 @@ class ErrorControllerTest extends TestCase
61 $assignedVariables = []; 85 $assignedVariables = [];
62 $this->assignTemplateVars($assignedVariables); 86 $this->assignTemplateVars($assignedVariables);
63 87
88 $this->container->loginManager->method('isLoggedIn')->willReturn(false);
89
64 $result = ($this->controller)($request, $response, new \Exception('abc')); 90 $result = ($this->controller)($request, $response, new \Exception('abc'));
65 91
66 static::assertSame(500, $result->getStatusCode()); 92 static::assertSame(500, $result->getStatusCode());
67 static::assertSame('An unexpected error occurred.', $assignedVariables['message']); 93 static::assertSame('An unexpected error occurred.', $assignedVariables['message']);
94 static::assertArrayNotHasKey('text', $assignedVariables);
68 static::assertArrayNotHasKey('stacktrace', $assignedVariables); 95 static::assertArrayNotHasKey('stacktrace', $assignedVariables);
69 } 96 }
70} 97}
diff --git a/tpl/default/error.html b/tpl/default/error.html
index c3e0c3c1..34f9707d 100644
--- a/tpl/default/error.html
+++ b/tpl/default/error.html
@@ -9,13 +9,17 @@
9<div id="pageError" class="page-error-container center"> 9<div id="pageError" class="page-error-container center">
10 <h2>{$message}</h2> 10 <h2>{$message}</h2>
11 11
12 <img src="{$asset_path}/img/sad_star.png#" alt="">
13
14 {if="!empty($text)"}
15 <p>{$text}</p>
16 {/if}
17
12 {if="!empty($stacktrace)"} 18 {if="!empty($stacktrace)"}
13 <pre> 19 <pre>
14 {$stacktrace} 20 {$stacktrace}
15 </pre> 21 </pre>
16 {/if} 22 {/if}
17
18 <img src="{$asset_path}/img/sad_star.png#" alt="">
19</div> 23</div>
20{include="page.footer"} 24{include="page.footer"}
21</body> 25</body>