From ef3fa542f83b5e12b999224aaa86c46bf328b24f Mon Sep 17 00:00:00 2001 From: Paul B Date: Mon, 23 Nov 2020 10:06:09 +0100 Subject: cleanup: remove useless use of if condition --- tap_google_sheets/schema.py | 38 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/tap_google_sheets/schema.py b/tap_google_sheets/schema.py index 56d2fb9..fe11844 100644 --- a/tap_google_sheets/schema.py +++ b/tap_google_sheets/schema.py @@ -279,24 +279,24 @@ def get_schemas(client, spreadsheet_id): spreadsheet_id=spreadsheet_id, params=params) - sheets = spreadsheet_md_results.get('sheets') - if sheets: - # Loop thru each worksheet in spreadsheet - for sheet in sheets: - # GET sheet_json_schema for each worksheet (from function above) - sheet_json_schema, columns = get_sheet_metadata(sheet, spreadsheet_id, client) - - # SKIP empty sheets (where sheet_json_schema and columns are None) - if sheet_json_schema and columns: - sheet_title = sheet.get('properties', {}).get('title') - schemas[sheet_title] = sheet_json_schema - sheet_mdata = metadata.new() - sheet_mdata = metadata.get_standard_metadata( - schema=sheet_json_schema, - key_properties=['__sdc_row'], - valid_replication_keys=None, - replication_method='FULL_TABLE' - ) - field_metadata[sheet_title] = sheet_mdata + sheets = spreadsheet_md_results.get('sheets', []) + + # Loop thru each worksheet in spreadsheet + for sheet in sheets: + # GET sheet_json_schema for each worksheet (from function above) + sheet_json_schema, columns = get_sheet_metadata(sheet, spreadsheet_id, client) + + # SKIP empty sheets (where sheet_json_schema and columns are None) + if sheet_json_schema and columns: + sheet_title = sheet.get('properties', {}).get('title') + schemas[sheet_title] = sheet_json_schema + sheet_mdata = metadata.new() + sheet_mdata = metadata.get_standard_metadata( + schema=sheet_json_schema, + key_properties=['__sdc_row'], + valid_replication_keys=None, + replication_method='FULL_TABLE' + ) + field_metadata[sheet_title] = sheet_mdata return schemas, field_metadata -- cgit v1.2.3